https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/148736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -323,12 +332,24 @@ foreach(header
COMMENT "LLDB headers: stage LLDB headers in include directory")
list(APPEND lldb_staged_headers ${staged_header})
+
+ if (LLDB_BUILD_FRAMEWORK)
+set(input_header ${staged_header})
+set(output_header $/Headers/${basename})
+
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148736
>From 97e5d4dbe1dd0be22be0b23c5861808b10a3391d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 14 Jul 2025 16:58:23 -0500
Subject: [PATCH] [lldb][framework] Glob headers from source for framewo
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148736
>From d56c148eb78fb7e8d750d42921afccd95410956d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 14 Jul 2025 16:58:23 -0500
Subject: [PATCH] [lldb][framework] Glob headers from source for framewo
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148736
>From 31b21cb6fde5d3d9e9a6fc8f2c77edc30167f512 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 14 Jul 2025 16:58:23 -0500
Subject: [PATCH] [lldb][framework] Glob headers from source for framewo
chelcassanova wrote:
To sum up the conversation I've been having with Vladimir Vereschaka
(@vvereschaka) thus far, for the cross-compile build on the
lldb-remote-linux-ubuntu bot, the step that generates and compiles the sources
from lldb-rpc-gen is taking place too early on the target. It's t
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/147655
>From 515f1136fb31abd68f4f668beaab9eb65375803d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 2 Jul 2025 00:17:31 -0700
Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters
This
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/147655
>From b842db905bf10fd6b89f2dfc07cd6a1eaa2bfd7b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 2 Jul 2025 00:17:31 -0700
Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters
This
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/147655
>From 3923ba0807cb211b6c92be4154b3135db4566b53 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 2 Jul 2025 00:17:31 -0700
Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters
This
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -105,18 +78,32 @@ set_target_properties(liblldb-resource-headers PROPERTIES
FOLDER "LLDB/Resources
add_dependencies(liblldb-resource-headers liblldb-header-staging)
add_dependencies(liblldb liblldb-resource-headers)
-# Take the headers from the staging directory and fix up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148736
>From e473fa9d67517d18ed106c900d665b4bda2f1aff Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 14 Jul 2025 16:58:23 -0500
Subject: [PATCH] [lldb][framework] Glob headers from source for framewo
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148996
>From 93913751666fa7121457dc7ab6a766fa90836598 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 15 Jul 2025 18:42:34 -0500
Subject: [PATCH] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
chelcassanova wrote:
> What happens when you don't put this annotation on one of these? It generates
> something I suppose, but it fails when you use lldb-rpc?
Correct, without an annotation (or in the earlier case, without having a given
function in the exception list), a function will still
chelcassanova wrote:
> The new code duplicates a lot of the existing logic in API/CMakeLists.txt.
> Wouldn't it be simpler to add the framework code to the existing loop behind
> if(LLDB_BUILD_FRAMEWORK)?
That can be done, I think we'd also have to move the top-level targets for
fixing up fra
chelcassanova wrote:
> You should email the worker admin and see if they can help. "Worker:" tab
> then "admin".
Thanks! I've reached out to them and I'm waiting to hear back.
> It is doing remote testing but the failure seems to be before that step so I
> think it's something to do with the
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148996
>From 015acc5f0dd749bcc51d690b1c7fb1577cf66aa4 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 15 Jul 2025 18:42:34 -0500
Subject: [PATCH] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146
@@ -105,18 +78,30 @@ set_target_properties(liblldb-resource-headers PROPERTIES
FOLDER "LLDB/Resources
add_dependencies(liblldb-resource-headers liblldb-header-staging)
add_dependencies(liblldb liblldb-resource-headers)
+# Glob all necessary header files from source and place
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/148736
>From 577cc56f48f8cbaba3c1af4a153cbd3be2216246 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 14 Jul 2025 16:58:23 -0500
Subject: [PATCH] [lldb][framework] Glob headers from source for framewo
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/148981
In LLDB RPC, we need to keep track of methods that have a pointer parameter
followed by a lengtgh parameter as these parameters need some exceptions when
they're being emitted by lldb-rpc-gen. Previously,
chelcassanova wrote:
I've undrafted this PR and updated the [design
doc](https://github.com/llvm/llvm-project/pull/138612) to reflect what the
client-side emitters are doing here.
@DavidSpickett Would you able to take a look at this PR and the updated design
doc when you can?
https://github.
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/147655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138612
>From 3d29af3b776c407de606cf507c9b03c49daa11b0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 09:04:40 -0700
Subject: [PATCH] [lldb][RPC] Design doc for upstreaming PR
This mainly
@@ -106,17 +112,17 @@ add_dependencies(liblldb-resource-headers
liblldb-header-staging)
add_dependencies(liblldb liblldb-resource-headers)
# Take the headers from the staging directory and fix up their includes for
the framework.
-# Then write them to the output directory.
+
chelcassanova wrote:
@slydiman
> What linux remote bots are you talking about? Everything worked. Looks like
> we need to revert this PR ASAP because it broke too much.
I reverted this PR, when I had landed the original PR it failed on the
`lldb-remote-linux-ubuntu` bot. When I tried to rela
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/147779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/147779
Reverts llvm/llvm-project#147417. Failing an assert:
`lldb-rpc-gen:
../llvm-project/lldb/tools/lldb-rpc/lldb-rpc-gen/server/RPCServerSourceEmitter.cpp:361:
void lldb_rpc_gen::RPCServerSourceEmitter::EmitM
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/147417
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/147417
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/147655
>From 899439d378923f22af7b11b99cafa1789ed436a7 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 2 Jul 2025 00:17:31 -0700
Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters
This
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/147655
This commit upstreams the client side emitters for the lldb-rpc-gen tool
alongside tests for its functionality and heuristics.
https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85804
>From cbcab9124c
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
>From 44b7628d7d77d3c63001890cb678ee6ab85e8034 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:24:03 -0700
Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters
Thi
chelcassanova wrote:
```
File
"/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/utils/lit/lit/Test.py",
line 418, in getUnsupportedFeatures
raise ValueError("Error in UNSUPPORTED list:\n%s" % str(e))
ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
>From 69009b34c7bfa0cb39f5ff805b213fe0164a2193 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:24:03 -0700
Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters
Thi
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/146969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/146969
Reverts llvm/llvm-project#138031. This is failing during the build phase on the
Ubuntu buildbot:
```
Error while processing
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/in
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Ok I was being way overkill with this patch, I updated it so that the script
creates the output directories if it doesn't exist.
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/146425
>From 7b11f001e18d0f8d641448cac63181c9ed3c33e8 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 30 Jun 2025 14:51:43 -0700
Subject: [PATCH] [lldb][framework] Copy framework files correctly
A bu
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 15f195fb304775578812836621fcf88ed9bff9db Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
chelcassanova wrote:
@DavidSpickett I think this is ready to go, I'd love if you could take another
look at this.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 024f1bb0c0b8198f3ca16e54a1944d160d58a4cd Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
The last test failure happening was this:
```
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 761601040deae05ab7aa5314c09af5a47d92662b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 682d39236976acb0fed92a5b7347427c38789dc9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From a454d432e9030b85e0b6330ab3b6a110eee67c67 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 386436bc42c7c17d311f4eda0abf3003ecb5ac5a Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
chelcassanova wrote:
I think it would actually be possible to just land this patch for now and then
reenable these tests when the tool land
chelcassanova wrote:
For the include problem, `cstdint` isn't in the Clang resource directory that
gets passed in. maybe a system include dir must also be passed in here. One
thing I'm confused about is that the tool is built and run correctly in the
actual CMake build phase.
https://github.c
chelcassanova wrote:
> I expect not because the compilation database only deals with sources, .cpp,
> .cc etc. not headers.
So it should be trying to load something like `compile_commands.json`? Which is
in the root of the build dir so when the tool needs to load it's going to try
and do some
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
chelcassanova wrote:
The unsupported can probably be removed actually, these tests still need to
test after the tool lands however.
https:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
>From 5b5ba0f552715cd68e82aa03adadb5323e5c6eff Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:24:03 -0700
Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters
Thi
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From e87953011acc6052c0ced1911e578347b66a2dc0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/146425
>From e199f4ece908cfe9454e4b4b61f04133a615f8d2 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 30 Jun 2025 14:51:43 -0700
Subject: [PATCH] [lldb][framework] Copy framework files correctly
A bu
chelcassanova wrote:
I'm still seeing the `no job control` error in the pre-commit CI. As far as I
know this error is not supposed to be happening, RPC should be getting built
which should mean that the `lldb-rpc-gen` tool is available for use in the
shell test. I can't repro locally, I'm wond
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 1e10fc233cdf59299b3c1720838e89e6acfc07ad Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
chelcassanova wrote:
> My understanding was the -o ${output_header} here should place it in the
> framework when ${output_header} is the right directory.
So did I, but when I actually tried a build with the framework enabled the
headers weren't there. Looking at this again copying the files *m
@@ -0,0 +1,6 @@
+# All tests for the tool need lldb-rpc-gen to be built.
+# As far as I can see, you need to check all possible ways to
+# say "no" in a CMake option.
+negation_options = ["OFF", "NO", 0]
+if not config.lldb_has_lldbrpc or config.lldb_has_lldbrpc in negation_option
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 63db109cdc1177b469ca695b504492623d268d13 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 0c0825263c3423a724a9d9253368332ebe0e7568 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
chelcassanova wrote:
> If framework-header-fix.py already puts the header in the framework, why
> might we want to wholesale copy it into the framework beforehand?
I don't think the script and build infrastructure was actually putting
everything in the framework itself, just the staging area i
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/146425
A build step needs to copy headers from the framework staging area to the
framework itself. This commit modifies the LLDB framework CMake module to do
this.
>From b08afa816f4555e2075bd3637217e43b7ba86fa9
chelcassanova wrote:
`home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/RPC/Generator/Tests/Output/CheckRPCGenToolByproducts.test.script:
line 1: fg: no job control` This means that the test does not recognize the
`lldb-rpc-gen` binary. It was working before an
chelcassanova wrote:
Actually, the test fails locally for me. On the pre-commit CI it's error
message is
`home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/RPC/Generator/Tests/Output/CheckRPCGenToolByproducts.test.script:
line 1: fg: no job control`, which mea
chelcassanova wrote:
When I updated the patch, the test now fails because of the error that it's
missing the clang resource dir. That repros locally and I haven't changed
anything about how the tool is built outside of adding a CMake variable,
investigating.
https://github.com/llvm/llvm-proje
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From bf72ec458e7788ddd8d7cb7d42fbf55a9112722f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
chelcassanova wrote:
One more time, I've updated the patch. Some points:
- I've removed our exception list for the methods that were unconditionally
given a connection
- For the FIXME that we had for changing the LLDB namespace I've changed to a
note as to why we use simple string replacement.
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From bfbf9e8b2c24b4e1d9a32a16b748cc1f96a54407 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
chelcassanova wrote:
```
cp: cannot stat
'/home/gha/actions-runner/_work/llvm-project/llvm-project/build/test-results.*.xml':
No such file or directory
+ :
+ shopt -s nullglob
+ python3
/home/gha/actions-runner/_work/llvm-project/llvm-project/.ci/generate_test_report_github.py
':penguin: Linu
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Such that we have `r'#include "lldb/(API/)?(?P.*){0,1}"'`
instead of `r'#
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Could be worth updating all other instances of `{0,1}`
https://github.com
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/145961
>From 7382a6a7e5636515c4882136d54c8133d77aa31d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 26 Jun 2025 13:05:56 -0700
Subject: [PATCH] [lldb][scripts] Fix bugs in framework fix script
The
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/145961
The script used to fix up LLDB's header for use in the macOS framework
contained 2 bugs that this commit addreses:
1. The output contents were appended to the output file multiple times instead
of only b
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/145111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
> I'd be alright with it going in a follow-up. That being said, it would be
> easy to kick this can down the road. Let's figure out a way to make this
> happen without blocking this PR.
I think that this should be addressed in a follow-up PR, mainly because I think
change
@@ -0,0 +1,22 @@
+include(CheckCXXCompilerFlag)
chelcassanova wrote:
Looking at this again, I realize that on its own this is probably unnecessary,
but this include is actually here for a check of a compiler flag:
```
check_cxx_compiler_flag("-Wno-gnu-zero-vari
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/145111
>From def09f294e36e2fe703d66eeae37253ac8fbb7b1 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Fri, 20 Jun 2025 13:47:32 -0700
Subject: [PATCH] Reland "[lldb][target] Add progress report for wait-at
@@ -0,0 +1,22 @@
+include(CheckCXXCompilerFlag)
chelcassanova wrote:
I'm actually not sure, though it seems to have originally been added to silence
compiler warnings, so maybe this should be kept.
https://github.com/llvm/llvm-project/pull/138031
__
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/145111
>From 9d9404b10d6f2073b89bb228079b8ee4e57534c8 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Fri, 20 Jun 2025 13:47:32 -0700
Subject: [PATCH] Reland "[lldb][target] Add progress report for wait-at
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/145419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
> I wonder if you would be better off actually attaching to something. Then you
> don't have to do all this waiting around, the progress message should still
> be there.
This is best thing to try here, I'll update the test to do this.
https://github.com/llvm/llvm-project/
chelcassanova wrote:
@labath
> Well.. IIUC, this test tries to attach to a process called "a.out" -- and
> hopes that the process doesn't appear.
That's pretty much it, I just need to wait-attach to _some_ process to trigger
the progress report I'm expecting and then drop the process once we
https://github.com/chelcassanova approved this pull request.
LGTM!
(For future reference, we should also do this when we run the framework fixup
Python script)
https://github.com/llvm/llvm-project/pull/144217
___
lldb-commits mailing list
lldb-commit
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/144768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
@bulbazord @medismailben Updated this patch to add both of your suggestions
https://github.com/llvm/llvm-project/pull/144768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/144768
>From daae7e75e5181643c5cf027c8623ee52edf052fc Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Jun 2025 09:26:08 -0700
Subject: [PATCH] [lldb][target] Add progress report for wait-attaching
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/144768
This commit adds a progress report when wait-attaching to a process as well as
a test for this.
>From 211e0e2e18002da509e29d2bc46eb2fb8658c499 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed,
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From ab03ecaf8a2d7b368d0eb1d65ebaea829a4c5c91 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 75061e1eb39383dae59ebd3ce3b77d8b550d0ab5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
@@ -838,6 +840,13 @@ void Breakpoint::GetDescription(Stream *s,
lldb::DescriptionLevel level,
bool show_locations) {
assert(s != nullptr);
+ // Grey out any disabled breakpoints in the list of breakpoints.
+ if (!IsEnabled())
+if (s->As
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 8608a949e6579f9ee69961ceabf8158a6b91b208 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH 1/2] [lldb][breakpoint] Grey out disabled breakpoints
Th
1 - 100 of 571 matches
Mail list logo
