[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; chandlerc wrote

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

@@ -33,25 +33,26 @@ using namespace llvm::opt; namespace { struct OptNameLess { - const char *StrTable; - ArrayRef PrefixesTable; + const StringTable *StrTable; chandlerc wrote: (same as above) https://github.com/llvm/llvm-project/pull/123308

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

chandlerc wrote: Ping https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Patch series to reapply #118734 and substantially improve it (PR #120534)

chandlerc wrote: > Some good news, everything seems to pass after your latest changes in this > PR! I didn't believe it at first and did a clean rebuild and test to verify. > In the end everything passed again. > > That being said, I am working on deploying an updated version of VS2019 to > o

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch intrinsics to StringTable and work around MSVC (PR #123548)

https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/123548 **Note:** This PR depends on #123302 and #123308 -- only the last of the three commits should be reviewed here. --- Historically, the main example of *very* large string tables used the `EmitCharArray` to wo

[Lldb-commits] [clang] [lldb] [llvm] Patch series to reapply #118734 and substantially improve it (PR #120534)

chandlerc wrote: @dyung - OK, I think the current just-pushed version of this PR is worth another test. I've taught the TableGen string table emission to go back to working around the MSVC issues using a different table form that we used to use in LLVM when MSVC had a reliable error on it. It

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/123308 Now that we have a dedicated abstraction for string tables, switch the option parser library's string table over to it rather than using a raw `const char*`. Also try to use the `StringTable::Offset` type rat

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

chandlerc wrote: Thanks for the careful review, merging! (And starting on the follow-ups!) https://github.com/llvm/llvm-project/pull/119198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/119198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/119198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -845,13 +845,14 @@ MemoryBufferRef LinkerDriver::convertResToCOFF(ArrayRef mbs, // Create OptTable +#define OPTTABLE_STR_TABLE_CODE chandlerc wrote: I have no idea. It took a lot of work to get even this to work, figuring out each of the different ways

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -80,15 +78,56 @@ class OptTable { const char *AliasArgs; const char *Values; -StringRef getName() const { - unsigned PrefixLength = Prefixes.empty() ? 0 : Prefixes[0].size(); - return PrefixedName.drop_front(PrefixLength); +bool hasNoPrefix() const

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

chandlerc wrote: > If you look for: > > ``` > FAILED: > �[0mtools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o > > ``` > > In the build log that's the failure reason. NP, and thanks. Sorry I missed that set of tests. Pushed a fix that makes `check-clang-too

Re: [Lldb-commits] [lldb] 3bea730 - [lldb] Fix compilation with gcc-6.5

On Tue, Jun 15, 2021 at 4:29 PM Tom Stellard wrote: > On 6/15/21 4:28 PM, Chandler Carruth wrote: > > +Tom Stellard - Could this get > cherry-picked into 12.0.N for the next point release? Without it, LLDB in > the 12 release doesn't build with GCC <= 6.5 which the do

Re: [Lldb-commits] [lldb] 3bea730 - [lldb] Fix compilation with gcc-6.5

+Tom Stellard - Could this get cherry-picked into 12.0.N for the next point release? Without it, LLDB in the 12 release doesn't build with GCC <= 6.5 which the docs indicate is supposed to work. On Wed, Mar 31, 2021 at 11:45 PM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote:

Re: [Lldb-commits] [lldb] r353324 - [Reproducers] SBReproducer framework: Capture & Replay

Several files in this commit incorrectly use the old file headers from before the relicense. I've fixed them, but please be careful with any other outstanding commits. On Wed, Feb 6, 2019 at 10:57 AM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere >

[Lldb-commits] [lldb] r353663 - Update files to the new header that were incorrectly landed with the old

Author: chandlerc Date: Mon Feb 11 00:03:41 2019 New Revision: 353663 URL: http://llvm.org/viewvc/llvm-project?rev=353663&view=rev Log: Update files to the new header that were incorrectly landed with the old one. Modified: lldb/trunk/source/API/SBReproducer.cpp lldb/trunk/source/API/SBRe

[Lldb-commits] [lldb] r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[Lldb-commits] [lldb] r351631 - Install new LLVM license structure and new developer policy.

Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631&view=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects i

Re: [Lldb-commits] [PATCH] D24369: [support] copying JSON parser/writer from lldb

chandlerc added a comment. In https://reviews.llvm.org/D24369#538472, @zturner wrote: > In https://reviews.llvm.org/D24369#538422, @aizatsky wrote: > > > > I'm a bit surprised there's not already a json parser in LLVM. Maybe > > > there's a reason for it. I think this CL needs a few more revie

[Lldb-commits] [lldb] r256616 - [ptr-traits] Add an #include to provide the complete type for Section

Author: chandlerc Date: Tue Dec 29 21:48:24 2015 New Revision: 256616 URL: http://llvm.org/viewvc/llvm-project?rev=256616&view=rev Log: [ptr-traits] Add an #include to provide the complete type for Section which is the pointee in a pointer keyed DenseMap. Pointer keys in a DenseMap have their low