[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. (In fact I observe many patterns in this review like: enum { Foo = alignof(void*); } aligned_storage_t<1234, Foo> x; and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack: align

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. In D65249#1603335 , @jfb wrote: > @rnk: how about I add a bit of code that wraps `aligned_storage` on all > platforms except MSVC (where I'd implement it as Billy suggests). That would > mean updating all the uses of `aligned_

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? aligned_storage is still capped at what the library can fake with unions. It would be an ABI break to change it to use alignas, so things where the x86 stack temporarily breaks T's usual alignme