puremourning wrote:
Yep. Good to go.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
puremourning wrote:
> @puremourning Let me know if you need someone to press the Merge button for
> you.
Yes please. I don't have commit rights.
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
puremourning wrote:
Done. The test fails (expectedly) at the line following "DeleteAllWatchpoints"
prior to this patch, and passes after.
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/125312
>From 6af277d30baaa1c8ff56bb4da13a6687dfa0c729 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Fri, 31 Jan 2025 22:38:04 +
Subject: [PATCH] LLDB: correct event when removing all watchpoints
Previously
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
puremourning wrote:
Yes, on it. Sorry I should have marked this PR [wip].
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/125312
>From 0bf7cf47b3373f3bd23802fcd41f6b831fff6adf Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Fri, 31 Jan 2025 22:38:04 +
Subject: [PATCH] LLDB: correct event when removing all watchpoints
Previously
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
puremourning wrote:
https://github.com/llvm/llvm-project/pull/125312
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning created
https://github.com/llvm/llvm-project/pull/125312
Previously we incorrectly emitted a "breakpoint changed" event when removing
all watchpoints (e.g. via SBTarget::DeleteAllWatchpoints()).
Correct it to emit the "watchpoint changed" event, as that's what "
puremourning wrote:
Looking again, of course you're right and the behaviour of RemoveAll and Remove
is inconsistent today, so I don't see a problem with fixing it.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-com
puremourning wrote:
> Seeing as you are working on watchpoints here, I found that `void
> WatchpointList::RemoveAll(bool notify)` is sending the wrong event of
> `Target::eBroadcastBitBreakpointChanged` instead of sending
> `Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get i
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 6b3ba3f6dcf11d8b18ff72bc736b24ac75231626 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
puremourning wrote:
I think the issue is that... we just don't support read-only watchpoints on
intel because the [hardware doesn't support
it](https://en.wikipedia.org/wiki/X86_debug_register#cite_note-brkpt_type-19).
I guess I'll mark this test as "skip on x86"
https://github.com/llvm/llvm-
puremourning wrote:
Hmm seems the behaviour on intel differs to arm. will need to think about it.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
puremourning wrote:
OK so the test is failing on CI, that's bad news.
will check
```
FAIL: LLDB
(/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-j6q2n-1/llvm-project/github-pull-requests/build/bin/clang-x86_64)
:: test_read_watchpoint_watch_address
(TestWatchpointRead.SetReadOnlyWatchpoin
puremourning wrote:
> This looks good to me, thanks for fixing this. This method used to take two
> bools, `read`, and `write`, I redefined the second to `modified` when I
> changed the default watchpoints to be modify-style. The method previously had
> a block doing
>
> ```
> -uint32_t w
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 169a8d84d4af08218227058db4968bed9fc701eb Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
@@ -1342,7 +1342,9 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBWatchpointOptions options;
options.SetWatchpointTypeRead(read);
puremourning wrote:
It doesn't need to: It passes read bool directly to the Set... method so
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 1edd2a7cae5acbe11ae58f486f5bca7c182184f5 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 3baafc236fb722a27799bd3abccb74e01656afab Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From afae250c45e769006a5ae7d078e2e0ae39a4d8c0 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
https://github.com/puremourning created
https://github.com/llvm/llvm-project/pull/124847
The WatchAddress API includes a flag to indicate if watchpoint should be for
read, modify or both. This API uses 2 booleans, but the 'modify' flag was
ignored and WatchAddress unconditionally watched write
27 matches
Mail list logo
