[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG0818e6cf1d30: [LLDB] Add support for AVR breakpoints (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl added a comment. In D74255#1871958 , @labath wrote: > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's > what 0x98 0x95 is), then I don't see a pr

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl abandoned this revision. aykevl added a comment. Closing this one. Maybe there is something useful in this patch but if there is, I'll submit that in a standalone (more focused) patch. The majority of it has been merged in D73969 . Repository: rG LLVM

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGec1efe71130f: [LLDB] Let DataExtractor deal with two-byte addresses (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://r

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. In D73969#1860696 , @labath wrote: > I agree only one of those two places should be enough. My idea was to make > the constructors delegate to one another (if necessary by creating a private > uber-constructor that everybody can d

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 246443. aykevl added a comment. Rebase on master (after `GetPointer` was removed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 Files: lldb/source/Utility/DataExtractor.cpp lldb/unittests/Utility/DataE

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl created this revision. aykevl added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, Jim, dylanmckay. Herald added a project: LLDB. I believe the actual opcode does not matter because the AVR architecture is a Harvard architecture that does not support writing to progra

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. >> Right now there are asserts both when constructing/copying(?) the object (5 >> asserts) and at the place where `m_addr_size` is used (3 asserts). I would >> propose picking one place, such as where it is used. That would reduce the >> number of asserts to 3 and keep t

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. > How do you normally generate the binaries with these kinds of addresses? Can > they be produced with clang? Can they be produced with llvm-mc? Linked with > lld ? With `avr-gcc`. I think it's easiest to just generate a minimal binary using `yaml2obj`. For the rest I'

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242694. aykevl set the repository for this revision to rG LLVM Github Monorepo. aykevl added a comment. > I do have one question though. Will the DataExtractor actually do something > reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if not,

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to test this by loading an AVR binary and connecting to a debugger (thus triggering this code), but I don't know how to add such a test. Suggestions would be appreciated.

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl created this revision. aykevl added reviewers: labath, dylanmckay, Andrzej. aykevl added projects: LLVM, LLDB. Herald added subscribers: lldb-commits, aprantl. aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to te

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. See D73969 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73961/new/ https://reviews.llvm.org/D73961 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl created this revision. aykevl added reviewers: granata.enrico, labath, dylanmckay, Andrzej. Herald added subscribers: llvm-commits, lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. Addresses are usually two bytes in size on AVR, so make sure LLDB deals with that. --- I'm not s

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG727ed11b24c0: [AVR] Recognize the AVR architecture in lldb (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.ll

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

aykevl added a comment. Ok, I've updated the title and the commit message (text until the separator). Does that look good? I have commit access so I can merge this myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.llvm.org/D73539 _

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl added a comment. It's worth noting that I haven't managed to get a line table from a binary produced by LLVM (with my own compiler frontend) and linked by avr-gcc. But I believe that is a bug in the AVR backend of LLVM as a binary built entirely by `avr-gcc` works just fine. CHANGES SI

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl updated this revision to Diff 240857. aykevl added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. @labath Thank you for the quick review! I have added a test per your suggestions. I'm not very familiar with lldb but this passes the tests. CHANG

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl created this revision. aykevl added reviewers: dylanmckay, deepak2427, Andrzej, clayborg, labath. Herald added subscribers: lldb-commits, Jim, aprantl. Herald added a project: LLDB. Add bare-metal AVR support to lldb. Loading a binary works, but little else. Things that work: $ ./llvm-b