[Lldb-commits] [PATCH] D42917: Adapt some tests to work with PPC64le architecture

anajuliapc created this revision. Merge branch 'master' into adaptPPC64tests https://reviews.llvm.org/D42917 Files: packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_hits/TestMultipleHits.py packages/Python/lldbsuite/test/lang/c/register_variables/test.c packages/Python/

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc updated this revision to Diff 119885. anajuliapc added a comment. - Remove unused enum https://reviews.llvm.org/D38897 Files: include/lldb/lldb-enumerations.h source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp source/Plugins/Process/Linux/NativeRegisterContextL

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:59 + + enum watch_mode { +write_mode = 1, I just realized I forgot to remove the enum I've created before. I know you already accepted this pa

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc updated this revision to Diff 119847. anajuliapc marked an inline comment as done. anajuliapc added a comment. - Use bitwise OR operator https://reviews.llvm.org/D38897 Files: include/lldb/lldb-enumerations.h source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp s

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc updated this revision to Diff 119835. anajuliapc added a comment. - Switch over read and write eWatchpointKind to match with watch_flags https://reviews.llvm.org/D38897 Files: include/lldb/lldb-enumerations.h source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp s

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:284 + switch (watch_flags) { + case write_mode: +rw_mode = PPC_BREAKPOINT_TRIGGER_WRITE; clayborg wrote: > We should use the lldb::WatchpointK

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:327-333 + for (uint32_t i = 0; i < m_max_hwp_supported; i++) { +if ((m_hwp_regs[i].control & 1) == 0) { + wp_index = i; // Mark last free slot +} else

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc updated this revision to Diff 119567. anajuliapc marked 2 inline comments as done. anajuliapc added a comment. - Change numeric values to enum - Use llvm's functions to align addresses https://reviews.llvm.org/D38897 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_pp

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc added a comment. I applied some of the suggestions. I'm still working on the others, since I may need to change some logic Thanks for the comments https://reviews.llvm.org/D38897 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc updated this revision to Diff 119336. anajuliapc marked 6 inline comments as done. anajuliapc added a comment. - Add values to header file - Use std::array to declare m_hwp_regs - Use llvm's mask - Remove switch and use assert instead - Remove unnecessary 'else' - Change return https:

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

anajuliapc added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:374 + uint32_t tempControl = m_hwp_regs[wp_index].control; + long * tempSlot = reinterpret_cast(m_hwp_regs[wp_index].slot); + zturner wrote: > `re