arphaman added a comment.
Ping @mizvekov.
Unfortunately I'm unable to revert this commit now so we won't be able to get
the bot back to green until it's fixed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131858/new/
https://reviews.llvm.org/D13
arphaman added a comment.
Herald added a reviewer: njames93.
Hi @mizvekov.
This change has caused a failure in Clang's stage 2 CI on the green dragon
Darwin CI:
https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console.
Assertion failed: (lvaluePath->getType() == elemTy && "Une
arphaman accepted this revision.
arphaman added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136844/new/
https://reviews.llvm.org/D136844
___
lldb-commits mailing list
lldb-commits@list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366956: [Support] move FileCollector from LLDB to
llvm/Support (authored by arphaman, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
https://reviews.llvm.org/D65237?vs=211
arphaman updated this revision to Diff 211603.
arphaman added a comment.
Use `private` as suggested by Jan.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65237/new/
https://reviews.llvm.org/D65237
Files:
lldb/include/lldb/Utility/FileCollector.h
lldb/source/Utility/CMakeLists.txt
arphaman updated this revision to Diff 211591.
arphaman added a comment.
Herald added a subscriber: ormris.
Small bug fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65237/new/
https://reviews.llvm.org/D65237
Files:
lldb/include/lldb/Utility/
arphaman created this revision.
arphaman added a reviewer: JDevlieghere.
Herald added subscribers: dexonsmith, jkorous, hiraditya, mgorny.
Herald added projects: LLDB, LLVM.
The file collector class is useful for creating reproducers, not just for LLDB,
but for other tools. That's why it should l