[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Thanks for the reviews! @davide could you please commit this on my behalf? Thanks for the advice. I intend to continue working on LLDB when I can so I will spend some time to fix the test suite on my Mac. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/n

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. Thanks for looking at this. I will need someone to commit it for me. However, I've been having issues with the test suite on my MacBook. `check-lldb-unit` works for me but `check-llvm` and `check-lldb` are hitting issues be

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 229291. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h lldb/unittests/debugserver/CMakeLists.txt lldb/unittests/de

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. I've had a try at writing some unit tests for the JSON parser in `debugserver`, including the empty array case which I'm fixing in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 ___

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 228561. Herald added a subscriber: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h lldb/unittests/debugserver

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Thank you for the suggestions! I'm assuming that since only the `debugserver` portion of this change is left, I should write a test specifically for that. I had a quick look and it wasn't obvious how to do that but I will spend some more time on it this weekend. @ji

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 222923. tetsuo-cpp added a comment. Rebased onto trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h Index: lldb

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. In D68179#1690073 , @JDevlieghere wrote: > Hey, I just want to give you a heads up that I'm in the process to replace > LLDB's JSON implementation with the one from LLVM. The parts in > StructuredData are already gone (r37335

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 81. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/include/lldb/Utility/JSON.h lldb/source/Utility/JSON.cpp lldb/source/Utility/StructuredData.cpp lldb/tools/debugserver/source/JSON

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp created this revision. tetsuo-cpp added a reviewer: xbolva00. tetsuo-cpp added projects: LLVM, LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39405 alexc@kitty:~/work/wiredtiger/build_posix$ cat breakpoint.json [{"Breakpo