[Lldb-commits] [lldb] 895529c - [lldb][PDB] Constexpr static member values as AST literals

Author: Aleksandr Urakov Date: 2020-06-25T11:27:16+03:00 New Revision: 895529cfd8756e2b4dc609f5af92e0d8ae280ed8 URL: https://github.com/llvm/llvm-project/commit/895529cfd8756e2b4dc609f5af92e0d8ae280ed8 DIFF: https://github.com/llvm/llvm-project/commit/895529cfd8756e2b4dc609f5af92e0d8ae280ed8.di

[Lldb-commits] [lldb] 84c398d - [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

Author: Aleksandr Urakov Date: 2020-04-27T11:08:19+03:00 New Revision: 84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec URL: https://github.com/llvm/llvm-project/commit/84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec DIFF: https://github.com/llvm/llvm-project/commit/84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec.di

Re: [Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

May be the test for PECallFrameInfo will be helpful? Martin Storsjö via Phabricator schrieb am Mo., 28. Okt. 2019, 19:43: > mstorsjo added a comment. > > In D69502#1723549 , @labath > wrote: > > > Any way to get a test for this? Maybe creating a object fi

[Lldb-commits] [lldb] r374888 - [Windows][NFC] Fix tests after r374528.

Author: aleksandr.urakov Date: Tue Oct 15 06:52:27 2019 New Revision: 374888 URL: http://llvm.org/viewvc/llvm-project?rev=374888&view=rev Log: [Windows][NFC] Fix tests after r374528. Differential Revision: https://reviews.llvm.org/D67347 Modified: lldb/trunk/packages/Python/lldbsuite/test/f

Re: [Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

Sorry, I'm OOO now. I'll take a look tomorrow, thanks for catching that! On Mon, 14 Oct 2019, 19:20 Stella Stamenova via Phabricator, < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > In D67347#1706405 , > @stella.stamenova wrote:

[Lldb-commits] [lldb] r374528 - [Windows] Use information from the PE32 exceptions directory to construct unwind plans

Author: aleksandr.urakov Date: Fri Oct 11 02:03:29 2019 New Revision: 374528 URL: http://llvm.org/viewvc/llvm-project?rev=374528&view=rev Log: [Windows] Use information from the PE32 exceptions directory to construct unwind plans This patch adds an implementation of unwinding using PE EH info. I

[Lldb-commits] [lldb] r374325 - [Windows] Introduce a switch for the `lldb-server` mode on Windows

Author: aleksandr.urakov Date: Thu Oct 10 05:21:04 2019 New Revision: 374325 URL: http://llvm.org/viewvc/llvm-project?rev=374325&view=rev Log: [Windows] Introduce a switch for the `lldb-server` mode on Windows Summary: This patch introduces a switch, based on the environment variable `LLDB_USE_LL

[Lldb-commits] [lldb] r373300 - [Windows] Added support of watchpoints to `NativeProcessWindows`

Author: aleksandr.urakov Date: Mon Sep 30 22:52:16 2019 New Revision: 373300 URL: http://llvm.org/viewvc/llvm-project?rev=373300&view=rev Log: [Windows] Added support of watchpoints to `NativeProcessWindows` Summary: This patch adds support of watchpoints to the new `NativeProcessWindows` plugin

[Lldb-commits] [lldb] r371166 - [Windows] Add support of watchpoints to `ProcessWindows`

Author: aleksandr.urakov Date: Thu Sep 5 22:37:03 2019 New Revision: 371166 URL: http://llvm.org/viewvc/llvm-project?rev=371166&view=rev Log: [Windows] Add support of watchpoints to `ProcessWindows` Summary: This patch adds support of watchpoints to the old `ProcessWindows` plugin. The `Process

[Lldb-commits] [lldb] r360587 - [NativePDB] Fix tests after r360569

Author: aleksandr.urakov Date: Mon May 13 08:06:13 2019 New Revision: 360587 URL: http://llvm.org/viewvc/llvm-project?rev=360587&view=rev Log: [NativePDB] Fix tests after r360569 Modified: lldb/trunk/lit/SymbolFile/NativePDB/stack_unwinding01.cpp Modified: lldb/trunk/lit/SymbolFile/NativePDB

[Lldb-commits] [lldb] r360569 - [NativePDB] Support member function types in PdbAstBuilder

Author: aleksandr.urakov Date: Mon May 13 02:41:57 2019 New Revision: 360569 URL: http://llvm.org/viewvc/llvm-project?rev=360569&view=rev Log: [NativePDB] Support member function types in PdbAstBuilder Summary: This patch implements missing case in PdbAstBuilder::CreateType for LF_MFU

[Lldb-commits] [lldb] r359420 - [Windows] Dump more information about access violation exception

Author: aleksandr.urakov Date: Mon Apr 29 00:29:25 2019 New Revision: 359420 URL: http://llvm.org/viewvc/llvm-project?rev=359420&view=rev Log: [Windows] Dump more information about access violation exception Summary: Dump more information about "access violation" and "in page error" exceptions to

[Lldb-commits] [lldb] r358873 - [NativePDB] Add anonymous namespaces support

Author: aleksandr.urakov Date: Mon Apr 22 00:14:40 2019 New Revision: 358873 URL: http://llvm.org/viewvc/llvm-project?rev=358873&view=rev Log: [NativePDB] Add anonymous namespaces support Summary: This patch adds anonymous namespaces support to the native PDB plugin. I had to reference from the

[Lldb-commits] [lldb] r353806 - [NativePDB] Process virtual bases in the correct order

Author: aleksandr.urakov Date: Tue Feb 12 00:17:11 2019 New Revision: 353806 URL: http://llvm.org/viewvc/llvm-project?rev=353806&view=rev Log: [NativePDB] Process virtual bases in the correct order Summary: This patch makes virtual bases to be added in the correct order to the bases list. It is i

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Thank you! On Mon, Feb 11, 2019 at 6:01 PM Zachary Turner wrote: > Lgtm! > On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < > revi...@reviews.llvm.org> wrote: > >> aleksandr.urakov added a comment. >> >> Zachary, can you take a look? please? >> >> >> Repository: >> rLLDB LLD

[Lldb-commits] [lldb] r353709 - [build.py] Add `-fms-compatibility-version=19` to `build.py`

Author: aleksandr.urakov Date: Mon Feb 11 07:13:33 2019 New Revision: 353709 URL: http://llvm.org/viewvc/llvm-project?rev=353709&view=rev Log: [build.py] Add `-fms-compatibility-version=19` to `build.py` Summary: `clang-cl` can't compile tests containing `char16_t` and `char32_t` types without th

[Lldb-commits] [lldb] r353503 - [NFC] Fix license headers after r352845

Author: aleksandr.urakov Date: Fri Feb 8 00:48:15 2019 New Revision: 353503 URL: http://llvm.org/viewvc/llvm-project?rev=353503&view=rev Log: [NFC] Fix license headers after r352845 Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp lldb/trunk/source/Plu

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

Yes, sure, here it is: https://reviews.llvm.org/D56904 On Tue, Feb 5, 2019 at 7:39 PM Zachary Turner wrote: > Yes, clang tries to find the visual studio installation, because that is > how it can find headers and libs. Can you make a separate patch with the > changes to build.py and upload that

[Lldb-commits] [lldb] r353281 - [x64] Process the B field of the REX prefix correctly for the PUSH and POP

Author: aleksandr.urakov Date: Wed Feb 6 00:48:30 2019 New Revision: 353281 URL: http://llvm.org/viewvc/llvm-project?rev=353281&view=rev Log: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions Summary: This patch makes `x86AssemblyInspectionEngine` to process

[Lldb-commits] [lldb] r353149 - [Expressions] Add support of expressions evaluation in some object's context

Author: aleksandr.urakov Date: Tue Feb 5 01:14:36 2019 New Revision: 353149 URL: http://llvm.org/viewvc/llvm-project?rev=353149&view=rev Log: [Expressions] Add support of expressions evaluation in some object's context Summary: This patch adds support of expression evaluation in a context of som

[Lldb-commits] [lldb] r352858 - [PDB] Fix build after r352845

Author: aleksandr.urakov Date: Fri Feb 1 03:10:28 2019 New Revision: 352858 URL: http://llvm.org/viewvc/llvm-project?rev=352858&view=rev Log: [PDB] Fix build after r352845 Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/Nat

[Lldb-commits] [lldb] r352845 - [PDB] Fix location retrieval for function local variables and arguments that are

Author: aleksandr.urakov Date: Fri Feb 1 02:01:18 2019 New Revision: 352845 URL: http://llvm.org/viewvc/llvm-project?rev=352845&view=rev Log: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME Summary: This patch makes LLDB able to retrieve

[Lldb-commits] [lldb] r352478 - [NativePDB] Fix lldb-x64-windows-ninja after r352464

Author: aleksandr.urakov Date: Tue Jan 29 02:46:28 2019 New Revision: 352478 URL: http://llvm.org/viewvc/llvm-project?rev=352478&view=rev Log: [NativePDB] Fix lldb-x64-windows-ninja after r352464 Modified: lldb/trunk/lit/SymbolFile/NativePDB/global-classes.cpp lldb/trunk/lit/SymbolFile/Na

[Lldb-commits] [lldb] r352464 - [NativePDB] Add basic support of methods recostruction in AST

Author: aleksandr.urakov Date: Tue Jan 29 01:32:23 2019 New Revision: 352464 URL: http://llvm.org/viewvc/llvm-project?rev=352464&view=rev Log: [NativePDB] Add basic support of methods recostruction in AST Summary: This patch adds the basic support of methods reconstruction by native PDB plugin. I

[Lldb-commits] [lldb] r351065 - [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild

Author: aleksandr.urakov Date: Mon Jan 14 05:08:13 2019 New Revision: 351065 URL: http://llvm.org/viewvc/llvm-project?rev=351065&view=rev Log: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild Summary: This patch allows to retrieve an address object for `ValueObject

Re: [Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

Yes, right! There's x64 fastcall for everything. Ok, I'll remove it later, thanks! Am So., 30. Dez. 2018, 09:26 hat Zachary Turner geschrieben: > Sorry, this comment was supposed to be deleted after I realized i was > wrong. > > On Sat, Dec 29, 2018 at 9:12 PM Aleksandr Urakov via Phabricator <

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Thank you! It seems that your commit have fixed the bug - it haven't been reproduced on `lldb-x64-windows-ninja` since your commit. On Thu, Dec 6, 2018 at 9:45 PM Zachary Turner wrote: > Hopefully fixed in r348511. I went with the approach of concatenating the > executable file name, for two re

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Yes, this solution would solve the current problem. But theoretically the uniqueness may be defined by the directory, where the file is located, not by the name. It looks very unlikely, but who knows... I thought about what Stella have said, and it seems that I have found a good solution for this.

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

With such solution there would be even no need to change the current commit. But I'm not sure that it's trivial to do - the output file name may contain path with directories. May be we can replace slashes with underscores in the output file path and concatenate it with the object file name? Or eve

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Ok, thanks! On Wed, Dec 5, 2018 at 6:06 PM Zachary Turner wrote: > Yes, if the tests pass for you with current builder, please commit > On Wed, Dec 5, 2018 at 6:06 AM Aleksandr Urakov via Phabricator < > revi...@reviews.llvm.org> wrote: > >> aleksandr.urakov added a comment. >> >> It seems that

[Lldb-commits] [lldb] r348386 - [PDB] Make PDB lit tests use the new builder

Author: aleksandr.urakov Date: Wed Dec 5 09:35:30 2018 New Revision: 348386 URL: http://llvm.org/viewvc/llvm-project?rev=348386&view=rev Log: [PDB] Make PDB lit tests use the new builder Reviewers: zturner, stella.stamenova Reviewed By: zturner Tags: #lldb Differential Revision: https://revie

[Lldb-commits] [lldb] r348250 - [Expr] Fix `TestExprOptions` after r348240 on MacOS X

Author: aleksandr.urakov Date: Tue Dec 4 03:08:02 2018 New Revision: 348250 URL: http://llvm.org/viewvc/llvm-project?rev=348250&view=rev Log: [Expr] Fix `TestExprOptions` after r348240 on MacOS X Summary: r348240 assumes that an expression contains the Objective C option if Objective C Runtime i

[Lldb-commits] [lldb] r348240 - [Expr] Check the language before ignoring Objective C keywords

Author: aleksandr.urakov Date: Tue Dec 4 01:51:29 2018 New Revision: 348240 URL: http://llvm.org/viewvc/llvm-project?rev=348240&view=rev Log: [Expr] Check the language before ignoring Objective C keywords Summary: This patch adds the check of the language before ignoring names like `id` or `Clas

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Ok, thank you! I'll contact you when I will be ready to work on the new plugin. Am Mo., 3. Dez. 2018, 20:07 hat Zachary Turner geschrieben: > Ok that makes sense. I’ll work on this soon, I’m trying to get all > existing dia PDB tests passing with the native plugin so i can delete old > plugin, s

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

If I understand correctly, the native plugin processes for now globals and constants, but it can't create locals, right? But this FPO conversion is applicable to locals only, so we need to implement locals creation in the new plugin first, before moving the conversion there. That's why we need thes

[Lldb-commits] [lldb] r348136 - [PDB] Support PDB-backed expressions evaluation (+ fix stuck test)

Author: aleksandr.urakov Date: Mon Dec 3 05:31:13 2018 New Revision: 348136 URL: http://llvm.org/viewvc/llvm-project?rev=348136&view=rev Log: [PDB] Support PDB-backed expressions evaluation (+ fix stuck test) Summary: This patch contains several small fixes, which makes it possible to evaluate e

Re: [Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

I'm already OOO today, feel free to revert it. Am Fr., 30. Nov. 2018, 20:15 hat Stella Stamenova via Phabricator < revi...@reviews.llvm.org> geschrieben: > stella.stamenova added a comment. > > It looks like after this change went in, the tests on Windows starting > timing out instead of completi

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Ah, it looks like my fail. I had an old piece of code, which retrieves an FPO program for the old PDB plugin, and have shared it with Leonid (we are colleagues). Sure, we will move this to the new plugin (and it looks like it's not so difficult). Am Fr., 30. Nov. 2018, 18:39 hat Zachary Turner ge

[Lldb-commits] [lldb] r347975 - [NativePDB] Fix ast-reconstruction test on x86

Author: aleksandr.urakov Date: Fri Nov 30 01:50:11 2018 New Revision: 347975 URL: http://llvm.org/viewvc/llvm-project?rev=347975&view=rev Log: [NativePDB] Fix ast-reconstruction test on x86 Summary: This patch fixes ast-reconstruction.cpp test on x86 platform. Patch by: leonid.mashinskiy Review

[Lldb-commits] [lldb] r347974 - [Target] Do not skip a stop on a breakpoint if a plan was completed

Author: aleksandr.urakov Date: Fri Nov 30 01:45:52 2018 New Revision: 347974 URL: http://llvm.org/viewvc/llvm-project?rev=347974&view=rev Log: [Target] Do not skip a stop on a breakpoint if a plan was completed Summary: This patch fixes the next situation. On Windows clang-cl makes no stub before

[Lldb-commits] [lldb] r347962 - [PDB] Support PDB-backed expressions evaluation

Author: aleksandr.urakov Date: Thu Nov 29 23:12:22 2018 New Revision: 347962 URL: http://llvm.org/viewvc/llvm-project?rev=347962&view=rev Log: [PDB] Support PDB-backed expressions evaluation Summary: This patch contains several small fixes, which makes it possible to evaluate expressions on Windo

[Lldb-commits] [lldb] r347960 - [Symbol] Search symbols with name and type in a symbol file

Author: aleksandr.urakov Date: Thu Nov 29 22:56:37 2018 New Revision: 347960 URL: http://llvm.org/viewvc/llvm-project?rev=347960&view=rev Log: [Symbol] Search symbols with name and type in a symbol file Summary: This patch adds possibility of searching a public symbol with name and type in a symb

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

On Thu, Nov 29, 2018 at 11:40 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > On 29/11/2018 21:29, Leonard Mosescu wrote: > > > Hi Aleksandr, yes, no objections to this patch. > > > > I was responding to Pavel's comments, which I also assume are > >

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Yes, I agree that the current model of object files - symbol files - symtabs is not clear and orthogonal for cases like PDB, and I think that it requires some redesign too. But can we commit this patch now to proceed with several dependent (and not directly related to the theme) patches? When a n

[Lldb-commits] [lldb] r346672 - [PDB] Fix `vbases.test` requirement

Author: aleksandr.urakov Date: Mon Nov 12 08:45:55 2018 New Revision: 346672 URL: http://llvm.org/viewvc/llvm-project?rev=346672&view=rev Log: [PDB] Fix `vbases.test` requirement Differential revision: https://reviews.llvm.org/D53506 Modified: lldb/trunk/lit/SymbolFile/PDB/vbases.test Modif

[Lldb-commits] [lldb] r346669 - [ClangASTContext] Extract VTable pointers from C++ objects

Author: aleksandr.urakov Date: Mon Nov 12 08:23:50 2018 New Revision: 346669 URL: http://llvm.org/viewvc/llvm-project?rev=346669&view=rev Log: [ClangASTContext] Extract VTable pointers from C++ objects This patch processes the case of retrieving a virtual base when the object is already read from

Re: [Lldb-commits] [PATCH] D54357: [NativePDB] Improved support for nested type reconstruction

On Mon, Nov 12, 2018 at 6:42 PM Zachary Turner wrote: > Clang only. But I don’t think we can ever replace it with an assert, > debug info is basically user input, so we have to be able to handle every > manner of malformed input. In fact, when this bug is fixed in clang, i > will probably try t

[Lldb-commits] [lldb] r346213 - [PDB] Introduce `MSVCUndecoratedNameParser`

Author: aleksandr.urakov Date: Tue Nov 6 00:02:55 2018 New Revision: 346213 URL: http://llvm.org/viewvc/llvm-project?rev=346213&view=rev Log: [PDB] Introduce `MSVCUndecoratedNameParser` This patch introduces the simple MSVCUndecoratedNameParser. It is needed for parsing names of PDB symbols corr

[Lldb-commits] [lldb] r345974 - [NativePDB] Make tests work on x86 too

Author: aleksandr.urakov Date: Fri Nov 2 07:15:29 2018 New Revision: 345974 URL: http://llvm.org/viewvc/llvm-project?rev=345974&view=rev Log: [NativePDB] Make tests work on x86 too Summary: This patch fixes the NativePDB tests to make them work from x86 command line too Reviewers: zturner, stel

[Lldb-commits] [lldb] r345957 - [Symbol] Search symbols with name and type in a symbol file

Author: aleksandr.urakov Date: Fri Nov 2 01:54:35 2018 New Revision: 345957 URL: http://llvm.org/viewvc/llvm-project?rev=345957&view=rev Log: [Symbol] Search symbols with name and type in a symbol file Summary: This patch adds possibility of searching a public symbol with name and type in a symb

[Lldb-commits] [lldb] r345956 - [Windows] Fix Windows build after be053dd5a384a03da5a77552686900ddc7bfc178

Author: aleksandr.urakov Date: Fri Nov 2 01:47:33 2018 New Revision: 345956 URL: http://llvm.org/viewvc/llvm-project?rev=345956&view=rev Log: [Windows] Fix Windows build after be053dd5a384a03da5a77552686900ddc7bfc178 Modified: lldb/trunk/source/Host/windows/FileSystem.cpp lldb/trunk/sour

[Lldb-commits] [lldb] r345815 - [Windows] A basic implementation of memory allocations in a debuggee process

Author: aleksandr.urakov Date: Thu Nov 1 01:54:38 2018 New Revision: 345815 URL: http://llvm.org/viewvc/llvm-project?rev=345815&view=rev Log: [Windows] A basic implementation of memory allocations in a debuggee process Summary: This patch adds a basic implementation of `DoAllocateMemory` and `Do

[Lldb-commits] [lldb] r345577 - [x86] Fix issues with a realigned stack in MSVC compiled applications

Author: aleksandr.urakov Date: Tue Oct 30 03:07:08 2018 New Revision: 345577 URL: http://llvm.org/viewvc/llvm-project?rev=345577&view=rev Log: [x86] Fix issues with a realigned stack in MSVC compiled applications Summary: This patch fixes issues with a stack realignment. MSVC maintains two frame

[Lldb-commits] [lldb] r345385 - [Windows] Define generic arguments registers for Windows x64

Author: aleksandr.urakov Date: Fri Oct 26 07:15:34 2018 New Revision: 345385 URL: http://llvm.org/viewvc/llvm-project?rev=345385&view=rev Log: [Windows] Define generic arguments registers for Windows x64 Summary: When evaluating expressions the generic arguments registers are required by ABI. Thi

[Lldb-commits] [lldb] r345374 - [PDB] Fix `SymbolFilePDBTests` after r345313

Author: aleksandr.urakov Date: Fri Oct 26 02:36:26 2018 New Revision: 345374 URL: http://llvm.org/viewvc/llvm-project?rev=345374&view=rev Log: [PDB] Fix `SymbolFilePDBTests` after r345313 Differential Revision: https://reviews.llvm.org/D53749 Modified: lldb/trunk/unittests/SymbolFile/PDB/Sym

[Lldb-commits] [lldb] r345247 - [API] Extend the `SBThreadPlan` interface

Author: aleksandr.urakov Date: Thu Oct 25 01:27:42 2018 New Revision: 345247 URL: http://llvm.org/viewvc/llvm-project?rev=345247&view=rev Log: [API] Extend the `SBThreadPlan` interface Summary: This patch extends the `SBThreadPlan` to allow retrieving of thread plans for scripted steps. Reviewer

[Lldb-commits] [lldb] r345013 - [PDB] Improve performance of the PDB DIA plugin

Author: aleksandr.urakov Date: Tue Oct 23 01:29:17 2018 New Revision: 345013 URL: http://llvm.org/viewvc/llvm-project?rev=345013&view=rev Log: [PDB] Improve performance of the PDB DIA plugin Summary: This patch improves performance of `SymbolFilePDB` on huge executables in two ways: - cache name

[Lldb-commits] [lldb] r344729 - [Windows] Fix threads comparison on Windows

Author: aleksandr.urakov Date: Thu Oct 18 00:52:56 2018 New Revision: 344729 URL: http://llvm.org/viewvc/llvm-project?rev=344729&view=rev Log: [Windows] Fix threads comparison on Windows Summary: This patch makes Windows threads to compare by a thread ID, not by a handle. It's because the same th

[Lldb-commits] [lldb] r343298 - [PDB] Handle `char` as a builtin type

Author: aleksandr.urakov Date: Fri Sep 28 00:59:49 2018 New Revision: 343298 URL: http://llvm.org/viewvc/llvm-project?rev=343298&view=rev Log: [PDB] Handle `char` as a builtin type Summary: `char`, `signed char` and `unsigned char` are three different types, and they are mangled differently: ```

[Lldb-commits] [lldb] r343084 - [PDB] Restore the calling convention from PDB

Author: aleksandr.urakov Date: Wed Sep 26 02:03:34 2018 New Revision: 343084 URL: http://llvm.org/viewvc/llvm-project?rev=343084&view=rev Log: [PDB] Restore the calling convention from PDB Summary: This patch implements restoring of the calling convention from PDB. It is necessary for expressions

[Lldb-commits] [lldb] r342208 - [PDB] Use the raw PDB symbol interface more accurately

Author: aleksandr.urakov Date: Fri Sep 14 00:46:06 2018 New Revision: 342208 URL: http://llvm.org/viewvc/llvm-project?rev=342208&view=rev Log: [PDB] Use the raw PDB symbol interface more accurately Summary: This patch adds some symbol tag checks before using the `IPDBRawSymbol` interface to impro

Re: [Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

Agreed. I'll implement it tomorrow, thanks! On Tue, Sep 11, 2018 at 7:24 PM Zachary Turner wrote: > A visitor would work, but unless we need this frequently it might be > overkill. If we do need it frequently then it would be very helpful though. > > For now since we just have this one use case

Re: [Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

Yes, you are right, we can just to consider some cases important for us in the function, but I thought to solve the problem in a more general way. I think that the key problem is that we lose some type info when we get a `PDBSymbol`. So we need to dyn_cast the symbol multiple times or to analyse t

[Lldb-commits] [lldb] r341942 - [PDB] Fix problems after rL341782

Author: aleksandr.urakov Date: Tue Sep 11 07:03:12 2018 New Revision: 341942 URL: http://llvm.org/viewvc/llvm-project?rev=341942&view=rev Log: [PDB] Fix problems after rL341782 Summary: This commit fixes following problems after rL341782: - Broken SymbolFilePDBTests - Warning on comparison of int

[Lldb-commits] [lldb] r341782 - [PDB] Restore AST from PDB symbols

Author: aleksandr.urakov Date: Mon Sep 10 01:08:43 2018 New Revision: 341782 URL: http://llvm.org/viewvc/llvm-project?rev=341782&view=rev Log: [PDB] Restore AST from PDB symbols Summary: This patch adds an implementation of retrieving of declarations and declaration contexts based on PDB symbols.

[Lldb-commits] [lldb] r341296 - [DWARF] Fix dwarf5-index-is-used.cpp

Author: aleksandr.urakov Date: Mon Sep 3 00:16:06 2018 New Revision: 341296 URL: http://llvm.org/viewvc/llvm-project?rev=341296&view=rev Log: [DWARF] Fix dwarf5-index-is-used.cpp Summary: `dwarf5-index-is-used.cpp` have been failing after rL340206, because `clang` have stopped to emit pubnames b

[Lldb-commits] [lldb] r340901 - [PDB] Resolve a symbol context block info correctly

Author: aleksandr.urakov Date: Wed Aug 29 00:26:11 2018 New Revision: 340901 URL: http://llvm.org/viewvc/llvm-project?rev=340901&view=rev Log: [PDB] Resolve a symbol context block info correctly Summary: This patch allows to resolve a symbol context block info even if a function info was not requ

[Lldb-commits] [lldb] r340597 - [PDB] Make variables.test to pass using a 32-bit compiler too

Author: aleksandr.urakov Date: Fri Aug 24 00:24:52 2018 New Revision: 340597 URL: http://llvm.org/viewvc/llvm-project?rev=340597&view=rev Log: [PDB] Make variables.test to pass using a 32-bit compiler too Summary: `variables.test` depends on mangled names, but the mangling depends on the bitness.

[Lldb-commits] [lldb] r340151 - [NFC] Minor update to comment

Author: aleksandr.urakov Date: Sun Aug 19 22:59:27 2018 New Revision: 340151 URL: http://llvm.org/viewvc/llvm-project?rev=340151&view=rev Log: [NFC] Minor update to comment Update comment after rLLDB339994 Differential Revision: https://reviews.llvm.org/D49980 Modified: lldb/trunk/source/Sy

[Lldb-commits] [lldb] r339994 - Fix compiler warnings after rL339649.

Author: aleksandr.urakov Date: Fri Aug 17 00:28:24 2018 New Revision: 339994 URL: http://llvm.org/viewvc/llvm-project?rev=339994&view=rev Log: Fix compiler warnings after rL339649. Differential Revision: https://reviews.llvm.org/D49980 Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBAS

[Lldb-commits] [lldb] r339649 - [PDB] Parse UDT symbols and pointers to members (combined patch)

Author: aleksandr.urakov Date: Tue Aug 14 00:57:44 2018 New Revision: 339649 URL: http://llvm.org/viewvc/llvm-project?rev=339649&view=rev Log: [PDB] Parse UDT symbols and pointers to members (combined patch) Summary: In this patch I've tried to combine the best ideas from D49368 and D49410, so it

Re: [Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

Thank you a lot for explanations and commit! On Thu, Jul 19, 2018 at 4:40 PM Pavel Labath wrote: > Thanks. > > I agree you're not in the best position to make these kinds of changes > (and I don't think I would have asked you to do them). In fact, I was > already considering just changing that f

Re: [Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

On Thu, Jul 19, 2018 at 2:14 PM Pavel Labath wrote: > I knew I should have stayed quiet :P, but now that I am in, here's my > reasoning: > Thank you for not staying quiet, I think it's the only way to have a dialog and solve the problems :) I find your argumentation convincing. The problem is th

Re: [Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

But can you, please, explain me why? Excuse me for so much fuss, I just wanted to explain my position... We have two cases now: - Just commit such a patch without an additional investigation. But it's not a good idea, because we can't be 100% sure that it is a typo (and even if it is, we still may

[Lldb-commits] Support of MSVC function-level linking

Hello! I'm Aleksandr from JetBrains. We are working on improving support of MSVC-compiled binaries in lldb. We have made several fixes and would like to upstream them. The first patch adds support of function-level linking feature. The SymbolFilePDB::ParseCompileUnitLineTable function relies on