[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-07 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: > Ok, I will revert this and try to work out how to test/fix the issues on > windows (I wonder why it passed the windows CI premerge tests). It might be picking up a different `sed` binary now rather than a reasonably consistent one used by bash. > Maybe not? The failing

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-06 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/156983 >From aa1a12795ee11d48cf0df8c58058a3a36992e6b2 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Sep 2025 16:41:15 -0700 Subject: [PATCH 1/2] [LLDB] Fix deterministic-build.cpp post #156931 This

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: > Just FYI: That blank line got removed because otherwise it failed the code > formatting premerge test. :-( Good point. Updated to change the line number rather than add in the extra blank line. I've confirmed this fixes the issue locally, so I'm going to merge this onc

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: #156939 should fix the last remaining issue. https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: I've tested this locally on Darwin. I can confirm it fixes part of `TestCustomShell.test` and completely fixes the other two tests. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 commented: `lldb/test/Shell/Host/TestCustomShell.test` will still fail after this, but this change is still necessary either way. It does fix the other two tests and enables implementing `env -i` within lit's internal shell to fix `lldb/test/Shell/Host/TestCus

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
@@ -6,7 +6,7 @@ # XFAIL: system-openbsd # RUN: %clang_host %S/Inputs/simple.c -g -o %t.out -# RUN: SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s --check-prefix ERROR +# RUN: env SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 requested changes to this pull request. If you have bots for this, please address specific failures rather than grepping through the entire monorepo for these constructs. A bunch of the files you have hit here (like the ones related to CI) will never be run as

[Lldb-commits] [lldb] cc220b1 - [lldb] Mark UnsupportedLanguage.test Unsupported on Windows

2025-09-04 Thread Aiden Grossman via lldb-commits
Author: Aiden Grossman Date: 2025-09-04T13:53:37Z New Revision: cc220b1d55297b5939eb7eb197767a8b27aa71f8 URL: https://github.com/llvm/llvm-project/commit/cc220b1d55297b5939eb7eb197767a8b27aa71f8 DIFF: https://github.com/llvm/llvm-project/commit/cc220b1d55297b5939eb7eb197767a8b27aa71f8.diff LOG

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Aiden Grossman via lldb-commits
@@ -13,3 +13,15 @@ config.name = "lldb" config.test_source_root = os.path.dirname(__file__) config.test_exec_root = os.path.join(config.lldb_obj_root, "test") + +# We prefer the lit internal shell which provides a better user experience on +# failures and is faster unless the u

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Aiden Grossman via lldb-commits
@@ -13,3 +13,15 @@ config.name = "lldb" config.test_source_root = os.path.dirname(__file__) config.test_exec_root = os.path.join(config.lldb_obj_root, "test") + +# We prefer the lit internal shell which provides a better user experience on +# failures and is faster unless the u

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/151343 >From f18f2c1b654fa6f5925109eae0277bbbceb48565 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 30 Jul 2025 14:13:02 + Subject: [PATCH 1/3] [lldb] Remove %T from lit tests %T has been depreca

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/151343 >From f18f2c1b654fa6f5925109eae0277bbbceb48565 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 30 Jul 2025 14:13:02 + Subject: [PATCH 1/2] [lldb] Remove %T from lit tests %T has been depreca

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 ready_for_review https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/151343 %T has been deprecated for about seven years, mostly because it is not unique to each test which can lead to races. This patch updates the few remaining tests in lldb that use %T to not use it (either di

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 commented: Do we want to do the initialization here or inside the struct definition in `ProtocolTypes.h`? https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [llvm] [ci] add dependencies for lldb python binding tests (PR #136158)

2025-04-18 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/136158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-16 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: When relanding it would probably be helpful to land individual improvements in separate patches rather than bundling them all together. https://github.com/llvm/llvm-project/pull/135499 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: Subsumed by 1fd7e4c517141ddfb527e7560e02fd5856244971. https://github.com/llvm/llvm-project/pull/136078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/136078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-15 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/135499 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -52,6 +52,8 @@ "clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, "clang-tools-extra": {"libc"}, "mlir": {"flang"}, +# Test everyything if ci scripts are changed. +".ci": {"llvm", "clang", "lld", "lldb"}, boomanaiden154

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT projects="${1}" targets="${2}" +runtimes="${3}" lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml --use-unique-output-file-name --timeout=1200 --time-tests" echo "--- cmake" export PIP_BREAK_SYSTEM_PACKAGES=1 + pip ins

[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-14 Thread Aiden Grossman via lldb-commits
@@ -52,6 +52,8 @@ "clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, "clang-tools-extra": {"libc"}, "mlir": {"flang"}, +# Test everyything if ci scripts are changed. +".ci": {"llvm", "clang", "lld", "lldb"}, boomanaiden154

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: > That PR is 3 months old? What are the odds or the timeline of it getting > merged? Probably whenever the author gets back to reviewers. There might be a couple rounds of review before things get pushed through, but patches for two subprojects have landed already. The

[Lldb-commits] [clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/78880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/78880 >From 80c9507d7f49ddbc5f2554f597950f797355c255 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sun, 21 Jan 2024 03:53:03 + Subject: [PATCH 1/7] Add make_corpus script test --- .../tests/corpus/ma

[Lldb-commits] [llvm] [libc] [lldb] [compiler-rt] [libcxxabi] [flang] [lld] [libcxx] [clang] [clang-tools-extra] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-19 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lld] [libc] [compiler-rt] [clang-tools-extra] [llvm] [flang] [lldb] [libcxxabi] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-16 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/76653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-23 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/69858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-23 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From 4d94c5fae6f72e3ad551cf3381b0a0e9efecbf9a Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH 1/2] [LLDB] Update docs on building documentation This pa

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From 4d94c5fae6f72e3ad551cf3381b0a0e9efecbf9a Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH] [LLDB] Update docs on building documentation This patch

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From b7ff618fe56ab8ba8cb40c5f69a06a805f4e6e62 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH] [LLDB] Update docs on building documentation This patch

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From b7ff618fe56ab8ba8cb40c5f69a06a805f4e6e62 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH 1/4] [LLDB] Update docs on building documentation This pa

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From b7ff618fe56ab8ba8cb40c5f69a06a805f4e6e62 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH 1/3] [LLDB] Update docs on building documentation This pa

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From b7ff618fe56ab8ba8cb40c5f69a06a805f4e6e62 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH 1/2] [LLDB] Update docs on building documentation This pa

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/69858 This patch updates the documentation to match recent changes and make it more clear. More specifically, the process for installing sphinx has changed with the transition to myst with the requirements.txt

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69834)

2023-10-21 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/69834 This patch updates the documentation to match recent changes and make it more clear. More specifically, the process for installing sphinx has changed with the transition to myst with the requirements.txt