[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
@@ -95,24 +95,25 @@ TC https://github.com/llvm/llvm-project/pull/155120 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Yanzuo Liu via lldb-commits
@@ -95,24 +95,25 @@ TC https://github.com/llvm/llvm-project/pull/155120 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] WIP: Stop using replicated variable ids (PR #124232)

2025-08-23 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: @Anthony-Eid could you rebase this PR, that'd be better to look at it https://github.com/llvm/llvm-project/pull/124232 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From e1c4ead49256ce93ca35dda58b57d96fdb7e001d Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/AST/TemplateBase.h clang/lib/AS

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 6f039d0a53ef53436624b6493bfcf3b6c9ba36cb Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 85ba1ffd8726a1596dfd3aebfd56ebed0460cf77 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From f31c4e385a66cf3e6c7aab499bcba7bd271902fb Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 3996f1f23d55e5d3fa121a75e015ce7fbd3624ca Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-08-23 Thread via lldb-commits
https://github.com/GameRoMan updated https://github.com/llvm/llvm-project/pull/144368 >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of grammar fi

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From 8c8a17a0ac56d31ec9cf8319a5aa33060852ef27 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/4] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
kastiglione wrote: thanks @medismailben, I did another update to add a `dynamic` property, which is effectively an unwrapping operation. These two expressions have the same result: ```py data["id"] == data.GetValueForKey("id").GetUnsignedInteger() ``` https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From 8c8a17a0ac56d31ec9cf8319a5aa33060852ef27 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/3] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-08-23 Thread Baranov Victor via lldb-commits
vbvictor wrote: Hi, could you rebase on fresh main and fix conflicts (should be easy). After that, could be merged https://github.com/llvm/llvm-project/pull/144368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Very cool! LGTM! https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] improve symbol table style (PR #155097)

2025-08-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes * apply odd table rows color from vscode theme * apply hover color from vscode theme [Screencast From 2025-08-23 14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415)

[Lldb-commits] [lldb] [lldb-dap] improve symbol table style (PR #155097)

2025-08-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/155097 * apply odd table rows color from vscode theme * apply hover color from vscode theme [Screencast From 2025-08-23 14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415)

[Lldb-commits] [lldb] Re-land LLDB dap module symbol tables (PR #155021)

2025-08-23 Thread Ely Ronnen via lldb-commits
eronnen wrote: I see that these tests failed in a build run before I merged this commit here: https://lab.llvm.org/buildbot/#/builders/195/builds/13641 https://github.com/llvm/llvm-project/pull/155021 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
Sirraide wrote: > maybe it should be called `TrapReasonBuilder` now? Either name is fine imo. https://github.com/llvm/llvm-project/pull/154618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -144,7 +145,8 @@ class Extension : Diagnostic; class ExtWarn : Diagnostic; // Notes can provide supplementary information on errors, warnings, and remarks. class Note : Diagnostic; - +// Traps messages attached to traps in debug info Sirraide wrote:

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -1534,6 +1536,103 @@ inline DiagnosticBuilder DiagnosticsEngine::Report(unsigned DiagID) { return Report(SourceLocation(), DiagID); } +//===--===// +// RuntimeTrapDiagnosticBuilder and helper classes +//

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -793,6 +795,36 @@ DiagnosticBuilder::DiagnosticBuilder(const DiagnosticBuilder &D) D.Clear(); } +RuntimeTrapDiagnosticBuilder::RuntimeTrapDiagnosticBuilder( +DiagnosticsEngine *DiagObj, unsigned DiagID, TrapReason &TR) +: DiagnosticBuilder(DiagObj, SourceLocation

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -1813,6 +1813,8 @@ void ScalarExprEmitter::EmitBinOpCheck( SanitizerHandler Check; SmallVector StaticData; SmallVector DynamicData; + std::unique_ptr RTDB = nullptr; Sirraide wrote: ```suggestion ``` I think you just forgot to delete this since it’s

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -0,0 +1,21 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -0,0 +1,30 @@ +//==--- DiagnosticTrapKinds.td - CodeGen Diagnostics ---===// Sirraide wrote: ```suggestion //==--- DiagnosticTrapKinds.td - Trap Diagnostics --===// ``` I think you just forgot to update this one. https://gi

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -0,0 +1,21 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -1534,6 +1536,103 @@ inline DiagnosticBuilder DiagnosticsEngine::Report(unsigned DiagID) { return Report(SourceLocation(), DiagID); } +//===--===// +// RuntimeTrapDiagnosticBuilder and helper classes +//

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
https://github.com/Sirraide commented: Just some minor comments; the overall approach looks fine to me. https://github.com/llvm/llvm-project/pull/154618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -1534,6 +1536,103 @@ inline DiagnosticBuilder DiagnosticsEngine::Report(unsigned DiagID) { return Report(SourceLocation(), DiagID); } +//===--===// +// RuntimeTrapDiagnosticBuilder and helper classes +//

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
@@ -1534,6 +1536,103 @@ inline DiagnosticBuilder DiagnosticsEngine::Report(unsigned DiagID) { return Report(SourceLocation(), DiagID); } +//===--===// +// RuntimeTrapDiagnosticBuilder and helper classes +//

[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-23 Thread via lldb-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/154618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-land LLDB dap module symbol tables (PR #155021)

2025-08-23 Thread Ely Ronnen via lldb-commits
eronnen wrote: Don't think I changed anything related, but checking https://github.com/llvm/llvm-project/pull/155021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-land LLDB dap module symbol tables (PR #155021)

2025-08-23 Thread Benjamin Maxwell via lldb-commits
MacDue wrote: There's some errors with `lldb-api::TestDataFormatterGenericForwardList.py` that are possibly from this PR: https://lab.llvm.org/buildbot/#/builders/197/builds/8325? https://github.com/llvm/llvm-project/pull/155021 ___ lldb-commits mail