[Lldb-commits] [lldb] [LLDB] Update SBMemoryRegionInfo doc strings to document len and str (PR #149903)

2025-07-21 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @JDevlieghere How would we go about documenting some of the python methods > `len()` and `str()` in doxygen? Asking for myself if you have an example Since those are Python specific they should remain docstrings in the `.i` interface files. I expect the latter to stick ar

[Lldb-commits] [lldb] [LLDB] Update SBMemoryRegionInfo doc strings to document len and str (PR #149903)

2025-07-21 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/149903 >From e9fdc0a001823db1df26158845301aec94cd2b8a Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 21 Jul 2025 13:29:58 -0700 Subject: [PATCH 1/7] added documenatation on GetDescription --- .../inter

[Lldb-commits] [lldb] [LLDB] Update SBMemoryRegionInfo doc strings to document len and str (PR #149903)

2025-07-21 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/149903 >From e9fdc0a001823db1df26158845301aec94cd2b8a Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 21 Jul 2025 13:29:58 -0700 Subject: [PATCH 1/4] added documenatation on GetDescription --- .../inter

[Lldb-commits] [lldb] [LLDB] Update SBMemoryRegionInfo doc strings to document len and str (PR #149903)

2025-07-21 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/149903 >From e9fdc0a001823db1df26158845301aec94cd2b8a Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 21 Jul 2025 13:29:58 -0700 Subject: [PATCH 1/3] added documenatation on GetDescription --- .../inter

[Lldb-commits] [lldb] [LLDB][NativePDB] Allow type lookup in namespaces (PR #149876)

2025-07-21 Thread Zequan Wu via lldb-commits
@@ -1630,6 +1630,53 @@ size_t SymbolFileNativePDB::ParseSymbolArrayInScope( return count; } +void SymbolFileNativePDB::CacheTypeNames() { ZequanWu wrote: Actually, `SymbolFileNativePDB::BuildParentMap()` already does the tpi stream iteration and it's calle

[Lldb-commits] [lldb] [lldb] Store the dummy target in the selected exeuction context (PR #149615)

2025-07-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/149615 >From 770178784e122e99596280159791c0e7c7db7cf5 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 18 Jul 2025 16:32:06 -0700 Subject: [PATCH] [lldb] Store the dummy target in the selected exeuction

[Lldb-commits] [lldb] [lldb] Store the dummy target in the selected exeuction context (PR #149615)

2025-07-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/149615 >From 2f65e1072e4e8dc729627b79ca6a4afa644f79dd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 18 Jul 2025 16:32:06 -0700 Subject: [PATCH] [lldb] Store the dummy target in the selected exeuction

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread via lldb-commits
@@ -1784,6 +1787,17 @@ static void LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_summary_flags, MsvcStlStringSummaryProvider, "MSVC STL std::u32string summary provider")); + + stl_summary_flags.SetDontShowChildren(false);

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-21 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > To be more precisely, the generated sources also will get built on the host > for the cross-platform builds, but during the second stage when the clang > toolchain for the target platform is already fully in place. Ah ok, this is why for lldb-server it has a CMake variab

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-21 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/149401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-21 Thread via lldb-commits
@@ -127,8 +123,16 @@ def look_for_content_and_continue(self, var_name, patterns): @add_test_categories(["libstdcxx"]) def test_with_run_command_libstdcpp(self): -self.do_test_with_run_command(USE_LIBSTDCPP) +self.build(dictionary={"USE_LIBSTDCPP": 1})

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-21 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149519 >From a791fe9b924b1722d11e11a25d940cc7c858a177 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 18 Jul 2025 16:08:04 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL unordered containers --- .../

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/5] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [docs] Add clang/llvm release notes for mipsel-windows-* targets (PR #147133)

2025-07-21 Thread Hervé Poussineau via lldb-commits
hpoussin wrote: Rebased about branch `origin/release/21.x`, but I'm not sure it is enough. https://github.com/llvm/llvm-project/pull/147133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-21 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149519 >From a791fe9b924b1722d11e11a25d940cc7c858a177 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 18 Jul 2025 16:08:04 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL unordered containers --- .../

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/5] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [docs] Add clang/llvm release notes for mipsel-windows-* targets (PR #147133)

2025-07-21 Thread Hervé Poussineau via lldb-commits
https://github.com/hpoussin updated https://github.com/llvm/llvm-project/pull/147133 From 6296ebd45d3f916bea6bf434c1b5580441f9234a Mon Sep 17 00:00:00 2001 From: Tobias Hieta Date: Tue, 15 Jul 2025 15:59:05 +0200 Subject: [PATCH 01/22] Bump version to 21.1.0-git --- cmake/Modules/LLVMVersion.

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/4] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-21 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: Kindly share any inputs or suggestion, if any. https://github.com/llvm/llvm-project/pull/147990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/149827 None >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -1784,6 +1787,17 @@ static void LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_summary_flags, MsvcStlStringSummaryProvider, "MSVC STL std::u32string summary provider")); + + stl_summary_flags.SetDontShowChildren(false);

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -1784,6 +1787,17 @@ static void LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_summary_flags, MsvcStlStringSummaryProvider, "MSVC STL std::u32string summary provider")); + + stl_summary_flags.SetDontShowChildren(false);

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -1784,6 +1787,17 @@ static void LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_summary_flags, MsvcStlStringSummaryProvider, "MSVC STL std::u32string summary provider")); + + stl_summary_flags.SetDontShowChildren(false);

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/149768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 19e2991 - [lldb] Proofread formatting.rst (#149768)

2025-07-21 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-07-21T07:24:15-07:00 New Revision: 19e299120936a8480b6da35dd8c98a1dd5483a5a URL: https://github.com/llvm/llvm-project/commit/19e299120936a8480b6da35dd8c98a1dd5483a5a DIFF: https://github.com/llvm/llvm-project/commit/19e299120936a8480b6da35dd8c98a1dd5483a5a.diff L

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/149801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
@@ -203,7 +203,7 @@ Scoping Many times the information that you might have in your prompt might not be available and you won``t want it to print out if it isn``t valid. To take care kazutakahirata wrote: Fixed in the latest revision. Thanks! https://github.

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/149768 >From b9c3f2c64644b0fcde6677151a8e49795c18c6cb Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Jul 2025 23:41:50 -0700 Subject: [PATCH 1/2] [lldb] Proofread formatting.rst --- lldb/docs/use/for

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. nice https://github.com/llvm/llvm-project/pull/149519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -127,8 +123,16 @@ def look_for_content_and_continue(self, var_name, patterns): @add_test_categories(["libstdcxx"]) def test_with_run_command_libstdcpp(self): -self.do_test_with_run_command(USE_LIBSTDCPP) +self.build(dictionary={"USE_LIBSTDCPP": 1})

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/148554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 401b5cc - [LLDB] Add formatters for MSVC STL std::variant (#148554)

2025-07-21 Thread via lldb-commits
Author: nerix Date: 2025-07-21T12:46:34+01:00 New Revision: 401b5ccf6b507ed36e959e7ae2f4b5e052647196 URL: https://github.com/llvm/llvm-project/commit/401b5ccf6b507ed36e959e7ae2f4b5e052647196 DIFF: https://github.com/llvm/llvm-project/commit/401b5ccf6b507ed36e959e7ae2f4b5e052647196.diff LOG: [L

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/145033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-07-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/145029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Adds synthetic children and a summary provider for `std::atomic` on MSVC's STL. This currently only supports DWARF because it relies on the template argument. Once there are PDB tests, this will probably use the ret

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::atomic (PR #149801)

2025-07-21 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149801 Adds synthetic children and a summary provider for `std::atomic` on MSVC's STL. This currently only supports DWARF because it relies on the template argument. Once there are PDB tests, this will probably use th

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -130,8 +139,11 @@ Module *Module::GetAllocatedModuleAtIndex(size_t idx) { return nullptr; } +// TODO: needs a mutex +static lldb::user_id_t g_unique_id = 1; + Module::Module(const ModuleSpec &module_spec) -: m_unwind_table(*this), m_file_has_changed(false), +: Us

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes LLDB currently attaches `AsmLabel`s to `FunctionDecl`s such that that the `IRExecutionUnit` can determine which mangled name to call (we can't rely on Clang deriving the correct mangled name to call becaus

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-21 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148554 >From fe30b282bb0ba181060d52ea823e357a5cd6f527 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Mon, 14 Jul 2025 00:30:48 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL std::variant --- .../Plugins/

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread Ebuka Ezike via lldb-commits
@@ -550,6 +550,15 @@ llvm::json::Value CreateStackFrame(DAP &dap, lldb::SBFrame &frame, if (frame.IsArtificial() || frame.IsHidden()) object.try_emplace("presentationHint", "subtle"); + lldb::SBModule module = frame.GetModule(); + if (module.IsValid()) { +std::str

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread Ebuka Ezike via lldb-commits
da-viper wrote: You can either use the `self.dap_server.get_modules` and compare the uuid received with the one returned from the stacktrace request. OR send an evaluate request of `image list --uuid --basename` and regex parse the modules to get the uuid. https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > where a test should go—`DAPTests.cpp`, `ProtocolTypesTest.cpp`, or elsewhere It should go into `TestDAP_stackTrace` https://github.com/llvm/llvm-project/blob/e94bc16b8e12a64ff28aedc58ee6e95e1f9d6f4b/lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py#L29-L31 >Also

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -0,0 +1,23 @@ +#include "Plugins/Process/Linux/NativeProcessLinux.h" +#include "Plugins/Process/Utility/NativeRegisterContextDBReg.h" +#include "lldb/Utility/Status.h" +#include +#include +#include +#include +#include + +namespace lldb_private { +namespace process_linux {

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -102,18 +105,8 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux { uint32_t m_gpr_arm[k_num_gpr_registers_arm]; RegisterInfoPOSIX_arm::FPU m_fpr; - // Debug register info for hardware breakpoints and watchpoints management. - struct DREG { -

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -0,0 +1,63 @@ +#include "NativeRegisterContextLinuxArm64Shared.h" + +using namespace lldb_private::process_linux::arm64; + +namespace lldb_private { +namespace process_linux { +namespace arm64 { DavidSpickett wrote: You don't need `using namespace` if you're t

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -74,8 +75,10 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux { bool WatchpointIsEnabled(uint32_t wp_index); - // Debug register type select - enum DREGType { eDREGTypeWATCH = 0, eDREGTypeBREAK }; + using DREGType = NativeRegisterContextDBR

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -0,0 +1,63 @@ +#include "NativeRegisterContextLinuxArm64Shared.h" DavidSpickett wrote: All new .cpp and .h files need the license header, you can copy one from an existing file and modify it. https://github.com/llvm/llvm-project/pull/147198 _

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -0,0 +1,63 @@ +#include "NativeRegisterContextLinuxArm64Shared.h" + +using namespace lldb_private::process_linux::arm64; + +namespace lldb_private { +namespace process_linux { +namespace arm64 { + +namespace { +Status ReadHardwareDebugInfoHelper(int regset, ::pid_t tid, ---

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -8,6 +8,7 @@ add_lldb_library(lldbPluginProcessLinux NativeRegisterContextLinux.cpp NativeRegisterContextLinux_arm.cpp NativeRegisterContextLinux_arm64.cpp + NativeRegisterContextLinuxArm64Shared.cpp DavidSpickett wrote: We have the term "dbreg" in u

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-21 Thread David Spickett via lldb-commits
@@ -0,0 +1,63 @@ +#include "NativeRegisterContextLinuxArm64Shared.h" DavidSpickett wrote: Also the top of this file needs a comment explaining why it needed to be split out. https://github.com/llvm/llvm-project/pull/147198 __

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -888,22 +890,27 @@ PdbAstBuilder::CreateFunctionDecl(PdbCompilandSymId func_id, tag_record = CVTagRecord::create(index.tpi().getType(*eti)).asTag(); } } + +ConstString mangled_name; +if (auto mangled_name_opt = pdb->FindMangledFunctionName(func_id)

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-07-21 Thread Michael Buch via lldb-commits
@@ -2353,3 +2356,67 @@ SymbolFileNativePDB::GetParentType(llvm::codeview::TypeIndex ti) { return std::nullopt; return parent_iter->second; } + +std::optional +SymbolFileNativePDB::FindMangledFunctionName(PdbCompilandSymId func_id) { + const CompilandIndexItem *cci = +

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149701 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: I don't see anything wrong with trying to attach a mangled name to methods here. Though not a PDB expert so CCing @rnk @ZequanWu https://github.com/llvm/llvm-project/pull/149701 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
https://github.com/woruyu updated https://github.com/llvm/llvm-project/pull/149774 >From 33c94346ac2b96d9f68fd1b8d62aebfa7b273499 Mon Sep 17 00:00:00 2001 From: woruyu <1214539...@qq.com> Date: Mon, 21 Jul 2025 15:52:50 +0800 Subject: [PATCH 1/3] [lldb-dap] support moduleId in the stackTrace res

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/148554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/149545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f0a7462 - [LLDB] Add formatters for MSVC STL std::optional (#149545)

2025-07-21 Thread via lldb-commits
Author: nerix Date: 2025-07-21T10:20:47+01:00 New Revision: f0a7462cf03dd69dc9d5affb870facc098d9e73d URL: https://github.com/llvm/llvm-project/commit/f0a7462cf03dd69dc9d5affb870facc098d9e73d DIFF: https://github.com/llvm/llvm-project/commit/f0a7462cf03dd69dc9d5affb870facc098d9e73d.diff LOG: [L

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py `` Vi

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
https://github.com/woruyu updated https://github.com/llvm/llvm-project/pull/149774 >From 33c94346ac2b96d9f68fd1b8d62aebfa7b273499 Mon Sep 17 00:00:00 2001 From: woruyu <1214539...@qq.com> Date: Mon, 21 Jul 2025 15:52:50 +0800 Subject: [PATCH 1/2] [lldb-dap] support moduleId in the stackTrace res

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
https://github.com/woruyu updated https://github.com/llvm/llvm-project/pull/149774 >From 33c94346ac2b96d9f68fd1b8d62aebfa7b273499 Mon Sep 17 00:00:00 2001 From: woruyu <1214539...@qq.com> Date: Mon, 21 Jul 2025 15:52:50 +0800 Subject: [PATCH 1/2] [lldb-dap] support moduleId in the stackTrace res

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function A

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. With the lack of apostrophes fixed, this LGTM. https://github.com/llvm/llvm-project/pull/149768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread David Spickett via lldb-commits
@@ -203,7 +203,7 @@ Scoping Many times the information that you might have in your prompt might not be available and you won``t want it to print out if it isn``t valid. To take care DavidSpickett wrote: You can fix the uses double back tick instead of apostro

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From bad568743a00fef16b8af90492cf12ab85b38175 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 019e83d2e589b0b90da2db1cc56bb567559db04b Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
woruyu wrote: @da-viper , I added `moduleId` to the `stackTrace` response where I think it fits, but I’m not very familiar with lldb-dap. Would appreciate feedback on whether this is the right place, and where a test should go—`DAPTests.cpp`, `ProtocolTypesTest.cpp`, or elsewhere? Also, is the

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: woruyu (woruyu) Changes ### Summary This PR resolves https://github.com/llvm/llvm-project/issues/149316 --- Full diff: https://github.com/llvm/llvm-project/pull/149774.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/JSONUtils.cpp

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-21 Thread via lldb-commits
https://github.com/woruyu created https://github.com/llvm/llvm-project/pull/149774 ### Summary This PR resolves https://github.com/llvm/llvm-project/issues/149316 >From 33c94346ac2b96d9f68fd1b8d62aebfa7b273499 Mon Sep 17 00:00:00 2001 From: woruyu <1214539...@qq.com> Date: Mon, 21 Jul 2025 15:5