[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] Reland [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types (PR #149613)

2025-07-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `clang-tools-extra,clang,libcxx,lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/27169 Here is the

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] Reland [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types (PR #149613)

2025-07-18 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/149613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] Reland [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types (PR #149613)

2025-07-18 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov approved this pull request. Thanks. It would be awesome to get the more strict check ironed out in another patch, and you can probably put it into a different warning group, not part of Wall. I am sure we can also come up with something to solve the common sugar pro

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] Reland [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types (PR #149613)

2025-07-18 Thread via lldb-commits
YexuanXiao wrote: @kazutakahirata Can you help me verify the usability of this PR? https://github.com/llvm/llvm-project/pull/149613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-18 Thread Vladimir Vereschaka via lldb-commits
vvereschaka wrote: Thank you @chelcassanova, I'll take a look and test the changes with the cross builder. >As I understand it, the lldb-rpc-gen tool would get built on the host, while >the sources are generated and compiled on the target using the just-built tool. To be more precisely, the g

[Lldb-commits] [lldb] [lldb] Use ThreadPlanSP instead of raw ThreadPlan* (NFC) (PR #149598)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes I'm investigating a lifetime issue and I noticed raw ThreadPlan pointers being passed around. Although this may be safe, it's really hard to prove and more fundamentally, defeats the purpose of usin

[Lldb-commits] [lldb] [lldb] Use ThreadPlanSP instead of raw ThreadPlan* (NFC) (PR #149598)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/149598 I'm investigating a lifetime issue and I noticed raw ThreadPlan pointers being passed around. Although this may be safe, it's really hard to prove and more fundamentally, defeats the purpose of using smart

[Lldb-commits] [lldb] 3641448 - [lldb] Use StopInfoSP instead of StopInfo* (NFC)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-18T14:29:20-07:00 New Revision: 3641448e08961d8b8621fafa01167f96d948ee9e URL: https://github.com/llvm/llvm-project/commit/3641448e08961d8b8621fafa01167f96d948ee9e DIFF: https://github.com/llvm/llvm-project/commit/3641448e08961d8b8621fafa01167f96d948ee9e.d

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/148239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/149401 >From 4e692b251329196ff09aa8fc7d0e329c42df1b50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Jul 2025 12:57:58 -0700 Subject: [PATCH 1/4] Add check-memory command to see if an address is in a Minid

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/149541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3c1a09d - [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (#149541)

2025-07-18 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-07-18T13:32:42-07:00 New Revision: 3c1a09d939f44cbe039ea178af5a77c40b2776a0 URL: https://github.com/llvm/llvm-project/commit/3c1a09d939f44cbe039ea178af5a77c40b2776a0 DIFF: https://github.com/llvm/llvm-project/commit/3c1a09d939f44cbe039ea178af5a77c40b2776a0.diff L

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/148736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d64802d - [lldb][framework] Glob headers from source for framework (#148736)

2025-07-18 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-07-18T15:26:09-05:00 New Revision: d64802d6d96ec5aff3739ce34f8143b935921809 URL: https://github.com/llvm/llvm-project/commit/d64802d6d96ec5aff3739ce34f8143b935921809 DIFF: https://github.com/llvm/llvm-project/commit/d64802d6d96ec5aff3739ce34f8143b935921809.d

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
@@ -323,12 +332,24 @@ foreach(header COMMENT "LLDB headers: stage LLDB headers in include directory") list(APPEND lldb_staged_headers ${staged_header}) + + if (LLDB_BUILD_FRAMEWORK) +set(input_header ${staged_header}) +set(output_header $/Headers/${basename}) +

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6a7f572 - [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (#146777)

2025-07-18 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-07-18T13:05:15-07:00 New Revision: 6a7f572ef9758f49fcf9e178ce1cb95aa3069415 URL: https://github.com/llvm/llvm-project/commit/6a7f572ef9758f49fcf9e178ce1cb95aa3069415 DIFF: https://github.com/llvm/llvm-project/commit/6a7f572ef9758f49fcf9e178ce1cb95aa3069415.diff

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148736 >From 97e5d4dbe1dd0be22be0b23c5861808b10a3391d Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 14 Jul 2025 16:58:23 -0500 Subject: [PATCH] [lldb][framework] Glob headers from source for framewo

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148736 >From d56c148eb78fb7e8d750d42921afccd95410956d Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 14 Jul 2025 16:58:23 -0500 Subject: [PATCH] [lldb][framework] Glob headers from source for framewo

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/scripts/framework-header-fix.py lldb/scripts/version-header-fix.py

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148736 >From 31b21cb6fde5d3d9e9a6fc8f2c77edc30167f512 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 14 Jul 2025 16:58:23 -0500 Subject: [PATCH] [lldb][framework] Glob headers from source for framewo

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/149133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] fix extra line after documentation (PR #149482)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/149482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/149541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-18 Thread via lldb-commits
jimingham wrote: > As intended, this is uncovering a non-deterministic issue in LLDB when > running `fork-follow-child-softbp.test`. I'm able to reproduce it locally (on > Linux) but I haven't figured out the cause yet. It's actually pretty encouraging that we only saw one test failure from th

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread via lldb-commits
https://github.com/ayalz approved this pull request. Thanks, now it LGTM! https://github.com/llvm/llvm-project/pull/148239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread via lldb-commits
@@ -103,6 +103,12 @@ struct VPlanTransforms { /// not valid. static bool adjustFixedOrderRecurrences(VPlan &Plan, VPBuilder &Builder); + /// Check if \p Plan contains any FMaxNumNoFMFs or FMinNumNoFMFs reductions. + /// If they do, try to update the vector loop to exit e

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
fhahn wrote: Fixed the PR the remove various changes added by accident. https://github.com/llvm/llvm-project/pull/148239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From b8e611658f462d2963a3f63018823c9f8908c772 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function A

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/149545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: As intended, this is uncovering a non-deterministic issue in LLDB when running `fork-follow-child-softbp.test`. I'm able to reproduce it locally (on Linux) but I haven't figured out the cause yet. https://github.com/llvm/llvm-project/pull/148994

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/opti

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > We agreed that the native parser would be the way forward in the last > EuroLLVM round-table IIRC (CC @JDevlieghere @labath). That's right. The problem is that neither implementation is complete, and things only work because there's an automatic fallback. No matter which

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149545 >From 927e9c7c9bdcd46154095b9cf5f7e714344f48b5 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 18 Jul 2025 18:05:48 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL std::optional --- .../Languag

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: To sum up the conversation I've been having with Vladimir Vereschaka (@vvereschaka) thus far, for the cross-compile build on the lldb-remote-linux-ubuntu bot, the step that generates and compiles the sources from lldb-rpc-gen is taking place too early on the target. It's t

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread Michael Buch via lldb-commits
@@ -1664,6 +1665,8 @@ static void LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { SyntheticChildren::Flags stl_synth_flags; stl_synth_flags.SetCascades(true).SetSkipPointers(false).SetSkipReferences( false); + SyntheticChildren::Flags stl_deref_f

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149545 >From 927e9c7c9bdcd46154095b9cf5f7e714344f48b5 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 18 Jul 2025 18:05:48 +0200 Subject: [PATCH] [LLDB] Add formatters for MSVC STL std::optional --- .../Language/CP

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Adds synthetic children for `std::optional` from MSVC's STL. Most of the machinery for `std::optional` is already there. Towards #24834. --- Full diff: https://github.com/llvm/llvm-project/pull/149545.diff 4 File

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::optional (PR #149545)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149545 Adds synthetic children for `std::optional` from MSVC's STL. Most of the machinery for `std::optional` is already there. Towards #24834. >From 9cb391e86385e1e0400f652b79633cd4e3bd23e1 Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes LLVM Coding Standards discourages llvm::for_each unless we already have a callable. --- Full diff: https://github.com/llvm/llvm-project/pull/149541.diff 1 Files Affected: - (modified) lldb/source/Pl

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/149541 LLVM Coding Standards discourages llvm::for_each unless we already have a callable. >From 906c5777505f9aeedef88c5eecf3327bf56406dd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 17 Jul 2025 10:05

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From 515f1136fb31abd68f4f668beaab9eb65375803d Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 2 Jul 2025 00:17:31 -0700 Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters This

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb] Correct spacing of = {...} when depth limit is hit (PR #149480)

2025-07-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/149480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-18 Thread via lldb-commits
YexuanXiao wrote: > Maybe split out the type sugar part from the warning part when you resubmit? > We could merge the type sugar part back straight away, while the warnings are > improved. I'll relax the checks to prevent false positives (only reporting UB and no longer reporting non-portable

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/issues/114906 as well. https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -941,10 +941,32 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr( m_Intrinsic(m_Value(), m_Value())) || match(I, m_Intrinsic(m_Value(), m_Value())); }; -if (isIntMinMaxRecurrenceKind(Kind) || -(HasRequir

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -103,6 +103,12 @@ struct VPlanTransforms { /// not valid. static bool adjustFixedOrderRecurrences(VPlan &Plan, VPBuilder &Builder); + /// Check if \p Plan contains any FMaxNumNoFMFs or FMinNumNoFMFs reductions. fhahn wrote: Updated thanks! https://gi

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -941,10 +941,32 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr( m_Intrinsic(m_Value(), m_Value())) || match(I, m_Intrinsic(m_Value(), m_Value())); }; -if (isIntMinMaxRecurrenceKind(Kind) || -(HasRequir

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -941,10 +941,32 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr( m_Intrinsic(m_Value(), m_Value())) || match(I, m_Intrinsic(m_Value(), m_Value())); }; -if (isIntMinMaxRecurrenceKind(Kind) || -(HasRequir

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,140 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -652,3 +652,146 @@ void VPlanTransforms::attachCheckBlock(VPlan &Plan, Value *Cond, Term->addMetadata(LLVMContext::MD_prof, BranchWeights); } } + +bool VPlanTransforms::handleMaxMinNumReductionsWithoutFastMath(VPlan &Plan) { + VPRegionBlock *LoopRegion = Plan.getVect

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -42,18 +42,60 @@ define float @fmaxnum(ptr %src, i64 %n) { ; CHECK-LABEL: define float @fmaxnum( ; CHECK-SAME: ptr [[SRC:%.*]], i64 [[N:%.*]]) { ; CHECK-NEXT: [[ENTRY:.*]]: +; CHECK-NEXT:[[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[N]], 8 +; CHECK-NEXT:br i1 [[MIN_ITERS

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -1096,7 +1100,8 @@ Value *llvm::createMinMaxOp(IRBuilderBase &Builder, RecurKind RK, Value *Left, Value *Right) { Type *Ty = Left->getType(); if (Ty->isIntOrIntVectorTy() || - (RK == RecurKind::FMinimum || RK == RecurKind::FMaximum || +

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

2025-07-18 Thread Florian Hahn via lldb-commits
@@ -941,10 +941,32 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr( m_Intrinsic(m_Value(), m_Value())) || match(I, m_Intrinsic(m_Value(), m_Value())); }; -if (isIntMinMaxRecurrenceKind(Kind) || -(HasRequir

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread via lldb-commits
Nerixyz wrote: > I can't find where a `Stream` actually gets "printed" to the stdout. A `NativeFile` stream is used, which is created [here](https://github.com/llvm/llvm-project/blob/a676ecd83fad9b04d315c4e667742d25679cbc9f/lldb/source/Core/Debugger.cpp#L967-L970). > [2b8c692](https://github.c

[Lldb-commits] [lldb] 32f0fc5 - [lldb] Correct spacing of = {...} when depth limit is hit (#149480)

2025-07-18 Thread via lldb-commits
Author: David Spickett Date: 2025-07-18T16:27:46+01:00 New Revision: 32f0fc597f92f98f1be81abbd07f5164377668ef URL: https://github.com/llvm/llvm-project/commit/32f0fc597f92f98f1be81abbd07f5164377668ef DIFF: https://github.com/llvm/llvm-project/commit/32f0fc597f92f98f1be81abbd07f5164377668ef.diff

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > As far as I know, `WriteConsoleW` is the proper way to get Unicode on the > console (this resolved #35615). However, that would require a new output, > because currently, everything goes through the stdout FD and the C API. Thanks for clarifying, I corrected the 4th opt

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 727ab0818b609f3f946af78b8679d3a80c25e175 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into functi

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread via lldb-commits
Nerixyz wrote: > I added `add_compile_options(/execution-charset:utf-8)` to > `llvm-project\lldb\CMakeLists.txt` however that did not fix the issue. Then setting the code page is probably the best idea, requiring the least amount of effort. As far as I know, `WriteConsoleW` is the proper way

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: I added `add_compile_options(/execution-charset:utf-8)` to `llvm-project\lldb\CMakeLists.txt` however that did not fix the issue. https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [lldb] Correct spacing of = {...} when depth limit is hit (PR #149480)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. that bothered me too, thanks! https://github.com/llvm/llvm-project/pull/149480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149519 >From b77b68a23dcf9e88aa604a75cb646dbf5b35789b Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 18 Jul 2025 16:08:04 +0200 Subject: [PATCH] [LLDB] Add formatters for MSVC STL unordered containers --- .../Plug

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/source/Plugins/Language/CPlusPlus/MsvcStlUnord

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From b842db905bf10fd6b89f2dfc07cd6a1eaa2bfd7b Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 2 Jul 2025 00:17:31 -0700 Subject: [PATCH] [lldb][rpc] Upstream RPC Client Library Emitters This

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Adds formatters for MSVC STL's unordered containers. This one is relatively simple, because it can reuse the `std::list` synthetic children. The unordered containers (aka [`_Hash`](https://github.com/microsoft/STL/

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL unordered containers (PR #149519)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149519 Adds formatters for MSVC STL's unordered containers. This one is relatively simple, because it can reuse the `std::list` synthetic children. The unordered containers (aka [`_Hash`](https://github.com/microsoft

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread Michael Buch via lldb-commits
Michael137 wrote: I think as a pre-requisite to this we should remove the non-native PDB parser (and anything associated with it). That way we wouldn't need any special environment variable setting etc. We agreed that the native parser would be the way forward in the last EuroLLVM round-table

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes >From https://github.com/llvm/llvm-project/pull/148554#issuecomment-3083261858 >- this adds an option for API tests to be run with the native PDB reader on >Windows. As there are a lot of failures with PDB, this is

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz ready_for_review https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 457d51e195fd2414424809efd88592884e13272d Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
Nerixyz wrote: I made it opt-in now. A test can set `TEST_WITH_PDB_DEBUG_INFO = True`. Unfortunately, all STL tests currently fail. Most of this is because the demangled name in the native PDB parser has spaces at different positions than the DIA parser which I used before. I'm not sure if it

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 0c9292538507307467cdf8184c5599dbadb79bb9 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [lldb][Expression][NFC] Make LoadAddressResolver::m_target a reference (PR #149490)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/149490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03b7766 - [lldb][Expression][NFC] Make LoadAddressResolver::m_target a reference (#149490)

2025-07-18 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-18T14:31:12+01:00 New Revision: 03b7766dba2f63ee7c9e67f915ea8394f6426f9a URL: https://github.com/llvm/llvm-project/commit/03b7766dba2f63ee7c9e67f915ea8394f6426f9a DIFF: https://github.com/llvm/llvm-project/commit/03b7766dba2f63ee7c9e67f915ea8394f6426f9a.diff

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: >From my understanding of the thread you linked, there are 3 ways to approach >this: 1. Switch to ASCII characters on Windows instead of the `"╰"` character. This is by far the easiest way to fix this specific rendering issue, but does not address the root issue. Debuggi

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: Opened https://github.com/llvm/llvm-project/issues/149498 so you can refer to it. I think it's a reasonable pitch to say: * Formatters that work with PDB are a good idea. * If we opt-in those formatters for testing using PDB, they will be run on at least Linaro's Windows o

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: I ran this on Linaro's bot machine and got these results: ``` Unresolved Tests (5): lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py lldb-api :: lang/c/vla/TestVLA.py lldb-api :: python_api/

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > Windows Terminal is the default on Windows 10 at least. I think buildbot > launches things in conhost, but if utf-8 there was a problem for tests, we > would have seen it before now. I was able to reproduce this with the latest release of lldb in the Windows 11 termina

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > I opened an issue for this #142568. > > Where @Nerixyz mentions that SetConsoleOutputCP might have problems in > cmd.exe (which probably means conhost, the original windows terminal host, as > opposed to "windows terminal", the new one). >From my understanding, the [or

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-18 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -1436,6 +1436,37 @@ bool DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated( return InstrDesc.isAuthenticated() || IsBrkC47x; } +void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef additional_features, +std::string &

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: Windows Terminal is the default on Windows 10 at least. I think buildbot launches things in conhost, but if utf-8 there was a problem for tests, we would have seen it before now. https://github.com/llvm/llvm-project/pull/149493 _

[Lldb-commits] [lldb] [lldb][windows] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: I opened an issue for this https://github.com/llvm/llvm-project/issues/142568. Where @Nerixyz mentions that SetConsoleOutputCP might have problems in cmd.exe (which probably means conhost, the original windows terminal host, as opposed to "windows terminal", the new one).

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/149493 >From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 18 Jul 2025 12:29:31 +0200 Subject: [PATCH 1/2] [windows][lldb] force the console to use a UTF-8 cod

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/source/Plugins/Platform/Windows/PlatformWindow

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
charles-zablit wrote: # Before https://github.com/user-attachments/assets/9b753728-5de8-4a12-9192-e0b53982bc3c"; /> # After https://github.com/user-attachments/assets/4d85e6dc-25d3-4fc4-b1cd-865831c46321"; /> https://github.com/llvm/llvm-project/pull/149493 _

[Lldb-commits] [lldb] [lldb][Expression][NFC] Make LoadAddressResolver::m_target a reference (PR #149490)

2025-07-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/149490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch sets the codepage of the parent Windows console to `utf-8` and resets it back to the original codepage once `lldb` exits. This fixes a rendering issue where the characters defined in `Dia

[Lldb-commits] [lldb] [windows][lldb] force the console to use a UTF-8 codepage (PR #149493)

2025-07-18 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/149493 This patch sets the codepage of the parent Windows console to `utf-8` and resets it back to the original codepage once `lldb` exits. This fixes a rendering issue where the characters defined in `Diagnos

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 386c354b54f619bdad4d3b3f965771282a4647b8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function A

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 4d8da53285939b9db314d374214efd4c3302d1f3 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function A

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression][NFC] Make LoadAddressResolver::m_target a reference (PR #149490)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The only place that passes a target to `LoadAddressResolver` already checks for pointer validity. And inside of the resolver we have been dereferencing the target anyway without nullptr checks. So codify t

  1   2   >