[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-23 Thread Michael Buch via lldb-commits
@@ -193,9 +193,8 @@ struct StatisticsOptions { bool GetIncludeTranscript() const { if (m_include_transcript.has_value()) return m_include_transcript.value(); -// `m_include_transcript` has no value set, so return a value based on -// `m_summary_only`. -r

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-23 Thread Michael Buch via lldb-commits
Michael137 wrote: > It seems the buildbot > [lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/10819) > is broken after this patch. > > ``` > Unresolved Tests (3): > lldb-api :: > commands/expression/import-std-module/basic/TestImportStdModule.py > lldb-api ::

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-23 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/143786 >From 837e8dd36446104b207248c9dbf372a6da6ffbf1 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Wed, 11 Jun 2025 14:24:17 -0700 Subject: [PATCH 1/8] [LLDB] Update DIL to handle smart pointers; add more tests.

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-23 Thread via lldb-commits
@@ -0,0 +1,34 @@ +""" +Test DIL pointer dereferencing. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + + +class TestFrameVarDILPointerDereference(Tes

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-23 Thread via lldb-commits
@@ -0,0 +1,26 @@ +#include + +struct NodeS; + +// Fake smart pointer definition. +class smart_ptr { +public: + NodeS *__ptr_; cmtice wrote: Done. https://github.com/llvm/llvm-project/pull/143786 ___ lldb-commits mail

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-23 Thread via lldb-commits
@@ -0,0 +1,32 @@ +import lldb + + +class smartPtrSynthProvider: +def __init__(self, valobj, dict): +self.valobj = valobj + +def num_children(self): +return 1 + +def get_child_at_index(self, index): +if index == 0: +return self.valobj

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-23 Thread via lldb-commits
jeffreytan81 wrote: @vvereschaka, are you only seeing `TestStats.py` timeout on Windows or Linux as well? cc @qxy11 to follow-up. https://github.com/llvm/llvm-project/pull/144424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/145212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 975d4df - [lldb] Remove an unused local variable (NFC) (#145212)

2025-06-23 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-06-23T18:04:26-07:00 New Revision: 975d4df147adf1bcfe200222626dc0121bf2b787 URL: https://github.com/llvm/llvm-project/commit/975d4df147adf1bcfe200222626dc0121bf2b787 DIFF: https://github.com/llvm/llvm-project/commit/975d4df147adf1bcfe200222626dc0121bf2b787.diff L

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-23 Thread via lldb-commits
qxy11 wrote: cc @jeffreytan81 @clayborg @dmpots https://github.com/llvm/llvm-project/pull/145436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Fix bug in convert script for RPC (PR #145419)

2025-06-23 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/145419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 92a7f6f - [lldb][rpc] Fix bug in convert script for RPC (#145419)

2025-06-23 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-06-23T15:46:12-07:00 New Revision: 92a7f6fbbe489c02bad77a41cf2d4154c3885796 URL: https://github.com/llvm/llvm-project/commit/92a7f6fbbe489c02bad77a41cf2d4154c3885796 DIFF: https://github.com/llvm/llvm-project/commit/92a7f6fbbe489c02bad77a41cf2d4154c3885796.d

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/test/API/comma

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] e391301 - [lldb] Use `proc` instead of `pro` to avoid command ambiguity

2025-06-23 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-23T10:35:48-07:00 New Revision: e391301e0e4d9183fe06e69602e87b0bc889aeda URL: https://github.com/llvm/llvm-project/commit/e391301e0e4d9183fe06e69602e87b0bc889aeda DIFF: https://github.com/llvm/llvm-project/commit/e391301e0e4d9183fe06e69602e87b0bc889aeda.d

[Lldb-commits] [lldb] [llvm] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/145175 >From fa67d1dc9ffa3157b3d1a5dd9173b99d7e6b75ef Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:36:58 +0200 Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows --- .../O

[Lldb-commits] [lldb] 698e9f5 - [lldb] Add support for NoneType to decorator skipIfBuildType (#145342)

2025-06-23 Thread via lldb-commits
Author: Ivan Tadeu Ferreira Antunes Filho Date: 2025-06-23T12:23:19-04:00 New Revision: 698e9f56558e20ceb80c08c4a880bed15970b777 URL: https://github.com/llvm/llvm-project/commit/698e9f56558e20ceb80c08c4a880bed15970b777 DIFF: https://github.com/llvm/llvm-project/commit/698e9f56558e20ceb80c08c4a8

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-23 Thread Vladimir Vereschaka via lldb-commits
vvereschaka wrote: Hi @jeffreytan81, looks like TestStats.py test is not working properly with these changes https://lab.llvm.org/staging/#/builders/211/builds/565 would you take care of it? https://github.com/llvm/llvm-project/pull/144424 ___ lldb-c

[Lldb-commits] [lldb] [lldb] Defend against infinite recursion in GetClassDescriptor (PR #145396)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/145396 We defend against a direct cycle where a base class ValueObject is its own parent, but not against a longer base cycle. This cycle requires that some value's Type includes a base class, and that base class

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-06-23 Thread via lldb-commits
jimingham wrote: Your solution is going in the right direction, but is trying to solve a problem "after the fact" that we can solve better by preventing the public stop events from making their way to the non-primary listener before the primary listener gets a chance to fully process them. Pr

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread Chad Smith via lldb-commits
https://github.com/cs01 created https://github.com/llvm/llvm-project/pull/145382 AdbClient and PlatformAndroid GetSyncService is not threadsafe. This was not an issue because it was (apparently) not used in a threaded environment. However when the new setting ``` set target.parallel-module-loa

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread John Harrison via lldb-commits
@@ -101,7 +101,8 @@ def test_server_interrupt(self): # Interrupt the server which should disconnect all clients. process.send_signal(signal.SIGINT) -self.dap_server.wait_for_terminated() +self.dap_server.wait_for_event(["terminated", "exited"])

[Lldb-commits] [lldb] 634fe0d - [lldb][DWARF] Support retrieving DW_FORM_implicit_const value with DWARFDebugInfoEntry::GetAttributeValue (#145328)

2025-06-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-06-23T17:25:57+01:00 New Revision: 634fe0de50418464635227443c1ac866362e2f08 URL: https://github.com/llvm/llvm-project/commit/634fe0de50418464635227443c1ac866362e2f08 DIFF: https://github.com/llvm/llvm-project/commit/634fe0de50418464635227443c1ac866362e2f08.diff

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #144913)

2025-06-23 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/144913 >From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 19 Jun 2025 16:17:33 +0100 Subject: [PATCH 1/2] [lldb][darwin] force BuiltinHeadersInSystemModules t

[Lldb-commits] [lldb] [llvm] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread via lldb-commits
@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(header_sp); unified_section_list.AddSection(header_sp); +std::vector truncated_dwarf_sections; const uint32_t nsects = m_sect_headers.

[Lldb-commits] [lldb] [lldb-dap] Fix URL label and error code in DAPError (PR #145010)

2025-06-23 Thread via lldb-commits
DrSergei wrote: > @DrSergei Do you need one of us to merge this on your behalf? Yes, please https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [lldb] Defend against infinite recursion in GetClassDescriptor (PR #145396)

2025-06-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We defend against a direct cycle where a base class ValueObject is its own parent, but not against a longer base cycle. This cycle requires that some value's Type includes a base class, and that bas

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-06-23 Thread via lldb-commits
jimingham wrote: Note, I have a patch I'm almost done with (finishing the test case now) that handles a similar version of this problem. "Attach" and "Launch" don't spin up the private state thread until they know the attach/launch succeeded, which means that the first event that comes in is

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-23 Thread via lldb-commits
github-actions[bot] wrote: @qxy11 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-23 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/144424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3095d3a - [lldb] Add count for number of DWO files loaded in statistics (#144424)

2025-06-23 Thread via lldb-commits
Author: qxy11 Date: 2025-06-23T11:51:08-07:00 New Revision: 3095d3a47d624b573d0748ee37f8f201d5702b63 URL: https://github.com/llvm/llvm-project/commit/3095d3a47d624b573d0748ee37f8f201d5702b63 DIFF: https://github.com/llvm/llvm-project/commit/3095d3a47d624b573d0748ee37f8f201d5702b63.diff LOG: [l

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-23 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: It seems the buildbot [lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/10819) is broken after this patch. ``` Unresolved Tests (3): lldb-api :: commands/expression/import-std-module/basic/TestImportStdModule.py lldb-api :: commands/expression/i

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread Chad Smith via lldb-commits
https://github.com/cs01 converted_to_draft https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chad Smith (cs01) Changes AdbClient and PlatformAndroid GetSyncService is not threadsafe. This was not an issue because it was (apparently) not used in a threaded environment. However when the new setting ``` set target.parallel-module-lo

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-23 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread via lldb-commits
github-actions[bot] wrote: @zyn-li Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] ff865b6 - [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (#144815)

2025-06-23 Thread via lldb-commits
Author: Zyn Date: 2025-06-23T13:02:51-05:00 New Revision: ff865b639af05e366b108c7acb034e3d0e069376 URL: https://github.com/llvm/llvm-project/commit/ff865b639af05e366b108c7acb034e3d0e069376 DIFF: https://github.com/llvm/llvm-project/commit/ff865b639af05e366b108c7acb034e3d0e069376.diff LOG: [lld

[Lldb-commits] [lldb] [lldb-dap] Fix URL label and error code in DAPError (PR #145010)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/145231 >From b3b919db7333ee20bc640e1b4b5a701891cc6443 Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Thu, 19 Jun 2025 15:50:27 +0300 Subject: [PATCH] [lldb-dap] Fix flaky test --- lldb/test/API/tools/lldb-dap/

[Lldb-commits] [lldb] Reland "[lldb][target] Add progress report for wait-attaching to proc… (PR #145111)

2025-06-23 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > I wonder if you would be better off actually attaching to something. Then you > don't have to do all this waiting around, the progress message should still > be there. This is best thing to try here, I'll update the test to do this. https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb] Eliminate check for HasLoadedSections (NFC) (PR #145366)

2025-06-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We can omit the call to Target::HasLoadedSections as Address::HasLoadedSections already "does the right thing" and returns LLDB_INVALID_ADDRESS if no sections are loaded. --- Full diff: https://git

[Lldb-commits] [lldb] [lldb] Eliminate check for HasLoadedSections (NFC) (PR #145366)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/145366 We can omit the call to Target::HasLoadedSections as Address::HasLoadedSections already "does the right thing" and returns LLDB_INVALID_ADDRESS if no sections are loaded. >From 1df38e3639abcd0c009024e6d49

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/145231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/145231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix DAPError (PR #145010)

2025-06-23 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix URL label and error code in DAPError (PR #145010)

2025-06-23 Thread via lldb-commits
https://github.com/DrSergei edited https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8d83d04 - [lldb] add plugin names to process save-core error output. (#143126)

2025-06-23 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-23T18:02:58+01:00 New Revision: 8d83d046376e7b57c1aa0c5bdd8958b21bbaf0ca URL: https://github.com/llvm/llvm-project/commit/8d83d046376e7b57c1aa0c5bdd8958b21bbaf0ca DIFF: https://github.com/llvm/llvm-project/commit/8d83d046376e7b57c1aa0c5bdd8958b21bbaf0ca.diff L

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread via lldb-commits
@@ -310,7 +310,7 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, "DAP session (" + client_name + ") error: "); } - + io->Close(); DrSerge

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/145231 >From f0b48bffc61c8f2b1c52d3f26b8a8b210a3756f7 Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Thu, 19 Jun 2025 15:50:27 +0300 Subject: [PATCH] [lldb-dap] Fix flaky test --- lldb/test/API/tools/lldb-dap/

[Lldb-commits] [lldb] 5a16645 - Reland "[lldb][DWARF] Remove object_pointer from ParsedDWARFAttributes (#145065)" (#145126)

2025-06-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-06-23T17:26:23+01:00 New Revision: 5a16645a3da29f3c1c2ef4ebc908e57a41bab87b URL: https://github.com/llvm/llvm-project/commit/5a16645a3da29f3c1c2ef4ebc908e57a41bab87b DIFF: https://github.com/llvm/llvm-project/commit/5a16645a3da29f3c1c2ef4ebc908e57a41bab87b.diff

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Ivan Tadeu Ferreira Antunes Filho via lldb-commits
https://github.com/itf closed https://github.com/llvm/llvm-project/pull/145342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/144998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1bc6326 - [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (#144998)

2025-06-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-06-23T17:58:17+01:00 New Revision: 1bc63265afbe007b9ec023e35a10fa0a8143e95b URL: https://github.com/llvm/llvm-project/commit/1bc63265afbe007b9ec023e35a10fa0a8143e95b DIFF: https://github.com/llvm/llvm-project/commit/1bc63265afbe007b9ec023e35a10fa0a8143e95b.diff

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @zyn-li please let me know if you need us to land this on your behalf. https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread via lldb-commits
zyn-li wrote: @JDevlieghere Hi, greatly appreciate it if you could land it for me. Thank you! cc: @Jlalond https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] 909cbcf - [lldb-dap] Fix URL label and error code in DAPError (#145010)

2025-06-23 Thread via lldb-commits
Author: DrSergei Date: 2025-06-23T11:34:22-05:00 New Revision: 909cbcf988fe7454660ce316ec1102a5591606a8 URL: https://github.com/llvm/llvm-project/commit/909cbcf988fe7454660ce316ec1102a5591606a8 DIFF: https://github.com/llvm/llvm-project/commit/909cbcf988fe7454660ce316ec1102a5591606a8.diff LOG:

[Lldb-commits] [lldb] Reland "[lldb][DWARF] Remove object_pointer from ParsedDWARFAttributes (#145065)" (PR #145126)

2025-06-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/145126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread Michael Buch via lldb-commits
@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(header_sp); unified_section_list.AddSection(header_sp); +std::vector truncated_dwarf_sections; const uint32_t nsects = m_sect_headers.

[Lldb-commits] [lldb] [lldb][DWARF] Support retrieving DW_FORM_implicit_const value with DWARFDebugInfoEntry::GetAttributeValue (PR #145328)

2025-06-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/145328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-23 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/144731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a0329ea - [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (#144731)

2025-06-23 Thread via lldb-commits
Author: Charles Zablit Date: 2025-06-23T18:41:48+02:00 New Revision: a0329eaa0cdcc86046c66533feb002b227553c33 URL: https://github.com/llvm/llvm-project/commit/a0329eaa0cdcc86046c66533feb002b227553c33 DIFF: https://github.com/llvm/llvm-project/commit/a0329eaa0cdcc86046c66533feb002b227553c33.diff

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/144731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/144998 >From 90cbdaf1bc0151cb57465b0741b2cf1560edce62 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 29 Jan 2025 12:15:35 + Subject: [PATCH 1/7] [lldb][DWARFASTParserClang] Support constant index encodi

[Lldb-commits] [lldb] [lldb-dap] Fix DAPError (PR #145010)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @DrSergei Do you need one of us to merge this on your behalf? https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/145342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/145342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix DAPError (PR #145010)

2025-06-23 Thread via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/145010 >From 83fefeedb9f758c2e765925a4fbd2a7af375876a Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Thu, 19 Jun 2025 15:50:27 +0300 Subject: [PATCH] [lldb-dap] Fix URL label and error code in DAPError --- lld

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Ivan Tadeu Ferreira Antunes Filho via lldb-commits
https://github.com/itf updated https://github.com/llvm/llvm-project/pull/145342 >From a79352fe1eac306b6065b1cba165b176ddc1376f Mon Sep 17 00:00:00 2001 From: Ivan Tadeu Ferreira Antunes Filho Date: Mon, 23 Jun 2025 11:30:09 -0400 Subject: [PATCH 1/3] [lldb] Add support to NoneType to decorator

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-23 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-23 Thread Ebuka Ezike via lldb-commits
@@ -310,7 +310,7 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, "DAP session (" + client_name + ") error: "); } - + io->Close(); da-vipe

[Lldb-commits] [lldb] [lldb][DWARF] Support retrieving DW_FORM_implicit_const value with DWARFDebugInfoEntry::GetAttributeValue (PR #145328)

2025-06-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/145328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][DWARF] Remove object_pointer from ParsedDWARFAttributes (#145065)" (PR #145126)

2025-06-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/145126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/145175 >From 72f30f6d2a1dfb5523bafd4a535b078b3de5cfc6 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:36:58 +0200 Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows --- .../O

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/145342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/decorators.py `` View the d

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-23 Thread Ivan Tadeu Ferreira Antunes Filho via lldb-commits
@@ -2,23 +2,35 @@ Test lldb-dap RestartRequest. """ -import os -from lldbsuite.test.decorators import * -from lldbsuite.test.lldbtest import line_number +from typing import Dict, Any, List + import lldbdap_testcase +from lldbsuite.test.decorators import skipIfWindows, skipIf,

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Ivan Tadeu Ferreira Antunes Filho via lldb-commits
https://github.com/itf updated https://github.com/llvm/llvm-project/pull/145342 >From a79352fe1eac306b6065b1cba165b176ddc1376f Mon Sep 17 00:00:00 2001 From: Ivan Tadeu Ferreira Antunes Filho Date: Mon, 23 Jun 2025 11:30:09 -0400 Subject: [PATCH 1/2] [lldb] Add support to NoneType to decorator

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ivan Tadeu Ferreira Antunes Filho (itf) Changes Currently if cmake_build_type is None we error with `AttributeError: 'NoneType' object has no attribute 'lower'` if the decorator skipIfBuildType is used. This fixes the issue by first checki

[Lldb-commits] [lldb] [lldb] Add support for NoneType to decorator skipIfBuildType (PR #145342)

2025-06-23 Thread Ivan Tadeu Ferreira Antunes Filho via lldb-commits
https://github.com/itf created https://github.com/llvm/llvm-project/pull/145342 Currently if cmake_build_type is None we error with `AttributeError: 'NoneType' object has no attribute 'lower'` if the decorator skipIfBuildType is used. This fixes the issue by first checking that cmake_build_type

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: Actually, add an entry to https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb as well. It's not something I'd normally put in the release notes but it may appear in existing workflows when people update. If it's in the release notes we

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. Whether it can be extended to other known sections, that's up to you, but in its current DWARF specific form I like it. https://github.com/llvm/llvm-project/pull/145175 ___ lldb-commi

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread David Spickett via lldb-commits
@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(header_sp); unified_section_list.AddSection(header_sp); +std::vector truncated_dwarf_sections; const uint32_t nsects = m_sect_headers.

[Lldb-commits] [lldb] [lldb-dap] Fix DAPError (PR #145010)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,38 @@ +//===-- DAPErrorTest.cpp +//---===// JDevlieghere wrote: Broken ASCII art https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb-dap] Fix DAPError (PR #145010)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. I would suggest making the title of this PR a bit more descriptive (e.g. "Fix URL label in DAPError") before merging. https://github.com/llvm/llvm-project/pull/145010 ___ lldb-commits

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread David Spickett via lldb-commits
@@ -1071,6 +1077,15 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(section_sp); unified_section_list.AddSection(section_sp); } + +if (!truncated_dwarf_sections.empty()) + module_sp->ReportWarning

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-23 Thread David Spickett via lldb-commits
@@ -173,6 +173,22 @@ help="Specify the C/C++ standard.", ) +parser.add_argument( DavidSpickett wrote: Ok, these are fine then. https://github.com/llvm/llvm-project/pull/145175 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/145212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/145338 >From 4b5a55eb2d7e8430eca4b76644b08fe705fbfec6 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 23 Jun 2025 14:29:53 + Subject: [PATCH 1/3] [lldb][AArch64] Handle core file tag segments missing

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/145338 >From 4b5a55eb2d7e8430eca4b76644b08fe705fbfec6 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 23 Jun 2025 14:29:53 + Subject: [PATCH 1/2] [lldb][AArch64] Handle core file tag segments missing

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes In the same way that memory regions may be known from a core file but not readable, tag segments can also have no content. For example: $ readelf --segments core <...> Program Headers: Type

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/145338 In the same way that memory regions may be known from a core file but not readable, tag segments can also have no content. For example: $ readelf --segments core <...> Program Headers: Type Of

[Lldb-commits] [lldb] [lldb] Deploy Python DLL on Windows (PR #137467)

2025-06-23 Thread via lldb-commits
Nerixyz wrote: Ping - would be great if the prebuilt binaries for the next release could include the python DLL. https://github.com/llvm/llvm-project/pull/137467 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-23 Thread via lldb-commits
@@ -1372,6 +1373,36 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "${var.__y_} ${var.__m_} ${var.__wdl_}"))); } +static void RegisterStdStringSummaryProvider( +const lldb::TypeCategoryImplSP &category_sp, llvm::StringRef string_

  1   2   >