[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
https://github.com/Thrrr closed https://github.com/llvm/llvm-project/pull/142747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-04 Thread via lldb-commits
@@ -246,6 +246,9 @@ llvm::StringRef SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() { } SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) { + // Don't create a debug map if the object file isn't a Mach-O. + if (!objfile_sp->GetArchitecture()

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139170 >From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 07:38:20 -0700 Subject: [PATCH 1/6] [lldb] Do not create SymbolFileDWARFDebugMap for non-Mach-O files

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
Thrrr wrote: Hi [dwblaikie](https://github.com/dwblaikie), Thanks for the clear explanation and guidance on handling cross-project changes between LLVM and LLDB. I completely understand the reasoning behind avoiding/splitting such commits, and your suggestions make perfect sense for better

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #142882)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM but I'm confused by the choice of reviewers given that this is a file in LLDB. https://github.com/llvm/llvm-project/pull/142882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
@@ -94,4 +94,59 @@ TEST_F(ObjectFileMachOTest, IndirectSymbolsInTheSharedCache) { for (size_t i = 0; i < 10; i++) OF->ParseSymtab(symtab); } + +TEST_F(ObjectFileMachOTest, ObjectFileFormatWithoutLoadCommand) { royitaqi wrote: Updated in latest commit.

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139170 >From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 07:38:20 -0700 Subject: [PATCH 1/5] [lldb] Do not create SymbolFileDWARFDebugMap for non-Mach-O files

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread John Harrison via lldb-commits
ashgti wrote: #142831 should fix this https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #142882)

2025-06-04 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/142882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

2025-06-04 Thread Prabhu Rajasekaran via lldb-commits
Prabhuk wrote: @jimingham The suggested fix did not address the test failures. Log file: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8712946848893941121/+/u/test_lldb/check_lldb/stdout The builder attempted this run from here: The builder ran the tests from here: https:

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #142882)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes Note that CommandArgumentEntry is an alias for: std::vector --- Full diff: https://github.com/llvm/llvm-project/pull/142882.diff 1 Files Affected: - (modified) lldb/source/Com

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #142882)

2025-06-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/142882 Note that CommandArgumentEntry is an alias for: std::vector >From 2e800e08e7645c82e86d2b466bd7cc0ba2b0d915 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 4 Jun 2025 12:50:57 -0700 Subject: [PA

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread via lldb-commits
royitaqi wrote: FYI It seems this has broken the [lldb-aarch64-ubuntu](https://lab.llvm.org/buildbot/#/builders/59) build bot. https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, Breakpoints. (PR #141983)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/141983 >From 60ca2ac18ccff832d2137107d3f5161614c02dd1 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 29 May 2025 09:55:42 -0700 Subject: [PATCH] [lldb-dap] Test Gardening, Breakpoints. Enabling the breakpoint

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, attach tests. (PR #141981)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/141981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7278805 - [lldb-dap] Test Gardening, attach tests. (#141981)

2025-06-04 Thread via lldb-commits
Author: John Harrison Date: 2025-06-04T17:07:28-07:00 New Revision: 7278805ccd46732445b7f1b365bea64135e4537b URL: https://github.com/llvm/llvm-project/commit/7278805ccd46732445b7f1b365bea64135e4537b DIFF: https://github.com/llvm/llvm-project/commit/7278805ccd46732445b7f1b365bea64135e4537b.diff

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d4d2f06 - [lldb] Set default object format to `MachO` in `ObjectFileMachO` (#142704)

2025-06-04 Thread via lldb-commits
Author: royitaqi Date: 2025-06-04T17:07:07-07:00 New Revision: d4d2f069dec4fb8b13447f52752d4ecd08d976d6 URL: https://github.com/llvm/llvm-project/commit/d4d2f069dec4fb8b13447f52752d4ecd08d976d6 DIFF: https://github.com/llvm/llvm-project/commit/d4d2f069dec4fb8b13447f52752d4ecd08d976d6.diff LOG:

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/142875 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga ready_for_review https://github.com/llvm/llvm-project/pull/142875 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/142875 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
@@ -152,7 +152,7 @@ struct DAP { llvm::DenseSet clientFeatures; /// The initial thread list upon attaching. - std::optional initial_thread_list; + std::optional> initial_thread_list; ashgti wrote: Changed to just a vector that we check. https://github.

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
@@ -414,6 +414,16 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A Thread. +struct Thread { + /// Unique identifier for the thread. + lldb::tid_t id; ---

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142510 >From 3a16210ba7643608dd0bd6a1ff4a76b4e72c74e3 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Jun 2025 18:07:52 -0700 Subject: [PATCH 1/6] [lldb-dap] Migrating 'threads' request to structured types.

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From 2d63dfe6e4f9671d3c22c319e01782aacee303e4 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga updated https://github.com/llvm/llvm-project/pull/142875 >From 4038f339bf5f359121848893eaeba90226ac01d6 Mon Sep 17 00:00:00 2001 From: satya janga Date: Wed, 4 Jun 2025 09:40:51 -0700 Subject: [PATCH] Minor fix to connect-url to support unix-connect sockets on loc

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga updated https://github.com/llvm/llvm-project/pull/142875 >From f4a3953d3556ce6ab54294d8b6aff8f7f71183ef Mon Sep 17 00:00:00 2001 From: satya janga Date: Wed, 4 Jun 2025 09:40:51 -0700 Subject: [PATCH] Minor fix to connect-url to support unix-connect sockets on loc

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/platform/connect/TestPlatformConnect.py ``

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (satyajanga) Changes Summary: when the unix-socket connections on localhost are used to for platform connect i.e. `platform connect unix-connect:///path/to/socket.sock` then `PlatformRemoteGDBServer.m_platform_hostname` is empty. Bas

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga converted_to_draft https://github.com/llvm/llvm-project/pull/142875 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-04 Thread via lldb-commits
https://github.com/satyajanga created https://github.com/llvm/llvm-project/pull/142875 Summary: when the unix-socket connections on localhost are used to for platform connect i.e. `platform connect unix-connect:///path/to/socket.sock` then `PlatformRemoteGDBServer.m_platform_hostname` is empty

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142510 >From 2fd86de03cbb207420ee45334639f82d19dbbc28 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Jun 2025 18:07:52 -0700 Subject: [PATCH 1/5] [lldb-dap] Migrating 'threads' request to structured types.

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -290,6 +290,45 @@ else() endif() endif() +# Stage all headers in the include directory in the build dir. +file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h) +set(lldb_header_staging_dir ${CMAKE_BINARY_DIR}/include/lldb) +file(GLOB root_public_headers ${LLDB

[Lldb-commits] [lldb] Reland "[lldb][headers] Create script to fix up versioning" (#142864)" (PR #142871)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This relands the original commit for the versioning script in LLDB. This commit uses '>' for output from `unifdef` for platforms that have that executable but do not have the `-o` option. It also f

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Patch to reland this patch: https://github.com/llvm/llvm-project/pull/142871 https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] Reland "[lldb][headers] Create script to fix up versioning" (#142864)" (PR #142871)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/142871 This relands the original commit for the versioning script in LLDB. This commit uses '>' for output from `unifdef` for platforms that have that executable but do not have the `-o` option. It also fixes th

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/142704 >From d01f75f4b8f75676ae15730f0035cca685dc5195 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 3 Jun 2025 17:04:29 -0700 Subject: [PATCH 1/3] Set default object format. Add test. --- .../ObjectFile/Mach-O/O

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > For the unifdef executable, -o option is not available in some of the system > like AIX, and its giving warning while building lldb on AIX. Is there any way to generate the output file without -o? may be using '>' operation ? I think this should be possible, although try

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
@@ -110,4 +116,50 @@ std::string GetLoadAddressString(const lldb::addr_t addr) { return "0x" + llvm::utohexstr(addr, false, 16); } +protocol::Thread CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { + std::string name; + lldb::SBStream stream; + if (format &&

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
@@ -414,6 +414,16 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A Thread. +struct Thread { + /// Unique identifier for the thread. + lldb::tid_t id; ---

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
@@ -152,7 +152,7 @@ struct DAP { llvm::DenseSet clientFeatures; /// The initial thread list upon attaching. - std::optional initial_thread_list; + std::optional> initial_thread_list; JDevlieghere wrote: Is it worth distinguishing between an empty list a

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Can you please revert this while we investigate both issues? Just reverted in https://github.com/llvm/llvm-project/pull/142864 https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] Revert "[lldb][headers] Create script to fix up versioning" (PR #142864)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes Reverts llvm/llvm-project#141116. It's breaking the Xcode build as well as the build on AIX. --- Full diff: https://github.com/llvm/llvm-project/pull/142864.diff 5 Files Affected: - (modified) l

[Lldb-commits] [lldb] Revert "[lldb][headers] Create script to fix up versioning" (PR #142864)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/142864 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e5cfa0a - Revert "[lldb][headers] Create script to fix up versioning" (#142864)

2025-06-04 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-06-04T15:04:36-07:00 New Revision: e5cfa0a15d58c278be6169aedba817ae5edd2235 URL: https://github.com/llvm/llvm-project/commit/e5cfa0a15d58c278be6169aedba817ae5edd2235 DIFF: https://github.com/llvm/llvm-project/commit/e5cfa0a15d58c278be6169aedba817ae5edd2235.d

[Lldb-commits] [lldb] Revert "[lldb][headers] Create script to fix up versioning" (PR #142864)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/142864 Reverts llvm/llvm-project#141116. It's breaking the Xcode build as well as the build on AIX. >From f0ca2226ce6c04d0585f80ffb08b52908e121e54 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 4 J

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can you please revert this while we investigate both issues? https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This also appears to be breaking the Xcode build: ``` 19:57:50 CMake Error in source/API/CMakeLists.txt: 19:57:50The custom command generating 19:57:50 19:57:50 /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-standalone/lldb-xcode-build/include/lldb/LLDB.h

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/decorators.py lldb/test/API/macosx/simu

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142244 >From ff28c4be506dd762a4f8550a4a5a44578e34535d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Jun 2025 16:03:36 -0700 Subject: [PATCH] [lldb] Revive TestSimulatorPlatform.py This test was in

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/142815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/142815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 9d6d38f912fd7bb7260839e5c44f0614b5b78da1 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/142815 >From 14a5860c98b5c0c067c8b12ccbaf32bfa45b1a66 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 4 Jun 2025 09:53:12 -0700 Subject: [PATCH 1/4] [lldb] Provide TrackingOutputBufferDeleter for custom u

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
@@ -159,4 +160,23 @@ struct TrackingOutputBuffer : public llvm::itanium_demangle::OutputBuffer { }; } // namespace lldb_private +/// Custom deleter to use with unique_ptr. +/// +/// Usage: +/// \code{.cpp} +/// +/// auto OB = +/// std::unique_ptr( +/// new Trackin

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/142815 >From 14a5860c98b5c0c067c8b12ccbaf32bfa45b1a66 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 4 Jun 2025 09:53:12 -0700 Subject: [PATCH 1/3] [lldb] Provide TrackingOutputBufferDeleter for custom u

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b8096b6ce5f76bcb2866e4f656b519f4918b4dda Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From c0079c3a84f65f362df25ec1dd4e4b263b7d5065 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From a431ee3044cbcf4ddb4e31866a342aecb3c34c62 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142831 >From ad3cd275d38fda7b61c96c532d4f807953beecf5 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 4 Jun 2025 11:03:37 -0700 Subject: [PATCH 1/2] [lldb-dap] Creating a 'capabilities' event helper. This adds

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
@@ -89,17 +91,14 @@ def test_supported_capability_x86_arch(self): self.assertEqual( len(breakpoint_ids), len(bp_lines), "expect correct number of breakpoints" ) -is_supported = self.dap_server.get_initialize_value( -"supportsStep

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142831 >From ad3cd275d38fda7b61c96c532d4f807953beecf5 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 4 Jun 2025 11:03:37 -0700 Subject: [PATCH 1/3] [lldb-dap] Creating a 'capabilities' event helper. This adds

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
@@ -491,13 +495,11 @@ def wait_for_terminated(self, timeout: Optional[float] = None): raise ValueError("didn't get terminated event") return event_dict -def get_initialize_value(self, key): +def get_capability(self, key, default=None): """

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
@@ -30,6 +30,8 @@ def test_basic(self): self.assertEqual( len(breakpoint_ids), len(lines), "expect correct number of breakpoints" ) +# Target based capability 'supportsStepInTargetsRequest' is sent in ashgti wrote: Done. h

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Correct, we don't have macOS premerge testing (yet?) https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. The test is ok. Mach-o files have LC_SEGMENT_64 load commands, so no need to change the test really. I mean, we can probably remove it and still have a mach-o file, but not sure we need to. https://github.com/llvm/llvm-project/pull/142704

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -30,6 +30,8 @@ def test_basic(self): self.assertEqual( len(breakpoint_ids), len(lines), "expect correct number of breakpoints" ) +# Target based capability 'supportsStepInTargetsRequest' is sent in da-viper wrote: the `c

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I was wondering why llvm build bot did not catch it ( I assume there is a build bot for macos ? ) https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -89,17 +91,14 @@ def test_supported_capability_x86_arch(self): self.assertEqual( len(breakpoint_ids), len(bp_lines), "expect correct number of breakpoints" ) -is_supported = self.dap_server.get_initialize_value( -"supportsStep

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This adds a new 'CapabilitiesEventBody' type for having a well structured type for the event and updates the 'stepInTargets' and 'restart' request to dynamically set their capabilities. This also fixes the '

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/142831 This adds a new 'CapabilitiesEventBody' type for having a well structured type for the event and updates the 'stepInTargets' and 'restart' request to dynamically set their capabilities. This also fixes the 'ste

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread David Blaikie via lldb-commits
dwblaikie wrote: (where possible, cross-project commits should be avoided/split into separate steps - eg: the functionality could be added to LLVM, with the unit test coverage in one change - then used from LLDB in another. Though possibly acceptable to review it in one go and commit it in two

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This appears to have broken the standalone build. I think we're no longer passing up the `ENTITLEMENTS` argument: ``` [2025-06-04T13:26:59.289Z] ld: library 'ENTITLEMENTS' not found [2025-06-04T13:26:59.289Z] c++: error: linker command failed with exit code 1 (use -v to see

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread John Harrison via lldb-commits
ashgti wrote: I'm working on a fix https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This broke the macOS bot: https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/27030/ https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/142820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
royitaqi wrote: > > It's not clear if there are legitimate production use cases where the > > Mach-O files don't have said load commands. If there is, then what is their > > expected object format? Without this patch, they are currently ELF. With > > this patch, they will become MachO > > At

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
ashgti wrote: Looking at this, I think I'll take a different approach to fixing this and close this PR for now. https://github.com/llvm/llvm-project/pull/142820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (PR #142689)

2025-06-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/142689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] db54719 - [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (#142689)

2025-06-04 Thread via lldb-commits
Author: Alex Langford Date: 2025-06-04T10:43:36-07:00 New Revision: db5471945b7e36f55c66dfa74e218390c0329dd4 URL: https://github.com/llvm/llvm-project/commit/db5471945b7e36f55c66dfa74e218390c0329dd4 DIFF: https://github.com/llvm/llvm-project/commit/db5471945b7e36f55c66dfa74e218390c0329dd4.diff

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142820 >From 0fc2c8223ecb0888c15152331474f4ffb63c142b Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 4 Jun 2025 10:29:33 -0700 Subject: [PATCH 1/2] [lldb-dap] Adjust the stepInTargets tests on non-intel platfo

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This test is failing for me on arm64 due to the capabilities not being sent until 'configurationDone' is called. I adjusted the test to ensure we call 'configurationDone' so the value is sent to the test cor

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/142820 This test is failing for me on arm64 due to the capabilities not being sent until 'configurationDone' is called. I adjusted the test to ensure we call 'configurationDone' so the value is sent to the test correc

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,107 @@ +//===-- RPCCommon.h ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Michael Buch via lldb-commits
@@ -159,4 +160,23 @@ struct TrackingOutputBuffer : public llvm::itanium_demangle::OutputBuffer { }; } // namespace lldb_private +/// Custom deleter to use with unique_ptr. +/// +/// Usage: +/// \code{.cpp} +/// +/// auto OB = +/// std::unique_ptr( +/// new Trackin

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self): self.run_with( arch=self.getArchitecture(), os="ios", -vers="11.0", +vers="14.0", adrian-prantl wrote: Apple silicon and/or macCatalyst mad

  1   2   >