llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867
---
Full diff: https://github.com/llvm/llvm-project/pull/140852.diff
1 Files Affected:
- (modified) lldb/test/API/tools/lldb-dap/disassemble/TestDA
https://github.com/talkeren created
https://github.com/llvm/llvm-project/pull/140853
This change remove the call to GetPlatform from GetDeploymentInfo and instead
pass it as an argument,so GetPlatform will be called only once for all the
load commands. The reason is that if we try to query the p
talkeren wrote:
Closing it following the discussion in the issue - I made a new PR that fixes
it differently without change the current behaviour.
https://github.com/llvm/llvm-project/pull/140611
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
https://github.com/talkeren closed
https://github.com/llvm/llvm-project/pull/140611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/4] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ely Ronnen
Date: 2025-05-21T08:10:22+02:00
New Revision: 2ed8c27d03dac098744d51f580e7cca38707b183
URL:
https://github.com/llvm/llvm-project/commit/2ed8c27d03dac098744d51f580e7cca38707b183
DIFF:
https://github.com/llvm/llvm-project/commit/2ed8c27d03dac098744d51f580e7cca38707b183.diff
LO
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/140852
Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867
>From cb69d50e158d9197b6e0fdb997de0086da1b8afa Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 08:09:23 +0200
Subject: [PATCH] add @
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions,
condition=None, hitCondition=None)
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.w
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
eronnen wrote:
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/3] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/4] [lldb-dap] Fix disassemble request instruction offset
handling
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ely Ronnen
Date: 2025-05-21T06:50:13+02:00
New Revision: 9d0614e77ab1c5e2264e07d9b4b5f9780b38781c
URL:
https://github.com/llvm/llvm-project/commit/9d0614e77ab1c5e2264e07d9b4b5f9780b38781c
DIFF:
https://github.com/llvm/llvm-project/commit/9d0614e77ab1c5e2264e07d9b4b5f9780b38781c.diff
LO
@@ -349,6 +349,10 @@ class LLDB_API SBTarget {
SBError SetLabel(const char *label);
+ uint32_t GetMinimumOpcodeByteSize() const;
+
+ uint32_t GetMaximumOpcodeByteSize() const;
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/140486
__
Author: Jonas Devlieghere
Date: 2025-05-20T18:51:59-07:00
New Revision: 7b513393872fe608721ce4014606b03dd780a5c9
URL:
https://github.com/llvm/llvm-project/commit/7b513393872fe608721ce4014606b03dd780a5c9
DIFF:
https://github.com/llvm/llvm-project/commit/7b513393872fe608721ce4014606b03dd780a5c9.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/140810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public
CommandObjectParsed {
return Status::FromErrorStringWithFormat("invalid line number:
'%s'.",
option_arg.str().c_str());
break;
- case 'b':
https://github.com/ashgti approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -349,6 +349,10 @@ class LLDB_API SBTarget {
SBError SetLabel(const char *label);
+ uint32_t GetMinimumOpcodeByteSize() const;
+
+ uint32_t GetMaximumOpcodeByteSize() const;
ashgti wrote:
Can we add a comment?
```
Architecture opcode byte size width ac
@@ -62,6 +65,71 @@ def test(self):
substrs=["error"],
)
+def test_jump_offset(self):
+"""Test Thread Jump by negative or positive offset"""
+exe = self.getBuildArtifact("a.out")
+file_name = "main.cpp"
+self.runCmd(f"targ
@@ -1102,3 +1103,28 @@ def is_feature_enabled():
return "%s is not supported on this system." % feature
return skipTestIfFn(is_feature_enabled)
+
+
+def skipIfBinaryToLarge(path: Optional[str], maxSize: int):
+"""Skip the test if a binary is to large.
+
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/140810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thank you. This is a big improvement compared to the previous revision and
makes it much easier to follow. Great job!
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailin
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public
CommandObjectParsed {
return Status::FromErrorStringWithFormat("invalid line number:
'%s'.",
option_arg.str().c_str());
break;
- case 'b':
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-05-20T23:29:34+01:00
New Revision: dfc65ef65e4e92fee244c0eed7ec9223fc943b65
URL:
https://github.com/llvm/llvm-project/commit/dfc65ef65e4e92fee244c0eed7ec9223fc943b65
DIFF:
https://github.com/llvm/llvm-project/commit/dfc65ef65e4e92fee244c0eed7ec9223fc943b65.diff
L
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/140777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,26 +1,23 @@
"""
-Test lldb-dap setBreakpoints request
+Test lldb-dap console output
"""
-import dap_server
import lldbdap_testcase
-from lldbsuite.test import lldbutil
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
-def get_subproces
jimingham wrote:
You can also use ScriptedProcesses for testing. They would allow wrapping a
real process and changing the answers it hands out in some way useful to you,
or just making up the process state out of whole cloth.
https://github.com/llvm/llvm-project/pull/140566
_
@@ -1,26 +1,23 @@
"""
-Test lldb-dap setBreakpoints request
+Test lldb-dap console output
"""
-import dap_server
import lldbdap_testcase
-from lldbsuite.test import lldbutil
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
-def get_subproces
@@ -1,26 +1,23 @@
"""
-Test lldb-dap setBreakpoints request
+Test lldb-dap console output
"""
-import dap_server
import lldbdap_testcase
-from lldbsuite.test import lldbutil
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
-def get_subproces
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
I got a bug report where a pedantic DAP client complains about getting two
"new" module events for the same UUID. This is caused by the dyld transition
from the on-disk dyld to the shared cache dyld
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140810
I got a bug report where a pedantic DAP client complains about getting two
"new" module events for the same UUID. This is caused by the dyld transition
from the on-disk dyld to the shared cache dyld, which
eronnen wrote:
@JDevlieghere Fixed comments, sorry for the trouble. I'll try to pay extra
attention next time :)
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
eronnen wrote:
@JDevlieghere I Tried to simplify the logics as much as I can in the way you
asked, handling the case of unfixed opcode size and disassembling backwards is
still a bit complex because there is the edge case where padding is needed, but
I hope it's readable enough now.
https://g
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/3] [lldb-dap] Fix disassemble request instruction offset
handling
https://github.com/igorkudrin closed
https://github.com/llvm/llvm-project/pull/139196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Igor Kudrin
Date: 2025-05-20T13:50:24-07:00
New Revision: 3f196e029314e3ccb429413a5f38ad241e50f3c5
URL:
https://github.com/llvm/llvm-project/commit/3f196e029314e3ccb429413a5f38ad241e50f3c5
DIFF:
https://github.com/llvm/llvm-project/commit/3f196e029314e3ccb429413a5f38ad241e50f3c5.diff
L
Author: Ebuka Ezike
Date: 2025-05-20T20:57:51+01:00
New Revision: 1b6b036c0220c095c2917308775aa2ddcba506ad
URL:
https://github.com/llvm/llvm-project/commit/1b6b036c0220c095c2917308775aa2ddcba506ad
DIFF:
https://github.com/llvm/llvm-project/commit/1b6b036c0220c095c2917308775aa2ddcba506ad.diff
L
@@ -1102,3 +1103,28 @@ def is_feature_enabled():
return "%s is not supported on this system." % feature
return skipTestIfFn(is_feature_enabled)
+
+
+def skipIfBinaryToLarge(path: Optional[str], maxSize: int):
+"""Skip the test if a binary is to large.
+
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/140777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@DavidSpickett fixed the test, I gotcha'd myself checking an optional of a
bool. I added my gist to the description, let me know what you think
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140771
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@anthonycabreralara Congratulations on having your first Pull Request (PR)
merged into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem wi
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/140746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Anthony Cabrera-Lara
Date: 2025-05-20T12:55:59-07:00
New Revision: be5b4fad2921dc28a0b9af8106177aa4c4862ce0
URL:
https://github.com/llvm/llvm-project/commit/be5b4fad2921dc28a0b9af8106177aa4c4862ce0
DIFF:
https://github.com/llvm/llvm-project/commit/be5b4fad2921dc28a0b9af8106177aa4c4862ce
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
JDevliegher
da-viper wrote:
@ashgti I haven't check this yet because of #140788, before remove the
skipifs.
https://github.com/llvm/llvm-project/pull/140777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
I was running the tests and encounted this
```sh
TIMEOUT: lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_gotoTargets.py (55 of
55)
TEST 'lldb-api ::
tools/lldb-dap/gotoTargets/TestDAP_g
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/140788
I was running the tests and encounted this
```sh
TIMEOUT: lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_gotoTargets.py (55 of
55)
TEST 'lldb-api ::
tools/lldb-dap/gotoTargets/TestDAP_go
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/137041
>From 68077c22670ec044aab57bacb50c1edc0eb72eef Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 May 2025 12:56:14 -0700
Subject: [PATCH 1/2] Implement PTRACE_SEIZE when a process is coredumping
---
..
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/140777
A bit of test gardenining. Enabling tests that were marked as skipped as part
of https://github.com/llvm/llvm-project/issues/137660. Fixed up some comments
and doc comments and fixed some test helpers.
>From e5
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
A bit of test gardenining. Enabling tests that were marked as skipped as part
of https://github.com/llvm/llvm-project/issues/137660. Fixed up some comments
and doc comments and fixed some test helpers.
---
https://github.com/anthonycabreralara reopened
https://github.com/llvm/llvm-project/pull/140746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/anthonycabreralara closed
https://github.com/llvm/llvm-project/pull/140746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1350,6 +1350,17 @@ Dump all symbols in ``a.out`` and ``liba.so``
(lldb) image dump symtab a.out liba.so
+Save current process as a core file
+~
JDevlieghere wrote:
```suggestion
Save current process as a core
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/140771
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/140771
>From 9e29cc1dd3a7a80fe2935b373b28ba998d2d053b Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 20 May 2025 18:41:29 +0100
Subject: [PATCH 1/2] [lldb][docs] add command to save core file in gdb to lldb
co
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/140771
None
>From 9e29cc1dd3a7a80fe2935b373b28ba998d2d053b Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 20 May 2025 18:41:29 +0100
Subject: [PATCH] [lldb][docs] add command to save core file in gdb to lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140771.diff
1 Files Affected:
- (modified) lldb/docs/use/map.rst (+11)
``diff
diff --git a/lldb/docs/use/map.rst b/lldb/docs/use/map.rst
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/2] refactor demangler range tracking
---
lldb/include
@@ -35,14 +35,24 @@ export class DebugSessionTracker
* The modules are kept in an array to maintain the load order of the
modules.
*/
private modules = new Map();
- private modulesChanged = new vscode.EventEmitter();
+ private modulesChanged = new vscode.EventEmitter
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
Changes
This PR is a subset of the commits made in
https://github.com/swiftlang/llvm-project/pull/10710.
The most notable change is the addition of `PrefixRange` and `SuffixRange`
which are a catch-all to
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
When inspecting/printing types from MSVC's STL, LLDB would crash because it
assumes these types were from libstdc++. Specifically, `std::shared_ptr` and
`std::optional` would crash because of a null pointer derefere
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/140762
This PR is a subset of the commits made in
https://github.com/swiftlang/llvm-project/pull/10710.
The most notable change is the addition of `PrefixRange` and `SuffixRange`
which are a catch-all to trac
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/140761
When inspecting/printing types from MSVC's STL, LLDB would crash because it
assumes these types were from libstdc++. Specifically, `std::shared_ptr` and
`std::optional` would crash because of a null pointer der
labath wrote:
Correct.
https://github.com/llvm/llvm-project/pull/140150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/140603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -70,9 +71,21 @@ export class DebugSessionTracker
/** Clear information from the active session. */
private onExit(session: vscode.DebugSession) {
this.modules.delete(session);
+// close when there is no more sessions
+if (this.modules.size <= 0) {
---
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/139826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-05-20T09:34:42-07:00
New Revision: ff127624be8cca921d1a6ed457cc3310b094ff59
URL:
https://github.com/llvm/llvm-project/commit/ff127624be8cca921d1a6ed457cc3310b094ff59
DIFF:
https://github.com/llvm/llvm-project/commit/ff127624be8cca921d1a6ed457cc3310b094ff59.diff
LOG:
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/137041
>From 68077c22670ec044aab57bacb50c1edc0eb72eef Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 May 2025 12:56:14 -0700
Subject: [PATCH] Implement PTRACE_SEIZE when a process is coredumping
---
.../Pr
Jlalond wrote:
@labath I think I misunderstand the vision you're trying to get at. Are you
suggesting we have Platform determine the Signal description and the
ProcessElfThread would call out to the platform_sp for it?
https://github.com/llvm/llvm-project/pull/140150
___
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/138551
>From ad204cdfd226ca2a886c5475775fe67b29a70926 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Wed, 30 Apr 2025 22:03:50 +0500
Subject: [PATCH 1/7] [LLDB] Add array subscription and integer parsing to DIL
---
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/140746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1620,6 +1620,88 @@ void DAP::EventThread() {
}
}
+std::vector DAP::SetSourceBreakpoints(
+const protocol::Source &source,
+const std::optional> &breakpoints)
{
+ std::vector response_breakpoints;
+ if (source.sourceReference) {
+// breakpoint set by assemb
@@ -33,16 +36,51 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) {
+llvm::Error SourceBreakpoint::S
@@ -219,6 +218,9 @@ struct DAP {
llvm::StringSet<> modules;
/// @}
+ /// Number of lines of assembly code to show when no debug info is available.
+ static constexpr uint32_t number_of_assembly_lines_for_nodebug = 32;
JDevlieghere wrote:
Constants use a
@@ -1620,6 +1620,88 @@ void DAP::EventThread() {
}
}
+std::vector DAP::SetSourceBreakpoints(
+const protocol::Source &source,
+const std::optional> &breakpoints)
{
+ std::vector response_breakpoints;
+ if (source.sourceReference) {
+// breakpoint set by assemb
@@ -33,16 +36,51 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) {
+llvm::Error SourceBreakpoint::S
@@ -1620,6 +1620,88 @@ void DAP::EventThread() {
}
}
+std::vector DAP::SetSourceBreakpoints(
+const protocol::Source &source,
+const std::optional> &breakpoints)
{
+ std::vector response_breakpoints;
+ if (source.sourceReference) {
+// breakpoint set by assemb
@@ -1620,6 +1620,88 @@ void DAP::EventThread() {
}
}
+std::vector DAP::SetSourceBreakpoints(
+const protocol::Source &source,
+const std::optional> &breakpoints)
{
+ std::vector response_breakpoints;
+ if (source.sourceReference) {
+// breakpoint set by assemb
@@ -72,21 +99,31 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -19,19 +19,46 @@ namespace lldb_dap {
llvm::Expected
BreakpointLocationsRequestHandler::Run(
const protocol::BreakpointLocationsArguments &args) const {
- std::string path = args.source.path.value_or("");
uint32_t start_line = args.line;
uint32_t start_column = ar
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Mostly style nits at this point. The comments and braces are relatively easy to
spot, so in the future please do a review pass over your own PRs. I bet you'll
be able to catch most of these yourself.
https://github.com/llvm/llvm-project/pull/139969
__
@@ -63,14 +65,31 @@ protocol::Breakpoint Breakpoint::ToProtocolBreakpoint() {
std::string formatted_addr =
"0x" + llvm::utohexstr(bp_addr.GetLoadAddress(m_bp.GetTarget()));
breakpoint.instructionReference = formatted_addr;
+
+lldb::StopDisassemblyType stop_d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Anthony Cabrera-Lara (anthonycabreralara)
Changes
Fix typo in interpreter property description
---
Full diff: https://github.com/llvm/llvm-project/pull/140746.diff
1 Files Affected:
- (modified) lldb/source/Interpreter/InterpreterPropert
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/anthonycabreralara created
https://github.com/llvm/llvm-project/pull/140746
Fix typo in interpreter property description
>From cd4f55e952ea2b5f8420d9f8ca3affde2045819a Mon Sep 17 00:00:00 2001
From: Anthony Cabrera-Lara
<60250777+anthonycabreral...@users.noreply.github.com>
1 - 100 of 138 matches
Mail list logo
