https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137920
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -71,22 +101,26 @@ BreakpointLocationsRequestHandler::Run(
locations.emplace_back(line, column);
}
}
+}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations
@@ -53,6 +54,8 @@ class LLDB_API SBFileSpec {
uint32_t GetPath(char *dst_path, size_t dst_len) const;
+ bool GetPath(lldb::SBStream &dst_path) const;
JDevlieghere wrote:
I have mixed feelings about adding this API. Generally, we usually use streams
when
@@ -19,19 +18,50 @@ namespace lldb_dap {
llvm::Expected
BreakpointLocationsRequestHandler::Run(
const protocol::BreakpointLocationsArguments &args) const {
- std::string path = args.source.path.value_or("");
uint32_t start_line = args.line;
uint32_t start_column = ar
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run(
}
}
- return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
+ return response_breakpoints;
+}
+
+std::vector
+SetBreakpointsRequestHandler::SetAssemblyBreakpoints(
+const protocol::Source
@@ -219,6 +221,9 @@ struct DAP {
llvm::StringSet<> modules;
/// @}
+ /// Number of lines of assembly code to show when no debug info is available.
+ uint32_t number_of_assembly_lines_for_nodebug = 32;
JDevlieghere wrote:
Is this a constant?
```suggesti
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run(
}
}
- return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
+ return response_breakpoints;
+}
+
+std::vector
+SetBreakpointsRequestHandler::SetAssemblyBreakpoints(
+const protocol::Source
@@ -19,19 +18,50 @@ namespace lldb_dap {
llvm::Expected
BreakpointLocationsRequestHandler::Run(
const protocol::BreakpointLocationsArguments &args) const {
- std::string path = args.source.path.value_or("");
uint32_t start_line = args.line;
uint32_t start_column = ar
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run(
}
}
- return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
+ return response_breakpoints;
+}
+
+std::vector
+SetBreakpointsRequestHandler::SetAssemblyBreakpoints(
+const protocol::Source
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run(
}
}
- return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
+ return response_breakpoints;
+}
+
+std::vector
+SetBreakpointsRequestHandler::SetAssemblyBreakpoints(
+const protocol::Source
@@ -71,22 +101,26 @@ BreakpointLocationsRequestHandler::Run(
locations.emplace_back(line, column);
}
}
+}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140424.diff
13 Files Affected:
- (modified) lldb/include/lldb/Symbol/CompilerType.h (+5)
- (modified) lldb/source/Plugins/ExpressionParser/Clang/Cl
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/140424
None
>From f00b0d192a921c6cec369d2d674b617a9ca1f706 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 16 May 2025 11:47:08 -0700
Subject: [PATCH] [lldb] Add templated CompilerType::GetTypeSystem (NFC)
---
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
* Support assembly source breakpoints
* Change `sourceReference` to be the load address for simplicity and
consistency across threads/frames
[Screencast From 2025-05-17
23-57-30.webm](https://github.com/user-a
https://github.com/eronnen ready_for_review
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/6] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From a705fec9e42d209ff64be3588ca74567d4319361 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/6] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From a705fec9e42d209ff64be3588ca74567d4319361 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/5] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/138093
>From fe9ac0fa05bb43ea718214746f0ea9b7eefc929a Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 1 May 2025 00:05:57 -0700
Subject: [PATCH 1/4] [LLDB] Add field member operators to DIL
Add the arrow and pe
cmtice wrote:
I believe I have addressed all the review comments so far. Please take another
look. Thanks!
https://github.com/llvm/llvm-project/pull/138093
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Move the command plugins out of the DAP header and into their file. This PR
also renames the classes from "RequestHandler" to "Command". Although they are
implemented in terms of sending requests, t
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140396
Move the command plugins out of the DAP header and into their file. This PR
also renames the classes from "RequestHandler" to "Command". Although they are
implemented in terms of sending requests, they are
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/140393
>From 82cd419423f74777e248743534f2da48ae6b72c9 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sat, 17 May 2025 11:34:48 -0700
Subject: [PATCH 1/3] [lldb-dap] Move the Variables struct into its own f
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/140393
>From 82cd419423f74777e248743534f2da48ae6b72c9 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sat, 17 May 2025 11:34:48 -0700
Subject: [PATCH 1/2] [lldb-dap] Move the Variables struct into its own f
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Move the Variables struct out of DAP.h and into its own file to reduce the
complexity of the latter. This PR also makes the members that are
implementation details private.
---
Full diff: https://g
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140393
Move the Variables struct out of DAP.h and into its own file to reduce the
complexity of the latter. This PR also makes the members that are
implementation details private.
>From 82cd419423f74777e24874353
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
- Use in-class member initialization to simplify the constructor.
- Remove unimplemented SetConfigurationDone.
- Consistently use Doxygen-style comments.
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140390
- Use in-class member initialization to simplify the constructor.
- Remove unimplemented SetConfigurationDone.
- Consistently use Doxygen-style comments.
>From c546c86ac849f316c9b31b881e92d8683aa5 Mon S
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-05-17T09:09:10-07:00
New Revision: 68e4f6090b369c14da8c6ef1f614664b9e0427e1
URL:
https://github.com/llvm/llvm-project/commit/68e4f6090b369c14da8c6ef1f614664b9e0427e1
DIFF:
https://github.com/llvm/llvm-project/commit/68e4f6090b369c14da8c6ef1f614664b9e0427e1.diff
L
https://github.com/tgymnich approved this pull request.
https://github.com/llvm/llvm-project/pull/140343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
37 matches
Mail list logo
