[Lldb-commits] [lldb] [lldb-dap] Give attach test binaries unique names (PR #138435)

2025-05-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Give the test binaries used for attaching unique names to avoid accidentally attaching to the wrong binary. Fixes #138197 --- Full diff: https://github.com/llvm/llvm-project/pull/138435.diff 3 Fi

[Lldb-commits] [lldb] [lldb-dap] Give attach test binaries unique names (PR #138435)

2025-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/138435 Give the test binaries used for attaching unique names to avoid accidentally attaching to the wrong binary. Fixes #138197 >From fabb7d6951d124292b3fd333f5bd64499242f6ea Mon Sep 17 00:00:00 2001 From: Jona

[Lldb-commits] [lldb] Handle step-in over a Darwin "branch island". (PR #138330)

2025-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-03 Thread Oliver Hunt via lldb-commits
ojhunt wrote: @AaronBallman have you made a decision? (if the keyword has to go away I need to replace all the tests and work out how to integrate with other libraries downstream in a way that works in both modes) https://github.com/llvm/llvm-project/pull/137580 ___

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-03 Thread Ely Ronnen via lldb-commits
eronnen wrote: @felipepiovezan Hopefully this should fix the problem in the macOS tests (https://github.com/llvm/llvm-project/pull/137512#issuecomment-2846104161) though I don't know how to trigger these tests from the PR :| https://github.com/llvm/llvm-project/pull/138416

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-03 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/138416 >From 3ec9e1962940799ab291aaa8455e6f76da02af0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 27 Apr 2025 13:48:45 +0200 Subject: [PATCH 1/4] Change ___lldb_unnamed_symbol generated names to have the file

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp,h -- lldb/test/API/python_api/unnamed_symbol_lookup/ma

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes * Changes the default synthetic symbol names to contain their file address This is a new PR after the first PR (#137512) was reverted because it didn't update the way unnamed symbols were searched in the symbol

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-03 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/138416 * Changes the default synthetic symbol names to contain their file address This is a new PR after the first PR (#137512) was reverted because it didn't update the way unnamed symbols were searched in the symbol

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-05-03 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: > I'm away for the long weekend but can revert on Wednesday if nobody does so > before then. However, I'm not sure how we can track down such lurking issues > other than by leaving this unreverted and fixing issues as they pop up, since > neither code review nor testcases

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #137512)

2025-05-03 Thread Ely Ronnen via lldb-commits
eronnen wrote: Aperrantly I missed that searching unnamed symbols is dependant on the symbol index at https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/Symtab.cpp#L668, so changing it will require a deeper change https://github.com/llvm/llvm-project/pull/137512 ___

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #137512)

2025-05-03 Thread Ely Ronnen via lldb-commits
eronnen wrote: Aperrantly I missed that searching unnamed symbols is dependant on the symbol index at https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/Symtab.cpp#L668, so changing it will require a deeper change https://github.com/llvm/llvm-project/pull/137512 ___

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #137512)

2025-05-03 Thread Ely Ronnen via lldb-commits
eronnen wrote: @felipepiovezan Thanks for noticing, I'll try to fix it soon https://github.com/llvm/llvm-project/pull/137512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-05-03 Thread via lldb-commits
anjenner wrote: I'm away for the long weekend but can revert on Wednesday if nobody does so before then. However, I'm not sure how we can track down such lurking issues other than by leaving this unreverted and fixing issues as they pop up, since neither code review nor testcases caught https