github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/DrSergei created
https://github.com/llvm/llvm-project/pull/138160
Added `runInTerminal` support for Windows based on Windows Named Pipes. Adapted
existed `FifoFile` class to Windows client-server pipes model. When server side
owns the assosieted filesystem handle and client
Author: David Spickett
Date: 2025-05-01T16:40:47+01:00
New Revision: 09488bcfba77d1a16b0b83c2d6b1135e5e7d5302
URL:
https://github.com/llvm/llvm-project/commit/09488bcfba77d1a16b0b83c2d6b1135e5e7d5302
DIFF:
https://github.com/llvm/llvm-project/commit/09488bcfba77d1a16b0b83c2d6b1135e5e7d5302.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AaronBallman wrote:
> > Perhaps silly initial question: why do we need a whole different qualifier
> > for this? Why can you not write `__ptrauth uintptr_t foo`?
>
> Not a silly question, back when first implemented we spent time thinking
> about this.
>
> The concern was basically `T* __ptra
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/137668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
@@ -1676,7 +1681,11 @@ GDBRemoteCommunication::PacketResult
GDBRemoteCommunicationServerLLGS::Handle_vCont_actions(
StringExtractorGDBRemote &packet) {
StreamString response;
- response.Printf("vCont;c;C;s;S;t");
+ if (m_current_process && m_current_process->CanResume()
DavidSpickett wrote:
> This is pretty complicated to test because it requires integration with the
> Kernel
Can you make the same thing happen without using a coredumper? I feel like the
answer is a solid no but I'm not sure why.
Another way we can do it is to write a test that checks that if
@@ -105,6 +105,10 @@ class LLDB_API SBThreadPlan {
SBThreadPlan QueueThreadPlanForStepOut(uint32_t frame_idx_to_step_to,
bool first_insn, SBError &error);
+ SBThreadPlan QueueThreadPlanForStepSingleInstruction(bool step_over);
--
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
`ValueObject::AddressOf()` used to return address as a value which has it's own
address, allowing to do `value.AddressOf().AddressOf()`.
This patch makes the return address a simple const value.
---
Full diff:
https://github.com/kuilpd ready_for_review
https://github.com/llvm/llvm-project/pull/137688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
---
Patch is 27.92 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/138116.diff
14 Files Affected:
- (modified) lldb/tools/lldb-dap/DAP.cpp (+1-14)
- (modified)
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/138116
None
>From 437c69ffb1f86733649a82aa2a991360dd40fd7c Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/4] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
DavidSpickett wrote:
Tests are pexpect so they're not running on Windows anyway.
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Something to do with control code handling in Windows terminals breaks the
statusline in various ways. It makes LLDB unusable and even if you set the
setting to disable statusline, it's too late, and
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/138111
Something to do with control code handling in Windows terminals breaks the
statusline in various ways. It makes LLDB unusable and even if you set the
setting to disable statusline, it's too late, and the
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
https://github.com/DavidSpickett commented:
> Currently we're creating inheritable (~FD_CLOEXEC) file descriptors in the
> (few) cases where we need to pass an FD to a subprocess. The problem with
> these is that, in a multithreaded application such as lldb, there's
> essentially no way to pre
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
+
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/126935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,3 +89,41 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT_ERROR(Host::LaunchProcess(info).takeError(), Succeeded());
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+
+#ifdef LLVM_ON_UNIX
+TEST(Host, LaunchProcessDuplicatesHandle) {
+ static constexpr llvm::Str
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const
Address &addr) {
return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr);
}
+static AddressRange ToAddressRange(const Address &func_addr,
+ const Bloc
@@ -0,0 +1,102 @@
+# REQUIRES: x86, lld
+
+# RUN: split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux %t/file.s -o %t/file.o
+# RUN: ld.lld %t/file.o -o %t/file.out -T %t/file.lds
+# RUN: %lldb %t/file.out -o "disassemble --name func1" -o exit | FileCheck %s
+
+
Author: David Spickett
Date: 2025-05-01T10:01:14Z
New Revision: 2dbab4ca8ddb218af555d8d1fd86b72612387582
URL:
https://github.com/llvm/llvm-project/commit/2dbab4ca8ddb218af555d8d1fd86b72612387582
DIFF:
https://github.com/llvm/llvm-project/commit/2dbab4ca8ddb218af555d8d1fd86b72612387582.diff
LOG
Author: David Spickett
Date: 2025-05-01T09:30:33Z
New Revision: 47424df2d5c6cc5a2b2d49a8cad438d8e75fec61
URL:
https://github.com/llvm/llvm-project/commit/47424df2d5c6cc5a2b2d49a8cad438d8e75fec61
DIFF:
https://github.com/llvm/llvm-project/commit/47424df2d5c6cc5a2b2d49a8cad438d8e75fec61.diff
LOG
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/frame/var-dil/basics/MemberOf/TestFrameVarDILMemberOf
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/138093
Add the arrow and period operators, allowing DIL to find and access member
fields.
>From fe9ac0fa05bb43ea718214746f0ea9b7eefc929a Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 1 May 2025 00:05:57 -070
real-mikhail wrote:
I assume that there will be no further comments here.
Since this is my first change in LLVM I cannot merge it myself. @jimingham may
I kindly ask you to merge this PR?
https://github.com/llvm/llvm-project/pull/129092
___
lldb-comm
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/test/API/commands/frame/var-dil/basics/MemberO
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Add the arrow and period operators, allowing DIL to find and access member
fields.
---
Patch is 28.98 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/138093.diff
18 Files
34 matches
Mail list logo
