[Lldb-commits] [lldb] [LLDB] Fix crash after second run when set a previous watchpoint. (PR #136649)

2025-04-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (hapee) Changes This PR fixes a crash in `LLDB` caused by a dangling pointer to a reused `ValueObjectSP` when re-running the debuggee and setting the same watchpoint again. As described by @jasonmolenda, the fix is to reinitializ

[Lldb-commits] [lldb] [LLDB] Fix crash after second run when set a previous watchpoint. (PR #136649)

2025-04-21 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB] Fix crash after second run when set a previous watchpoint. (PR #136649)

2025-04-21 Thread via lldb-commits
https://github.com/hapee created https://github.com/llvm/llvm-project/pull/136649 This PR fixes a crash in `LLDB` caused by a dangling pointer to a reused `ValueObjectSP` when re-running the debuggee and setting the same watchpoint again. As described by @jasonmolenda, the fix is to reini

[Lldb-commits] [lldb] [lldb-dap] Updating the 'next' request handler use well structured types (PR #136642)

2025-04-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This updates the 'next' request to use well structured types. While working on this I also simplified the 'RequestHandler' implementation to better handle void responses by allowing requests to return a 'llvm

[Lldb-commits] [lldb] [lldb-dap] Updating the 'next' request handler use well structured types (PR #136642)

2025-04-21 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/136642 This updates the 'next' request to use well structured types. While working on this I also simplified the 'RequestHandler' implementation to better handle void responses by allowing requests to return a 'llvm::E

[Lldb-commits] [lldb] [lldb] Clarify the documentation for GetIndexOfChildMemberWithName (PR #136633)

2025-04-21 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/136633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clarify the documentation for GetIndexOfChildMemberWithName (PR #136633)

2025-04-21 Thread via lldb-commits
@@ -450,6 +450,9 @@ class CompilerType { /// Lookup a child member given a name. This function will match member names /// only and will descend into "clang_type" children in search for the first /// member in this class, or any base class that matches "name". + /// \par

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
royitaqi wrote: > Hi, this patch broke green dragon lldb tests > > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/24375/changes#d5b40c71f6be972f677de5d9886f91866df007b5 > > Failed Tests (1): lldb-api :: commands/statistics/basic/TestStats.py > > I am reverting this change

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: Change reverted with 08b4c52540727455194b0cf0f6310f391e87c2a5 https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 08b4c52 - Revert "[lldb] Avoid force loading symbols in statistics collection (#136236)"

2025-04-21 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2025-04-21T17:19:54-07:00 New Revision: 08b4c52540727455194b0cf0f6310f391e87c2a5 URL: https://github.com/llvm/llvm-project/commit/08b4c52540727455194b0cf0f6310f391e87c2a5 DIFF: https://github.com/llvm/llvm-project/commit/08b4c52540727455194b0cf0f6310f391e87

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: Hi, this patch broke green dragon lldb tests https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/24375/changes#d5b40c71f6be972f677de5d9886f91866df007b5 Failed Tests (1): lldb-api :: commands/statistics/basic/TestStats.py I am reverting this change to ma

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d5b40c7 - [lldb] Avoid force loading symbols in statistics collection (#136236)

2025-04-21 Thread via lldb-commits
Author: royitaqi Date: 2025-04-21T16:53:14-07:00 New Revision: d5b40c71f6be972f677de5d9886f91866df007b5 URL: https://github.com/llvm/llvm-project/commit/d5b40c71f6be972f677de5d9886f91866df007b5 DIFF: https://github.com/llvm/llvm-project/commit/d5b40c71f6be972f677de5d9886f91866df007b5.diff LOG:

[Lldb-commits] [lldb] [lldb] Clarify the documentation for GetIndexOfChildMemberWithName (PR #136633)

2025-04-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136633.diff 2 Files Affected: - (modified) lldb/include/lldb/Symbol/CompilerType.h (+3) - (modified) lldb/include/lldb/Symbol/TypeSystem.h (

[Lldb-commits] [lldb] [lldb] Clarify the documentation for GetIndexOfChildMemberWithName (PR #136633)

2025-04-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/136633 None >From 85d2543eee9de66a58208901d1f666fb1c241e6b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 21 Apr 2025 16:22:30 -0700 Subject: [PATCH] [lldb] Clarify the documentation for GetIndexOfChil

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/statusline/TestStatusline.py `` V

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/136611 >From 5783bec58f5074399edc2d528cbde454f44dd12b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 21 Apr 2025 13:56:28 -0700 Subject: [PATCH] [lldb] Make the statusline separator configurable And use

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/8] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
@@ -761,3 +761,77 @@ TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { Symtab *cached_module_symtab = module_sp->GetSymtab(/*can_create=*/false); ASSERT_EQ(module_symtab, cached_module_symtab); } + +TEST_F(SymtabTest, TestSymbolTableCreatedOnDemand) { + const char *yamldata

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/7] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/statistics/basic/TestStats.py `` View th

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/6] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM module a test. Can you add a test to the Statusline PExpect test that changes the separator? I think with the new default you might need to update the existing one too. https://github.com/llvm/llvm-project/pull/136611 __

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/136611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread Jonas Devlieghere via lldb-commits
@@ -176,10 +176,19 @@ let Definition = "debugger" in { Global, DefaultTrue, Desc<"Whether to show a statusline at the bottom of the terminal.">; - def StatuslineFormat: Property<"statusline-format", "FormatEntity">, -Global, -DefaultStringValue<"${ansi.nega

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value + lldb::SBCommandReturnObj

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 11e5a1b7cd10f722455efdc49adc24ed277f3dfc Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/4] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes And use this functionality to replace the ASCII "|" with the same full-geight line-drawing character used in diagnostics rendering on a color terminal. --- Full diff: https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb] Make the statusline separator configurable (PR #136611)

2025-04-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/136611 And use this functionality to replace the ASCII "|" with the same full-geight line-drawing character used in diagnostics rendering on a color terminal. >From 3d9d4eba319b33072113ca333d07099be2fba09c Mon S

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Jonas Devlieghere via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value + lldb::SBCommandReturnObj

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I like it. I would suggest to move domain/abstract socket checking to a static helper, something like ``` Socket* DomainSocket::Create(NativeSocket sockfd, bool should_close) { #ifdef __linux__ // Check if fd represents domain socket or abstract socket. if (/*abstract*/)

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/5] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/5] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] c873ca2 - [lldb] Add symbol/table count into statistics (#136226)

2025-04-21 Thread via lldb-commits
Author: royitaqi Date: 2025-04-21T11:36:26-07:00 New Revision: c873ca25976d81f54421d9f4e24c5f700824d0d1 URL: https://github.com/llvm/llvm-project/commit/c873ca25976d81f54421d9f4e24c5f700824d0d1 DIFF: https://github.com/llvm/llvm-project/commit/c873ca25976d81f54421d9f4e24c5f700824d0d1.diff LOG:

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-21 Thread via lldb-commits
royitaqi wrote: Merging this PR, because it will make it easier for me to add a test case in https://github.com/llvm/llvm-project/pull/136236 https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread David Peixotto via lldb-commits
https://github.com/dmpots commented: After your change we can expect that no symbols are loaded by your simple repro, right? Can we extend the test here (or add a new one) to show that no symbols will be loaded in that case by checking the stats? https://github.com/dmpots/llvm-project/blob/mai

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread David Peixotto via lldb-commits
@@ -761,3 +761,77 @@ TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { Symtab *cached_module_symtab = module_sp->GetSymtab(/*can_create=*/false); ASSERT_EQ(module_symtab, cached_module_symtab); } + +TEST_F(SymtabTest, TestSymbolTableCreatedOnDemand) { + const char *yamldata

[Lldb-commits] [lldb] 1ab9e53 - [lldb][Mach-O corefiles] Don't init Target arch to corefile (#136065)

2025-04-21 Thread via lldb-commits
Author: Jason Molenda Date: 2025-04-21T10:58:58-07:00 New Revision: 1ab9e53e4910557f2a4c0f00c7a7f8b5ac493b48 URL: https://github.com/llvm/llvm-project/commit/1ab9e53e4910557f2a4c0f00c7a7f8b5ac493b48 DIFF: https://github.com/llvm/llvm-project/commit/1ab9e53e4910557f2a4c0f00c7a7f8b5ac493b48.diff

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-21 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/136065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: @slydiman Could you also take a look at this PR, as you are the author of the 2 commits mentioned in the description? Thanks. https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH] Fix connecting via abstract socket Commit 82ee31f and Co

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From fd514c43019e25f36e12166b7239f7882ea7eca4 Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH] Fix connecting via abstract socket Commit 82ee31f and Co

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-21 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From 2aedf974b8743b9291fbd333af2eaa6d4d5cadcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH] Fix connecting via abstract socket Commits 82ee31f and 2

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135626 >From 0487d125beb27f87acc2c137b1554e08a52d195d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 14 Apr 2025 12:08:38 +0100 Subject: [PATCH 1/3] [lldb] Fix use-color has no effect after starting lldb the m

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value eronnen wr

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits