https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-04-20T19:59:37-07:00
New Revision: 2ba20c52e43ae881dc54037fff94d7e2f217c99d
URL:
https://github.com/llvm/llvm-project/commit/2ba20c52e43ae881dc54037fff94d7e2f217c99d
DIFF:
https://github.com/llvm/llvm-project/commit/2ba20c52e43ae881dc54037fff94d7e2f217c99d.diff
L
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136527
None
>From a053656528fc7c1495b971fb77da030215aeb0e5 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sun, 20 Apr 2025 18:31:31 -0700
Subject: [PATCH] [lldb] Use llvm::unique (NFC)
---
lldb/source/Symbo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136527.diff
3 Files Affected:
- (modified) lldb/source/Symbol/Symtab.cpp (+2-4)
- (modified) lldb/source/Target/Target.cpp (+2-3)
- (modifie
eronnen wrote:
Maybe this setting should be exposed in the vscode launch configuration so it
will be more findable for users though
https://github.com/llvm/llvm-project/pull/136494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From 0bf4cfcbd1fe2a006a68cb6f85af9a09a49b47e7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH 1/3] fallback to assembly when source code is not available
---
ll
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/136494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/136494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
I refactored the code now to use the `stop-assembly-display` setting, I think
it makes sense to use it especially since it support the `no-source` value
which was what I was looking for
https://github.com/llvm/llvm-project/pull/136494
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/tools/lldb-dap/stackTraceDisassemblyDisplay/TestDAP_stackTrace
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From 0bf4cfcbd1fe2a006a68cb6f85af9a09a49b47e7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH 1/3] fallback to assembly when source code is not available
---
ll
jasonmolenda wrote:
Just to be super clear, if we were talking about core lldb behavior, I would be
insistent about how it behaves. But we're talking about DAP and i'm just a
bystander on that part of the codebase, and my feedback is just an opinion that
you might want to consider, but don't
jasonmolenda wrote:
One side note, I was commenting while not 100% awake and didn't realize this
was only in the DAP side of the codebase, I have less weight to argue one way
or the other there. After I posted that I was like, I wonder why I didn't see
the `stop-assembly-display` preference u
eronnen wrote:
@jasonmolenda fair enough, but still as a user who would like to see assembly
instead of an error when the source is not available I don't have any solution
currently. If I were to check the `stop-disassembly-display` value when
returning the source info, would that be acceptab
jasonmolenda wrote:
Maybe I'm missing something, but I disagree with this change. We're talking
about when you're stopped in a stack frame that has debug info (a file and line
number), but the source file is unavailable, right. There is a setting to
control this behavior already -- `stop-disa
https://github.com/JDevlieghere commented:
The change LGTM but please add a test. You should be able to remove the source
file between building and launching LLDB. I believe there are some examples of
that in the LLDB test suite.
https://github.com/llvm/llvm-project/pull/136494
___
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/136486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From c7da2d8281823d689b85bc836f3ed947857aaa32 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH] fallback to assembly when source code is not available
---
lldb/t
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/tools/lldb-dap/JSONUtils.cpp
``
Vie
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Show assembly code when the source code for a frame is not available in the
debugger machine
Fix #136492
After the fix:
[Screencast From 2025-04-20
18-00-30.webm](https://github.com/user-attachments/assets/1
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/136494
Show assembly code when the source code for a frame is not available in the
debugger machine
Fix #136492
After the fix:
[Screencast From 2025-04-20
18-00-30.webm](https://github.com/user-attachments/assets/1
github-actions[bot] wrote:
@eronnen Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
Author: Ely Ronnen
Date: 2025-04-20T08:33:28-07:00
New Revision: 839f52147c0cdbe7d4590cfdda089f250e5ec119
URL:
https://github.com/llvm/llvm-project/commit/839f52147c0cdbe7d4590cfdda089f250e5ec119
DIFF:
https://github.com/llvm/llvm-project/commit/839f52147c0cdbe7d4590cfdda089f250e5ec119.diff
LO
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/135544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Fix wrong assembly line number calculation that assumes the instruction size
is `GetAddressByteSize() / 2`
---
Full diff: https://github.com/llvm/llvm-project/pull/136486.diff
3 Files Affected:
- (modified)
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/136486
Fix wrong assembly line number calculation that assumes the instruction size
is `GetAddressByteSize() / 2`
>From 0efcbcfa2383e8ffac29904af90313f04bcdfa4a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 2
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
yuvald-sweet-security wrote:
> I can push the button for you if you could just update the patch description
> to what you'd like the commit message to say (in particular, I think the last
> paragraph is no longer correct).
>
> As for cherry-picking, is this related to the lldb-server platform
https://github.com/yuvald-sweet-security edited
https://github.com/llvm/llvm-project/pull/131609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
30 matches
Mail list logo
