[Lldb-commits] [lldb] [llvm] [CI] monolithic-linux improvements (PR #135499)

2025-04-16 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: When relanding it would probably be helpful to land individual improvements in separate patches rather than bundling them all together. https://github.com/llvm/llvm-project/pull/135499 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: Subsumed by 1fd7e4c517141ddfb527e7560e02fd5856244971. https://github.com/llvm/llvm-project/pull/136078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/136078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
@@ -368,3 +373,37 @@ bool lldb_private::formatters::NSTaggedString_SummaryProvider( stream << suffix; return true; } + +bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider( +ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor, +

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-16 Thread via lldb-commits
@@ -578,20 +605,47 @@ Status ProcessMachCore::DoLoadCore() { SetCanJIT(false); + // If we have an executable binary in the Target already, + // use that to set the Target's ArchSpec. + // + // Don't initialize the ArchSpec based on the corefile's cputype/cpusubtype + /

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-arm Author: None (yronglin) Changes This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some missed changes in LLDB. I found this issue when I working on https://github.com/llvm/llvm-project/pull/10

[Lldb-commits] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/136078 None >From e70b8283d7778568ff715f8cc400732ad92ac321 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 17 Apr 2025 11:45:52 +0800 Subject: [PATCH] Revert "[CI] monolithic-linux improvements (#135499)" This

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-16 Thread via lldb-commits
@@ -578,20 +605,47 @@ Status ProcessMachCore::DoLoadCore() { SetCanJIT(false); + // If we have an executable binary in the Target already, + // use that to set the Target's ArchSpec. + // + // Don't initialize the ArchSpec based on the corefile's cputype/cpusubtype + /

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (yronglin) Changes This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some missed changes in LLDB. I found this issue when I working on https://github.com/llvm/llvm-project/pull/107168. Currently we h

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/136077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: None (yronglin) Changes This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some missed changes in LLDB. I found this issue when I working on https://github.com/llvm/llvm-project/pull/107168. Currently we have many simi

[Lldb-commits] [lldb] [lldb][Minidump parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/136040 Recently I was debugging a Minidump with a few thousand ranges, and came across the (now deleted) comment: ``` // I don't have a sense of how frequently this is called or how many memory // ranges a Minidum

[Lldb-commits] [lldb] disable test on older compilers (PR #136037)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shubham Sandeep Rastogi (rastogishubham) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136037.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/inva

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136025.diff 3 Files Affected: - (modified) lldb/source/Plugins/Language/ObjC/NSString.cpp (+45-6) - (modified) lldb/source/Plugins/Language/ObjC/NS

[Lldb-commits] [lldb] 18855ec - [lldb] Add summary for NSIndirectTaggedPointerString (#136025)

2025-04-16 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-16T17:31:01-07:00 New Revision: 18855ece3c34a0d76a2126538d60760ddeee2de8 URL: https://github.com/llvm/llvm-project/commit/18855ece3c34a0d76a2126538d60760ddeee2de8 DIFF: https://github.com/llvm/llvm-project/commit/18855ece3c34a0d76a2126538d60760ddeee2de8.diff LOG:

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/136065 This patch is making three changes, when loading a Mach-O corefile: 1. At the start of `DoLoadCore`, if a binary was provided in addition to the corefile, initialize the Target's ArchSpec. 2. Before Proce

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
@@ -368,3 +373,37 @@ bool lldb_private::formatters::NSTaggedString_SummaryProvider( stream << suffix; return true; } + +bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider( +ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor, +

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
@@ -368,3 +373,37 @@ bool lldb_private::formatters::NSTaggedString_SummaryProvider( stream << suffix; return true; } + +bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider( +ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor, +

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
@@ -368,3 +373,37 @@ bool lldb_private::formatters::NSTaggedString_SummaryProvider( stream << suffix; return true; } + +bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider( +ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor, +

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136025 >From 1f9c152dbb7a1e2d70cdf924a8109c8cdb7d0a6f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 16 Apr 2025 13:03:23 -0700 Subject: [PATCH 1/3] [lldb] Add summary for NSIndirectTaggedPointerString --- ..

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
@@ -368,3 +373,37 @@ bool lldb_private::formatters::NSTaggedString_SummaryProvider( stream << suffix; return true; } + +bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider( +ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor, +

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: LGTM with some nits https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Adrian Prantl via lldb-commits
@@ -63,12 +63,17 @@ bool lldb_private::formatters::NSStringSummaryProvider( if (class_name.empty()) return false; - bool is_tagged_ptr = class_name == "NSTaggedPointerString" && - descriptor->GetTaggedPointerInfo(); - // for a tagged pointer, the

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione ready_for_review https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136025 >From 1f9c152dbb7a1e2d70cdf924a8109c8cdb7d0a6f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 16 Apr 2025 13:03:23 -0700 Subject: [PATCH 1/2] [lldb] Add summary for NSIndirectTaggedPointerString --- ..

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/136040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-16 Thread Michael Buch via lldb-commits
Michael137 wrote: > > We probably shouldnt be removing the test. Is there some way to test > > whatever we used to test without the API? > > I see 2 options: > > 1. Move the body of `CompilerType::GetIndexOfFieldWithName` into the test > directly. This way, we remove the API but keep the test

[Lldb-commits] [lldb] [lldb][Minidump parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Recently I was debugging a Minidump with a few thousand ranges, and came across the (now deleted) comment: ``` // I don't have a sense of how frequently this is called or how many memory // ranges a Mini

[Lldb-commits] [lldb] disable test on older compilers (PR #136037)

2025-04-16 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham closed https://github.com/llvm/llvm-project/pull/136037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] disable test on older compilers (PR #136037)

2025-04-16 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham created https://github.com/llvm/llvm-project/pull/136037 None >From 58c4bcec97c984ba43a5d141d8a5bf0bb53714b5 Mon Sep 17 00:00:00 2001 From: Shubham Sandeep Rastogi Date: Wed, 16 Apr 2025 14:40:49 -0700 Subject: [PATCH] disable test on older compilers --- ...

[Lldb-commits] [lldb] 9dbe107 - disable test on older compilers (#136037)

2025-04-16 Thread via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2025-04-16T14:41:20-07:00 New Revision: 9dbe107219c7ab1c422300f9eeb9ca3f7fc87c53 URL: https://github.com/llvm/llvm-project/commit/9dbe107219c7ab1c422300f9eeb9ca3f7fc87c53 DIFF: https://github.com/llvm/llvm-project/commit/9dbe107219c7ab1c422300f9eeb9ca3f7fc8

[Lldb-commits] [lldb] [lldb] Fix lock inversion between statusline mutex and output mutex (PR #135956)

2025-04-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Looks good, thanks! https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione converted_to_draft https://github.com/llvm/llvm-project/pull/136025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add summary for NSIndirectTaggedPointerString (PR #136025)

2025-04-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/136025 None >From 1f9c152dbb7a1e2d70cdf924a8109c8cdb7d0a6f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 16 Apr 2025 13:03:23 -0700 Subject: [PATCH] [lldb] Add summary for NSIndirectTaggedPointerString ---

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe > > it's not working? > > There is only one constructor for step out, and it always skips those frames. > So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over > frames. In

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe it's > not working? There is only one constructor for step out, and it always skips those frames. So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over frames. https://github.

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/6] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread via lldb-commits
jimingham wrote: That one should just do "Go where I tell you, then stop". https://github.com/llvm/llvm-project/pull/135866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread via lldb-commits
jimingham wrote: That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe it's not working? https://github.com/llvm/llvm-project/pull/135866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/tools/lldb-dap/DAP.cpp lldb/tools/lldb-dap/Ha

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/5] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > The `frame_idx` parameter is the frame you step out to. I don't think this is quite true, that parameter indicates where we step out _from_. I know this distinction may look unimportant at first, but it is exactly that distinction that gives the constructor space to ski

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread via lldb-commits
jimingham wrote: > > then it would queue up a ThreadPlanStepOut that would go to that frame. > > To elaborate on this, today there is no constructor for StepOut that allows > one to specify a target frame. This is also something we would need to create > for that to work, right? The main cons

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/135963 >From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 16 Apr 2025 11:28:54 +0100 Subject: [PATCH 1/2] [lldb] Remove unused API CompilerType::GetIndexOfFi

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > We probably shouldnt be removing the test. Is there some way to test whatever > we used to test without the API? I see 2 options: 1. Move the body of `CompilerType::GetIndexOfFieldWithName` into the test directly. This way, we remove the API but keep the test. 2. Keep

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-16 Thread Michael Buch via lldb-commits
Michael137 wrote: We probably shouldnt be removing the test. Is there some way to test whatever we used to test without the API? https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > It's worth mentioning that the LLVM convention (as opposed to what is done in > the swift fork) is to avoid force-pushing. Thanks! I will avoid that for the future PRs 👍 https://github.com/llvm/llvm-project/pull/135963 ___ ll

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: It's worth mentioning that the LLVM convention (as opposed to what is done in the swift fork) is to avoid force-pushing. Instead, you'd always add a new fixup commit (`git commit --fixup`) and squash them when merging (note that, for llvm, github will force you into squas

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/135944 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 419fa1b - [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (#135944)

2025-04-16 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-16T17:57:51+02:00 New Revision: 419fa1b06a36336ad85f1c71fc72ffa719ceb659 URL: https://github.com/llvm/llvm-project/commit/419fa1b06a36336ad85f1c71fc72ffa719ceb659 DIFF: https://github.com/llvm/llvm-project/commit/419fa1b06a36336ad85f1c71fc72ffa719ceb659.diff

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Oh this is fantastic! https://github.com/llvm/llvm-project/pull/135944 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Walter Erquinigo via lldb-commits
@@ -28,15 +28,12 @@ def test_completions(self): self.set_source_breakpoints(source, [breakpoint1_line, breakpoint2_line]) -self.assertEvaluate( -"`command regex user_command s/^$/platform/", r"\(lldb\) command regex" -) -self.asse

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/135963 >From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 16 Apr 2025 11:28:54 +0100 Subject: [PATCH] [lldb] Remove unused API CompilerType::GetIndexOfFieldW

[Lldb-commits] [lldb] [lldb-dap] fix inconsistent debugAdapterHostname argument name (PR #135544)

2025-04-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/135544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. LGTM. Let's see if Jonas has more comments https://github.com/llvm/llvm-project/pull/135008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Walter Erquinigo via lldb-commits
@@ -164,7 +164,8 @@ void EvaluateRequestHandler::operator()( dap.focus_tid = frame.GetThread().GetThreadID(); } auto result = RunLLDBCommandsVerbatim(dap.debugger, llvm::StringRef(), - {std::string(expression)}); +

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/135008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-16 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Probably the default is Auto. I guess we should add an option in the typescript code for selecting the mode. And about `:`, I confused you because I set up my debugger to use `:` instead of a backtick. In this mode, I think it would be great to determine via a quick p

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-16 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I am using what is the default. which is automode. ![image](https://github.com/user-attachments/assets/66ee395e-f513-4ba8-bae3-f4651b2343c9) I am not sure if there is a way to change the mode from the user. https://github.com/llvm/llvm-project/pull/134562 ___

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/134722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-16 Thread Walter Erquinigo via lldb-commits
@@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()( const auto inst_count = GetInteger(arguments, "instructionCount").value_or(0); - lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count); + + std::string flavor_string{}; + const

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

2025-04-16 Thread Walter Erquinigo via lldb-commits
@@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()( const auto inst_count = GetInteger(arguments, "instructionCount").value_or(0); - lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count); + + std::string flavor_string{}; + const

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: >then it would queue up a ThreadPlanStepOut that would go to that frame. To elaborate on this, today there is no constructor for StepOut that allows one to specify a target frame. This is also something we would need to create for that to work, right? https://github.com

[Lldb-commits] [lldb] [lldb][nfc] Remove redundant check in if statement (PR #135869)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135869 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f875dd1 - [lldb][nfc] Remove redundant check in if statement (#135869)

2025-04-16 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-16T08:10:29-07:00 New Revision: f875dd10162dcfb8f4625cef2bfc8e6b9f73f8fc URL: https://github.com/llvm/llvm-project/commit/f875dd10162dcfb8f4625cef2bfc8e6b9f73f8fc DIFF: https://github.com/llvm/llvm-project/commit/f875dd10162dcfb8f4625cef2bfc8e6b9

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-04-16 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @da-viper , I'm a bit surprised by this. Which mode are you using for the debug console? I remember that in Variable mode (or whichever is the default), I was able to type `:expr ` and that worked. Is your problem occurring in the Auto mode? I think that in this case,

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > Is this API used for anything outside of that `PlatformSigInfoTest`? It > doesn't seem to be used anywhere (including the apple fork). Should we just > remove this API? It's not used anywhere apart from the `PlatformSigInfoTest`. It's also inside the `lldb_private` nam

[Lldb-commits] [lldb] [lldb-dap] Fixing a race during disconnect. (PR #135872)

2025-04-16 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/135872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 183cb45 - [lldb-dap] Fixing a race during disconnect. (#135872)

2025-04-16 Thread via lldb-commits
Author: John Harrison Date: 2025-04-16T07:52:16-07:00 New Revision: 183cb45c1280b80a0022649d1db8a93544bb97b0 URL: https://github.com/llvm/llvm-project/commit/183cb45c1280b80a0022649d1db8a93544bb97b0 DIFF: https://github.com/llvm/llvm-project/commit/183cb45c1280b80a0022649d1db8a93544bb97b0.diff

[Lldb-commits] [lldb] [lldb] Fix lock inversion between statusline mutex and output mutex (PR #135956)

2025-04-16 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Michael Buch via lldb-commits
@@ -909,7 +909,7 @@ uint32_t CompilerType::GetIndexOfFieldWithName( return index; } } - return UINT32_MAX; + return llvm::createStringError("Invalid name: Cannot find index"); Michael137 wrote: Could we include the name of the field? This should

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Is this API used for anything outside of that `PlatformSigInfoTest`? It doesn't seem to be used anywhere (including the apple fork). Should we just remove this API? If we do want to keep it, we could add a test for this in `lldb/unittests/Symbol/TestTy

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Forgot to ask here earlier, but would you also be able to add a release note in `llvm-project/llvm/docs/ReleaseNotes.md`? Thanks! https://github.com/llvm/llvm-project/pull/130912 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb] Fix lock inversion between statusline mutex and output mutex (PR #135956)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix deadlock between statusline and output mutex (PR #135956)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix deadlock between statusline and output mutex (PR #135956)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix deadlock between statusline and output mutex (PR #135956)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/135956 >From 215f32820d09d215f2c1b4f4c4c0e0fbe9437264 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 16 Apr 2025 15:55:25 +0200 Subject: [PATCH] [lldb] Fix lock inversion between statusline mutex and

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch updates the `CompilerType::GetIndexOfFieldWithName` API to use `llvm::Expected` if no index is found instead of `UINT32_MAX`. --- Full diff: https://github.com/llvm/llvm-project/pull/13596

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/135963 This patch updates the `CompilerType::GetIndexOfFieldWithName` API to use `llvm::Expected` if no index is found instead of `UINT32_MAX`. >From aaf9c4ec3e68d78d963cdac3d3f08dc207d49cad Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb] Fix deadlock between statusline and output mutex (PR #135956)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Fix a deadlock between the statusline mutex (in Debugger) and the output file mutex (in LockedStreamFile). The deadlock occurs when the main thread is calling the statusline callback while holding t

[Lldb-commits] [lldb] [lldb] Fix deadlock between statusline and output mutex (PR #135956)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/135956 Fix a deadlock between the statusline mutex (in Debugger) and the output file mutex (in LockedStreamFile). The deadlock occurs when the main thread is calling the statusline callback while holding the outp

[Lldb-commits] [lldb] [lldb-dap] Fixing a race during disconnect. (PR #135872)

2025-04-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/135872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-16 Thread Andy Hippo via lldb-commits
werat wrote: > I'm sure lldb-eval had its reasons to implement this, but its use case was > very different from this, and it wasn't in a position to change lldb to make > things faster. We are. As far as I remember flow analysis was implemented because according to C rules `&*p` is equivalent

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135944 >From 28ffd29ac558c8eb3ec8b3305480f237c822b4fd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 16 Apr 2025 11:46:29 +0200 Subject: [PATCH 1/3] [lldb][DataFormatter] Surface CalculateNumChildren errors

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/test/API/functionalities/data-formatter/data-for

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135944 >From 28ffd29ac558c8eb3ec8b3305480f237c822b4fd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 16 Apr 2025 11:46:29 +0200 Subject: [PATCH 1/2] [lldb][DataFormatter] Surface CalculateNumChildren errors

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When the data-formatters happen to break (e.g., due to layout changes in libc++), there's no clear indicator of them failing from a user's perspective. E.g., for `std::vector`s we would just show: ``` (std

[Lldb-commits] [lldb] [lldb][DataFormatter] Surface CalculateNumChildren errors in std::vector summary (PR #135944)

2025-04-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/135944 When the data-formatters happen to break (e.g., due to layout changes in libc++), there's no clear indicator of them failing from a user's perspective. E.g., for `std::vector`s we would just show: ``` (std::

[Lldb-commits] [lldb] include telemetry session-id in diagnostic msg when enabled (PR #135924)

2025-04-16 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/135924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >