[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread John Harrison via lldb-commits
@@ -0,0 +1,33 @@ +//===-- DAPError.h ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -808,85 +808,35 @@ bool Process::HandleProcessStateChangedEvent( std::lock_guard guard(thread_list.GetMutex()); ThreadSP curr_thread(thread_list.GetSelectedThread()); -ThreadSP thread; -StopReason curr_thread_stop_reason = eStopReasonInvalid;

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,33 @@ +//===-- DAPError.h ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] a19c018 - Revert "[lldb][debugserver] Save and restore the SVE/SME register state (#134184)"

2025-04-05 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-02T23:01:51-07:00 New Revision: a19c018379a1d08eceb5db533a19a6bf37423975 URL: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975 DIFF: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975.diff

[Lldb-commits] [lldb] [lldb] Fix use-after-free in SBMutexTest (PR #133840)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The `locked` variable can be accessed from the asynchronous thread until the call to f.wait() completes. However, the variable is scoped in a lexical block that ends before that, leading to a use-af

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-04-05 Thread John Harrison via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb-dap] Swapping to not use FLAG_ENUM and just defining typed enums. (PR #133622)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/133622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e6e8252 - [lldb][AIX] Minor AIX specific changes (#132718)

2025-04-05 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2025-03-25T15:16:23+05:30 New Revision: e6e8252ba0a090d3a43f9df88214b415f9bb4e77 URL: https://github.com/llvm/llvm-project/commit/e6e8252ba0a090d3a43f9df88214b415f9bb4e77 DIFF: https://github.com/llvm/llvm-project/commit/e6e8252ba0a090d3a43f9df88214b415f9bb4e77.di

[Lldb-commits] [lldb] [lldb-dap] Add progress events to the packet list (PR #134157)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @Jlalond changed the approach and the description. Please take another look. https://github.com/llvm/llvm-project/pull/134157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

2025-04-05 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/133299 This reverts commit d7cea2b18717f0cc31b7da4a03f772d89ee201db. It causes crashes in API tests. >From 4139d0625afed999878ff26bd86e61c873beb29f Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Thu, 27 Mar

[Lldb-commits] [lldb] [lldb] Use *Set::insert_range and a range constructor (NFC) (PR #133548)

2025-04-05 Thread Jakub Kuderski via lldb-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update examples in docs/use/python-reference.rst to work with Python 3 (PR #134204)

2025-04-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-04-05 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Sure, Thanks. I have modified my test case for this one. Please let me know your comments. @labath https://github.com/llvm/llvm-project/pull/131304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-05 Thread Pavel Labath via lldb-commits
labath wrote: > > Global variables are > > [banned](https://llvm.org/docs/CodingStandards.html#do-not-use-static-constructors) > > by the coding standards, but I wouldn't be surprised if there were still > > some around that cause this. > > TypeSystemClang.cpp contains global `char TypeSystem

[Lldb-commits] [lldb] d4b586a - [LLDB][NFC] Fix typo in docs (#131388)

2025-04-05 Thread via lldb-commits
Author: Kon Date: 2025-03-20T09:19:33+01:00 New Revision: d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb URL: https://github.com/llvm/llvm-project/commit/d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb DIFF: https://github.com/llvm/llvm-project/commit/d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb.diff LOG: [LLD

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self): self.runCmd("target create {}".format(self.getBuildArtifact("a.out"))) self.expect("run", substrs=["unable to launch a GDB server on"], error=True) + +@skipIfRemote +@skipUnlessPlatf

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 51c2750 - [lldb] Update examples in docs/use/python-reference.rst to work with Python 3 (#134204)

2025-04-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-03T07:40:00-07:00 New Revision: 51c2750599d2472dafce0231aa8b95f5137c7de8 URL: https://github.com/llvm/llvm-project/commit/51c2750599d2472dafce0231aa8b95f5137c7de8 DIFF: https://github.com/llvm/llvm-project/commit/51c2750599d2472dafce0231aa8b95f5137c7de8.d

[Lldb-commits] [lldb] [lldb] Fix prologue size calculation for discontinuous functions (PR #131597)

2025-04-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/6462 Here is the relevant piece

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-05 Thread Karl Traunmüller via lldb-commits
ktraunmueller wrote: Famous last words, haha https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > `test_platform_process_launch_gdb_server` is worth looking into. hm, seems useful. do you think it makes sense to just modify it to run through a symlink, e.g. ``` diff --git a/lldb/test/API/commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py b/ll

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "Reland: [clang] preserve class type sugar when taking pointer to member" (PR #132280)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Matheus Izvekov (mizvekov) Changes Reverts llvm/llvm-project#132234 Needs to be reverted due to dependency. This blocks reverting another PR, see here: https://github.com/llvm/llvm-project/pull/131965#issuecomment-2741619498

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/131683 >From 6d9b82be9fc681f25967a57a5c23148f3d023022 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 17 Mar 2025 23:54:30 + Subject: [PATCH 1/5] [lldb] Add JSON serialization for FileSpec and FileSpecList

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-05 Thread Robert O'Callahan via lldb-commits
@@ -744,6 +744,10 @@ let Command = "process continue" in { Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to, temporarily " "ignoring other breakpoints. Can be specified more than once. " "The continue action will be done synchronously if this o

[Lldb-commits] [lldb] Add enable/disable api for SystemRuntime plugins (PR #133794)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This change LGTM. Are you able to share the motivation behind wanting to enable/disable plugins at runtime? I added support for disabling plugins at configuration/build time and at the time @labath had concerns about that as variou

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134184 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Refactor common test setup into SetUp method (PR #131203)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/131203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -36,18 +36,19 @@ class FuncUnwinders { ~FuncUnwinders(); - lldb::UnwindPlanSP GetUnwindPlanAtCallSite(Target &target, Thread &thread); + std::shared_ptr GetUnwindPlanAtCallSite(Target &target, JDevlieghere wrote: Makes sense. > One idea I have had th

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -107,6 +107,10 @@ def read_packet_thread(vs_comm, log_file): # termination of lldb-dap and stop waiting for new packets. done = not vs_comm.handle_recv_packet(packet) finally: +# Wait for the process to fully exit before dumping the log fi

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self): self.runCmd("target create {}".format(self.getBuildArtifact("a.out"))) self.expect("run", substrs=["unable to launch a GDB server on"], error=True) + +@skipIfRemote +@skipUnlessPlatf

[Lldb-commits] [lldb] [lldb] Prefer PointerType::get with LLVMContext over Type (NFC) (PR #133869)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mats Jun Larsen (junlarsen) Changes Part of #123569 --- Full diff: https://github.com/llvm/llvm-project/pull/133869.diff 2 Files Affected: - (modified) lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.cpp (+2-2) - (modified)

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,104 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix intel trace plugin tests (PR #133826)

2025-04-05 Thread David Peixotto via lldb-commits
dmpots wrote: Here are the relevant test result changes for this change. Trace Hardware Unsupported == Before --- -- Testing: 11 tests, 11 workers -- Unresolved Tests (7): lldb-api :: commands/trace/TestTraceDumpFunctionCalls.py lldb-api :: commands/trace/

[Lldb-commits] [lldb] [lldb-dap] Speed up TestDAP_Progress (PR #134048)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134048 While trying to make progress on #133782, I noticed that TestDAP_Progress was taking 90 seconds to complete. This patch brings that down to 10 seocnds by making the following changes: 1. Don't call `wait_

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-04-05 Thread Pavel Labath via lldb-commits
labath wrote: I've skipped them (I hope) with 6d38dbf6eb56fd2b3399565af455de96a99ffa0f. @rocallahan, it seems the only way to extract information from these bots is to commit PRs. Let me know what kind of information would help you and I'll try to find a way to get the test to do that. https:

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-04-05 Thread Paul Kirth via lldb-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s ilovepi wrote: Lets move this down w/ the HTML FileChe

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-04-05 Thread via lldb-commits
jimingham wrote: I don't think it's necessary to turn off stepping past hidden frames with this patch. You need to get the ThreadPlanStepInRange's SetDefaultFlags to add eStepOutPastHiddenFunctions by or-ing that into the ThreadPlanStepInRange::s_default_flag_values. That will handle the cas

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-05 Thread Adrian Vogelsgesang via lldb-commits
@@ -463,6 +463,8 @@ void InitializeRequestHandler::operator()( body.try_emplace("supportsDataBreakpoints", true); // The debug adapter supports the `readMemory` request. body.try_emplace("supportsReadMemoryRequest", true); + // The debug adapter supports the 'writeMemory

[Lldb-commits] [lldb] ee60f7c - [lldb] Hoist UUID generation into the UUID class (#133662)

2025-04-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-02T08:50:28-07:00 New Revision: ee60f7c7a4e4e400918c83decb6cd498aff94012 URL: https://github.com/llvm/llvm-project/commit/ee60f7c7a4e4e400918c83decb6cd498aff94012 DIFF: https://github.com/llvm/llvm-project/commit/ee60f7c7a4e4e400918c83decb6cd498aff94012.d

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-04-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/18611 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 7bad765585b2ae96faf2d2558b099f4b965d2791 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/23] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -38,7 +39,7 @@ enum DWARFProducer { eProducerOther }; -class DWARFUnit : public UserID { +class DWARFUnit : public UserID, public DWARFExpression::Delegate { labath wrote: ```suggestion class DWARFUnit : public DWARFExpression::Delegate, public UserID {

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130104 >From 2c51a8bdb27764a358e76e554d693a4af57074fc Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 14:13:58 +0100 Subject: [PATCH] [lldb-dap] Adding support for well typed events. This adds a mech

[Lldb-commits] [lldb] [lldb] Convert Breakpoint & Watchpoints structs to classes (NFC) (PR #133780)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133780 Convert Breakpoint & Watchpoints structs to classes to provide proper access control. This is in preparation for adopting SBMutex to protect the underlying SBBreakpoint and SBWatchpoint. >From 2f22b24840e

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 351bcd9fe229121fac58e051f9a83dce2d3066ae...9a6d64373f45921c5b23460b12544869355ddd15 lldb/

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-04-05 Thread Paul Kirth via lldb-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/127661 >From 22c489dbd334fb84b8d81deac8e7e6c5590fc6d9 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 18 Feb 2025 16:14:30 +0100 Subject: [PATCH] [lldb] s/ValidRange/ValidRanges in UnwindPlan To be able to descr

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The surrounding code doesn't use them anymore. This removes the internal usages. This patch makes the Rows actual values. An alternative would be to make them unique_ptrs. That would make vector resizes faster

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-04-05 Thread Vy Nguyen via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-04-05 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/130912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-05 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/134173 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create a default rate limit constant in Progress (NFC) (PR #133506)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133506 >From 497d45360ad50ae909d946b4a34b55346c56ff69 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 28 Mar 2025 11:55:23 -0700 Subject: [PATCH 1/2] [lldb] Create a default rate limit constant in Prog

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-04-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15220 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-05 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#134072 https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix tests on Windows (PR #131600)

2025-04-05 Thread Aleksandr Korepanov via lldb-commits
https://github.com/AlexK0 updated https://github.com/llvm/llvm-project/pull/131600 >From 2186582c6113033a7adf2c3ac7fb1a6fcde5726c Mon Sep 17 00:00:00 2001 From: Aleksandr Korepanov Date: Mon, 17 Mar 2025 11:03:57 +0100 Subject: [PATCH 1/2] [LLDB][tests] Transfer APPDATA env for running tests O

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-05 Thread Michael Buch via lldb-commits
Michael137 wrote: > LGTM. Even the variable name made it clear this wasn't being set correctly. > We just usually do evaluate expressions in the selected frame context. This > should cause a failure in the current code if you call > SBThread.SetSelectedFrame for frame A and then get the SBFram

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-04-05 Thread Dave Lee via lldb-commits
kastiglione wrote: @luporl https://github.com/llvm/llvm-project/pull/131890 https://github.com/llvm/llvm-project/pull/131475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 825460a - [lldb/gdb-remote] Do not crash on an invalid server response (#131979)

2025-04-05 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-03-19T10:51:27-07:00 New Revision: 825460a7728662d0062405e690485b7a1b689484 URL: https://github.com/llvm/llvm-project/commit/825460a7728662d0062405e690485b7a1b689484 DIFF: https://github.com/llvm/llvm-project/commit/825460a7728662d0062405e690485b7a1b689484.diff L

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-04-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Will be great when debugging LLDB itself! https://github.com/llvm/llvm-project/pull/133211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] 4492632 - [lldb-dap] Do not take ownership of stdin. (#133811)

2025-04-05 Thread via lldb-commits
Author: John Harrison Date: 2025-03-31T15:51:07-07:00 New Revision: 4492632432190ed8ab3bc39ff8ee5ba9a89256cf URL: https://github.com/llvm/llvm-project/commit/4492632432190ed8ab3bc39ff8ee5ba9a89256cf DIFF: https://github.com/llvm/llvm-project/commit/4492632432190ed8ab3bc39ff8ee5ba9a89256cf.diff

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-05 Thread David Spickett via lldb-commits
@@ -220,6 +220,8 @@ Changes to LLDB information about the current state of the debugger at the bottom of the terminal. This is on by default and can be configured using the `show-statusline` and `statusline-format` settings. +* LLDB now supports `process continue --revers

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This doesn't seem to be enough. When I added this, the SIGHUP disappeared for a bunch of runs, but now I'm seeing it again, with this patch applied. https://github.com/llvm/llvm-project/pull/133791 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-05 Thread John Harrison via lldb-commits
ashgti wrote: I did that while I was trying to figure out how to have `cancel` request support. I was trying to close the FD to stop the reader thread, but that actually doesn't interrupt in-progress `read` calls. I should have reverted that when I did some of the `Transport` refactors. In my

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -777,28 +798,134 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +template +static std::optional getArgumentsIfRequest(const protocol::Message &pm, + llvm::StringLiteral command) { + auto *co

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP] [libcxxabi][ItaniumDemangle] Add infrastructure to track location information of parts of a demangled function name (PR #133249)

2025-04-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/133249 >From 0875195a7ed39c21e9b639bf66d56b48e9869e51 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 11 Mar 2025 08:57:13 + Subject: [PATCH 1/4] [llvm][ItaniumDemangle] Add function name location tracki

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values, part 2 (PR #132008)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Robert O'Callahan (rocallahan) Changes This introduces the options "-F/--forward" and "-R/--reverse" to `process continue`. These only work if you're running with a gdbserver backend that supports reverse execution, such as rr. For testin

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/133007 This adds new types and helpers to support the 'initialize' request with the new typed RequestHandler. While working on this I found there were a few cases where we incorrectly treated initialize arguments as ca

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-04-05 Thread Pavel Labath via lldb-commits
labath wrote: @JDevlieghere, @jasonmolenda any chance I could get a review on this patch? Or ask me questions -- I can explain where I'm trying to go with this. As much as I like refactoring around this code, I do actually need to make progress on adding the functionality. :) https://github.c

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-05 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/10] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-05 Thread Karl Traunmüller via lldb-commits
ktraunmueller wrote: Just out of curiosity: I was also surprised by the precondition, which looks unnecessary and, more importantly, very unexpected, to me. How would a caller know (from looking at the API) that passing a non-empty string would be fatal? If there's a preconditions in the co

[Lldb-commits] [lldb] [lldb] Handle improperly nested blocks differently (PR #117725)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,100 @@ +## This test checks that lldb handles (corrupt?) debug info which has improperly +## nested blocks. The behavior here is not prescriptive. We only want to check +## that we do something "reasonable". + + +# RUN: llvm-mc -triple=x86_64-pc-linux -filetype=obj %s

[Lldb-commits] [lldb] [lldb] Move two methods from Platfrom -> Host (NFC) (PR #132119)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/132119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/132255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-04-05 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/132884 >From 6edc108199044d30eed396145aab463db40d6351 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Thu, 13 Mar 2025 16:13:45 -0700 Subject: [PATCH 1/2] Remove raw access to PluginInstances vector This commit mod

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132234)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes Original PR: #130537 Reland after updating lldb too. This changes the MemberPointerType representation to use a NestedNameSpecifier instead of a Type to represent t

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-05 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Still seeing a crash even with the latest fix applied ``` assertion failed at clang/include/clang/AST/Type.h:945 in const ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() && "Cannot retrieve a NULL type pointer" *** Check failure stack trace: *** @

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-04-05 Thread Matthew Bastien via lldb-commits
@@ -0,0 +1,130 @@ +import * as child_process from "node:child_process"; +import * as vscode from "vscode"; + +function areArraysEqual(lhs: T[], rhs: T[]): boolean { + if (lhs.length !== rhs.length) { +return false; + } + for (let i = 0; i < lhs.length; i++) { +if (lhs[i

[Lldb-commits] [lldb] Reapply "[lldb] Return *const* UnwindPlan pointers from FuncUnwinders " (PR #134246)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This reverts commit 094904303d50e0ab14bc5f2586a602f79af95953, reapplying d7afafdbc464e65c56a0a1d77bad426aa7538306 (#133247). The failure ought to be fixed by 0509932bb6a291ba11253f30c465ab3ad164ae08. --- Pat

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-04-05 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/132043 >From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Mar 2025 10:44:12 -0400 Subject: [PATCH 1/4] Reapply "[LLDB][Telemetry]Define TargetInfo for collecting data

[Lldb-commits] [lldb] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-05 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: I suppose we need to add documentation for this but I'm not sure where... https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb-dap] Enable runInTerminal tests on macOS. (PR #133824)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes These tests are currently filtered on macOS if your on an M1 (or newer) device. These tests do work on macOS, for me at least on M1 Max with macOS 15.3.2 and Xcode 16.2. Enabling them again, but if we have C

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-04-05 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Based on the 2013 commit that added those, I don't think there is a clean way of testing this. That said, since these methods simply forward to the underlying register context, I think it's ok to rely on the lack of regression from the OS plugin tests https://github.com/

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes an exit status. +struct ExitDescription { + int exit_code; + std::string description; +}; +

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/132255 >From a696c1c3ce5cf0f652e0a016c5d5d422b2ae24d3 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 20 Mar 2025 10:08:53 -0700 Subject: [PATCH 1/3] [lldb-dap] Adding a DAPError for showing users error message

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-05 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: > There is another Pull Request for the same functionality #108036. The other > PR seems to be outdated, though, and this PR seems to be further along (e.g. > it also has test cases). CC @jennphilqc @walter-erquinigo @clayborg since you > commented on the other PR and might

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-05 Thread via lldb-commits
@@ -0,0 +1,283 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/132395 The check is not correct for discontinuous functions, as one of the blocks could very well begin before the function entry point. To catch dead-stripped ranges, I check whether the functions is after the first k

[Lldb-commits] [lldb] [lldb-dap] Protect SetBreakpoint with the API mutex (PR #134030)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looks great! https://github.com/llvm/llvm-project/pull/134030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [clang-doc] Add regression test for test comments in macros (PR #132360)

2025-04-05 Thread via lldb-commits
https://github.com/ZhongUncle closed https://github.com/llvm/llvm-project/pull/132360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133791 This makes the DAP test server resilient against broken pipes. I'm not sure what is causing the broken pipe, but IIRC this isn't the first time we've seen an issues related to that. I worry about swooping

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-04-05 Thread John Harrison via lldb-commits
@@ -0,0 +1,118 @@ +//===-- GoToRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-04-05 Thread Matthew Bastien via lldb-commits
@@ -0,0 +1,130 @@ +import * as child_process from "node:child_process"; +import * as vscode from "vscode"; + +function areArraysEqual(lhs: T[], rhs: T[]): boolean { + if (lhs.length !== rhs.length) { +return false; + } + for (let i = 0; i < lhs.length; i++) { +if (lhs[i

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (PR #132688)

2025-04-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/Process/Utility/LinuxSignals.cpp

[Lldb-commits] [lldb] [lldb] Fix TestBreakpointLocations (PR #131890)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/131890.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py (+2-2)

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [clang-doc] Add regression test for test comments in macros (PR #132360)

2025-04-05 Thread via lldb-commits
ZhongUncle wrote: I am not familiar with PR, so accidentally closed this PR. I create a new one #132510 https://github.com/llvm/llvm-project/pull/132360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

  1   2   >