[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-03-18 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/131979 An invalid RLE sequence in the received packet could result in an out-of-bounds reading that could cause a crash. >From 239aeaa5686350681dc79cad63d5aae5a5f2310a Mon Sep 17 00:00:00 2001 From: Igor Kudrin Da

[Lldb-commits] [lldb] ca87823 - [LLDB][NFC]Refactor common test setup into SetUp method (#131203)

2025-03-18 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-03-18T10:09:03-04:00 New Revision: ca87823438e312f4fc7f13bda6ced448e4216cf6 URL: https://github.com/llvm/llvm-project/commit/ca87823438e312f4fc7f13bda6ced448e4216cf6 DIFF: https://github.com/llvm/llvm-project/commit/ca87823438e312f4fc7f13bda6ced448e4216cf6.diff LOG

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-18 Thread David Tenty via lldb-commits
https://github.com/daltenty approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/131200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestBreakpointLocations (PR #131890)

2025-03-18 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/131890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5728813 - [lldb] Fix TestBreakpointLocations (#131890)

2025-03-18 Thread via lldb-commits
Author: Dave Lee Date: 2025-03-18T22:57:35-07:00 New Revision: 57288136fecfac35ef161cb8f147d269715d2634 URL: https://github.com/llvm/llvm-project/commit/57288136fecfac35ef161cb8f147d269715d2634 DIFF: https://github.com/llvm/llvm-project/commit/57288136fecfac35ef161cb8f147d269715d2634.diff LOG:

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +struct APILock { + APILock(std::recursive_mutex &mutex) : lock(mutex) {} + std::lock_guard lock; +}; + +/// The private implementation used by

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/130104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-18 Thread David Tenty via lldb-commits
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib) set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH "Path where built compiler-rt libraries should be instal

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -1559,10 +1560,29 @@ void Target::DidExec() { void Target::SetExecutableModule(ModuleSP &executable_sp, LoadDependentFiles load_dependent_files) { + telemetry::ScopedDispatcher helper(&m_debugger); Log *log = GetLog(LLDBLog::Target);

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/131943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4088557 - [lldb-dap] Move request capabilities into request handlers (NFC) (#131943)

2025-03-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-18T19:56:04-07:00 New Revision: 40885572783b1b1d3fe5dc7bce119f08728dc11f URL: https://github.com/llvm/llvm-project/commit/40885572783b1b1d3fe5dc7bce119f08728dc11f DIFF: https://github.com/llvm/llvm-project/commit/40885572783b1b1d3fe5dc7bce119f08728dc11f.d

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
oontvoo wrote: Thanks! https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 04e39ce - [LLDB][Telemetry]Define TargetInfo for collecting data about a target (#127834)

2025-03-18 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-03-18T22:54:08-04:00 New Revision: 04e39ce3fddaaec41d9c7babcca55133d7e49969 URL: https://github.com/llvm/llvm-project/commit/04e39ce3fddaaec41d9c7babcca55133d7e49969 DIFF: https://github.com/llvm/llvm-project/commit/04e39ce3fddaaec41d9c7babcca55133d7e49969.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131943 >From c9770d124155beabcb133e47a5d798d22bcb7de2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 18 Mar 2025 17:47:26 -0700 Subject: [PATCH 1/2] [lldb-dap] Move request capabilities into request

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebase on top of #131658: The unit test should pass now. https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread John Harrison via lldb-commits
@@ -1145,4 +1145,33 @@ lldb::SBValue Variables::FindVariable(uint64_t variablesReference, return variable; } +llvm::StringMap DAP::GetCapabilities() { + llvm::StringMap capabilities; + + // Supported capabilities. + capabilities["supportTerminateDebuggee"] = true; + cap

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/131943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/131916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131943 >From c9770d124155beabcb133e47a5d798d22bcb7de2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 18 Mar 2025 17:47:26 -0700 Subject: [PATCH] [lldb-dap] Move request capabilities into request handl

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This distributes the registration of request related capabilities to the corresponding request handler. Global and unsupported capabilities are registered at the DAP level. --- Full diff: https://g

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -1145,4 +1145,33 @@ lldb::SBValue Variables::FindVariable(uint64_t variablesReference, return variable; } +llvm::StringMap DAP::GetCapabilities() { + llvm::StringMap capabilities; + + // Supported capabilities. + capabilities["supportTerminateDebuggee"] = true; + cap

[Lldb-commits] [lldb] [lldb-dap] Move request capabilities into request handlers (NFC) (PR #131943)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/131943 This distributes the registration of request related capabilities to the corresponding request handler. Global and unsupported capabilities are registered at the DAP level. >From f2d2cf931ab65612303178c57

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -14,11 +14,11 @@ #ifndef LLDB_TOOLS_LLDB_DAP_TRANSPORT_H #define LLDB_TOOLS_LLDB_DAP_TRANSPORT_H +#include "DAPLog.h" vogelsgesang wrote: is a forward declaration sufficient? https://github.com/llvm/llvm-project/pull/131916 ___

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -9,44 +9,66 @@ #ifndef LLDB_TOOLS_LLDB_DAP_DAPLOG_H #define LLDB_TOOLS_LLDB_DAP_DAPLOG_H +#include "llvm/ADT/StringRef.h" #include "llvm/Support/Error.h" #include "llvm/Support/FormatAdapters.h" #include "llvm/Support/FormatVariadic.h" #include #include +#include #

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes I noticed this while debugging some unit tests that the logs occasionally would intersperse two log statements. Previously, it was possible for a log statement to have two messages interspersed since the tim

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/28] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-18 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: > Ah, turns out there's a HostInfo::GetProgramFileSpec() function which solves > both these issues. I am aware of that function. The reason I did not suggest it is because `GetProgramFileSpec` (on linux) returns the canonical path (with all symlinks resolv

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
@@ -256,7 +257,27 @@ void DAP::SendJSON(const llvm::json::Value &json) { } return; } - auto status = transport.Write(log, M); + Send(M); +} + +void DAP::Send(const protocol::Message &M) { + lldb_private::Status status; + // If the debugger was interrupted while ha

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Maybe disabling tests for macOS < 15 would be OK even in the long term? There isn't any looming plan to actually use this code on macOS < 15. The main reason to run these tests on non-Linux is so to help developers catch it early if they break these tests. I guess most develo

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-03-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This should ensure we have the full logs prior to dumping the logs. Additionally, printing log dumps to stderr so they are adjacent to assertion failures. --- Full diff: https://github.com/llvm/llvm-projec

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2025-03-18 Thread Izzy Muerte via lldb-commits
bruxisma wrote: > I think it change the meaning completely. I read "Coverage Sanitizer" as a > tool which finds bugs in Coverage. When "Sanitizer Coverage" as a coverage > used by sanitizers. > > This component is not sanitizer at all, and the current name is more > appropriate. The document

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/131917 This should ensure we have the full logs prior to dumping the logs. Additionally, printing log dumps to stderr so they are adjacent to assertion failures. >From ca59812b9b23c96354982b6c696fb2b129bf117d Mon Se

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/131916 I noticed this while debugging some unit tests that the logs occasionally would intersperse two log statements. Previously, it was possible for a log statement to have two messages interspersed since the timest

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Adding support for cancelling requests. There are two forms of request cancellation. * Preemptively cancelling a request that is in the queue. * Actively cancelling the in progress request as a best effort at

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130169 >From 8b71292a70deeab65799c0d88072e17366a594ce Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 18 Mar 2025 14:05:38 -0700 Subject: [PATCH] [lldb-dap] Adding support for cancelling a request. Adding suppo

[Lldb-commits] [lldb] [lldb] Fix TestBreakpointLocations (PR #131890)

2025-03-18 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/131890 >From dc99a05203deef893db75dd2f32a5a6453aaae9a Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 18 Mar 2025 11:33:46 -0700 Subject: [PATCH 1/2] [lldb] Fix TestBreakpointLocations --- .../breakpoint_locat

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/27] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
@@ -0,0 +1,56 @@ +//===-- SourceRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
@@ -67,7 +67,7 @@ static Status ReadExpected(IOObjectSP &descriptor, llvm::StringRef expected) { if (status.Fail()) return status; if (expected != result) { -return Status::FromErrorStringWithFormatv("expected %s, got %s", expected, +return Status::FromErrorStr

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
@@ -152,6 +153,8 @@ struct Response { bool fromJSON(const llvm::json::Value &, Response &, llvm::json::Path); llvm::json::Value toJSON(const Response &); +using VoidResponseBody = std::nullptr_t; ashgti wrote: Done. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
@@ -348,6 +351,71 @@ llvm::json::Value toJSON(const ExitedEventBody &); // MARK: Requests +// "CancelRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +// "description": "The `cancel` request is used by the client in two +//

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-18 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130169 >From 6bb322fd3ed0df56adcb2bc4687f89ee7f4cdf5f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 27 Feb 2025 15:17:15 -0800 Subject: [PATCH] [lldb-dap] Adding support for cancelling a request. Adding suppo

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-18 Thread Daniel Chen via lldb-commits
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib) set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH "Path where built compiler-rt libraries should be instal

[Lldb-commits] [lldb] [lldb] Fix TestBreakpointLocations (PR #131890)

2025-03-18 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/131890 None >From dc99a05203deef893db75dd2f32a5a6453aaae9a Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 18 Mar 2025 11:33:46 -0700 Subject: [PATCH] [lldb] Fix TestBreakpointLocations --- .../breakpoint_loc

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread John Harrison via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread John Harrison via lldb-commits
@@ -112,3 +112,23 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @jasonmolenda Pavel Labath thought you might have some insight here. Thanks. https://github.com/llvm/llvm-project/pull/128156 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-18 Thread David Tenty via lldb-commits
https://github.com/daltenty edited https://github.com/llvm/llvm-project/pull/131200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; oontvoo wrote: done htt

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-18 Thread Dave Lee via lldb-commits
kastiglione wrote: @luporl I have a fix, I'll share the link soon. https://github.com/llvm/llvm-project/pull/131475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-18 Thread Leandro Lupori via lldb-commits
luporl wrote: This change broke https://lab.llvm.org/buildbot/#/builders/141/builds/7116. `functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py` passes when I revert this change. Can you please take a look? https://github.com/llvm/llvm-project/pull/131475 ___

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
@@ -1559,10 +1560,29 @@ void Target::DidExec() { void Target::SetExecutableModule(ModuleSP &executable_sp, LoadDependentFiles load_dependent_files) { + telemetry::ScopedDispatcher helper(&m_debugger); Log *log = GetLog(LLDBLog::Target);

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
@@ -76,15 +76,36 @@ void CommandInfo::serialize(Serializer &serializer) const { serializer.write("error_data", error_data.value()); } +std::atomic CommandInfo::g_command_id_seed = 0; +uint64_t CommandInfo::GetNextId() { return g_command_id_seed.fetch_add(1); }

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
@@ -1066,6 +1067,26 @@ const char *Process::GetExitDescription() { bool Process::SetExitStatus(int status, llvm::StringRef exit_string) { // Use a mutex to protect setting the exit status. std::lock_guard guard(m_exit_status_mutex); + telemetry::ScopedDispatcher helper; +

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-18 Thread via lldb-commits
satyajanga wrote: > Pretty good start. There can be more than one breakpoint at a location and we > need to be sure we test these cases. Like we can have an exception breakpoint > (which might be at `cxa_throw`) and we can have a function breakpoint for > this as well. We need to make sure we

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -77,6 +77,7 @@ add_lldb_tool(lldb-dap Protocol/ProtocolBase.cpp Protocol/ProtocolTypes.cpp Protocol/ProtocolRequests.cpp + Handler/WriteMemoryRequestHandler.cpp JDevlieghere wrote: This should go between the other `Handler/` files (which are sorted

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// JDevlieghere wrote: ```suggestion //===-- WriteMemoryRequestHandler.cpp -===// ``` https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -76,15 +76,36 @@ void CommandInfo::serialize(Serializer &serializer) const { serializer.write("error_data", error_data.value()); } +std::atomic CommandInfo::g_command_id_seed = 0; +uint64_t CommandInfo::GetNextId() { return g_command_id_seed.fetch_add(1); }

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo nits. https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131404 >From cd65c4cf07b5b2f03fd1f2ebe8d586b4d1bbc062 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 14 Mar 2025 15:19:58 -0700 Subject: [PATCH 1/4] [lldb] Expose the Target API lock through the SB AP

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; JDevlieghere wrote: Let'

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -1066,6 +1067,26 @@ const char *Process::GetExitDescription() { bool Process::SetExitStatus(int status, llvm::StringRef exit_string) { // Use a mutex to protect setting the exit status. std::lock_guard guard(m_exit_status_mutex); + telemetry::ScopedDispatcher helper; +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes an exit status. +struct ExitDescription { + int exit_code; + std::string description; +}; +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes an exit status. +struct ExitDescription { + int exit_code; + std::string description; +}; +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { JDevlieghere wrote: ```suggestion struct ExecutableM

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +struct ExecModuleInfo : public LLDBBaseTelemetryInfo { + lldb::ModuleSP exec_mod; + + /// The same as the executable-module

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes an exit status. +struct ExitDescription { + int exit_code; + std::string description; +}; +

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 03a4172a3a4dae7d1ed45570fff66a89e792ca71 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 11 Mar 2025 08:57:13 + Subject: [PATCH 1/4] [llvm][ItaniumDemangle] Add function name location tracki

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-18 Thread Vy Nguyen via lldb-commits
oontvoo wrote: Hi, friendly ping? @JDevlieghere thanks! https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] (PR #131836)

2025-03-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/131836 This is a prototype of highlighting function basenames in LLDB's backtraces. This is done by tracking information about components of a demangled function name and plumbing that from the demangler through to

[Lldb-commits] [lldb] [lldb/platform-gdb] Do not assume a persistent connection (PR #131736)

2025-03-18 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/131736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6d38dbf - [lldb] Skip reverse continue tests on macos<15.0

2025-03-18 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-03-18T17:52:36+01:00 New Revision: 6d38dbf6eb56fd2b3399565af455de96a99ffa0f URL: https://github.com/llvm/llvm-project/commit/6d38dbf6eb56fd2b3399565af455de96a99ffa0f DIFF: https://github.com/llvm/llvm-project/commit/6d38dbf6eb56fd2b3399565af455de96a99ffa0f.diff

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFUnitInterface to break dependencies and reduce lldb-server size (PR #131645)

2025-03-18 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/131645 >From 464460db7550673bac788ad11e3ed4d45946cd71 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Mon, 17 Mar 2025 19:13:20 +0400 Subject: [PATCH 1/2] [LLDB][NFC] Added the interface DWARFUnitInterface to br

[Lldb-commits] [lldb] [lldb] Fix double free in CommandPluginInterfaceImplementation (PR #131658)

2025-03-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/131658 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7b3455e - [lldb] Fix double free in CommandPluginInterfaceImplementation (#131658)

2025-03-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-18T09:48:34-07:00 New Revision: 7b3455e24ab5aa090e5b2b9ce50c249843c45754 URL: https://github.com/llvm/llvm-project/commit/7b3455e24ab5aa090e5b2b9ce50c249843c45754 DIFF: https://github.com/llvm/llvm-project/commit/7b3455e24ab5aa090e5b2b9ce50c249843c45754.d

[Lldb-commits] [lldb] 6542cf1 - [lldb/platform-gdb] Do not assume a persistent connection (#131736)

2025-03-18 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-03-18T09:25:35-07:00 New Revision: 6542cf1973208a83b2f883f2143464c4fdbac9eb URL: https://github.com/llvm/llvm-project/commit/6542cf1973208a83b2f883f2143464c4fdbac9eb DIFF: https://github.com/llvm/llvm-project/commit/6542cf1973208a83b2f883f2143464c4fdbac9eb.diff L

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -138,10 +139,10 @@ class CPlusPlusLanguage : public Language { ConstString GetDemangledFunctionNameWithoutArguments(Mangled mangled) const override; - bool GetFunctionDisplayName(const SymbolContext *sc, - const ExecutionContext *exe_ctx, -

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -83,6 +99,127 @@ class OutputBuffer { return std::string_view(Buffer, CurrentPosition); } + // Stores information about parts of a demangled function name. + struct FunctionNameInfo { +///< A [start, end) pair for the function basename. adrian-p

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -83,6 +99,127 @@ class OutputBuffer { return std::string_view(Buffer, CurrentPosition); } + // Stores information about parts of a demangled function name. adrian-prantl wrote: ```suggestion /// Stores information about parts of a demangled functi

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0a21ef9536e0f591d334b230bd388bcb503e27ec 5656cdd65048c0af5482aef7de1e163dd078d437 --e

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: May I recommend we add a skip for macOS < 15 to get the bot green again? https://github.com/llvm/llvm-project/pull/128156 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > It would be useful to know if you can reproduce this problem locally (because > I can't -- the test passes on my mac). If you can't then it would be useful > to get as much information about this buildbot as possible (what kind of > debugserver it uses, OS versions and s

  1   2   >