https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105594
>From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 19 Jul 2024 17:26:13 -0700
Subject: [PATCH 01/14] [lldb] Change lldb's breakpoint handling behavior
(#
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Remove Debugger::GetOutputStream and Debugger::GetErrorStream in preparation
for replacing both with a new variant that needs to be locked and hence can't
be handed out like we do right now.
The pa
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/126821
Remove Debugger::GetOutputStream and Debugger::GetErrorStream in preparation
for replacing both with a new variant that needs to be locked and hence can't
be handed out like we do right now.
The patch rep
jasonmolenda wrote:
The details of the bug that Martin found were actually bit a interesting.
The core of the issue is that the thread has a ThreadPlanStepOut, and before we
resume execution, because we're at a BreakpointSite that has been hit, we push
a ThreadPlanStepOverBreakpoint plan. It
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH] [lldb] Add terminfo dependency for ncurses
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan R AW (ajordanr-google)
Changes
For some operating systems, terminfo is a separate package and library from
ncurses. Both are still requirements for curses support in lldb, individually.
This is a rebase of this original spack commit
https://github.com/ajordanr-google created
https://github.com/llvm/llvm-project/pull/126810
For some operating systems, terminfo is a separate package and library from
ncurses. Both are still requirements for curses support in lldb, individually.
This is a rebase of this original spack commit:
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/126803
>From a07148100b02fa109cd3131d2d7742cdc0ae2bfa Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Tue, 11 Feb 2025 16:38:43 -0500
Subject: [PATCH] add `debugAdapterExecutable` property to launch configu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Matthew Bastien (matthewbastien)
Changes
The Swift extension for VS Code requires that the `lldb-dap` executable come
from the Swift toolchain which may or may not be configured in `PATH`. At the
moment, this can be configured via LLDB DAP
https://github.com/matthewbastien created
https://github.com/llvm/llvm-project/pull/126803
The Swift extension for VS Code requires that the `lldb-dap` executable come
from the Swift toolchain which may or may not be configured in `PATH`. At the
moment, this can be configured via LLDB DAP's ex
https://github.com/RossComputerGuy approved this pull request.
https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
Related follow-up :
[PR/126746](https://github.com/llvm/llvm-project/pull/126746) (for excluding
telemetry code)
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/2] Addressed additional review comments from PR/119716.
---
lldb/
https://github.com/mgorny approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> .. and fix the code so that it uses the new macro name ? (You'll need to
> include llvm-config.h before you can use the macro, and I'd recommend doing a
> build with telemetry disabled to check that everything works as it should)
Done. (also tested with explicitly specifying
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/5] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
labath wrote:
.. and fix the code so that it uses the new macro name ? (You'll need to
include llvm-config.h before you can use the macro, and I'd recommend doing a
build with telemetry disabled to check that everything works as it should)
https://github.com/llvm/llvm-project/pull/126746
_
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9387fd96314c59fc9aff1a82e478f9b89a97c20a
b767a2efb6f1d39e83523cfdf330ddd26a8cf892 --e
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/126583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> In that case, could you also delete the definition in llvm/lib/CMakeLists.txt
> and the one introduced in #126715 ?
done
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/4] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Background:
Telemetry code isn't always built (controlled by this LLVM_BUILD_TELEMETRY
cmake flag)
This means users of the library may not have the library. So we're definding
the `-DLLVM_BUILD_TELEMETRY` to b
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/3] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
Author: Jonas Devlieghere
Date: 2025-02-11T09:51:18-08:00
New Revision: 918848d03bb9d0e06dea2ef588bda17ff961923c
URL:
https://github.com/llvm/llvm-project/commit/918848d03bb9d0e06dea2ef588bda17ff961923c
DIFF:
https://github.com/llvm/llvm-project/commit/918848d03bb9d0e06dea2ef588bda17ff961923c.d
JDevlieghere wrote:
> it doesn't e.g. prevent someone from printing something in the middle of a
> statusline update.
Technically it does, because the statusline is printed as a single call to
write, but I agree that's fragile and one could argue that works by accident
rather than by design.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/126757.diff
2 Files Affected:
- (modified) lldb/include/lldb/Core/Telemetry.h (+1-1)
- (modified) lldb/source/Core/Telemetry.cpp (+5-9)
``d
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/126757
None
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH] Addressed additional review comments from PR/119716.
---
lld
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/126652
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Keith Smiley
Date: 2025-02-11T08:04:51-08:00
New Revision: 5bf42d3e2e83344db14fc0e33623840c53cebfc4
URL:
https://github.com/llvm/llvm-project/commit/5bf42d3e2e83344db14fc0e33623840c53cebfc4
DIFF:
https://github.com/llvm/llvm-project/commit/5bf42d3e2e83344db14fc0e33623840c53cebfc4.diff
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,74 @@
+//===-- Telemetry.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/4] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/2] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/126505
>From a716420ee79ea03cd64cf79f1e1f727b86960995 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 9 Jan 2025 13:02:24 +0100
Subject: [PATCH 1/2] [lldb] Support disassembling discontinuous functions
The comma
@@ -262,9 +269,11 @@ CommandObjectDisassemble::GetContainingAddressRanges() {
addr, eSymbolContextEverything, sc, resolve_tail_call_address);
if (sc.function || sc.symbol) {
AddressRange range;
- sc.GetAddressRange(eSymbolContextFunction | eSymbolContextS
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/126526
>From fda9035cddce78e2109462c9cec176bcb96392d8 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 10 Feb 2025 15:20:05 +0100
Subject: [PATCH 1/2] [lldb] Fixing edge cases in "command source"
While looking at
labath wrote:
> "command source" is another lldb command which this PR is not about... This
> is about "source list" and/or "source info". Not important but the title was
> pretty confusing...
Yeah, sorry. I myself got confused because I was looking at another test case
in this directory with
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -320,25 +320,37 @@ void Function::GetStartLineSourceInfo(SupportFileSP
&source_file_sp,
}
}
-void Function::GetEndLineSourceInfo(FileSpec &source_file, uint32_t &line_no) {
- line_no = 0;
- source_file.Clear();
-
- // The -1 is kind of cheesy, but I want to get the la
@@ -784,14 +784,12 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (sc.block == nullptr) {
// Not an inlined function
-sc.function->GetStartLineSourceInfo(start_file, start_line);
-if (start_line == 0) {
- result.Appen
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mgorny closed
https://github.com/llvm/llvm-project/pull/126715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michał Górny
Date: 2025-02-11T14:22:44Z
New Revision: bf2d4eb7030b809004dd1e6d0cc15a94a9e18c88
URL:
https://github.com/llvm/llvm-project/commit/bf2d4eb7030b809004dd1e6d0cc15a94a9e18c88
DIFF:
https://github.com/llvm/llvm-project/commit/bf2d4eb7030b809004dd1e6d0cc15a94a9e18c88.diff
LOG:
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -8,3 +8,4 @@ add_subdirectory(OpenBSD)
add_subdirectory(POSIX)
add_subdirectory(QemuUser)
add_subdirectory(Windows)
+add_subdirectory(AIX)
labath wrote:
Let's keep the list sorted (looks like you get to be first).
https://github.com/llvm/llvm-project/pull/
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DhruvSrivastavaX wrote:
Hi @DavidSpickett @labath , Do let me know if this can be merged now
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/3] Modify the localCache API to require an explicit commit
on
https://github.com/mgorny created
https://github.com/llvm/llvm-project/pull/126715
Use a preprocessor `#ifdef LLVM_BUILD_TELEMETRY` guard rather than
`PARTIAL_SOURCES_INTENDED` for the `Telemetry.cpp` file, to fix building with
telemetry disabled. `PARTIAL_SOURCES_INTENDED` does not currently
mgorny wrote:
Filed #126710 to fix passing `LLVM_BUILD_TELEMETRY` in standalone builds, and
#126715 to fix building with telemetry disabled.
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michał Górny (mgorny)
Changes
Use a preprocessor `#ifdef LLVM_BUILD_TELEMETRY` guard rather than
`PARTIAL_SOURCES_INTENDED` for the `Telemetry.cpp` file, to fix building with
telemetry disabled. `PARTIAL_SOURCES_INTENDED` does not current
mgorny wrote:
`PARTIAL_SOURCES_INTENDED` doesn't work there since it isn't passed to
`llvm_add_library()`, and `llvm_process_sources()` is called again there.
That said, I would personally lean towards putting the whole file around an
`#if` rather than disabling the QA check. In the end,
`PAR
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -52,6 +52,39 @@ class StreamFile : public Stream {
const StreamFile &operator=(const StreamFile &) = delete;
};
+class SynchronizedStreamFile : public StreamFile {
+public:
+ SynchronizedStreamFile(uint32_t flags, uint32_t addr_size,
+ lldb::ByteO
@@ -52,6 +52,39 @@ class StreamFile : public Stream {
const StreamFile &operator=(const StreamFile &) = delete;
};
+class SynchronizedStreamFile : public StreamFile {
+public:
+ SynchronizedStreamFile(uint32_t flags, uint32_t addr_size,
+ lldb::ByteO
@@ -3108,13 +3108,11 @@ void CommandInterpreter::PrintCommandOutput(IOHandler
&io_handler,
llvm::StringRef line;
std::tie(line, str) = str.split('\n');
{
- std::lock_guard guard(io_handler.GetOutputMutex());
labath wrote:
This is an example o
https://github.com/labath commented:
So, the problem I see here is that this is enforcing mutual exclusion at the
level of most basic write operations. That's fine if what you want to achieve
is to protect the internal state of the stream object. However, I'm not sure if
that's your goal, sinc
@@ -46,9 +46,16 @@ StreamFile::StreamFile(const char *path, File::OpenOptions
options,
StreamFile::~StreamFile() = default;
+SynchronizedStreamFile::~SynchronizedStreamFile() = default;
+
void StreamFile::Flush() { m_file_sp->Flush(); }
labath wrote:
I'm p
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/5] Introducing PlatformAIX from PlatformLinux
---
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
73 matches
Mail list logo
