https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kper wrote:
> Only those with [write
> access](https://docs.github.com/articles/what-are-the-different-access-permissions)
> to this repository can merge pull requests.
@JDevlieghere Thank you, I think that one of you needs to merge it. Next to
this message is also a "Update branch" button bu
ashgti wrote:
#125156 should fix this
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Note that this error occurred on Windows host building
`tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp` using
MSVC.
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@li
vvereschaka wrote:
@ashgti ,
these changes break the windows build with the following errors:
```
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\tools\lldb-dap\IOStream.h(41):
error C2061: syntax error: identifier 'SOCKET'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
A previous change is triggering a failure due to SOCKET not being defined in
IOStream.h. Adjusting the Windows includes to correct the imports and using a
more narrow import (winsock2.h vs windows.h).
Also r
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/125156
A previous change is triggering a failure due to SOCKET not being defined in
IOStream.h. Adjusting the Windows includes to correct the imports and using a
more narrow import (winsock2.h vs windows.h).
Also remo
jimingham wrote:
I worry a bit about the fact that in the host case, GetValueAsData is going to
end up calling:
memcpy(dst, reinterpret_cast(address), byte_size);
where address is the host data buffer and byte_size is the size of the new
dynamic type. But in the case where the Value ha
jimingham wrote:
There were a bunch of review comments that need to be addressed. But I also am
a bit nervous about adding a feature that is intended to be a general "lldb
interesting classes lifecycle notification" but when designed only supports
Debugger Lifecycle Events. Those are the sim
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
…uffer
ValueObjectDynamicValue::UpdateValue() assumes that the dynamic type found by
GetDynamicTypeAndAddress() would return an address in the inferior. This
commit makes it so it can deal with being
Author: John Harrison
Date: 2025-01-30T16:35:15-08:00
New Revision: adb9ef035552d7fc42a34560677f89f4f6421295
URL:
https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295
DIFF:
https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295.diff
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/125143
…uffer
ValueObjectDynamicValue::UpdateValue() assumes that the dynamic type found by
GetDynamicTypeAndAddress() would return an address in the inferior. This
commit makes it so it can deal with being pass
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
Is there any update on this PR? I'm interested in working on a similar callback
that can be triggered when target is created, but I want to wait for this one
to get landed first as they will share some common code.
https://github.com/llvm/llvm-project/pull/111206
__
@@ -411,6 +412,30 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
dap.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
+static std::string GetStringFromStructuredData(lldb::SBStructuredData &data,
+
@@ -411,6 +412,30 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
dap.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
+static std::string GetStringFromStructuredData(lldb::SBStructuredData &data,
Jlalond wrote:
@JDevlieghe
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 55e22921d0b1b5088540ffa29a6e67a7816949cf Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/3] Only include title on the first message
---
lldb/include/l
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125132
None
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandRetu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
I just noticed with these changes lldb-dap was using 200% of my CPU and root
causing the issue it seems that lldb_private::Pipe::Read() (without a timeout)
is using a timeout of `std::chrono::microseconds::ze
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/125136
I just noticed with these changes lldb-dap was using 200% of my CPU and root
causing the issue it seems that lldb_private::Pipe::Read() (without a timeout)
is using a timeout of `std::chrono::microseconds::zero(
JDevlieghere wrote:
@kper Please let us know if you need one of us to press the merge button for
you.
https://github.com/llvm/llvm-project/pull/124758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
cmtice wrote:
I think I have addressed/fixed all the latest review comments. Please take
another look now.
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/123521
>From 468f73f8539dcb8addf8ed9618d9eb797dabbb01 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 19 Jan 2025 09:15:34 -0800
Subject: [PATCH 1/4] [LLDB] Add Lexer (with tests) for DIL (Data Inspection
Langu
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/3] [lldb] Use llvm::Error instead of CommandReturnObje
Author: Augusto Noronha
Date: 2025-01-30T14:29:16-08:00
New Revision: 6a05beeb2bed366f7e6e0056a758c6f8d385fdde
URL:
https://github.com/llvm/llvm-project/commit/6a05beeb2bed366f7e6e0056a758c6f8d385fdde
DIFF:
https://github.com/llvm/llvm-project/commit/6a05beeb2bed366f7e6e0056a758c6f8d385fdde.dif
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/2] [lldb] Use llvm::Error instead of CommandReturnObje
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 26c2da5a122532035b8bf63af89208d6d799e40e
24ddc550e3ee61b863cbaea05ff49981bc20f7ad --e
Author: Jonas Devlieghere
Date: 2025-01-30T14:21:37-08:00
New Revision: 26c2da5a122532035b8bf63af89208d6d799e40e
URL:
https://github.com/llvm/llvm-project/commit/26c2da5a122532035b8bf63af89208d6d799e40e
DIFF:
https://github.com/llvm/llvm-project/commit/26c2da5a122532035b8bf63af89208d6d799e40e.d
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bda19768de03a0322c4094c8d0e00ad033268309
87eca7770ba2a747db1843a8abfdceaa2f4debf8 --e
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -590,13 +550,50 @@ void Options::GenerateOptionUsage(Stream &strm,
CommandObject &cmd,
strm.SetIndentLevel(save_indent_level);
}
+llvm::Error Options::VerifyOptions() {
+ bool options_are_valid = false;
+
+ int num_levels = GetRequiredOptions().size();
+ if (num_level
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH] [lldb] Use llvm::Error instead of CommandReturnObject f
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH 1/3] [NFC][lldb] Document a few ivars on the value object
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH 1/2] [NFC][lldb] Document a few ivars on the value object
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Use `llvm::Error` instead of `CommandReturnObject` for error reporting. The
command return objects were populated with errors but never displayed. With
this patch they're at least logged.
---
Full
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125125
Use `llvm::Error` instead of `CommandReturnObject` for error reporting. The
command return objects were populated with errors but never displayed. With
this patch they're at least logged.
>From 218db812d5
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 62f6d637c015a6fcf6e493e25e91f5d833da999f
a0ba821cf6f0a20e3cdc8de196b27fb85e0399d1 --e
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105594
>From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 19 Jul 2024 17:26:13 -0700
Subject: [PATCH 1/9] [lldb] Change lldb's breakpoint handling behavior
(#96
Author: Jonas Devlieghere
Date: 2025-01-30T13:36:25-08:00
New Revision: c1e9b908d9c205970f025c188c6fbe6fb93be98d
URL:
https://github.com/llvm/llvm-project/commit/c1e9b908d9c205970f025c188c6fbe6fb93be98d
DIFF:
https://github.com/llvm/llvm-project/commit/c1e9b908d9c205970f025c188c6fbe6fb93be98d.d
github-actions[bot] wrote:
@matthewbastien Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Matthew Bastien
Date: 2025-01-30T12:18:55-08:00
New Revision: 0d46657cb6bf04430ff8222e1974e49441767d47
URL:
https://github.com/llvm/llvm-project/commit/0d46657cb6bf04430ff8222e1974e49441767d47
DIFF:
https://github.com/llvm/llvm-project/commit/0d46657cb6bf04430ff8222e1974e49441767d47.dif
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From f946fd70bb550320bb153a59b8acd702dc97e75d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH 1/3] [lldb-dap] Refactoring lldb-dap port listening mode to
allow
JDevlieghere wrote:
Landed the NFC changes and rebase the PR.
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From d9c0b0e1e6c18b6710c5b15843e23a96ca0a9dc8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 17:08:52 -0800
Subject: [PATCH 1/3] [lldb] Support CommandInterpreter print callbacks
Author: Jonas Devlieghere
Date: 2025-01-30T10:37:23-08:00
New Revision: 74690327c8fb3b1bc8722b8ae40091b268100468
URL:
https://github.com/llvm/llvm-project/commit/74690327c8fb3b1bc8722b8ae40091b268100468
DIFF:
https://github.com/llvm/llvm-project/commit/74690327c8fb3b1bc8722b8ae40091b268100468.d
@@ -1167,21 +1168,61 @@ def __init__(
if log_file:
adaptor_env["LLDBDAP_LOG"] = log_file
+args = [executable]
+
+if connection is not None:
+args.append("--connection")
+args.append(connection)
@@ -4952,6 +4930,28 @@ static int DuplicateFileDescriptor(int fd) {
#endif
}
+static llvm::Expected>
+parseConnection(llvm::StringRef conn) {
+ if (conn.contains("://")) {
ashgti wrote:
Updated this to validate the connection and used the URI Parser to parse
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) {
auto terminate_debugger =
llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); });
- StreamDescriptor input;
- StreamDescriptor output;
- std::FILE *redirectOut = nullptr;
- std::FILE *redirectErr = n
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From f946fd70bb550320bb153a59b8acd702dc97e75d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH 1/2] [lldb-dap] Refactoring lldb-dap port listening mode to
allow
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/jimingham approved this pull request.
LGTM. You might add a comment to GetAddressRange saying "I'm in the process of
getting rid of this, don't use it in the meantime...". But presumably you are
also watching PR's to make sure nobody reintroduces its use.
https://github.co
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
I do th
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -148,6 +150,32 @@ class Value {
static ValueType GetValueTypeFromAddressType(AddressType address_type);
protected:
+ /// Represents a value, which can be a scalar, a load address, a file
address,
+ /// or a host address.
+ ///
+ /// The interpretation of `m_value` de
@@ -148,6 +150,32 @@ class Value {
static ValueType GetValueTypeFromAddressType(AddressType address_type);
protected:
+ /// Represents a value, which can be a scalar, a load address, a file
address,
+ /// or a host address.
+ ///
+ /// The interpretation of `m_value` de
https://github.com/JDevlieghere approved this pull request.
LGMT with some formatting nits.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
Re-requesting review as I added more comments.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH] [NFC][lldb] Document a few ivars on the value object syste
Author: Jonas Devlieghere
Date: 2025-01-30T09:53:57-08:00
New Revision: a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9
URL:
https://github.com/llvm/llvm-project/commit/a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9
DIFF:
https://github.com/llvm/llvm-project/commit/a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9.d
JDevlieghere wrote:
Alright, I have two follow-ups/action items:
- Check if we can improve the breakpoint callback with a lambda.
- Add the command string to `CommandReturnObject`.
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits ma
https://github.com/JDevlieghere approved this pull request.
Nice cleanup. Thank you!
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
jimingham wrote:
> > If this result printing callback was also passed the command string (which
> > it has from just above where the callback is called) then this would also
> > be an easy way to do logging of command execution. That's not needed for
> > your current purpose, but would add ano
rocallahan wrote:
And thanks!
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
It sounds fine. rr HEAD uses the Gdb flavour for GDB and the old-LLDB flavor
for LLDB. After a decent amount of time has passed I will update to the new
regime.
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits maili
@@ -743,3 +743,41 @@ void SBCommand::SetFlags(uint32_t flags) {
if (IsValid())
m_opaque_sp->GetFlags().Set(flags);
}
+
+namespace lldb_private {
+struct CommandCallbackData {
+ SBCommandPrintCallback callback;
+ void *callback_baton;
+};
+
+class CommandPrintCallbackBat
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From fdac9c0292cef848b880904cf84b2c0083065005 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 15:43:31 -0800
Subject: [PATCH 1/5] [lldb] Fix CommandInterpreter formatting (NFC)
---
DavidSpickett wrote:
Arm and AArch64 Linux were fine (aside from a flaky test on the latter).
Windows on Arm is complaining, I'm investigating.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Reverts llvm/llvm-project#123945
Has failed on the Windows on Arm buildbot:
https://lab.llvm.org/buildbot/#/builders/141/builds/5865
```
Unresolved Tests (2):
lldb-api ::
funct
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125091
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-30T16:45:36Z
New Revision: a774de807e56c1147d4630bfec3110c11d41776e
URL:
https://github.com/llvm/llvm-project/commit/a774de807e56c1147d4630bfec3110c11d41776e
DIFF:
https://github.com/llvm/llvm-project/commit/a774de807e56c1147d4630bfec3110c11d41776e.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/125091
Reverts llvm/llvm-project#123945
Has failed on the Windows on Arm buildbot:
https://lab.llvm.org/buildbot/#/builders/141/builds/5865
```
Unresolved Tests (2):
lldb-api ::
functiona
DavidSpickett wrote:
The easy one to fix is:
```
Traceback (most recent call last):
File
"C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueNotSupported.py",
line 25, in test_reverse_continue_not_supported
self
JDevlieghere wrote:
> It's not clear from the patch description whether you actually need the
> ability to suppress the command output, or if you just want the ability to
> "access" the diagnostics. Because, if its the latter, then perhaps an (async)
> event would be a slightly more lightweigh
tmatheson-arm wrote:
I've just noticed 2/3 of these are redundant now since the existing neon
functions have been removed. I'll remove them.
https://github.com/llvm/llvm-project/pull/125063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
Author: Michael Buch
Date: 2025-01-30T15:09:53Z
New Revision: 38cb69373eef033c219efc7aaa11b84d9b307e69
URL:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69
DIFF:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69.diff
LOG:
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 01/10] [lldb] Analyze enum promotion type during parsing
---
clang/
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/125063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Tomas Matheson (tmatheson-arm)
Changes
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
---
Patch is 47.44 KiB, truncated to 20.0
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tomas Matheson (tmatheson-arm)
Changes
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
---
Patch is 47.44 KiB, truncated to 20.00 KiB bel
https://github.com/tmatheson-arm created
https://github.com/llvm/llvm-project/pull/125063
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
>From 63159e8e82b56850213fb0e2479bd708f008ea81 Mon Sep
labath wrote:
GDB has already implemented this, and it looks like they'll do a new release
this weekend: https://sourceware.org/pipermail/gdb/2025-January/051731.html
Robert, any last words before I merge this? :)
https://github.com/llvm/llvm-project/pull/124733
___
puremourning wrote:
Hmm seems the behaviour on intel differs to arm. will need to think about it.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks for handling this.
Maybe the final say goes to @rocallahan since `rr` is the origin of the issue?
We have to wait on GDB for a bit anyway I expect.
https://github.com/llvm/llvm-project/pull/124733
___
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
Author: David Spickett
Date: 2025-01-30T14:03:01Z
New Revision: 0caba6c8dc2f6f0da61f30c169f59d40591cddbc
URL:
https://github.com/llvm/llvm-project/commit/0caba6c8dc2f6f0da61f30c169f59d40591cddbc
DIFF:
https://github.com/llvm/llvm-project/commit/0caba6c8dc2f6f0da61f30c169f59d40591cddbc.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
My inbox is ready :)
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Also thanks for tackling this, I know I said once (possibly twice) that I'd do
it but kept getting distracted. I know you put a bunch of research time into
this too.
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commi
https://github.com/DavidSpickett approved this pull request.
We're hitting limitations in Windows itself, and 1 watchpoint is more useful
than zero, so this LGTM.
To preempt a potential discussion: I think this should not be backported to 20.
Unless you've got a very good reason for it. We don
1 - 100 of 140 matches
Mail list logo
