[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1181921 - [lldb] Remove (unused) SymbolContext::Dump (#123211)

2025-01-16 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-17T08:44:13+01:00 New Revision: 118192148273bfe1faf02403a301baeebda59d19 URL: https://github.com/llvm/llvm-project/commit/118192148273bfe1faf02403a301baeebda59d19 DIFF: https://github.com/llvm/llvm-project/commit/118192148273bfe1faf02403a301baeebda59d19.diff

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang,lldb` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/6887 Here is the relevant piece of the build l

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,lldb` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11867 Here is

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/123152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 263fed7 - [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (#123152)

2025-01-16 Thread via lldb-commits
Author: Chuanqi Xu Date: 2025-01-17T12:46:00+08:00 New Revision: 263fed7ce9d2c155af44829018673caa67fa4f47 URL: https://github.com/llvm/llvm-project/commit/263fed7ce9d2c155af44829018673caa67fa4f47 DIFF: https://github.com/llvm/llvm-project/commit/263fed7ce9d2c155af44829018673caa67fa4f47.diff LO

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-16 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Pavel tested a recent version of this PR on Mac and it worked. I've rebased this on top of the refactoring work in PR #120817. CI looks green. I think this is ready to finish reviewing. https://github.com/llvm/llvm-project/pull/112079 _

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/123152 >From ea3eb4454319ce703bf689dac000f0ed382c2ee5 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 16 Jan 2025 11:30:30 +0800 Subject: [PATCH] [AST] Add OriginalDC argument to ExternalASTSource::FindExterna

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: > Compile-time looks fine on this one: > https://llvm-compile-time-tracker.com/compare.php?from=8fb29ba287d72392bd7900c33d2a8d2149126dbe&to=fd734a392a094a573ee7fe587b9fc5f616f92a9a&stat=instructions:u Thanks. I'll land this after CI gets green. https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-16 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Thanks!! https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-16 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From daf6c946e52c7c5c778ab6a397c2de95bee56eb8 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/3] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/2] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes `GetAttributes` returns all attributes on a given DIE, including any attributes that the DIE references via `DW_AT_abstract_origin` and `DW_AT_specification`. However, if an attribute exists on both the re

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/123261 `GetAttributes` returns all attributes on a given DIE, including any attributes that the DIE references via `DW_AT_abstract_origin` and `DW_AT_specification`. However, if an attribute exists on both the refe

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,296 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,102 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,106 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Improve user expression diagnostics (PR #123242)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/123242 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8ac0aaa - [lldb] Improve user expression diagnostics (#123242)

2025-01-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-16T16:09:20-08:00 New Revision: 8ac0aaae38d3dc863c5c5b331c8ec3238e27 URL: https://github.com/llvm/llvm-project/commit/8ac0aaae38d3dc863c5c5b331c8ec3238e27 DIFF: https://github.com/llvm/llvm-project/commit/8ac0aaae38d3dc863c5c5b331c8ec3238e27.d

[Lldb-commits] [lldb] cb82771 - [lldb] Add OS plugin property for reporting all threads (#123145)

2025-01-16 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-01-16T15:05:46-08:00 New Revision: cb82771c96d7055d89ca67f383e6fb3c9aced178 URL: https://github.com/llvm/llvm-project/commit/cb82771c96d7055d89ca67f383e6fb3c9aced178 DIFF: https://github.com/llvm/llvm-project/commit/cb82771c96d7055d89ca67f383e6fb3c9

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/123145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-16 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/123145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -34,6 +34,9 @@ def __init__(self, process): if not self.g_value.IsValid(): print("Could not find g_value") +def does_plugin_report_all_threads(self): +return False felipepiovezan wrote: FYI I have changed this to Tru

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/123145 >From ac1711204064c4740d5f1386bc6132d4d968dda3 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Tue, 14 Jan 2025 09:27:29 -0800 Subject: [PATCH 1/2] [lldb] Add OS plugin property for report

[Lldb-commits] [lldb] 96ef428 - [lldb] Avoid calling raw_string_ostream::str() in LLDBAssert.cpp (NFC)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-16T13:48:23-08:00 New Revision: 96ef428953ed0f2a6c973709005fd17fd18318a1 URL: https://github.com/llvm/llvm-project/commit/96ef428953ed0f2a6c973709005fd17fd18318a1 DIFF: https://github.com/llvm/llvm-project/commit/96ef428953ed0f2a6c973709005fd17fd18318a1.d

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7ea5f19 - [lldb] Rename lldb_assert -> _lldb_assert (NFC) (#123225)

2025-01-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-16T13:31:35-08:00 New Revision: 7ea5f195039ba357285076043ad381ed22e3842e URL: https://github.com/llvm/llvm-project/commit/7ea5f195039ba357285076043ad381ed22e3842e DIFF: https://github.com/llvm/llvm-project/commit/7ea5f195039ba357285076043ad381ed22e3842e.d

[Lldb-commits] [lldb] [lldb][test] Fix some 'import-std-module' tests (PR #122358)

2025-01-16 Thread via lldb-commits
Prabhuk wrote: Verified that the failure in our bots were due to our LLDB recipe and not this patch. Thank you @labath for helping to isolate the problem on our end. https://github.com/llvm/llvm-project/pull/122358 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb] Improve user expression diagnostics (PR #123242)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/123242 >From db80b44d603bd00127d8de52fa32577ec352dc22 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 Jan 2025 12:57:15 -0800 Subject: [PATCH 1/2] [lldb] Improve user expression diagnostics This pa

[Lldb-commits] [lldb] [lldb] Improve user expression diagnostics (PR #123242)

2025-01-16 Thread via lldb-commits
https://github.com/jimingham approved this pull request. That's clearer... https://github.com/llvm/llvm-project/pull/123242 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-16 Thread Jacob Lalonde via lldb-commits
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec, progress_up = std::make_unique( "Reading binary from memory", file_spec.GetFilename().GetString()); +if (size_to_read == 0) { + // No size was provided, figure ou

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-16 Thread Jacob Lalonde via lldb-commits
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec, progress_up = std::make_unique( "Reading binary from memory", file_spec.GetFilename().GetString()); +if (size_to_read == 0) { + // No size was provided, figure ou

[Lldb-commits] [lldb] [lldb] Improve user expression diagnostics (PR #123242)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch rewords some of the user expression diagnostics. - Differentiate between being interrupted and hitting a breakpoint. - Use "expression execution" to make it more obvious that the diagnos

[Lldb-commits] [lldb] [lldb] Improve user expression diagnostics (PR #123242)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/123242 This patch rewords some of the user expression diagnostics. - Differentiate between being interrupted and hitting a breakpoint. - Use "expression execution" to make it more obvious that the diagnostic is

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-16 Thread Jacob Lalonde via lldb-commits
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec, progress_up = std::make_unique( "Reading binary from memory", file_spec.GetFilename().GetString()); +if (size_to_read == 0) { + // No size was provided, figure ou

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/123132 >From dbe633443f608f292c1f7f775d1b96b7eb808965 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 14 Jan 2025 14:23:05 -0800 Subject: [PATCH 1/2] Add draft docstrings for SBSaveCoreOptions --- .../interfa

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-16 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,72 @@ +%feature("docstring", +"A container for options to use when saving a core file. + +SBSaveCoreOptions includes API's to specify the memory regions and threads to include +when generating a core file. These options are not exclusive the existing SaveCoreStyle opt

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-16 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: I can still make an RFC if that is desired, but I believed we reached a compromise with the new broadcast bit. I think we should frame the SBProgress very differently to @labath's recent improvements to Progress itself. I think the critical feature is the disposal of SBProgress

[Lldb-commits] [lldb] 06edefa - [LLDB] Make the thread list for SBSaveCoreOptions iterable (#122541)

2025-01-16 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-01-16T11:49:02-08:00 New Revision: 06edefac10f4481bdd458c0362d9a305f6a1ce6a URL: https://github.com/llvm/llvm-project/commit/06edefac10f4481bdd458c0362d9a305f6a1ce6a DIFF: https://github.com/llvm/llvm-project/commit/06edefac10f4481bdd458c0362d9a305f6a1ce6a.diff

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/122541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Sorry, I didn't get the ping (I think because this is marked as a draft). I'm not familiar enough with Windows to review this, so I'm adding some folks that are or work on related stuff in `lldb-dap`. https://github.com/llvm/llvm-project/pull/121269

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. Maybe you can also add a doxygen comment explaining that it shouldn't be used directly and use the lldbassert macro instead? https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/123225 >From 8db51a67cd5447d51755a7a411b4d5e4857a86fa Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 Jan 2025 10:27:10 -0800 Subject: [PATCH 1/2] [lldb] Rename lldb_assert -> _lldb_assert (NFC) Re

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/119052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. I'm happy with this, as it addresses my concerns. @labath, you had some similar, and some different concerns (i.e. the RAII benefit of the C++ implementation). Should we have an RFC for this to flesh that out or how do you feel about

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/122541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/123225 >From 8db51a67cd5447d51755a7a411b4d5e4857a86fa Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 Jan 2025 10:27:10 -0800 Subject: [PATCH] [lldb] Rename lldb_assert -> _lldb_assert (NFC) Rename

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6b3ba6677d64e394b9c929ea0d1f7c54e3146fda e4013bfe60902505d4631c59dba5205344caaf6c --e

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Rename `lldb_assert` to `_lldb_assert` to make it more obvious that you shouldn't be using this function directly. Instead, you should use the `lldbassert` macro which becomes a regular assert in a

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: FWIW this in response to seeing `lldb_assert` being used directly in the Swift fork. https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/123225 Rename `lldb_assert` to `_lldb_assert` to make it more obvious that you shouldn't be using this function directly. Instead, you should use the `lldbassert` macro which becomes a regular assert in a debug/a

[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread via lldb-commits
jimingham wrote: Originally the idea was that `GetDescription` was for showing to users and `Dump` was like the llvm `dump`, it was meant to show all the gory details and you weren't supposed to call it in code so much as by hand when debugging. So that it is unused doesn't really mean it isn

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -3183,10 +3183,24 @@ Expr *Expr::IgnoreUnlessSpelledInSource() { } return E; }; + + auto IgnoreImplicitCallSingleStep = [](Expr *E) { +if (auto *C = dyn_cast(E)) { + auto NumArgs = C->getNumArgs(); + if (NumArgs == 1 || + (NumArgs > 1 && isa

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-16 Thread via lldb-commits
@@ -859,7 +859,9 @@ SBError SBThread::StepOverUntil(lldb::SBFrame &sb_frame, addr_t step_addr = sc.line_entry.range.GetBaseAddress().GetLoadAddress(target); if (step_addr != LLDB_INVALID_ADDRESS) { -if (fun_range.ContainsLoadAddress(step_addr, targ

[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/123211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/123107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8965dd4 - [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (#123107)

2025-01-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-16T09:33:59-08:00 New Revision: 8965dd40c63cf00610fcf550017b46dae736d94b URL: https://github.com/llvm/llvm-project/commit/8965dd40c63cf00610fcf550017b46dae736d94b DIFF: https://github.com/llvm/llvm-project/commit/8965dd40c63cf00610fcf550017b46dae736d94b.d

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via lldb-commits
@@ -3183,10 +3183,24 @@ Expr *Expr::IgnoreUnlessSpelledInSource() { } return E; }; + + auto IgnoreImplicitCallSingleStep = [](Expr *E) { +if (auto *C = dyn_cast(E)) { + auto NumArgs = C->getNumArgs(); + if (NumArgs == 1 || + (NumArgs > 1 && isa

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via lldb-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via lldb-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo comment request. Thanks https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123217 .. by changing the signal stop reason format :facepalm: The reason this did not work is because the code in `StopInfo::GetCrashingDereference` was looking for the string "address=" to extract the address of the

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes .. by changing the signal stop reason format :facepalm: The reason this did not work is because the code in `StopInfo::GetCrashingDereference` was looking for the string "address=" to extract the address of t

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-16 Thread Hu Jialun via lldb-commits
SuibianP wrote: Hi @JDevlieghere, sorry for pinging again but could you please kindly help take a look at this when you have time? Thanks in advance! https://github.com/llvm/llvm-project/pull/121269 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes We still have GetDescription and DumpStopContext which serve a similar purpose. (The main reason this is bothering me is because I'm working through the uses of (deprecated) Function::GetAddressRange.) --- Fu

[Lldb-commits] [lldb] [lldb] Remove (unused) SymbolContext::Dump (PR #123211)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123211 We still have GetDescription and DumpStopContext which serve a similar purpose. (The main reason this is bothering me is because I'm working through the uses of (deprecated) Function::GetAddressRange.) >From 5c

[Lldb-commits] [lldb] [lldb] Remove some unused code in SymbolFileDWARF::ResolveFunction (PR #123206)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The purpose of this originally was to check for DWARF which refers to garbage-collected functions (by checking whether we're able to get a good address out of the function). The address check has been removed

[Lldb-commits] [lldb] [lldb] Remove some unused code in SymbolFileDWARF::ResolveFunction (PR #123206)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123206 The purpose of this originally was to check for DWARF which refers to garbage-collected functions (by checking whether we're able to get a good address out of the function). The address check has been removed in

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Nikita Popov via lldb-commits
nikic wrote: Thanks for the context! "I'm landing this without approval because I'm the maintainer for this component" is a lot less scary than "I'm landing this without approval because there's no time to wait on a review". https://github.com/llvm/llvm-project/pull/122887

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: > > Looks like this change has some compile-time impact even if modules are not > > used: > > https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u > > It seems to add ab

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: > Looks like this change has some compile-time impact even if modules are not > used: > https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u > It seems to add about 0.

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Nikita Popov via lldb-commits
nikic wrote: Compile-time looks fine on this one: https://llvm-compile-time-tracker.com/compare.php?from=8fb29ba287d72392bd7900c33d2a8d2149126dbe&to=fd734a392a094a573ee7fe587b9fc5f616f92a9a&stat=instructions:u https://github.com/llvm/llvm-project/pull/123152

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [DO NOT SUBMIT] querying precommit CI... (PR #123178)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Pavel Labath via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123046 >From 74d436310319d17cb43ba598836b70a92c827111 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 15 Jan 2025 12:41:23 +0100 Subject: [PATCH 1/6] [lldb] Fix SBThread::StepOverUntil for discontinuous function

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123046 >From 74d436310319d17cb43ba598836b70a92c827111 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 15 Jan 2025 12:41:23 +0100 Subject: [PATCH 1/5] [lldb] Fix SBThread::StepOverUntil for discontinuous function

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123046 >From 74d436310319d17cb43ba598836b70a92c827111 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 15 Jan 2025 12:41:23 +0100 Subject: [PATCH 1/4] [lldb] Fix SBThread::StepOverUntil for discontinuous function

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Pavel Labath via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-16 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Sanitizer build has been fixed but I know this will also break the Fuchsia > build bots if we reland it (see [#115379 > (comment)](https://github.com/llvm/llvm-project/pull/115379#issuecomment-2469268557)) > - not sure if there is any plan to update those builders to use inst

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [DO NOT SUBMIT] querying precommit CI... (PR #123178)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123178 None >From da349663bf90a53e50ad6d22a088e19edfb9ee83 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 16 Jan 2025 11:08:00 +0100 Subject: [PATCH] [DO NOT SUBMIT] querying precommit CI... --- lldb/test/She

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7e00e3a - [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (#123054)

2025-01-16 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-16T10:49:51+01:00 New Revision: 7e00e3ae6dd4ba215dad27d1729df533cbb37795 URL: https://github.com/llvm/llvm-project/commit/7e00e3ae6dd4ba215dad27d1729df533cbb37795 DIFF: https://github.com/llvm/llvm-project/commit/7e00e3ae6dd4ba215dad27d1729df533cbb37795.diff

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-16 Thread Pavel Labath via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-16 Thread Pavel Labath via lldb-commits
@@ -859,7 +859,9 @@ SBError SBThread::StepOverUntil(lldb::SBFrame &sb_frame, addr_t step_addr = sc.line_entry.range.GetBaseAddress().GetLoadAddress(target); if (step_addr != LLDB_INVALID_ADDRESS) { -if (fun_range.ContainsLoadAddress(step_addr, targ

  1   2   >