[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-13 Thread via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan edited https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
@@ -582,31 +531,92 @@ bool ThreadList::WillResume() { // There are two special kinds of thread that have priority for "StopOthers": // a "ShouldRunBeforePublicStop thread, or the currently selected thread. If // we find one satisfying that critereon, put it here. - Thre

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan edited https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
@@ -582,31 +531,92 @@ bool ThreadList::WillResume() { // There are two special kinds of thread that have priority for "StopOthers": // a "ShouldRunBeforePublicStop thread, or the currently selected thread. If // we find one satisfying that critereon, put it here. - Thre

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
@@ -582,31 +531,92 @@ bool ThreadList::WillResume() { // There are two special kinds of thread that have priority for "StopOthers": // a "ShouldRunBeforePublicStop thread, or the currently selected thread. If // we find one satisfying that critereon, put it here. - Thre

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
@@ -582,31 +531,92 @@ bool ThreadList::WillResume() { // There are two special kinds of thread that have priority for "StopOthers": // a "ShouldRunBeforePublicStop thread, or the currently selected thread. If // we find one satisfying that critereon, put it here. - Thre

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-13 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/120817 >From a3968690f394f15083839ea91e9908d6d7d1e886 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Tue, 17 Dec 2024 23:40:34 + Subject: [PATCH 1/8] [lldb] Move thread-notification setup to happen later

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-13 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/122817 >From b42dc01256c8a433629d3594d54e942417705f83 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 18 Dec 2024 14:47:08 -0800 Subject: [PATCH 1/2] [lldb] Remove unfiltered stop reason pro

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > > clang-format on the test is actually problematic for the breakpoint regex, > > so I am just going to ignore it. > > you can do `// clang-format off` / `// clang-format on` around it, if you > want to bother. (you could also just set the regex breakpoint on the string y

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > clang-format on the test is actually problematic for the breakpoint regex, so > I am just going to ignore it. you can do `// clang-format off` / `// clang-format on` around it, if you want to bother. https://github.com/llvm/llvm-project/pull/122817 _

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-13 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: clang-format on the test is actually problematic for the breakpoint regex, so I am just going to ignore it. https://github.com/llvm/llvm-project/pull/122817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [llvm] Debuginfod cache use index cache settings and include real file name (PR #120814)

2025-01-13 Thread via lldb-commits
GeorgeHuyubo wrote: PR to revert the problematic commit: https://github.com/llvm/llvm-project/pull/122816 https://github.com/llvm/llvm-project/pull/120814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [llvm] Revert "[lldb] Switch debuginfod cache to use lldb index cache settings" (PR #122816)

2025-01-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: None (GeorgeHuyubo) Changes This reverts commit 7b808e73aa0193c8a42eae8f2420a803f424bee1. Previous commit which change default debuginfod cache path and pruning policy settings is problematic. It broke multiple tests across lldb and l

[Lldb-commits] [lldb] [llvm] Revert "[lldb] Switch debuginfod cache to use lldb index cache settings" (PR #122816)

2025-01-13 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/122816 This reverts commit 7b808e73aa0193c8a42eae8f2420a803f424bee1. Previous commit which change default debuginfod cache path and pruning policy settings is problematic. It broke multiple tests across lldb and

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2025-01-13 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @DavidSpickett > Or you can tell me a 1/2 sentence summary of it and I'll meld it into release > notes style lldb-server now listens to a single port for gdbserver connections and provides it to the connection handler processes. This allows only 2 ports to be opened in the fi

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This moves the ownership of the threads that forward stdout/stderr to the DAP object itself to ensure that the threads are joined and that the forwarding is cleaned up when the DAP connection is disconnected.

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-13 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/122783 This moves the ownership of the threads that forward stdout/stderr to the DAP object itself to ensure that the threads are joined and that the forwarding is cleaned up when the DAP connection is disconnected. T

[Lldb-commits] [lldb] [lldb] Add amd64 ArchSpec (PR #122533)

2025-01-13 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/122533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] de252e7 - [lldb] Add amd64 ArchSpec (#122533)

2025-01-13 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-13T14:37:06-05:00 New Revision: de252ec1c6b45626a58aa34ea99dee58cc40 URL: https://github.com/llvm/llvm-project/commit/de252ec1c6b45626a58aa34ea99dee58cc40 DIFF: https://github.com/llvm/llvm-project/commit/de252ec1c6b45626a58aa34ea99dee58cc40.diff LO

[Lldb-commits] [lldb] [lldb] Add amd64 ArchSpec (PR #122533)

2025-01-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/122533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reduce duplication in two of DWARFDIE context functions (PR #122712)

2025-01-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/122712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-13 Thread Jacob Lalonde via lldb-commits
@@ -79,3 +81,26 @@ def test_adding_thread_different_process(self): self.assertTrue(error.Fail()) error = options.AddThread(thread) self.assertTrue(error.Success()) + +def test_removing_and_adding_insertion_order(self): +"""Test insertion orde

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From e82cc29033102dfed2a145e7235be8743c3bbdbe Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 Jan 2025 18:13:16 -0800 Subject: [PATCH 1/4] Add OptionValueFormatEntityList --- lldb/include/l

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-13 Thread Louis Dionne via lldb-commits
ldionne wrote: Apologies for the spam everyone, I rebased this onto `main` and didn't realize the merge base was set to something else, causing this. https://github.com/llvm/llvm-project/pull/115380 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-13 Thread Louis Dionne via lldb-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/115380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From e82cc29033102dfed2a145e7235be8743c3bbdbe Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 Jan 2025 18:13:16 -0800 Subject: [PATCH 1/2] Add OptionValueFormatEntityList --- lldb/include/l

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-13 Thread Alex Langford via lldb-commits
@@ -79,3 +81,26 @@ def test_adding_thread_different_process(self): self.assertTrue(error.Fail()) error = options.AddThread(thread) self.assertTrue(error.Success()) + +def test_removing_and_adding_insertion_order(self): +"""Test insertion orde

[Lldb-commits] [lldb] [llvm] Debuginfod cache use index cache settings and include real file name (PR #120814)

2025-01-13 Thread via lldb-commits
Prabhuk wrote: @GeorgeHuyubo I am part of the Fuchsia toolchain team and we are seeing the same `tools/llvm-debuginfod-find/cache.test` test failure in our toolchain builders as well. Logs: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8726076614943013857/+/u/clang/tests/st

[Lldb-commits] [lldb] The _code field in an NSError is signed, not unsigned. (PR #119764)

2025-01-13 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/119764 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7c165f7 - The _code field in an NSError is signed, not unsigned. (#119764)

2025-01-13 Thread via lldb-commits
Author: jimingham Date: 2025-01-13T10:08:50-08:00 New Revision: 7c165f7fccfd40ae3bc2823d0ccd50257c21ab3e URL: https://github.com/llvm/llvm-project/commit/7c165f7fccfd40ae3bc2823d0ccd50257c21ab3e DIFF: https://github.com/llvm/llvm-project/commit/7c165f7fccfd40ae3bc2823d0ccd50257c21ab3e.diff LOG

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From e82cc29033102dfed2a145e7235be8743c3bbdbe Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 Jan 2025 18:13:16 -0800 Subject: [PATCH 1/2] Add OptionValueFormatEntityList --- lldb/include/l

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: >From the Discourse thread: > I also went through all the commits since the llvmorg-20-init tag until > today, and noted anything I thought might warrant a release note. If there was unfinished work in 19 that is now finished by later PRs that's fair to include too. > I a

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2025-01-13 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Hey @DavidSpickett, sure I'm drafting that up now. What time frame should we include commits from? I ask because one of my original patches added [64b support, and paging](https://github.com/llvm/llvm-project/pull/95312). I assume we could include anyway as I don't see it in the

[Lldb-commits] [lldb] [llvm] Debuginfod cache use index cache settings and include real file name (PR #120814)

2025-01-13 Thread via lldb-commits
GeorgeHuyubo wrote: Working on fixing the tests broke by this diff. https://github.com/llvm/llvm-project/pull/120814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2025-01-13 Thread Louis Dionne via lldb-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/105990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2025-01-13 Thread Louis Dionne via lldb-commits
ldionne wrote: Closing as stale, please feel free to reopen if you want to pursue this. https://github.com/llvm/llvm-project/pull/105990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-13 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere friendly bump, I just wanna sneak this into our release this week, I think all the comments are addressed! https://github.com/llvm/llvm-project/pull/119052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/122541 >From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 10 Jan 2025 14:26:10 -0800 Subject: [PATCH 1/6] Make the thread list for SBSaveCoreOptions iterable --- ll

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
Michael137 wrote: Added tests and updated PR description. https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/7] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7e01a322f850e86be9eefde8ae5a30e532d22cfa 66250572fc6a76ea7470028ad3529af8b8aef0b4 --e

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/6] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hi @slydiman, I am looking at commits that warrant a release note for LLDB 20, and I think your work on lldb-server's port map might fit the bill. If you want to do that yourself you can send a PR adding a bullet point to https://github.com/llvm/llvm-project/blob/main/llvm

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hi @Jlalond I am looking at commits that warrant a release note for LLDB 20, and I think this and the rest of your Minidump changes might qualify. If you want to do that yourself you can send a PR adding a bullet point to https://github.com/llvm/llvm-project/blob/main/llv

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hi @dlav-sc I am looking at commits that warrant a release note for LLDB 20, and I think this is one of them. If you want to do that yourself you can send a PR adding a bullet point to https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lld

[Lldb-commits] [lldb] [lldb][RISCV] Support optionally disabled FPR for riscv64 (PR #104547)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hi @AlexeyMerzlyakov I am looking at commits that warrant a release note for LLDB 20, and I think this is one of them. If you want to do that yourself you can send a PR adding a bullet point to https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#change

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/5] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [lldb] [llvm] Debuginfod cache use index cache settings and include real file name (PR #120814)

2025-01-13 Thread Pavel Labath via lldb-commits
labath wrote: Same here, and the lldb debuginfod test is failing as well: ``` == FAIL: test_debuginfod_executable (TestDebuginfod.DebugInfodTests.test_debuginfod_executable) Test behavior with the full binary available from D

[Lldb-commits] [lldb] [lldb] Reduce duplication in two of DWARFDIE context functions (PR #122712)

2025-01-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This doesn't make much of a difference now, but it makes it easier to add -gsimple-template-names support to these functions (the idea is to add an argument to say whether you want the name as spelled in the d

[Lldb-commits] [lldb] [lldb] Reduce duplication in two of DWARFDIE context functions (PR #122712)

2025-01-13 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/122712 This doesn't make much of a difference now, but it makes it easier to add -gsimple-template-names support to these functions (the idea is to add an argument to say whether you want the name as spelled in the deb

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
Michael137 wrote: > Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr? Updated to use this approach in latest commit. Seems to work well (including the explicit object parameter case). Didn't find a great way to test this in the clang AST unit-tests yet. Trying to underst

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/4] [clang][DebugInfo] Expand detection of structured bindings

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-13 Thread Pavel Labath via lldb-commits
@@ -2393,10 +2393,29 @@ Function *DWARFASTParserClang::ParseFunctionFromDWARF( assert(func_type == nullptr || func_type != DIE_IS_BEING_PARSED); const user_id_t func_user_id = die.GetID(); + +// The base address of the scope for any of the debugging information +

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-13 Thread Pavel Labath via lldb-commits
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope { /// The section offset based address for this function. Function(CompileUnit *comp_unit, lldb::user_id_t func_uid, lldb::user_id_t func_type_uid, const Mangled &mangled, -

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-13 Thread Pavel Labath via lldb-commits
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope { /// The section offset based address for this function. Function(CompileUnit *comp_unit, lldb::user_id_t func_uid, lldb::user_id_t func_type_uid, const Mangled &mangled, -

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-13 Thread Pavel Labath via lldb-commits
@@ -3,17 +3,30 @@ # int baz(); # int bar() { return 47; } # int foo(int flag) { return flag ? bar() : baz(); } -# The function bar has been placed "in the middle" of foo. +# The function bar has been placed "in the middle" of foo, and the function +# entry point is deliberately

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: > The latter bits could be added to the qemu testing page, I'll see if any of > it overlaps. https://github.com/llvm/llvm-project/pull/122694 https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb][Docs] Expand remote testing instructions (PR #122694)

2025-01-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes There's a lot of fiddly bits to get right here, so I've added a more complete example and explained why you might choose one method over another. I thought about adding this to the qemu testing page,

[Lldb-commits] [lldb] [lldb][Docs] Expand remote testing instructions (PR #122694)

2025-01-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/122694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Expand remote testing example (PR #122694)

2025-01-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/122694 There's a lot of fiddly bits to get right here, so I've added a more complete example and explained why you might choose one method over another. I thought about adding this to the qemu testing page, as t

[Lldb-commits] [lldb] [llvm] [LLDB][LoongArch] Add LSX and LASX register definitions and operations (PR #120664)

2025-01-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,66 @@ +""" +Test lldb's ability to read and write the LoongArch LASX registers. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class LoongArch64LinuxRegisters(TestBase): +

[Lldb-commits] [lldb] [llvm] [LLDB][LoongArch] Add LSX and LASX register definitions and operations (PR #120664)

2025-01-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/120664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][LoongArch] Add LSX and LASX register definitions and operations (PR #120664)

2025-01-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. The tests are excellent, thanks! This all LGTM, assuming @SixWeining agrees. https://github.com/llvm/llvm-project/pull/120664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [llvm] [LLDB][LoongArch] Add LSX and LASX register definitions and operations (PR #120664)

2025-01-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/120664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also because shrinkwrap defaults to putting this all in Docker, it can cause VPNs to do strange things. If so, there is an option to in shrinkwrap not use the docker "runtime" as it calls it, or disable the VPN temporarily. https://github.com/llvm/llvm-project/pull/117861

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: I do this using 1 build that is a host build, with no options changed from the usual recipe. Then a second cross compilation build done like https://lldb.llvm.org/resources/build.html#example-1-cross-compiling-for-linux-arm64-on-ubuntu-host in which I just build `ninja lldb

[Lldb-commits] [clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via lldb-commits
Michael137 wrote: > > > Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr? > > > > > > Yea I was thinking about it initially. But I wasn't sure what that would > > look like tbh. IIUC `IgnoreImplicitMemberCallSingleStep` will unwrap > > `CXXMemberCallExpr` into the under

[Lldb-commits] [lldb] [llvm] [LLDB][Process] Add LSX and LASX register definitions and operations on the LoongArch64 (PR #120664)

2025-01-13 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/120664 >From 7e56f86ec79865de0c2bc49ffa3f9f2b17a6f36f Mon Sep 17 00:00:00 2001 From: wanglei Date: Fri, 20 Dec 2024 09:10:10 +0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[Lldb-commits] [lldb] [lldb][OpenBSD] Fixes for process handling (PR #122534)

2025-01-13 Thread Pavel Labath via lldb-commits
@@ -40,49 +40,63 @@ class ProcessLaunchInfo; static bool GetOpenBSDProcessArgs(const ProcessInstanceInfoMatch *match_info_ptr, ProcessInstanceInfo &process_info) { - if (process_info.ProcessIDIsValid()) { -int mib[4] = {CTL_KERN, KERN_PROC, KERN_PROC_