llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sad Al Abdullah (SiamAbdullah)
Changes
### Issue:
Currently lldb `platform connect unix-connect://localhost:43045/` is failing
and showing "Failed to connect port" error message.
![IMG_2492](https://github.com/user-attachments/assets/8
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/SiamAbdullah created
https://github.com/llvm/llvm-project/pull/121879
### Issue:
Currently lldb `platform connect unix-connect://localhost:43045/` is failing
and showing "Failed to connect port" error message.
![IMG_2492](https://github.com/user-attachments/assets/816931
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/121860
This is a draft PR with my prototype implementation of
https://discourse.llvm.org/t/rfc-lldb-statusline/83948
>From 24fea391893de79fc0455a81c1ce6cd77b6106fc Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/94794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Julian Lettner
Date: 2025-01-06T15:26:18-08:00
New Revision: 01e980e792651391dfc3b399dbe300eddbbd0997
URL:
https://github.com/llvm/llvm-project/commit/01e980e792651391dfc3b399dbe300eddbbd0997
DIFF:
https://github.com/llvm/llvm-project/commit/01e980e792651391dfc3b399dbe300eddbbd0997.diff
https://github.com/jimingham approved this pull request.
LGTM. It was silly to remove the section information from the Address only to
have the Breakpoint have to find it again.
The only potentially concerning change here is the removal of a check for when
you go to set the breakpoint and the
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@ashgti , this looks very nice! It's good overall that we are able to reuse
some components and reduce the number of responsibilities in lldb-dap.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
Author: Jacob Lalonde
Date: 2025-01-06T12:49:15-08:00
New Revision: 774c22686330f3ca43e48a1b8076eb30ae03dbd8
URL:
https://github.com/llvm/llvm-project/commit/774c22686330f3ca43e48a1b8076eb30ae03dbd8
DIFF:
https://github.com/llvm/llvm-project/commit/774c22686330f3ca43e48a1b8076eb30ae03dbd8.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +144,9 @@ class Progress {
/// Data needed by the debugger to broadcast a progress event.
const ProgressData m_progress_data;
+ /// The origin of this progress event.
+ const Origin m_origin;
Jlalond wrote:
Good catch! Fixed.
https://github.c
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/7] Add external progress bit category
---
lldb/include/lldb/C
https://github.com/JDevlieghere approved this pull request.
LGTM with the redundant field removed.
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +144,9 @@ class Progress {
/// Data needed by the debugger to broadcast a progress event.
const ProgressData m_progress_data;
+ /// The origin of this progress event.
+ const Origin m_origin;
JDevlieghere wrote:
This seems redundant if we stor
jimingham wrote:
This isn't directly relevant, but internally lldb has a "ShouldStopHere"
mechanism that was meant to be extendable. Currently all the behaviors like
the "library & regex avoid" settings are implemented in the
DefaultShouldStopHere, but it wouldn't be terribly hard to add a mo
Jlalond wrote:
Hey @JDevlieghere, I was out for the holidays, but did you want to take a
second look at this? Or can I land it to rebase the SBProgress changes on top
of?
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
ashgti wrote:
@walter-erquinigo Wanted to double check with you on this since this change now
will always link `lldb-dap` with `lldbHost`
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From 4131b8c5af83a219efb2513a1ac90e8b9877d2ef Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/8] [lldb-dap] Ensure the IO forwarding threads are managed
by t
github-actions[bot] wrote:
@rchamala Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build
Author: rchamala
Date: 2025-01-06T09:17:58-08:00
New Revision: b6960e2a631df38c076cee2845978b0606cea066
URL:
https://github.com/llvm/llvm-project/commit/b6960e2a631df38c076cee2845978b0606cea066
DIFF:
https://github.com/llvm/llvm-project/commit/b6960e2a631df38c076cee2845978b0606cea066.diff
LOG:
https://github.com/rchamala closed
https://github.com/llvm/llvm-project/pull/120832
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2025-01-06T11:26:38Z
New Revision: 3bd494dfa6d520e25dc03047c92f28c121293a75
URL:
https://github.com/llvm/llvm-project/commit/3bd494dfa6d520e25dc03047c92f28c121293a75
DIFF:
https://github.com/llvm/llvm-project/commit/3bd494dfa6d520e25dc03047c92f28c121293a75.diff
L
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Reference Discussion:
https://github.com/llvm/llvm-project/pull/120979#discussion_r1903934719
Please see if this is okay @DavidSpickett
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
Replaced `bzero` with the standard `memset` so that it is common to all
platforms.
Review Request: @DavidSpickett
---
Full diff: https://github.com/llvm/llvm-project/pull/121747.diff
1 Files
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/121747
Replaced `bzero` with the standard `memset` so that it is common to all
platforms.
Review Request: @DavidSpickett
>From ced564a1ae7938cddd360684e08077af210654cb Mon Sep 17 00:00:00 2001
From: Dhruv-
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2025-01-06T10:27:48Z
New Revision: 3a7a9c928671adc17046acc3a25e2d9bd5c80fcc
URL:
https://github.com/llvm/llvm-project/commit/3a7a9c928671adc17046acc3a25e2d9bd5c80fcc
DIFF:
https://github.com/llvm/llvm-project/commit/3a7a9c928671adc17046acc3a25e2d9bd5c80fcc.diff
L
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Okay sure. Done. Please check! 🙂
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DavidSpickett wrote:
These changes get things building I assume. So in that context I'm OK with
this. I have a feeling HostInfoAIX might end up essentially blank eventually,
but just because of the way we handle the HostInfo type, I think some file has
to exist for it to build. So it's OK to a
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -1226,7 +1226,7 @@ bool lldb_private::formatters::ObjCSELSummaryProvider(
time_t lldb_private::formatters::GetOSXEpoch() {
static time_t epoch = 0;
if (!epoch) {
-#ifndef _WIN32
+#if !defined(_WIN32) && !defined(_AIX)
DavidSpickett wrote:
Yes this is fi
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
ConnectionStatus ConnectionFileDescriptor::ConnectFile(
llvm::StringRef s, socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#if LLDB_ENABLE_POSIX && !defin
@@ -16,6 +16,9 @@
#include
#include
#include
+#ifdef _AIX
+#include
DavidSpickett wrote:
Please do a PR to switch this to memset. This is more standard and saves us
from changing these includes.
https://github.com/llvm/llvm-project/pull/120979
__
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/120740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-06T09:17:25Z
New Revision: b0c0a148dbad9f4d9a2e855deec05669269d30c7
URL:
https://github.com/llvm/llvm-project/commit/b0c0a148dbad9f4d9a2e855deec05669269d30c7
DIFF:
https://github.com/llvm/llvm-project/commit/b0c0a148dbad9f4d9a2e855deec05669269d30c7.diff
LOG
44 matches
Mail list logo