[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread via lldb-commits
@@ -274,7 +161,7 @@ uint32_t NativeRegisterContextDBReg_arm64::SetHardwareWatchpoint( } // Setup control value - control_value = g_enable_bit | g_pac_bits | GetSizeBits(size); + control_value = m_hw_dbg_enable_bit | g_pac_bits | GetSizeBits(size); wangl

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-12-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From ca04cd4dbdba506ddc1f4816922819d0bfe3f1eb Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode

[Lldb-commits] [lldb] [lldb][NFC] Make the target's SectionLoadList private. (PR #113278)

2024-12-05 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/113278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Make the target's SectionLoadList private. (PR #113278)

2024-12-05 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/113278 >From dab763afbe46a59020ae10530c062e9420f45605 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Tue, 22 Oct 2024 01:16:40 -0700 Subject: [PATCH 1/3] Make the target's SectionLoadList private. Lots of code aro

[Lldb-commits] [lldb] [lldb-dap] Add attach & corefile templates (PR #118894)

2024-12-05 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/118894 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
jimingham wrote: If we ever come across a language that allows numbers for ivar names, overloading `child` for by name access will make us sad, but I think such a language would make us sadder, so I'm not much concerned... https://github.com/llvm/llvm-project/pull/118814 __

[Lldb-commits] [lldb] [lldb-dap] Add attach & corefile templates (PR #118894)

2024-12-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/118894 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 244b207 - [lldb-dap] Add attach & corefile templates (#118894)

2024-12-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-12-05T16:20:11-08:00 New Revision: 244b207d3c2e5a2a72cd4470829ac39c653c406a URL: https://github.com/llvm/llvm-project/commit/244b207d3c2e5a2a72cd4470829ac39c653c406a DIFF: https://github.com/llvm/llvm-project/commit/244b207d3c2e5a2a72cd4470829ac39c653c406a.d

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
jimingham wrote: The other way to do it would be to use "::Foo" to refer to the base class, and "Foo" the member. Maybe even nicer would be to allow just "Foo" if there's no ambiguity, and only require the :: if there is. https://github.com/llvm/llvm-project/pull/118814 __

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
jimingham wrote: I think you have to do lookup by name just of the members (and maybe a separate lookup by name of the base classes?) https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
jimingham wrote: Unfortunately, this is legal C++: ``` class Foo { public: int m_intvar = 10; }; class Bar : Foo { public: int Foo = 100; }; int main() { Bar myBar; return myBar.Foo; } ``` So the lookup by name of Foo wouldn't be unique here. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb-dap] Add attach & corefile templates (PR #118894)

2024-12-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118894.diff 2 Files Affected: - (modified) lldb/tools/lldb-dap/package-lock.json (+2-2) - (modified) lldb/tools/lldb-dap/package.json (+2

[Lldb-commits] [lldb] [lldb-dap] Add attach & corefile templates (PR #118894)

2024-12-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/118894 None >From 0863b603d0bdf53e977f707d58083cf505fa0f29 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 5 Dec 2024 14:46:42 -0800 Subject: [PATCH] [lldb-dap] Add attach & corefile templates --- l

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
kastiglione wrote: I updated the PR to support look up of base class children by name. https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/118814 >From 639fc6d87345c8d68a822032917102a4225df355 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 4 Dec 2024 14:37:24 -0800 Subject: [PATCH 1/3] [lldb] Add lookup by name to SBValue.child --- lldb/bindings

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/118814 >From 639fc6d87345c8d68a822032917102a4225df355 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 4 Dec 2024 14:37:24 -0800 Subject: [PATCH 1/2] [lldb] Add lookup by name to SBValue.child --- lldb/bindings

[Lldb-commits] [lldb] abb6919 - [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (#118719)

2024-12-05 Thread via lldb-commits
Author: Alex Langford Date: 2024-12-05T10:38:23-08:00 New Revision: abb6919a63c7ef017bb4f9c86057adcdb8129964 URL: https://github.com/llvm/llvm-project/commit/abb6919a63c7ef017bb4f9c86057adcdb8129964 DIFF: https://github.com/llvm/llvm-project/commit/abb6919a63c7ef017bb4f9c86057adcdb8129964.diff

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/118719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > or, should we allow base classes to be looked up by name as well? I'd prefer the latter so they can used interchangeably. I like the fact that the subscript can be either an int or a string. https://github.com/llvm/llvm-project/pull/118814 ___

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
kastiglione wrote: or, should we allow base classes to be looked up by name as well? https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
kastiglione wrote: @jimingham are you proposing a new property named `member`? In which case `child` would be used for index based access, and `member` would be used for name based access? https://github.com/llvm/llvm-project/pull/118814 ___ lldb-com

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
jimingham wrote: I wonder if "member" might be a better name than "child". The base classes of an SBValue representing a C++ object are also children of the value, but you won't be able to look them up in this array. https://github.com/llvm/llvm-project/pull/118814 ___

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Nice! LGTM! https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0964328 - [lldb] Fix the SocketTest failure on unsupported hosts (#118673)

2024-12-05 Thread via lldb-commits
Author: John Harrison Date: 2024-12-05T09:08:17-08:00 New Revision: 0964328c2960159f66ad232bb2257fbabab3c0ec URL: https://github.com/llvm/llvm-project/commit/0964328c2960159f66ad232bb2257fbabab3c0ec DIFF: https://github.com/llvm/llvm-project/commit/0964328c2960159f66ad232bb2257fbabab3c0ec.diff

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/118673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread John Harrison via lldb-commits
@@ -116,6 +116,24 @@ bool lldb_private::HostSupportsIPv6() { return CheckIPSupport("IPv6", "[::1]:0"); } +bool lldb_private::HostSupportsLocalhostToIPv4() { + if (!HostSupportsIPv4()) +return false; + + auto addresses = SocketAddress::GetAddressInfo("localhost", nullpt

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/118673 >From becab1c1b0a3a9237637909212f7ea7586b82321 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 4 Dec 2024 09:39:12 -0800 Subject: [PATCH 1/2] [lldb] Fix the SocketTest::TCPListen0MultiListenerGetListenin

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-12-05 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: So, is this patch worth pursuing or is it too much code for a too specific use case? https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2024-12-05 Thread via lldb-commits
https://github.com/anjenner updated https://github.com/llvm/llvm-project/pull/115331 >From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001 From: Andrew Jenner Date: Thu, 7 Nov 2024 10:47:42 -0500 Subject: [PATCH 1/3] Modify the localCache API to require an explicit commit on

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2024-12-05 Thread via lldb-commits
@@ -131,11 +138,22 @@ Expected llvm::localCache(const Twine &CacheNameRef, }); if (E) - report_fatal_error(Twine("Failed to rename temporary file ") + - TempFile.TmpName + " to " + ObjectPathName + ": " + -

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2024-12-05 Thread via lldb-commits
@@ -88,9 +89,10 @@ Expected llvm::localCache(const Twine &CacheNameRef, AddBuffer(std::move(AddBuffer)), TempFile(std::move(TempFile)), ModuleName(ModuleName), Task(Task) {} - ~CacheStream() { -// TODO: Manually commit rather than using no

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118814.diff 2 Files Affected: - (modified) lldb/bindings/interface/SBValueExtensions.i (+4-2) - (modified) lldb/test/API/python_api/value/TestValue

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/118814 None >From 639fc6d87345c8d68a822032917102a4225df355 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 4 Dec 2024 14:37:24 -0800 Subject: [PATCH] [lldb] Add lookup by name to SBValue.child --- lldb/bindin

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -116,6 +116,24 @@ bool lldb_private::HostSupportsIPv6() { return CheckIPSupport("IPv6", "[::1]:0"); } +bool lldb_private::HostSupportsLocalhostToIPv4() { + if (!HostSupportsIPv4()) +return false; + + auto addresses = SocketAddress::GetAddressInfo("localhost", nullpt

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread David Spickett via lldb-commits
@@ -274,7 +161,7 @@ uint32_t NativeRegisterContextDBReg_arm64::SetHardwareWatchpoint( } // Setup control value - control_value = g_enable_bit | g_pac_bits | GetSizeBits(size); + control_value = m_hw_dbg_enable_bit | g_pac_bits | GetSizeBits(size); David

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread David Spickett via lldb-commits
@@ -234,9 +234,9 @@ class NativeRegisterContextLinux_arm64 size_t GetFPMRBufferSize() { return sizeof(m_fpmr_reg); } - llvm::Error ReadHardwareDebugInfo() override; + Status ReadHardwareDebugInfo() override; DavidSpickett wrote: @labath I seem to remembe

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I was looking at the Arm (32 bit) code and it's also very similar, so if I find the time I'll migrate this to this base class too. See if you can move the use of pac_bits, then I'll test this for you on AArch64. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Hmm, on my machine it fails with the same error after the commit is applied ``` Script: -- /home/parallels/llvm-build-release/tools/lldb/unittests/Host/./HostTests --gtest_filter=SocketTest.TCPListen0MultiListenerGetListeningConnectionURI -- /home/parallels/llvm-project/lldb/un

[Lldb-commits] [lldb] 15de77d - [lldb] (Prepare to) speed up dwarf indexing (#118657)

2024-12-05 Thread via lldb-commits
Author: Pavel Labath Date: 2024-12-05T10:38:29+01:00 New Revision: 15de77db91c199f9431e81d0b85bb6984d1c5296 URL: https://github.com/llvm/llvm-project/commit/15de77db91c199f9431e81d0b85bb6984d1c5296 DIFF: https://github.com/llvm/llvm-project/commit/15de77db91c199f9431e81d0b85bb6984d1c5296.diff

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-05 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/118657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread via lldb-commits
https://github.com/wangleiat edited https://github.com/llvm/llvm-project/pull/118043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-05 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/118657 >From 6a9384e47441117cff7b2903b4ad8bdfd11f06b4 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 2 Dec 2024 12:44:24 + Subject: [PATCH 1/2] [lldb] (Prepare to) speed up dwarf indexing Indexing a single

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-05 Thread Pavel Labath via lldb-commits
labath wrote: > Makes sense, LGTM. > > If the amount of work here is so small, and the granularity was too fine for > creating separate tasks, I'd argue that it's too fine for progress reporting > as well. I think that's what you're saying too. There's probably multiple > ways of dealing with

[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

2024-12-05 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/118043 >From a7cba7ef089a6f2004b1879d30675652729370e5 Mon Sep 17 00:00:00 2001 From: wanglei Date: Fri, 29 Nov 2024 10:43:31 +0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-05 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/118719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-05 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/118673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits