https://github.com/jasonmolenda approved this pull request.
This looks reasonable to me.
https://github.com/llvm/llvm-project/pull/117996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
DavidSpickett wrote:
And I don't see that LoongArch is doing anything unusual, so I think this is
just a refactoring exercise. It is native code so if you don't have an AArch64
machine to build on, I can test the PR for you.
https://github.com/llvm/llvm-project/pull/118043
@@ -337,4 +354,471 @@
NativeRegisterContextLinux_loongarch64::GetExpeditedRegisters(
return expedited_reg_nums;
}
+uint32_t
+NativeRegisterContextLinux_loongarch64::NumSupportedHardwareBreakpoints() {
+ Log *log = GetLog(LLDBLog::Breakpoints);
+
+ // Read hardware breakpo
@@ -337,4 +354,471 @@
NativeRegisterContextLinux_loongarch64::GetExpeditedRegisters(
return expedited_reg_nums;
}
+uint32_t
+NativeRegisterContextLinux_loongarch64::NumSupportedHardwareBreakpoints() {
+ Log *log = GetLog(LLDBLog::Breakpoints);
+
+ // Read hardware breakpo
@@ -337,4 +354,471 @@
NativeRegisterContextLinux_loongarch64::GetExpeditedRegisters(
return expedited_reg_nums;
}
+uint32_t
+NativeRegisterContextLinux_loongarch64::NumSupportedHardwareBreakpoints() {
+ Log *log = GetLog(LLDBLog::Breakpoints);
+
+ // Read hardware breakpo
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/117500
>From 3199d3ee3817a8551cda1f5fce6083fef1c079d9 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Sat, 23 Nov 2024 18:25:22 -0800
Subject: [PATCH 1/3] [lldb] Update dwim-print to show expanded objc instances
Whe
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/117500
>From 3199d3ee3817a8551cda1f5fce6083fef1c079d9 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Sat, 23 Nov 2024 18:25:22 -0800
Subject: [PATCH 1/2] [lldb] Update dwim-print to show expanded objc instances
Whe
Author: Dave Lee
Date: 2024-12-02T16:23:26-08:00
New Revision: 0a96161beb161933e64e188bfb0754df494c3a58
URL:
https://github.com/llvm/llvm-project/commit/0a96161beb161933e64e188bfb0754df494c3a58
DIFF:
https://github.com/llvm/llvm-project/commit/0a96161beb161933e64e188bfb0754df494c3a58.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/117504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/118411
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
🚢
https://github.com/llvm/llvm-project/pull/118411
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
This doesn't seem to be used anywhere. LGTM!
https://github.com/llvm/llvm-project/pull/118411
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/118411.diff
1 Files Affected:
- (modified) lldb/include/lldb/Target/Platform.h (-3)
``diff
diff --git a/lldb/include/lldb/Target/Platf
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/118411
None
>From 41ce9de83da1a7131bf6c479fd0de3a57f5b8113 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 2 Dec 2024 14:42:25 -0800
Subject: [PATCH] [lldb][NFC] Remove unused field Platform::m_remote_url
-
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/118222
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-12-02T13:55:35-08:00
New Revision: 1250a1db1a378736afda389c94d2846d7a254576
URL:
https://github.com/llvm/llvm-project/commit/1250a1db1a378736afda389c94d2846d7a254576
DIFF:
https://github.com/llvm/llvm-project/commit/1250a1db1a378736afda389c94d2846d7a254576.diff
LOG:
JDevlieghere wrote:
Thanks, I suggested something similar in #118032.
https://github.com/llvm/llvm-project/pull/118222
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
You should be able to debug lldb and step through the code that tries to get
the synthetic child provider for the type and watch if fail. You can also step
through the C++ example code from my screen shot and see how it is working to
see what is going wrong and how the two thin
@@ -118,6 +124,15 @@ std::string TCPSocket::GetRemoteConnectionURI() const {
return "";
}
+std::string TCPSocket::GetListeningConnectionURI() const {
ashgti wrote:
Split this into its own PR https://github.com/llvm/llvm-project/pull/118330
https://github.c
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/118330
>From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 2 Dec 2024 08:29:01 -0800
Subject: [PATCH 1/2] [lldb] For a host socket, add a method to print the
listening
https://github.com/ashgti unassigned
https://github.com/llvm/llvm-project/pull/118330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This is most useful if you are listening on an address like 'localhost:0' and
want to know the resolved ip + port of the socket listener.
---
Full diff: https://github.com/llvm/llvm-project/pull/118330.diff
@@ -131,11 +138,22 @@ Expected llvm::localCache(const Twine
&CacheNameRef,
});
if (E)
- report_fatal_error(Twine("Failed to rename temporary file ") +
- TempFile.TmpName + " to " + ObjectPathName + ": "
+
-
@@ -88,9 +89,10 @@ Expected llvm::localCache(const Twine
&CacheNameRef,
AddBuffer(std::move(AddBuffer)), TempFile(std::move(TempFile)),
ModuleName(ModuleName), Task(Task) {}
- ~CacheStream() {
-// TODO: Manually commit rather than using no
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/118390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Can you post a copy of a the python code for the synthetic child provider you
are creating and also how you are registering it with LLDB?
https://github.com/llvm/llvm-project/pull/117755
___
lldb-commits mailing list
lldb-commits@lists
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/118222
>From bb68e6d523f3e80b991c7370bb00bac2bb9582b6 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sun, 1 Dec 2024 21:35:52 +0400
Subject: [PATCH 1/3] [lldb] Increase MAX_ATTEMPTS in
connect_to_debug_monitor(
skuznetsov wrote:
> Can you post a copy of a the python code for the synthetic child provider you
> are creating and also how you are registering it with LLDB?
Here it is:
```
# Hash(K,V) class support providers
class CrystalHashSyntheticProvider:
def __init__(self, valobj, internal_dict):
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
The ManualDWARFIndex class can create a index cache if the LLDB index cache is
enabled. This used to save the index to the same file, regardless of wether the
cache was a full index (no .debug_names) or a pa
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/118390
The ManualDWARFIndex class can create a index cache if the LLDB index cache is
enabled. This used to save the index to the same file, regardless of wether the
cache was a full index (no .debug_names) or a part
skuznetsov wrote:
> src="https://private-user-images.githubusercontent.com/4421997/391664786-b7dbb80c-5f7d-4dd8-a0db-d0b8fe10cf21.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzMxNjQxODMsIm5iZiI6M
Michael137 wrote:
Apologies for the late ping but looks like this is breaking macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/16280/execution/node/97/log/?consoleFull
```
==
FAIL: test_shadowed_stat
Author: Dmitry Vasilyev
Date: 2024-12-02T20:51:44+04:00
New Revision: a951e76fbed642dbe3f51965d17ca566be586cc5
URL:
https://github.com/llvm/llvm-project/commit/a951e76fbed642dbe3f51965d17ca566be586cc5
DIFF:
https://github.com/llvm/llvm-project/commit/a951e76fbed642dbe3f51965d17ca566be586cc5.dif
@@ -151,10 +151,23 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
result.SetStatus(eReturnStatusSuccessFinishResult);
};
- // First, try `expr` as the name of a frame variable.
- if (frame) {
-auto valobj_sp = frame->FindVariable(ConstString(expr));
-
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/117452
>From cce676f2e8e0ed7a81ae1fa78082765cb698de85 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Sat, 23 Nov 2024 14:37:10 -0800
Subject: [PATCH 1/3] [lldb] Update dwim-print to support limited variable
express
https://github.com/bulbazord approved this pull request.
Overall LGTM. It'd be nice if the test could be architecture independent but I
understand if that's difficult or not possible right now.
https://github.com/llvm/llvm-project/pull/117532
___
lldb
@@ -0,0 +1,182 @@
+# REQUIRES: x86
bulbazord wrote:
Is there any way we can have an architecture-independent test? If it's a ton of
work, I say don't worry about it, most folks are going to build the x86 target
probably.
https://github.com/llvm/llvm-project/pu
@@ -444,8 +444,11 @@ class Function : public UserID, public SymbolContextScope {
Function *CalculateSymbolContextFunction() override;
+ // DEPRECATED: Use GetAddressRanges instead.
bulbazord wrote:
Can you make this into a Doxygen comment? It will show up
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/117532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
https://github.com/user-attachments/assets/b7dbb80c-5f7d-4dd8-a0db-d0b8fe10cf21";>
Still works inside of a structure. Anything else I can try?
https://github.com/llvm/llvm-project/pull/117755
___
lldb-commits mailing list
lldb-commits@
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/118330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/118330
This is most useful if you are listening on an address like 'localhost:0' and
want to know the resolved ip + port of the socket listener.
>From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001
F
@@ -154,5 +163,25 @@ def test_preserves_persistent_variables(self):
def test_missing_type(self):
"""The expected output of po opaque is its address (no error)"""
self.build()
-lldbutil.run_to_source_breakpoint(self, "break here",
lldb.SBFileSpec("ma
DavidSpickett wrote:
We could move all this back into NativeRegisterContextLinux too but A: let's
take one step at a time and B: it may be that some architecture does not fit
the pattern that AArch64 and LoongArch do.
So in the interests of you getting this done and us having less churn, stick
https://github.com/DavidSpickett commented:
I started to comment on some style issues here then realised that this code is
adapted from
`lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp` and
I think about 90% of it is the same.
I would prefer that you extract the gener
https://github.com/labath approved this pull request.
Yeah, that's the general idea, although 16 attempts @ 262s sounds a bit too
much (that's like almost three times as long as the first version with 30*3s).
I worry that the tests will take too long to time out if they not able to
establish a
labath wrote:
I don't run remote tests these days, but it sounds like you need to invoke the
tests through lit rather than running tests directly. Here's some description
of this:
https://github.com/llvm/llvm-project/blob/4930f69b78e215c60eb53e25596599c2f98b6564/lldb/test/API/lit.cfg.py#L292
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/118222
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc closed
https://github.com/llvm/llvm-project/pull/118093
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: dlav-sc
Date: 2024-12-02T14:51:22+03:00
New Revision: 9a34a4f8d668b72868fde3b6a58bb3a57d72c0c9
URL:
https://github.com/llvm/llvm-project/commit/9a34a4f8d668b72868fde3b6a58bb3a57d72c0c9
DIFF:
https://github.com/llvm/llvm-project/commit/9a34a4f8d668b72868fde3b6a58bb3a57d72c0c9.diff
LOG:
DavidSpickett wrote:
Please dig into why it's failing, remotely or locally whatever you can
reproduce. I doubt the reason is anything sinister but I'd like to know what it
is before approving anything.
https://github.com/llvm/llvm-project/pull/118095
___
slydiman wrote:
Updated the patch:
Added an exponential algorithm for the sleep time. Reduced MAX_ATTEMPTS to 16.
The sleep time will be 3, 3.6, 4.3, ..., 38, 46.
The total sleep time is 262 + 0.5*MAX_CONNECT_ATTEMPTS*MAX_ATTEMPTS = 342.
Note the timeout is 600, so the rest time must be enough
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/118222
>From bb68e6d523f3e80b991c7370bb00bac2bb9582b6 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sun, 1 Dec 2024 21:35:52 +0400
Subject: [PATCH 1/2] [lldb] Increase MAX_ATTEMPTS in
connect_to_debug_monitor(
dlav-sc wrote:
> I'd switch to the (standard) one-process-per-test mode.
It's good you've written about this mode, because I haven't even known that
lldb testsuite has such option. Could you provide more information how can I
enable it, please? Is there a corresponding flag for a `dotest.py`?
@@ -3194,16 +3194,19 @@ lldb::ValueObjectSP
ValueObject::CastToBasicType(CompilerType type) {
GetCompilerType().IsPointerType() || GetCompilerType().IsNullPtrType();
bool is_float = GetCompilerType().IsFloat();
bool is_integer = GetCompilerType().IsInteger();
+ Exec
@@ -642,6 +649,16 @@ bool
lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject(
pfunc(SWIGBridge::ToSWIGWrapper(std::move(debugger)), PythonString(args),
SWIGBridge::ToSWIGWrapper(exe_ctx_ref_sp), cmd_retobj_arg.obj());
+ if (PyErr_Occurred()) {
+p
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName(
llvm::StringRef field_name = field->getName();
if (field_name.empty()) {
CompilerType field_type = GetType(field->getType());
+std::vector save_indices = c
@@ -0,0 +1,19 @@
+int main(int argc, char** argv) {
+ struct A {
+struct {
+ int x = 1;
+};
+int y = 2;
+ } a;
+
+ struct B {
+// Anonymous struct inherits another struct.
+struct : public A {
+ int z = 3;
+};
+int w = 4;
+A a;
+ } b;
labath wrote:
20 attempts is already more than what I would consider reasonable. Increasing
it doesn't sound like a good idea. If the problem is lingering sockets, then I
think a better approach is to slow down the rate of socket creation, not churn
out more of them.
While this code tries to
anjenner wrote:
Ping for code review please - thank you.
https://github.com/llvm/llvm-project/pull/115331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath commented:
I think we can make some progress here, but I don't think we'll get far without
ProcessLauncher support. At some point, not too far from now, I'm going to
start asking questions like "which tests does this fix", and I don't think
you'll be able to run any o
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
So, using the llvm structures for parsing (instead of rolling your own) is
definitely a step in the right direction. However, I don't think you need to
roll your own parsing either, given that the headers have already been parsed
in llvm::XCOFFObjectFile. Why can't you just use t
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
labath wrote:
> Maybe it's true, I've tried to test lldb on riscv using dotest.py with remote
> debugging options.
It sounds like you're using the mode which runs all tests (files) in the same
process. I don't know if anyone uses it these days (and this error sort of says
"no"). I don't think
labath wrote:
> > I'm only using it in an internal branch
>
> Not sure what the protocol is for this (CC @JDevlieghere @labath). At the
> very least we should have some coverage for it in the test-suite. There's
> precedent for this, e.g., APIs that only get exercised on the Swift branch,
> b
80 matches
Mail list logo
