[Lldb-commits] [lldb] [lldb] Include `` for `system_clock` (PR #118059)

2024-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Lily Wang (LilyWangLL) Changes I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in `llvm`. It must add include `` to fix this error. Compiler error wit

[Lldb-commits] [lldb] [lldb] Include `` for `system_clock` (PR #118059)

2024-11-28 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Include `` for `system_clock` (PR #118059)

2024-11-28 Thread Lily Wang via lldb-commits
https://github.com/LilyWangLL created https://github.com/llvm/llvm-project/pull/118059 I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in `llvm`. It must add include `` to fix this error. Compiler error with this

[Lldb-commits] [lldb] Add 'FindFirstSymbolWithNameAndType()' to ModuleList. (PR #117777)

2024-11-28 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > > I'm only using it in an internal branch > > > > Not sure what the protocol is for this (CC @JDevlieghere @labath). At the > very least we should have some coverage for it in the test-suite. There's > precedent for this, e.g., APIs that only get exercised on the Swift

[Lldb-commits] [lldb] [lldb][Process/Linux] Introduce LoongArch64 hw break/watchpoint support (PR #118043)

2024-11-28 Thread via lldb-commits
https://github.com/wangleiat created https://github.com/llvm/llvm-project/pull/118043 This patch adds support for setting/clearing hardware watchpoints and breakpoints on LoongArch 64-bit hardware. Refer to the following document for the hw break/watchpoint: https://loongson.github.io/LoongArch

[Lldb-commits] [lldb] [lldb][Process/Linux] Introduce LoongArch64 hw break/watchpoint support (PR #118043)

2024-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: wanglei (wangleiat) Changes This patch adds support for setting/clearing hardware watchpoints and breakpoints on LoongArch 64-bit hardware. Refer to the following document for the hw break/watchpoint: https://loongson.github.io/LoongArch-Do

[Lldb-commits] [lldb] [lldb][Mach-O] Handle shared cache binaries correctly (PR #117832)

2024-11-28 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/117832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 448ac7d - [lldb][Mach-O] Handle shared cache binaries correctly (#117832)

2024-11-28 Thread via lldb-commits
Author: Jason Molenda Date: 2024-11-28T10:31:57-08:00 New Revision: 448ac7d3418a31d35b462440c8bf644287efac8a URL: https://github.com/llvm/llvm-project/commit/448ac7d3418a31d35b462440c8bf644287efac8a DIFF: https://github.com/llvm/llvm-project/commit/448ac7d3418a31d35b462440c8bf644287efac8a.diff

[Lldb-commits] [lldb] [lldb][Mach-O] Handle shared cache binaries correctly (PR #117832)

2024-11-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/117832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O] Handle shared cache binaries correctly (PR #117832)

2024-11-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. I like @Michael137's suggestion and the name makes it obvious what's going on. LGTM. https://github.com/llvm/llvm-project/pull/117832 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-28 Thread Michael Buch via lldb-commits
@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions( m_expr_options.m_verbosity, m_format_options.GetFormat()); - dump_options.SetHideRootName(suppress_result); + dump_opt

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 deleted https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add 'FindFirstSymbolWithNameAndType()' to ModuleList. (PR #117777)

2024-11-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > Reference in Not sure what the protocol is for this (CC @JDevlieghere @labath). At the very least we should have some coverage for it in the test-suite. There's precedent for this, e.g., APIs that only get exercised on the Swift branch, but at least those are on a public f

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
Michael137 wrote: This is quite an interesting case. Basically the issue arises only because we have an `anonymous` struct in `B` with a base class that has an "indirect field" called `x`: ``` IndirectFieldDecl 0x104145868 <> implicit x 'int' |-Field 0x104145758 '' 'A::(anonymous struct)' `-

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/117996 >From 78b8dabf1ada3d567d3f1a193fdf0cc0f159cb37 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 27 Nov 2024 17:05:23 +0100 Subject: [PATCH 1/2] [lldb] Use the function block as a source for function ranges

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 871e3dc8d8717bbcf5e3ad44331a21c3417c2639 78b8dabf1ada3d567d3f1a193fdf0cc0f159cb37 --e

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread Pavel Labath via lldb-commits
@@ -10,7 +10,7 @@ # CHECK: 1 match found in {{.*}} # CHECK: Summary: {{.*}}`foo -# CHECK: Function: id = {{.*}}, name = "foo", ranges = [0x-0x0007)[0x0007-0x000e)[0x0014-0x001b)[0x001b-0x0

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread Pavel Labath via lldb-commits
@@ -2,7 +2,6 @@ REQUIRES: system-windows, lld RUN: %build --compiler=clang-cl --nodefaultlib --output=%t.exe %S/Inputs/FunctionNestedBlockTest.cpp RUN: lldb-test symbols -find=function -file FunctionNestedBlockTest.cpp -line 4 %t.exe | FileCheck --check-prefix=CHECK-FUNCTION %

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread Pavel Labath via lldb-commits
@@ -3240,8 +3195,17 @@ size_t SymbolFileDWARF::ParseBlocksRecursive(Function &func) { DWARFDIE function_die = dwarf_cu->GetNonSkeletonUnit().GetDIE(function_die_offset); if (function_die) { -ParseBlocksRecursive(*comp_unit, &func.GetBlock(false), function_die, -

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is a follow-up/reimplementation of #115730. While working on that patch, I did not realize that the correct (discontinuous) set of ranges is already stored in the block representing the whole function. Th

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

2024-11-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/117996 This is a follow-up/reimplementation of #115730. While working on that patch, I did not realize that the correct (discontinuous) set of ranges is already stored in the block representing the whole function. The

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-11-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Will keep this in review until the code changes land. I might not reflect reality if changes are made along the way. https://github.com/llvm/llvm-project/pull/117860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-11-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > Here's the test case I used: $ cat main.cpp struct A { struct { int x = 1; }; > int y = 2;6 } a; > > struct B { // Anonymous struct inherits another struct. struct : public A { > int z = 3; }; int w = 4; A a; } b; > > return 0; // Set a breakpoint here } $ clang++ -g -O0 m

[Lldb-commits] [lldb] 871e3dc - [lldb] Fixup #117699 for windows builds

2024-11-28 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2024-11-28T11:13:29+01:00 New Revision: 871e3dc8d8717bbcf5e3ad44331a21c3417c2639 URL: https://github.com/llvm/llvm-project/commit/871e3dc8d8717bbcf5e3ad44331a21c3417c2639 DIFF: https://github.com/llvm/llvm-project/commit/871e3dc8d8717bbcf5e3ad44331a21c3417c2639.diff

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2024-11-28 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,213 @@ +//===-- HostInfoAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2024-11-28 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,213 @@ +//===-- HostInfoAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2024-11-28 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,43 @@ +//===-- HostInfoAIX.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache