https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/117095
>From fc6cc65d4673de145989b334f67eeb4fb54aa25c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 20 Nov 2024 17:45:54 -0800
Subject: [PATCH] [lldb] Fix a regression in Status::GetErrorType()
The ref
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
14667119bcc78fe7d8a2d8f6c31407f2b6a6f8a5...27308496b00d90e798d4c73940602d3e3cf1684b
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
The refactored code did not correctly determine the type of expression errors.
rdar://139699028
---
Full diff: https://github.com/llvm/llvm-project/pull/117095.diff
2 Files Affected:
- (modified) ll
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/117095
The refactored code did not correctly determine the type of expression errors.
rdar://139699028
>From 27308496b00d90e798d4c73940602d3e3cf1684b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 20 N
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 53a6a11e0d51229d341b8906252645cd8a5de796
b285bba80b7b7ad4e351485d59df41f328462867 --e
https://github.com/splhack edited
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/splhack updated
https://github.com/llvm/llvm-project/pull/117070
>From 6b8f4a824d39ce557230e610a846d316358b4f20 Mon Sep 17 00:00:00 2001
From: Kazuki Sakamoto
Date: Wed, 20 Nov 2024 16:20:40 -0800
Subject: [PATCH 1/2] Run clang format.
---
lldb/source/Core/DynamicLoader.cpp
@@ -2809,6 +2956,374 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP &type_sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ if (auto target_sp = GetTargetSP()) {
+const b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
I backed this out due to a problem on one of the bots that myself and others
have problems reproducing locally. I'd like to try to land it again, at least
to gain more information.
Summary:
This improves
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/117079
I backed this out due to a problem on one of the bots that myself and others
have problems reproducing locally. I'd like to try to land it again, at least
to gain more information.
Summary:
This improves the
@@ -97,6 +97,9 @@ class ProcessElfCore : public lldb_private::PostMortemProcess
{
bool GetProcessInfo(lldb_private::ProcessInstanceInfo &info) override;
+ // Returns the gnu uuid from matched NT_FILE entry
+ lldb_private::UUID FindBuildId(const llvm::StringRef path) over
@@ -157,6 +157,10 @@ DynamicLoader::GetSectionListFromModule(const ModuleSP
module) const {
ModuleSP DynamicLoader::FindModuleViaTarget(const FileSpec &file) {
Target &target = m_process->GetTarget();
ModuleSpec module_spec(file, target.GetArchitecture());
+ if (UUID uuid
@@ -281,6 +281,13 @@ void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
}
}
+UUID ProcessElfCore::FindBuildId(const llvm::StringRef path) {
clayborg wrote:
Change to overrite `GetModuleSpec` instead.
https://github.com/llvm/llvm-project/pull/117070
___
https://github.com/splhack approved this pull request.
https://github.com/llvm/llvm-project/pull/117028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dwblaikie wrote:
if you're sending things for presubmit checks, but not for precommit review,
please include the `skip-precommit-approval` label - but in this case it looks
like you requested review, but then submitted without waiting for that review?
Please don't do that, per:
https://llvm.o
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1380,6 +1380,8 @@ class Process : public
std::enable_shared_from_this,
virtual bool GetProcessInfo(ProcessInstanceInfo &info);
+ virtual lldb_private::UUID FindBuildId(const llvm::StringRef path);
+
clayborg wrote:
There is already a function in Proc
@@ -6080,6 +6080,11 @@ bool Process::GetProcessInfo(ProcessInstanceInfo &info) {
return platform_sp->GetProcessInfo(GetID(), info);
}
+lldb_private::UUID Process::FindBuildId(const llvm::StringRef path) {
+ lldb_private::UUID invalid_uuid;
+ return invalid_uuid;
+}
+
-
@@ -1034,7 +1041,8 @@ UUID ProcessElfCore::FindBuidIdInCoreMemory(lldb::addr_t
address) {
std::vector note_bytes;
note_bytes.resize(program_header.p_memsz);
-byte_read = ReadMemory(program_header.p_vaddr, note_bytes.data(),
+const lldb::addr_t program_header_v
clayborg wrote:
The reading of build IDs is tracked in this PR:
https://github.com/llvm/llvm-project/pull/117028
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
splhack wrote:
> The reading of build IDs is tracked in this PR: #117028
will rebase onto #117028
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](const std::vector &details) {
+uint16_t column = 0;
+std::vector result, group;
@@ -157,6 +157,10 @@ DynamicLoader::GetSectionListFromModule(const ModuleSP
module) const {
ModuleSP DynamicLoader::FindModuleViaTarget(const FileSpec &file) {
Target &target = m_process->GetTarget();
ModuleSpec module_spec(file, target.GetArchitecture());
+ if (UUID uuid
ZequanWu wrote:
> This patch broke the lldb incremental bot on greendragon
>
> https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15486/
>
> TEST 'lldb-shell ::
> SymbolFile/DWARF/x86/simplified-template-names.cpp' FAILED
> Exit Code:
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/117012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/117071
This is a reland of https://github.com/llvm/llvm-project/pull/112811. Fixed the
bot breakage by running ld.lld explicitly.
>From 88aac9780b33410b0fb119c07eec6b4005149cf4 Mon Sep 17 00:00:00 2001
From: Zequan W
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Zequan Wu (ZequanWu)
Changes
This is a reland of https://github.com/llvm/llvm-project/pull/112811. Fixed the
bot breakage by running ld.lld explicitly.
---
Patch is 24.81 KiB, truncated to 20.00 KiB below, full version:
https://gith
@@ -157,6 +157,10 @@ DynamicLoader::GetSectionListFromModule(const ModuleSP
module) const {
ModuleSP DynamicLoader::FindModuleViaTarget(const FileSpec &file) {
Target &target = m_process->GetTarget();
ModuleSpec module_spec(file, target.GetArchitecture());
+ if (UUID uuid
cs01 wrote:
Thank you! Are there any unit tests that can exercise this?
Or at least repro steps to generate a core with the elf headers in case any one
wants to manually test.
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing
Author: Zequan Wu
Date: 2024-11-20T17:19:35-05:00
New Revision: f06c187799d910fd3ac3e9106397e5eecff9f265
URL:
https://github.com/llvm/llvm-project/commit/f06c187799d910fd3ac3e9106397e5eecff9f265
DIFF:
https://github.com/llvm/llvm-project/commit/f06c187799d910fd3ac3e9106397e5eecff9f265.diff
LOG
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/117071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazuki Sakamoto (splhack)
Changes
Addressing two issues on ELF core debugging
1. ProcessElfCore::FindBuidIdInCoreMemory reads wrong address for ELF header
(fixed by @clayborg)
2. DynamicLoader does not use ProcessElfCore NT_FILE entries to
https://github.com/splhack created
https://github.com/llvm/llvm-project/pull/117070
Addressing two issues on ELF core debugging
1. ProcessElfCore::FindBuidIdInCoreMemory reads wrong address for ELF header
(fixed by @clayborg)
2. DynamicLoader does not use ProcessElfCore NT_FILE entries to get
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/5] [Clang] Improve Sema diagnostic performance for
__builtin
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/7] [Clang] Improve Sema diagnostic performance for
__builtin
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/6] [Clang] Improve Sema diagnostic performance for
__builtin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The logic that prints completions and their descriptions assumes neither the
completion itself nor the description ends with a newline. I considered making
this an assert, but decided against it as
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/4] [Clang] Improve Sema diagnostic performance for
__builtin
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/117054
The logic that prints completions and their descriptions assumes neither the
completion itself nor the description ends with a newline. I considered making
this an assert, but decided against it as complet
bwendling wrote:
> > Could you point to a place in the code where it creates a placeholder?
>
> I mean, e.g. `CheckPointerToMemberOperands()` can return `BoundMemberTy` as
> the type of a `.*` expression, and `CreateBuiltinMatrixSubscriptExpr()`
> creates a `MatrixSubscriptExpr` with type `Inc
bwendling wrote:
> The main thing I’m concerned about here is that I feel like there ought to be
> a better way of doing this than checking for and disallowing it in every
> place where we can have a subexpression in C.
Yeah, but we don't have such a method, partially due to the languages Clan
https://github.com/jasonmolenda approved this pull request.
Sorry for the delay, I read the patch quickly yesterday without reading the
description and was a little confused. Read the description and seeing the
test case, I see what this is doing. Looks good to me. I didn't realize the
disc
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/117028
>From 37eccb509ea6468879cf530c6952aab7adec4001 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 20 Nov 2024 10:55:12 -0800
Subject: [PATCH 1/2] Fix loading UUIDs from ELF headers.
A previous patch added
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 012dd8be4b5a4c00deb22345c630990f160b3aa3
37eccb509ea6468879cf530c6952aab7adec4001 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
A previous patch added the ability to load UUID from ELF headers using the
program header and finding PT_NOTE entries. The fix would attempt to read the
data for the PT_NOTE from memory, but it didn't slide
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/117028
A previous patch added the ability to load UUID from ELF headers using the
program header and finding PT_NOTE entries. The fix would attempt to read the
data for the PT_NOTE from memory, but it didn't slide th
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/2] [Clang] Improve Sema diagnostic performance for
__builtin
@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
Author: Adrian Prantl
Date: 2024-11-20T10:07:23-08:00
New Revision: 6473a36edc571cf0734a2e8d4354e332efb170e9
URL:
https://github.com/llvm/llvm-project/commit/6473a36edc571cf0734a2e8d4354e332efb170e9
DIFF:
https://github.com/llvm/llvm-project/commit/6473a36edc571cf0734a2e8d4354e332efb170e9.diff
Author: Jonas Devlieghere
Date: 2024-11-20T10:18:08-08:00
New Revision: 2c63e6d94261d6c9d045523f37f350f9e60ed35b
URL:
https://github.com/llvm/llvm-project/commit/2c63e6d94261d6c9d045523f37f350f9e60ed35b
DIFF:
https://github.com/llvm/llvm-project/commit/2c63e6d94261d6c9d045523f37f350f9e60ed35b.d
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/117019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/117019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
One last diff I missed between Swift and LLVM.
---
Full diff: https://github.com/llvm/llvm-project/pull/117019.diff
2 Files Affected:
- (modified) lldb/include/lldb/API/SBFrame.h (+1-1)
- (modified)
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/117019
One last diff I missed between Swift and LLVM.
>From a91cd8e02b41a3028df671806eb78cb7c5251546 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 20 Nov 2024 09:58:52 -0800
Subject: [PATCH] Make SBFra
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/117012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-11-20T09:43:57-08:00
New Revision: 8f8dcedb007c21412956208e524ff245c0ba5f58
URL:
https://github.com/llvm/llvm-project/commit/8f8dcedb007c21412956208e524ff245c0ba5f58
DIFF:
https://github.com/llvm/llvm-project/commit/8f8dcedb007c21412956208e524ff245c0ba5f58.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Unbeknownst to me the Swift LLDB branch already had an almost identical API
with this name, so it makes sense to merge the two.
---
Full diff: https://github.com/llvm/llvm-project/pull/117012.diff
9
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/117012
Unbeknownst to me the Swift LLDB branch already had an almost identical API
with this name, so it makes sense to merge the two.
>From 92408ce615fe9abdfa69f0e6309a39d9f87a764a Mon Sep 17 00:00:00 2001
From
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
In #108907, the index classes started filtering the DIEs according to
the full type query (instead of just the base name). This means that the checks
in SymbolFileDWARF are now redundant.
I've also moved the
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/116904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-11-20T08:49:07-08:00
New Revision: e660e6503ba14684bd460b7baaf3da7336d0f46e
URL:
https://github.com/llvm/llvm-project/commit/e660e6503ba14684bd460b7baaf3da7336d0f46e
DIFF:
https://github.com/llvm/llvm-project/commit/e660e6503ba14684bd460b7baaf3da7336d0f46e.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/116904
>From ac342fac93ee63c21e0797af5a7c9d6d6088d260 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 19 Nov 2024 17:30:10 -0800
Subject: [PATCH] [lldb] Add an API to derive language-specific runtime
inf
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/116876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/116989
In #108907, the index classes started filtering the DIEs according to the full
type query (instead of just the base name). This means that the checks in
SymbolFileDWARF are now redundant.
I've also moved the no
@@ -137,9 +137,19 @@ void DWARFIndex::GetTypesWithQuery(
bool DWARFIndex::ProcessTypeDIEMatchQuery(
TypeQuery &query, DWARFDIE die,
llvm::function_ref callback) {
- // Nothing to match from query
- if (query.GetContextRef().size() <= 1)
labath wrote:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/116850
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/116838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-11-20T09:09:00+01:00
New Revision: 0394e08bfbb110d606ace49bd10d951eb904e5d6
URL:
https://github.com/llvm/llvm-project/commit/0394e08bfbb110d606ace49bd10d951eb904e5d6
DIFF:
https://github.com/llvm/llvm-project/commit/0394e08bfbb110d606ace49bd10d951eb904e5d6.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/116827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
69 matches
Mail list logo
