[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Dmitrii Galimzianov via lldb-commits
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, if (image_module_sp) { added_modules.AppendIfNeeded(image_module_sp, false); ObjectFile *objfile = image_module_sp->GetObjectFile(); - if (objfile) + i

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -395,7 +394,44 @@ bool ThreadPlanStepRange::SetNextBranchBreakpoint() { m_next_branch_bp_sp->GetID(), bp_site_id, run_to_address.GetLoadAddress(&m_process.GetTarget())); } - +// The "next branch breakpoint might land on

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/114628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/114333 >From c9a4d24f222a70c7c108deebb6c25222893d7159 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 24 Jan 2024 12:42:45 -0800 Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 80b9f07436617d650bdab7035394705f643d1b19 042ac07ed67a5465aaf5c2dc8c4396adf5da2948 --e

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 80b9f07436617d650bdab7035394705f643d1b19...042ac07ed67a5465aaf5c2dc8c4396adf5da2948 lldb/

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes When you set a "next branch breakpoint" and run to it while stepping, you have to claim the stop at that breakpoint to be the top of the inlined call stack, or you will seem to "step in" and then plans might try to

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/114628 When you set a "next branch breakpoint" and run to it while stepping, you have to claim the stop at that breakpoint to be the top of the inlined call stack, or you will seem to "step in" and then plans might

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/114507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114507 >From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 31 Oct 2024 21:42:38 -0700 Subject: [PATCH 1/3] [lldb] Create dependent modules in parallel MIME-Ve

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c820994 - [lldb] Improve locking in PathMappingLists (NFC) (#114576)

2024-11-01 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-01T16:38:14-07:00 New Revision: c8209943faeead43c6932c5ddcc69c9e9d1e4262 URL: https://github.com/llvm/llvm-project/commit/c8209943faeead43c6932c5ddcc69c9e9d1e4262 DIFF: https://github.com/llvm/llvm-project/commit/c8209943faeead43c6932c5ddcc69c9e9d1e4262.d

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs) const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) { if (this != &rhs) { -std::scoped_lock locks(m_mutex, rhs.m_mutex); +std::scoped_lock pairs_locks(m_pairs_m

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, if (image_module_sp) { added_modules.AppendIfNeeded(image_module_sp, false); ObjectFile *objfile = image_module_sp->GetObjectFile(); - if (objfile) -

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114576 >From 9ebfdc84c46a795d35b4dd157573b97a57b232ce Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 1 Nov 2024 09:58:28 -0700 Subject: [PATCH 1/2] [lldb] Improve locking in PathMappingLists (NFC) In

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114610 >From ef1aaf94b52726c77e5569c84c09ecdd73811abd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 1 Nov 2024 15:02:59 -0700 Subject: [PATCH] [lldb] Highlight "note:" in CommandReturnObject We have

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 edited https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Augusto Noronha via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Improve command status when dwim-print has no result (PR #114478)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: @kastiglione Is there a way to turn this into a test? Apparently this works: ``` (lldb) p ; (lldb) ``` https://github.com/llvm/llvm-project/pull/114478 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. I was going to say this is not the right way to do this, but I suppose there isn't really a better mechanism available, since this isn't an error. Otherwise you'd be better off joining a diagnostic error with the note so the UI layer

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/114610 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/114610 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Augusto Noronha via lldb-commits
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) { << "warning: "; } +static llvm::raw_ostream ¬e(Stream &strm) { augusto2112 wrote: Since `note` is a function should it be capitalized to follow the LLDB style? https://github.com/l

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Augusto Noronha via lldb-commits
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) { << "warning: "; } +static llvm::raw_ostream ¬e(Stream &strm) { augusto2112 wrote: Actually `error` and `warning` are not capitalized, I guess we can either keep all three lower cas

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Augusto Noronha via lldb-commits
@@ -110,6 +110,11 @@ class CommandReturnObject { void AppendMessageWithFormat(const char *format, ...) __attribute__((format(printf, 2, 3))); + void AppendNote(llvm::StringRef in_string); + + void AppendNoteWithFormat(const char *format, ...) + __attribute__((fo

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-11-01 Thread Jorge Gorbe Moya via lldb-commits
slackito wrote: Repro was pretty straightforward from the description above. common.cc: ```c++ #include #define XSTR(x) STR(x) #define STR(x) #x namespace NAMESPACE { void DoSomeStuff() { printf("%s::DoSomeStuff()\n", XSTR(NAMESPACE)); } } // end NAMESPACE ``` main.cc: ```c++ namespace

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs) const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) { if (this != &rhs) { -std::scoped_lock locks(m_mutex, rhs.m_mutex); +std::scoped_lock pairs_locks(m_pairs_m

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: It took me some time to read this and think about the implications, but I think this is generally okay. I left 1 comment about the order of lock acquisition for `operator=`. The only way I can see this going wrong is if a callback can mutate the list in

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We have helpers to emit warnings and errors. Do the same thing for notes to they stand out more. --- Full diff: https://github.com/llvm/llvm-project/pull/114610.diff 3 Files Affected: - (modified

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Motivated by #114608 https://github.com/llvm/llvm-project/pull/114610 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/114610 We have helpers to emit warnings and errors. Do the same thing for notes to they stand out more. >From 155396aa89fd418268cfcf8d054849c67bf1207e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri,

[Lldb-commits] [lldb] [llvm] [LLDB] Add a target.launch-working-dir setting (PR #113521)

2024-11-01 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/113521 >From 819380f93381eff8200c7eb9c55372f9a840c379 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 24 Oct 2024 00:17:48 -0400 Subject: [PATCH] [LLDB] Add a target.launch-working-dir setting Inte

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
kastiglione wrote: I will cherry-pick this downstream to swiftlang/llvm-project too. https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. Nice! This code lives upstream though so you'll need to open a patch there too https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/114608.diff 1 Files Affected: - (modified) lldb/source/Commands/CommandObjectDWIMPrint.cpp (+8-8) ``diff diff --git a/lldb/source/Command

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/114608 None >From e244e4557a618c6d532f9d369624234ad739cf11 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 1 Nov 2024 14:38:19 -0700 Subject: [PATCH] [lldb] Avoid unnecessary regex check in dwim-print --- lld

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-11-01 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/113508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c1df376 - [LLDB] Finish implementing support for DW_FORM_data16 (#113508)

2024-11-01 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-11-01T17:33:08-04:00 New Revision: c1df376b0c8b3edbb6c5ad3fb6ebf39e75b5ad88 URL: https://github.com/llvm/llvm-project/commit/c1df376b0c8b3edbb6c5ad3fb6ebf39e75b5ad88 DIFF: https://github.com/llvm/llvm-project/commit/c1df376b0c8b3edbb6c5ad3fb6ebf39e75b5ad88.di

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-11-01 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/113508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2bd21b2 - [lldb] Improve command status when dwim-print has no result (#114478)

2024-11-01 Thread via lldb-commits
Author: Dave Lee Date: 2024-11-01T13:39:14-07:00 New Revision: 2bd21b26e26e5a4b962307d30c8e6279b464bf02 URL: https://github.com/llvm/llvm-project/commit/2bd21b26e26e5a4b962307d30c8e6279b464bf02 DIFF: https://github.com/llvm/llvm-project/commit/2bd21b26e26e5a4b962307d30c8e6279b464bf02.diff LOG:

[Lldb-commits] [lldb] [lldb] Improve command status when dwim-print has no result (PR #114478)

2024-11-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/114478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-11-01 Thread Jorge Gorbe Moya via lldb-commits
slackito wrote: Hi, I'm having some problems with one of our tests, that also reproduce after [#114337](https://github.com/llvm/llvm-project/pull/114337). I don't have a repro yet but I'll describe what I know of the problem so far in case it rings a bell. The test in question has a common s

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-11-01 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: I was able to make it work using @labath 's suggestion. Fortunately it just works. Please give it another look :) https://github.com/llvm/llvm-project/pull/113508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-11-01 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/113508 >From dce501d494a3d559d490f8d58f6918b63ed9d175 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Wed, 23 Oct 2024 19:49:24 -0400 Subject: [PATCH 1/2] [LLDB] Finish implementing support for DW_FORM_d

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-11-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0cfcd38 - [lldb][NativePDB] Parse global variables. (#114303)

2024-11-01 Thread via lldb-commits
Author: Zequan Wu Date: 2024-11-01T14:15:54-04:00 New Revision: 0cfcd387f968f2c9de0648673b5db9e221e5c84e URL: https://github.com/llvm/llvm-project/commit/0cfcd387f968f2c9de0648673b5db9e221e5c84e DIFF: https://github.com/llvm/llvm-project/commit/0cfcd387f968f2c9de0648673b5db9e221e5c84e.diff LOG

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-11-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable automatically opening editor for TestSessionSave (PR #114469)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/114469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c3782f6 - [lldb] Disable automatically opening editor for TestSessionSave (#114469)

2024-11-01 Thread via lldb-commits
Author: Alex Langford Date: 2024-11-01T11:12:29-07:00 New Revision: c3782f67daf462f6b289b5898cb65c61f64c197d URL: https://github.com/llvm/llvm-project/commit/c3782f67daf462f6b289b5898cb65c61f64c197d DIFF: https://github.com/llvm/llvm-project/commit/c3782f67daf462f6b289b5898cb65c61f64c197d.diff

[Lldb-commits] [lldb] 16a6c10 - [lldb] Fix warning: comparison of integers of different signs

2024-11-01 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-01T11:06:18-07:00 New Revision: 16a6c10bd485979ba2edf4b487d633230a9df01f URL: https://github.com/llvm/llvm-project/commit/16a6c10bd485979ba2edf4b487d633230a9df01f DIFF: https://github.com/llvm/llvm-project/commit/16a6c10bd485979ba2edf4b487d633230a9df01f.d

[Lldb-commits] [lldb] f33b5b7 - [lldb] INSTANTIATE_TEST_CASE_P -> INSTANTIATE_TEST_SUITE_P

2024-11-01 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-01T11:03:19-07:00 New Revision: f33b5b79372c7a46e2e6b89a314bce0009bf4ab7 URL: https://github.com/llvm/llvm-project/commit/f33b5b79372c7a46e2e6b89a314bce0009bf4ab7 DIFF: https://github.com/llvm/llvm-project/commit/f33b5b79372c7a46e2e6b89a314bce0009bf4ab7.d

[Lldb-commits] [lldb] d6a1501 - [lldb] Skip TestDAP_completions on older versions of libcxx

2024-11-01 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2024-11-01T08:55:23-07:00 New Revision: d6a150137773bd1d104aa5a1847863a5138f14d9 URL: https://github.com/llvm/llvm-project/commit/d6a150137773bd1d104aa5a1847863a5138f14d9 DIFF: https://github.com/llvm/llvm-project/commit/d6a150137773bd1d104aa5a1847863a51

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, if (image_module_sp) { added_modules.AppendIfNeeded(image_module_sp, false); ObjectFile *objfile = image_module_sp->GetObjectFile(); - if (objfile) + i

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114507 >From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 31 Oct 2024 21:42:38 -0700 Subject: [PATCH 1/3] [lldb] Create dependent modules in parallel MIME-Ve

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The test failures were both caused by the locking in `PathMappingList`, which I'm addressing in #114576. https://github.com/llvm/llvm-project/pull/114507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes In D148380 [1], Alex added locking to PathMappingLists. The current implementation runs the callback under the lock, which I don't believe is necessary. As far as I can tell, no users of the callbac

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/114576 In D148380 [1], Alex added locking to PathMappingLists. The current implementation runs the callback under the lock, which I don't believe is necessary. As far as I can tell, no users of the callback are r

[Lldb-commits] [lldb] [lldb][test] Fix `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-11-01 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > > It's interesting that the 17.0 bot is still not happy: > > ``` > > > > File > > "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", > > line 321, in check_value > > > > test_base.assertEqu

[Lldb-commits] [lldb] [lldb][test] Fix `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-11-01 Thread Michael Buch via lldb-commits
Michael137 wrote: > It's interesting that the 17.0 bot is still not happy: > > > > ``` > > File > "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", > line 321, in check_value > > test_base.assertEqual( > > As

[Lldb-commits] [lldb] [lldb][test] Fix `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-11-01 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: It's interesting that the 17.0 bot is still not happy: ``` File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 321, in check_value test_base.assertEqual( AssertionError: '"Hello"' !=

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
Michael137 wrote: Example constructor decl would look like the following: ``` | `-CXXConstructorDecl 0x246e6f8 <> Bar 'void ()' | `-StructorMangledNamesAttr 0x246e7c0 <> Implicit 2:$__lldb_func_0x014B6560:257 1:$__lldb_func_0x014B6560:294 ``` https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-01 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/5] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/114529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/114529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix pointer to reference type (PR #113596)

2024-11-01 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: FWIW, codelldb also dereferences pointers and references when displaying values. They [provide a user-facing setting](https://github.com/vadimcn/codelldb/blob/v1.10.0/MANUAL.md#pointers) for it and [implement it in the debug adapter](https://github.com/vadimcn/codelldb/blo

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/114529 >From 7f18d96b7117e83c4ed246ac498ee4c9a72064ff Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 20 Oct 2024 11:35:15 +0100 Subject: [PATCH] [WIP][lldb][Expression] More reliable function call resolutio

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/114529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/114529 >From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 20 Oct 2024 11:35:15 +0100 Subject: [PATCH] [WIP][lldb][Expression] More reliable function call resolutio

[Lldb-commits] [lldb] [lldb][test] Skip one inline stepping test for arm-ubuntu. (PR #114295)

2024-11-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: dwarfdump: [arm_dwarfdump.txt](https://github.com/user-attachments/files/17598949/arm_dwarfdump.txt) (this doesn't seem different to what AArch64 produces) objdump: [arm_objdump.txt](https://github.com/user-attachments/files/17598953/arm_objdump.txt) stepping log: [arm_st

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
@@ -140,6 +141,64 @@ void MangleContext::mangleName(GlobalDecl GD, raw_ostream &Out) { const ASTContext &ASTContext = getASTContext(); const NamedDecl *D = cast(GD.getDecl()); + if (const StructorMangledNamesAttr *SMA = + D->getAttr()) { +CXXConstructorDecl

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/114529 Naive implementation of all the parts of following RFC: https://discourse.llvm.org/t/rfc-lldb-handling-abi-tagged-constructors-destructors-in-expression-evaluator/82816 Main changes: 1. Instead of relying on

[Lldb-commits] [lldb] [lldb][test] Skip libc++ tests if it is linked statically (PR #113935)

2024-11-01 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Agree with Pavel. > > I'm not sure you do :P > > > > When libcxx is linked with a program as an archive of static libraries, > > > functions that aren't used in the program are omitted. > > > > > > This really isn't the problem. The tests _want_ those symbols to not be

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/114507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Jason Molenda via lldb-commits
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, if (image_module_sp) { added_modules.AppendIfNeeded(image_module_sp, false); ObjectFile *objfile = image_module_sp->GetObjectFile(); - if (objfile) + i