[Lldb-commits] [lldb] [lldb] Add a fuzzer for the DWARF Expression Evaluator (PR #114286)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114286 >From cb898b4f2f0cedfa7674f5b5cdcf2963dce377e4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Oct 2024 11:22:20 -0700 Subject: [PATCH 1/2] [lldb] Add a fuzzer for the DWARF Expression Evalua

[Lldb-commits] [lldb] [lldb] Use PY_VERSION_HEX to simplify conditional compilation (NFC) (PR #114346)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use PY_VERSION_HEX to simplify conditional compilation depending on the Python version. This also adds a static_assert to lldb-python to error out with a meaningful diagnostic when you try building

[Lldb-commits] [lldb] [lldb] Use PY_VERSION_HEX to simplify conditional compilation (NFC) (PR #114346)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/114346 Use PY_VERSION_HEX to simplify conditional compilation depending on the Python version. This also adds a static_assert to lldb-python to error out with a meaningful diagnostic when you try building LLDB w

[Lldb-commits] [lldb] 75aaa31 - [lldb] Fix formatting and whitespace in ScriptInterpreterPython (NFC)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-30T20:33:28-07:00 New Revision: 75aaa312ffa9aa044b84bd1b32491937795c110a URL: https://github.com/llvm/llvm-project/commit/75aaa312ffa9aa044b84bd1b32491937795c110a DIFF: https://github.com/llvm/llvm-project/commit/75aaa312ffa9aa044b84bd1b32491937795c110a.d

[Lldb-commits] [lldb] de7ad6b - [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (#114112)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-30T18:48:43-07:00 New Revision: de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8 URL: https://github.com/llvm/llvm-project/commit/de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8 DIFF: https://github.com/llvm/llvm-project/commit/de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8.d

[Lldb-commits] [lldb] 3243e3d - Fix stepping away from the bottom-most frame of a virtual inlined call stack. (#114337)

2024-10-30 Thread via lldb-commits
Author: jimingham Date: 2024-10-30T18:26:38-07:00 New Revision: 3243e3d8872585091d65ea7ff0639155b4c1dd7a URL: https://github.com/llvm/llvm-project/commit/3243e3d8872585091d65ea7ff0639155b4c1dd7a DIFF: https://github.com/llvm/llvm-project/commit/3243e3d8872585091d65ea7ff0639155b4c1dd7a.diff LOG

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/114337 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
jimingham wrote: This is a fairly uncontroversial patch, and fixes a breakage in the dexter tests (part of the "cross-project-tests"). So I'm going to push this now even though folks haven't had a chance to review it yet. https://github.com/llvm/llvm-project/pull/114337 __

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f582cd3dc70fa8c9519f74f16ab0a33ad663038e...48c51370545165095867c480ddf8b7fdbb312630 lldb/

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114337 >From 48c51370545165095867c480ddf8b7fdbb312630 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 30 Oct 2024 17:18:39 -0700 Subject: [PATCH 1/3] Fix stepping away from the bottom-most frame of a virtual in

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114337 >From 48c51370545165095867c480ddf8b7fdbb312630 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 30 Oct 2024 17:18:39 -0700 Subject: [PATCH 1/2] Fix stepping away from the bottom-most frame of a virtual in

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-30 Thread John Harrison via lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) { } } +// "BreakpointLocationsRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +// "description": "The `breakpointLocations` request returns all poss

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-30 Thread via lldb-commits
jimingham wrote: That's fixed in: https://github.com/llvm/llvm-project/pull/114337 Fix stepping away from the bottom-most frame of a virtual inlined call stack. by jimingham · Pull Request #114337 · llvm/llvm-project github.com which is waiting on review. Would have fixed this sooner but d

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f582cd3dc70fa8c9519f74f16ab0a33ad663038e 48c51370545165095867c480ddf8b7fdbb312630 --e

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The computation of 'Thread::IsVirtualStep" was wrong - it called being at the bottom of a virtual call stack a "virtual step" but that is actually when you've gotten to concrete code and need to step for real. I a

[Lldb-commits] [lldb] Fix stepping away from the bottom-most frame of a virtual inlined call stack. (PR #114337)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/114337 The computation of 'Thread::IsVirtualStep" was wrong - it called being at the bottom of a virtual call stack a "virtual step" but that is actually when you've gotten to concrete code and need to step for real

[Lldb-commits] [lldb] Fix stepping away from the bottom most level of the inline call stack (PR #114335)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/114335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix stepping away from the bottom most level of the inline call stack (PR #114335)

2024-10-30 Thread via lldb-commits
jimingham wrote: I have to redo this, the repo I started from had an older change as well. https://github.com/llvm/llvm-project/pull/114335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes Compared to the python version, this also does type checking and error handling, so it's slightly longer, however, it's still comfortably under 500 lines. See https://discourse.llvm.org/t/a-bytecode-for

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/114333 Compared to the python version, this also does type checking and error handling, so it's slightly longer, however, it's still comfortably under 500 lines. See https://discourse.llvm.org/t/a-bytecode-for-ll

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-30 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/114122 >From 00d136ed33cdc4362f7f23804ee184ddb1fb2539 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 29 Oct 2024 20:23:13 + Subject: [PATCH 1/2] [lldb][test] Skip `LibCxxInternalsRecognizerTestC

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-30 Thread via lldb-commits
dyung wrote: @jimingham your change is causing two cross-project-test failures, can you take a look or revert if you need time to investigate? https://github.com/llvm/llvm-project/pull/114158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] 3a782ef - [lldb] Add a link to LLDB's Discord channel on the website (#114289)

2024-10-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-30T15:47:48-07:00 New Revision: 3a782ef97de771af9fd565e0043d49bdd0f2c850 URL: https://github.com/llvm/llvm-project/commit/3a782ef97de771af9fd565e0043d49bdd0f2c850 DIFF: https://github.com/llvm/llvm-project/commit/3a782ef97de771af9fd565e0043d49bdd0f2c850.d

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-10-30 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Looking at this again. The last issue that I needed to investigate was Martin's mingw testsuite that had a regression when I landed it. The test program was https://github.com/mstorsjo/llvm-mingw/blob/master/test/hello-exception.cpp and when run ``` bin/lldb -x -b -o 'b

[Lldb-commits] [lldb] [lldb] Add a link to LLDB's Discord channel on the website (PR #114289)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/114289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Zequan Wu (ZequanWu) Changes This is the second half of https://github.com/llvm/llvm-project/pull/90008. Essentially, it replaces the work of resolving template types when we just need the qualified names with walking the DIE tree usi

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This is the second half of https://github.com/llvm/llvm-project/pull/90008. Essentially, it replaces the work of resolving template types when we just need the qualified names with walking the DIE tree using `D

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu ready_for_review https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-30 Thread Dave Lee via lldb-commits
@@ -621,6 +623,9 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommand( pfunc(debugger_arg, PythonString(args), SWIGBridge::ToSWIGWrapper(std::move(exe_ctx_ref_sp)), cmd_retobj_arg.obj(), dict); + if (PyErr_Occurred()) kastiglion

[Lldb-commits] [lldb] f7c36d2 - [lldb] Fix API test for file redirection to existing files (#114119)

2024-10-30 Thread via lldb-commits
Author: Wanyi Date: 2024-10-30T17:00:40-04:00 New Revision: f7c36d2f88e05a1747fa7916ad2fefdd9d459a55 URL: https://github.com/llvm/llvm-project/commit/f7c36d2f88e05a1747fa7916ad2fefdd9d459a55 DIFF: https://github.com/llvm/llvm-project/commit/f7c36d2f88e05a1747fa7916ad2fefdd9d459a55.diff LOG: [l

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-30 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/114119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This doesn't parse S_CONSTANT case yet, because I found that `std::strong_ordering::equal` being a S_CONSTANT and has type of LF_STRUCTURE which is not currently handled when creating dwarf expression for the v

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/114303 This doesn't parse S_CONSTANT case yet, because I found that `std::strong_ordering::equal` being a S_CONSTANT and has type of LF_STRUCTURE which is not currently handled when creating dwarf expression for the

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-30 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/114119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread David Spickett via lldb-commits
@@ -92,7 +92,38 @@ namespace { struct InitializePythonRAII { public: InitializePythonRAII() { -InitializePythonHome(); +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +PyConfig config; +PyConfig_InitPythonConfig(&config); +#endif +

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/114112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Skip one inline stepping test for arm-ubuntu. (PR #114295)

2024-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 5545f76dc94e76ef6800823bdd1e107ad2264717...effa929cd73cde63e31dbedf8c5fadcb767aae37 lldb/

[Lldb-commits] [lldb] Skip one inline stepping test for arm-ubuntu. (PR #114295)

2024-10-30 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114295 >From c152f18b0c0436891eeb172700a4b7b84e5a0a1c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 30 Oct 2024 12:41:52 -0700 Subject: [PATCH 1/2] Skip one inline stepping test for arm-ubuntu. The test is cu

[Lldb-commits] [lldb] [lldb] Add a fuzzer for the DWARF Expression Evaluator (PR #114286)

2024-10-30 Thread Alex Langford via lldb-commits
@@ -0,0 +1,34 @@ +set(LLVM_LINK_COMPONENTS + Support + ) + +add_llvm_fuzzer(lldb-dwarf-expression-fuzzer + EXCLUDE_FROM_ALL + lldb-dwarf-expression-fuzzer.cpp + ) + +include_directories(${LLDB_SOURCE_ROOT}) bulbazord wrote: suggestion: Use `target_include_di

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-30 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Nevermind, 74e1554d7b4013a975cf5fb8df64a6419bb14a45 already fixed this, I was a bit behind trunk in my last test https://github.com/llvm/llvm-project/pull/112109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Add a link to LLDB's Discord channel on the website (PR #114289)

2024-10-30 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/114289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a link to LLDB's Discord channel on the website (PR #114289)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/114289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,63 @@ +; Test finding types by CompilerContext. +; REQUIRES: aarch64 +; RUN: llc %s -filetype=obj -o %t.o +; RUN: lldb-test symbols %t.o -find=type --mangled-name=UniqueDifferentName | FileCheck %s +; +; NORESULTS: Found 0 types +; CHECK: Found 1 types: +; CHECK: stru

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: Ok, I was able to add a test https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] eac2c18 - Remove a flaky and unnecessary check (#114251)

2024-10-30 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-10-30T08:59:08-07:00 New Revision: eac2c182c6f852fc187af9952250a43d6fb17b28 URL: https://github.com/llvm/llvm-project/commit/eac2c182c6f852fc187af9952250a43d6fb17b28 DIFF: https://github.com/llvm/llvm-project/commit/eac2c182c6f852fc187af9952250a43d6fb17b28.diff

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/112596 >From 0ff6ba499bcb04581cf5b77780f769bee05e4aef Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Sat, 28 Sep 2024 15:05:37 -0700 Subject: [PATCH 1/3] Add support for reading the dynamic symbol table from progr

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/113007 >From 7fc51bb1a812c5dd1bef8d96b51a17ff02eb23fc Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Tue, 22 Oct 2024 14:34:44 -0700 Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-30 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 6 "test-build-unified-tree-check-cross-project". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/bui

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Thanks! https://github.com/llvm/llvm-project/pull/114161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Can you add a test (perhaps using lldb-test and a .ll or .s file)? https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-30 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. beautiful https://github.com/llvm/llvm-project/pull/113787 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-30 Thread Walter Erquinigo via lldb-commits
@@ -281,12 +270,11 @@ def test_clear_breakpoints_unset_breakpoints(self): self.assertEqual( len(breakpoints), len(lines), "expect %u source breakpoints" % (len(lines)) ) -for breakpoint, index in zip(breakpoints, range(len(lines))): +

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-30 Thread Walter Erquinigo via lldb-commits
@@ -238,9 +238,10 @@ def set_global(self, name, value, id=None): def stepIn( self, threadId=None, targetId=None, waitForStop=True, granularity="statement" ): -self.dap_server.request_stepIn( +response = self.dap_server.request_stepIn(

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-10-30 Thread Walter Erquinigo via lldb-commits
@@ -165,6 +172,11 @@ .long .Lulong_ptr-.Lcu_begin0 # DW_AT_type .uleb128 0xdeadbeefbaadf00d # DW_AT_const_value +.byte 18 # Abbrev DW_TAG_variable +.asciz "data16"# DW_AT_name +.long .Lu128

[Lldb-commits] [lldb] Fix pointer to reference type (PR #113596)

2024-10-30 Thread via lldb-commits
jeffreytan81 wrote: I haven't had time to look into your example in details. But to share high level context about the bug behavior, we have observed cases that, there is real world scenarios using `std::vector&` object, which data formatters, and "v obj" reports this vector "size=13", but th

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-30 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 6 "test-build-unified-tree-check-cross-project". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/768

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
@@ -92,7 +92,38 @@ namespace { struct InitializePythonRAII { public: InitializePythonRAII() { -InitializePythonHome(); +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +PyConfig config; +PyConfig_InitPythonConfig(&config); +#endif +

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112582 >From de19f43fbee9aff2a99106a23b7f264012ab5485 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 21 Oct 2024 13:40:02 -0700 Subject: [PATCH 1/2] [lldb] Use LLVM's helper for Unicode conversion (NF

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,42 @@ +// This test verifies that loading an ELF file that has no section headers can +// load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or +// the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC +// segment. + +// RUN: llv

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-30 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > Sorry to clarify. I think based on @felipepiovezan comment here: [#108870 > (comment)](https://github.com/llvm/llvm-project/pull/108870#issuecomment-281588) > > On Clang 17 we compile fine, just the assertion fails to find the expected > function name (because of th

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Think the intention was to originally make sure that we're debugging libc++. Checking this here is unnecessary (and should really be asserted at the Makefile layer, which do on Apple platforms) https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. --- Full diff: https://github.com/llvm/llvm-project/pull/114251.dif

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/114251 The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. >From 553d4742e6972a068105177aafd47b3da2c01d8f Mon Sep 17 00:00:00 200

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/114112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 45f420e - [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (#114112)

2024-10-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-30T08:41:30-07:00 New Revision: 45f420e34476d2963e13b2f916be1e5a73ec95ae URL: https://github.com/llvm/llvm-project/commit/45f420e34476d2963e13b2f916be1e5a73ec95ae DIFF: https://github.com/llvm/llvm-project/commit/45f420e34476d2963e13b2f916be1e5a73ec95ae.d

[Lldb-commits] [lldb] [llvm] [DebugInfo] Add explicit visibility macros to CodeView template functions (PR #113102)

2024-10-30 Thread Pavel Labath via lldb-commits
labath wrote: The lldb change looks good (you can submit that in its own patch without a review), but you'll probably want to find a different reviewer for the codeview part (I have no idea who's responsible for that these days). https://github.com/llvm/llvm-project/pull/113102 ___

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -1574,25 +1584,23 @@ bool Editline::CompleteCharacter(char ch, EditLineGetCharType &out) { out = (unsigned char)ch; return true; #else - LLDB_DEPRECATED_WARNING_DISABLE - std::codecvt_utf8 cvt; - LLDB_DEPRECATED_WARNING_RESTORE llvm::SmallString<4> input; for (

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -12,6 +12,8 @@ #include "lldb/Host/Editline.h" +#include labath wrote: I guess this is not needed now (?) https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

2024-10-30 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix pointer to reference type (PR #113596)

2024-10-30 Thread Pavel Labath via lldb-commits
labath wrote: Let's back up a bit. Before this patch, both the ValueObject class and the "frame var" command treated references essentially as pointers (in the example, `xp` is a pointer to `x` and `xpr` is a reference to `xp`): ``` (lldb) v *x x &x (int) ::x = 47 (int *) &::x = 0x8

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114112 >From c58438160c016841c6a72e53cd5c4985ebd1e521 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 29 Oct 2024 11:19:33 -0700 Subject: [PATCH 1/3] [lldb] Use Py_InitializeFromConfig with Python >= 3

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread David Spickett via lldb-commits
@@ -117,15 +148,22 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +config.install_signal_handlers = 0; +Py_InitializeFromConfig(&config); +

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
@@ -117,15 +148,22 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +config.install_signal_handlers = 0; +Py_InitializeFromConfig(&config); +

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -165,6 +172,11 @@ .long .Lulong_ptr-.Lcu_begin0 # DW_AT_type .uleb128 0xdeadbeefbaadf00d # DW_AT_const_value +.byte 18 # Abbrev DW_TAG_variable +.asciz "data16"# DW_AT_name +.long .Lu128

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,42 @@ +// This test verifies that loading an ELF file that has no section headers can +// load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or +// the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC +// segment. + +// RUN: llv

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,42 @@ +// This test verifies that loading an ELF file that has no section headers can +// load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or +// the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC +// segment. + +// RUN: llv

[Lldb-commits] [lldb] Fix the sort function for languages to have "strict weak ordering". (PR #114160)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/114160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Michael Buch via lldb-commits
Michael137 wrote: > @Michael137 I wasn't able to run `yaml2obj` to convert back an object file > that contains debug info, I'm not sure if the issue is that `yaml2obj` > doesn't support something that's encoded in the debug info, or some bug with > MachO. > > This is the error: > > ``` > err

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Michael Buch via lldb-commits
@@ -2758,6 +2758,20 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { return true; // Keep iterating over index types, language mismatch. } +// Since mangled names are unique, we only need to check if the names are +// the

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread Pavel Labath via lldb-commits
@@ -117,15 +148,22 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +config.install_signal_handlers = 0; +Py_InitializeFromConfig(&config); +

[Lldb-commits] [lldb] [LLDB] Add a target.launch-working-dir setting (PR #113521)

2024-10-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: `launch-working-dir` sounds like `working-dir` to me. Do we need the `launch` prefix? Should this be `target.process` not `target`? This issue could be re-stated as "a process launched with -w does not use the same working dir if run again". Which I think is certainly unex

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-30 Thread David Spickett via lldb-commits
@@ -117,15 +148,22 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3) +config.install_signal_handlers = 0; +Py_InitializeFromConfig(&config); +