https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111951
>From e027444340be4020002126da0d2c8a705c2c7e3f Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Thu, 10 Oct 2024 20:27:10 -0700
Subject: [PATCH] [lldb] Speed up FindInMemory tests
A memory region can be rela
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1809d0fa1c15b16ca94381d8be3ef70c4a83c36b...6ea11737a9edbf1a1be413c2eaa7075438effb05
lldb/
https://github.com/igorkudrin edited
https://github.com/llvm/llvm-project/pull/111951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
A memory region can be relatively large. Searching for a value in the entire
region is time-consuming, especially when running tests against a remote
target, because the memory data is transferred in small
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/111951
A memory region can be relatively large. Searching for a value in the entire
region is time-consuming, especially when running tests against a remote
target, because the memory data is transferred in small c
emrekultursay wrote:
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/111237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DmT021 wrote:
> I was playing with the performance in a couple of different scenarios. For
> some reason that I haven't looked into, we're getting less parallelism when
> many of the binaries are in the shared cache in lldb. Maybe there is locking
> around the code which finds the binary in ll
adrian-prantl wrote:
> > Looks good, I guess. Is that constructor even necessary, given that it just
> > forwards the argument to the base class, and we already have the forwarding
> > `using` declaration?
>
> The constructor looks redundant at the moment, perhaps it is just a legacy
> from t
@@ -160,6 +166,9 @@ class CommandReturnObject {
StreamTee m_out_stream;
StreamTee m_err_stream;
+ std::vector m_diagnostics;
+ StreamString m_diag_stream;
+ std::optional m_diagnostic_indent;
adrian-prantl wrote:
Because DiagnostcDetails are created in
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From e13c841a6452ae5b0cfae129764dc95d6ac29e09 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
@@ -5,22 +5,21 @@
import os
HEADER = """\
-//===-- SBLanguages.h -*- C++ -*-===//
+//===-- SourceLanguageNames.h ---*- C++
-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLV
https://github.com/chelcassanova commented:
This looks good to me and I agree with the original feedback that led to this
change in the first place, though I'll also wait for any comments Adrian might
have.
https://github.com/llvm/llvm-project/pull/111929
__
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> This looks better to me. I'm not sure why we were using defines from
> llvm::DWARF that seem to overlap the ones here, however. So I'll defer to
> Adrian or someone more knowledgeable about that side of things.
Yeah, that wasn't clear to me either, why didn't we just use
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch moves `SBLanguages.h` out of the API tree. This file gets generated
at build time using DWARF table-gen file and contains an enumeration of the
DWARF supported source language names and
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/111929
This patch moves `SBLanguages.h` out of the API tree. This file gets generated
at build time using DWARF table-gen file and contains an enumeration of the
DWARF supported source language names and there re
jimingham wrote:
> On Oct 10, 2024, at 4:14 PM, Alex Langford ***@***.***> wrote:
>
>
> My mental model is that everything in lldb-enumerations.h should be public
> and all the private enumerations should go in lldb-private-enumerations.h. In
> practice I think there are tons of things in l
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Jason Molenda
Date: 2024-10-10T16:24:38-07:00
New Revision: a28e7ce378d717e6aacbdc3089974b93b6b62948
URL:
https://github.com/llvm/llvm-project/commit/a28e7ce378d717e6aacbdc3089974b93b6b62948
DIFF:
https://github.com/llvm/llvm-project/commit/a28e7ce378d717e6aacbdc3089974b93b6b62948.diff
Author: Jason Molenda
Date: 2024-10-10T16:24:38-07:00
New Revision: 4f320778148ba481881eb53ba065ed2a9d9bbc03
URL:
https://github.com/llvm/llvm-project/commit/4f320778148ba481881eb53ba065ed2a9d9bbc03
DIFF:
https://github.com/llvm/llvm-project/commit/4f320778148ba481881eb53ba065ed2a9d9bbc03.diff
bulbazord wrote:
My mental model is that everything in `lldb-enumerations.h` should be public
and all the private enumerations should go in `lldb-private-enumerations.h`. In
practice I think there are tons of things in `lldb-enumerations.h` that should
not be public at all, but I'm not sure wh
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-10-10T16:08:19-07:00
New Revision: c686eeb7fcc89673909e7e1f0a0a09a0da269d28
URL:
https://github.com/llvm/llvm-project/commit/c686eeb7fcc89673909e7e1f0a0a09a0da269d28
DIFF:
https://github.com/llvm/llvm-project/commit/c686eeb7fcc89673909e7e1f0a0a09a0da269d28.diff
Author: Jonas Devlieghere
Date: 2024-10-10T16:08:19-07:00
New Revision: fae7d6848bbb59fc2bad17adbdb34bd6a11a0651
URL:
https://github.com/llvm/llvm-project/commit/fae7d6848bbb59fc2bad17adbdb34bd6a11a0651
DIFF:
https://github.com/llvm/llvm-project/commit/fae7d6848bbb59fc2bad17adbdb34bd6a11a0651.d
Author: Robert O'Callahan
Date: 2024-10-10T16:08:19-07:00
New Revision: 4f297566b3150097de26c6a23a987d2bd5fc19c5
URL:
https://github.com/llvm/llvm-project/commit/4f297566b3150097de26c6a23a987d2bd5fc19c5
DIFF:
https://github.com/llvm/llvm-project/commit/4f297566b3150097de26c6a23a987d2bd5fc19c5.d
https://github.com/jimingham commented:
This layering seems wrong to me. If you put an SB header in
lldb-enumerations.h, then you are pretty much including it in all of lldb. But
SB defines should really only be used in include/lldb/API and source/API.
Note, SBLanguages.h itself seems wrong t
chelcassanova wrote:
I was going to fix the dependency issue here to make sure that SBLanguages gets
generated before trying to build any of these targets, but talking with
@jimingham, this shouldn't have been included at all as `lldb-enumerations`
shouldn't be exposed to any SB layer componen
https://github.com/mentlerd updated
https://github.com/llvm/llvm-project/pull/111892
>From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001
From: David Mentler
Date: Mon, 7 Oct 2024 21:46:50 +0200
Subject: [PATCH 1/7] Make existing tests break
---
.../data-formatter-stl/libcx
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/109477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-10-10T15:59:51-07:00
New Revision: e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
URL:
https://github.com/llvm/llvm-project/commit/e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
DIFF:
https://github.com/llvm/llvm-project/commit/e9c8f75d45ababe7f805078bbf7bda2e7425f1b7.diff
@@ -0,0 +1,11 @@
+# RUN: echo quit | %lldb -o "log enable -x" \
adrian-prantl wrote:
Thanks! Indeed, there's bug there.
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/igorkudrin edited
https://github.com/llvm/llvm-project/pull/111237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
To clone an error, do Status::FromError(error). Every call to Status::toError()
clones the error (as opposed to takeError()). Generally we want to avoid
cloning errors though.
https://github.com/llvm/llvm-project/pull/111911
___
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
igorkudrin wrote:
So the test basically shows that it makes sense to set `use-source-cache` to
`false` on Windows, otherwise the source file will be locked for editing.
Windows 11 seems to allow deleting mmaped files, so we need to try opening the
file for writing to re-enable the test. Thanks
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
JDevlieghere wrote:
I considered *always* logging to the system log, but copying errors is a bit
tricky. I could reuse the logic that Adrian added to status, but wanted to
gather your input. Regardless, I tried this out locally by debugging the
`count` tool and this already reported a bunch of
augusto2112 wrote:
I reverted both this commit and also
https://github.com/llvm/llvm-project/commit/b77fdf5799be6b29869f2f7969851709e03938ba,
so you'll need to add that change to your commit before merging again.
https://github.com/llvm/llvm-project/pull/99736
_
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: 2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
URL:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
DIFF:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9.dif
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: f02252e1fd2965db007cf7be74c448b7a119c321
URL:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321
DIFF:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321.dif
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1809d0fa1c15b16ca94381d8be3ef70c4a83c36b...ef848fd2c7de9483cfe2cb0286a20df0a2005f97
lldb/
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/2] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Log errors to the (always-on) system log if they would otherwise get dropped by
LLDB_LOG_ERROR and LLDB_LOG_ERRORV.
---
Full diff: https://github.com/llvm/llvm-project/pull/111911.diff
3 Files Aff
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/111911
Log errors to the (always-on) system log if they would otherwise get dropped by
LLDB_LOG_ERROR and LLDB_LOG_ERRORV.
>From 55eab57c695d4be99305d2b6cee0c4f44261a473 Mon Sep 17 00:00:00 2001
From: Jonas Devli
Author: Jason Molenda
Date: 2024-10-10T14:50:34-07:00
New Revision: c99b36554745837c549e1b46cd60db70588affcf
URL:
https://github.com/llvm/llvm-project/commit/c99b36554745837c549e1b46cd60db70588affcf
DIFF:
https://github.com/llvm/llvm-project/commit/c99b36554745837c549e1b46cd60db70588affcf.diff
vvereschaka wrote:
@chelcassanova `lldb/API/SBLanguages.h` is generated file. I suppose its
generation must be enabled for the `lldb-server` target in that case; otherwise
we get the following build errors:
```
In file included from
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/l
augusto2112 wrote:
I'll revert it!
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
I don't know what your normal protocol is but maybe you should revert it while
I debug the failure?
The last successful CI run in this PR was from September 25.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailin
augusto2112 wrote:
Looks like `TestReverseContinueBreakpoints.py` is failing on the bots
(https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/13228/console)
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
https://github.com/mentlerd updated
https://github.com/llvm/llvm-project/pull/111892
>From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001
From: David Mentler
Date: Mon, 7 Oct 2024 21:46:50 +0200
Subject: [PATCH 1/5] Make existing tests break
---
.../data-formatter-stl/libcx
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-10-10T13:11:46-07:00
New Revision: b3554265f24aa570bbc8693af8420a306c459f94
URL:
https://github.com/llvm/llvm-project/commit/b3554265f24aa570bbc8693af8420a306c459f94
DIFF:
https://github.com/llvm/llvm-project/commit/b3554265f24aa570bbc8693af8420a306c459f94.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/111882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-10T13:11:08-07:00
New Revision: 69b0b7e7ac3adc42df517c25ed7017b5af9be9f1
URL:
https://github.com/llvm/llvm-project/commit/69b0b7e7ac3adc42df517c25ed7017b5af9be9f1
DIFF:
https://github.com/llvm/llvm-project/commit/69b0b7e7ac3adc42df517c25ed7017b5af9be9f1.d
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/111907
>From e4393924a46dc62f2edfae5675b48002042f2032 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 10 Oct 2024 12:58:06 -0700
Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/111907
>From c179c081ff76ce53a0c13265b1e68eb682699415 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 10 Oct 2024 12:58:06 -0700
Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration
https://github.com/medismailben approved this pull request.
LGTM with format fix
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a4916d200518ac077be93995af18bd80fcb89cc2
133ace4b281abf205d35bbb6ed6ef7b2a39a8c2a --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/111601
>From 2d693e8208ea99fc57b1137668ee0e12777ab767 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 8 Oct 2024 15:52:45 -0700
Subject: [PATCH 1/5] Create new extension for save core to save a thread and N
po
@@ -38,19 +38,23 @@ class Args {
std::unique_ptr ptr;
char quote = '\0';
+/// The position of the argument in the original argument string.
+std::optional column;
char *data() { return ptr.get(); }
public:
ArgEntry() = default;
-ArgEntry(ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This adds an include for SBLanguages.h in lldb-enumerations.h so that files
that need this enum do not have to explicitly include SBLanguages.
---
Full diff: https://github.com/llvm/llvm-project/pu
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/111907
This adds an include for SBLanguages.h in lldb-enumerations.h so that files
that need this enum do not have to explicitly include SBLanguages.
>From 133ace4b281abf205d35bbb6ed6ef7b2a39a8c2a Mon Sep 17 00:
github-actions[bot] wrote:
@rocallahan Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bui
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Robert O'Callahan
Date: 2024-10-10T13:01:47-07:00
New Revision: d5e1de6da96c1ab3b8cae68447e8ed3696a7006e
URL:
https://github.com/llvm/llvm-project/commit/d5e1de6da96c1ab3b8cae68447e8ed3696a7006e
DIFF:
https://github.com/llvm/llvm-project/commit/d5e1de6da96c1ab3b8cae68447e8ed3696a7006e.d
jimingham wrote:
Except for the test request, this LGTM.
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,19 +38,23 @@ class Args {
std::unique_ptr ptr;
char quote = '\0';
+/// The position of the argument in the original argument string.
+std::optional column;
char *data() { return ptr.get(); }
public:
ArgEntry() = default;
-ArgEntry(ll
@@ -0,0 +1,11 @@
+# RUN: echo quit | %lldb -o "log enable -x" \
jimingham wrote:
Can you write one of these tests where the wrong option isn't the first? From
the standpoint of "things you could get wrong", "only working for the first
option" seems a likely fa
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/94165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/94127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
> @rocallahan Let me know if you need me to merge this on your behalf.
Please do! Thanks!
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/adrian-prantl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/111882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Sometimes users (esp. gdb-longtime users) accidentally use GDB syntax, such as
`breakpoint foo`, and they would get an error message from LLDB saying simply
`Invalid command "breakpoint foo"`, which is not very
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/mentlerd created
https://github.com/llvm/llvm-project/pull/111892
Work in progress attempt at fixing #111291. Looking for maintainer
feedback/direction from @Michael137
>From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001
From: David Mentler
Date: Mon, 7
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/111891
Sometimes users (esp. gdb-longtime users) accidentally use GDB syntax, such as
`breakpoint foo`, and they would get an error message from LLDB saying simply
`Invalid command "breakpoint foo"`, which is not very
JDevlieghere wrote:
@rocallahan Let me know if you need me to merge this on your behalf.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
github-actions[bot] wrote:
@ldm0 Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build, yo
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Donough Liu
Date: 2024-10-10T11:46:19-07:00
New Revision: b800ff67dae59e194c8e9fc5d795a5932dc726f8
URL:
https://github.com/llvm/llvm-project/commit/b800ff67dae59e194c8e9fc5d795a5932dc726f8
DIFF:
https://github.com/llvm/llvm-project/commit/b800ff67dae59e194c8e9fc5d795a5932dc726f8.diff
L
@@ -3180,15 +3180,24 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
if ((result.Succeeded() &&
io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) ||
io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) {
-// Display a
@@ -2078,6 +2078,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
ElapsedTime elapsed(execute_time);
cmd_obj->SetOriginalCommandString(real_original_command_string);
+pos = real_original_command_string.rfind(remainder);
jimin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This fixes the following assertion: "Cannot create Expected from Error
success value." The problem was that GetFrameBaseValue returned false without
updating the Status argument. This patch makes
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/111882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/111882
This fixes the following assertion: "Cannot create Expected from Error
success value." The problem was that GetFrameBaseValue return false without
updating the Status argument. This patch makes sure that e
@@ -38,19 +38,23 @@ class Args {
std::unique_ptr ptr;
char quote = '\0';
+/// The position of the argument in the original argument string.
+std::optional column;
char *data() { return ptr.get(); }
public:
ArgEntry() = default;
-ArgEntry(ll
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/108870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-10-10T19:27:27+02:00
New Revision: 7e16571eb02e7e9da24fee45359e981af783d0d0
URL:
https://github.com/llvm/llvm-project/commit/7e16571eb02e7e9da24fee45359e981af783d0d0
DIFF:
https://github.com/llvm/llvm-project/commit/7e16571eb02e7e9da24fee45359e981af783d0d0
jimingham wrote:
> > it should definitely be enabled by default when we're at the point to merge
> > it, and the setting should only be a safety mechanism if this turns out to
> > cause a problem for a configuration we weren't able to test.
>
> That's fine with me either.
>
> > I would even p
DmT021 wrote:
> I was chatting with Jim Ingham and he was a little bummed that we're looking
> at doing this in a single DynamicLoader plugin, instead of having the
> DynamicLoader plugin create a list of ModuleSpec's and having a central
> method in ModuleList or something, create Modules for
jimingham wrote:
> (This is in reply to Jim's comment
> [here](https://github.com/llvm/llvm-project/pull/111206#issuecomment-2400376223).
> I can't quote it, because github garbles it beyond recognition, probably
> because it was sent by email :/)
I'm trying to remember not to believe the bi
Author: Jonas Devlieghere
Date: 2024-10-10T09:56:31-07:00
New Revision: f2c5aa920054fa60372a161520e6ea8e8d23880d
URL:
https://github.com/llvm/llvm-project/commit/f2c5aa920054fa60372a161520e6ea8e8d23880d
DIFF:
https://github.com/llvm/llvm-project/commit/f2c5aa920054fa60372a161520e6ea8e8d23880d.d
DmT021 wrote:
> it should definitely be enabled by default when we're at the point to merge
> it, and the setting should only be a safety mechanism if this turns out to
> cause a problem for a configuration we weren't able to test.
That's fine with me either.
> I would even put it explicitly
dzhidzhoev wrote:
Rebased&undrafted
https://github.com/llvm/llvm-project/pull/98694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev ready_for_review
https://github.com/llvm/llvm-project/pull/98694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/98694
>From 35db69bd4f65c2b99ba8f366d7de36e7901ccb88 Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka
Date: Thu, 30 May 2024 03:04:58 +
Subject: [PATCH] [lldb][test] Fix TestStdCXXDisassembly test when tests a
1 - 100 of 178 matches
Mail list logo
