llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/6721
Here is the relevant piece of the build log
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-09-19T23:35:34-07:00
New Revision: 1e131ddfa8f1d7b18c85c6e4079458be8b419421
URL:
https://github.com/llvm/llvm-project/commit/1e131ddfa8f1d7b18c85c6e4079458be8b419421
DIFF:
https://github.com/llvm/llvm-project/commit/1e131ddfa8f1d7b18c85c6e4079458be8b419421.
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/105449
>From 3387de37a8c0da9174653062b0804494d8ebf53e Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 19 Sep 2024 23:29:13 -0700
Subject: [PATCH 1/3] [lldb/Interpreter] Create
ScriptedStopHook{,Pytho
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
+"raw" commands. The command interpreter
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
+"raw" commands. The command interpreter
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/109062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result):
will return True if the user set this option, and False if it was left at its
default
value.
-There are example commands in the lldb testsuite at:
+Custom Completions:
+
+You can also implement custo
@@ -1637,6 +1637,129 @@ class CommandObjectScriptingObjectParsed : public
CommandObjectParsed {
size_t GetNumOptions() { return m_num_options; }
+void PrepareOptionsForCompletion(CompletionRequest &request,
+ OptionElementVector &o
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
+"raw" commands. The command interpreter
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
medismailben wrote:
```s
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
+"raw" commands. The command interpreter
@@ -587,8 +587,150 @@ say
SBCommandReturnObject and SBStream both support this file-like behavior by
providing write() and flush() calls at the Python layer.
+The commands that are added using this Class definition are what lldb calls
+"raw" commands. The command interpreter
@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result):
will return True if the user set this option, and False if it was left at its
default
value.
-There are example commands in the lldb testsuite at:
+Custom Completions:
+
+You can also implement custo
@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result):
will return True if the user set this option, and False if it was left at its
default
value.
-There are example commands in the lldb testsuite at:
+Custom Completions:
+
+You can also implement custo
https://github.com/medismailben commented:
Overall, this looks fine. It would be nice to surround the keywords with
backticks and the function definition with a `.. code-block:: python` so it
gets rendered properly on the website.
https://github.com/llvm/llvm-project/pull/109062
__
@@ -54,13 +54,20 @@ def run_test_evaluate_expressions(
line_number(source, "// breakpoint 5"),
line_number(source, "// breakpoint 6"),
line_number(source, "// breakpoint 7"),
+line_number(source, "// breakpoint 8")
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/9] [lldb-dap] Add feature to remember last non-empty
expression.
jimingham wrote:
This looks good to me so far, but of course it needs tests.
https://github.com/llvm/llvm-project/pull/109219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -957,53 +962,43 @@ PrintRecognizerDetails(Stream &strm, const std::string
&name,
llvm::interleaveComma(symbols, strm);
}
-class CommandObjectFrameRecognizerDelete : public CommandObjectParsed {
-public:
- CommandObjectFrameRecognizerDelete(CommandInterpreter &interprete
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an
l
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an
l
jeffreytan81 wrote:
> I'm also not sure where's the " NameEntry> mapping table"
> you mention in the description. Could you point me to it?
@labath, that is the first prototype I tried, but benchmark shows it did not
improve any performance because the time to build this mapping offsets any
q
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/105449
>From 89ed41f52916bdc67d244488e5ee1d7da7c7bb90 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 20 Aug 2024 16:13:54 -0700
Subject: [PATCH 1/3] [lldb/Interpreter] Create
ScriptedStopHook{,Pytho
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -444,6 +492,98 @@ void DebugNamesDWARFIndex::GetNamespaces(
m_fallback.GetNamespaces(name, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ Progress progress("Get
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/105449
>From 897dd358d3b15ec59e63068f7e328e914db49495 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 19 Sep 2024 13:25:06 -0700
Subject: [PATCH] [lldb/Interpreter] Add requirements to Scripted Interf
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/109063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-09-19T13:55:41-07:00
New Revision: 21026073e3b0583caf0c81564c4d7ebf002fe67b
URL:
https://github.com/llvm/llvm-project/commit/21026073e3b0583caf0c81564c4d7ebf002fe67b
DIFF:
https://github.com/llvm/llvm-project/commit/21026073e3b0583caf0c81564c4d7ebf002fe67b.
adrian-prantl wrote:
This is now ready for review. Out of scope for this PR, but the obvious next
step: `dwim-print` / `p` support.
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an
l
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/109063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl ready_for_review
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106470
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an
l
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/109063
>From 897dd358d3b15ec59e63068f7e328e914db49495 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 19 Sep 2024 13:25:06 -0700
Subject: [PATCH] [lldb/Interpreter] Add requirements to Scripted Interf
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
clayborg wrote:
Instead of just an array of names, we
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From d2a4e7dac1fcbea87216048e8afd7754d39787ca Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/107906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jennphilqc wrote:
> > I actually wrote this for a team that already has their own viewer. We've
> > suggested that they upstream that as well.
>
> Is that viewer in VS-Code or in some other editor? (Trying to avoid
> duplicating effort, so I don't accidentally implement the same thing)
It is
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
Michael137 wrote:
Is it worth splitting this into two PRs (one for the type lookup and one for
namespaces)?
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -20,6 +23,47 @@
namespace lldb_private {
+/// A compiler-independent representation of a Diagnostic. Expression
+/// evaluation failures often have more than one diagnostic that a UI
+/// layer might want to render differently, for example to colorize
+/// it.
+///
+/// Ru
@@ -1,71 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -1,71 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -1,71 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/109266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
I have updated Socket::Create() with minimal changes. But later I used
TCPSocket and DomainSocket constructors directly to keep Socket.cpp untouched.
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-c
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 16:12:50 +0400
Subject: [PATCH 1/3] [lldb] Removed gdbserver ports map from lldb-server
Liste
@@ -186,36 +210,49 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
if (!checker_or_err)
return checker_or_err.takeError();
+llvm::Error abstract_method_errors = llvm::Error::success();
for (const auto &method_checker : *checker_or_err)
@@ -186,36 +210,49 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
if (!checker_or_err)
return checker_or_err.takeError();
+llvm::Error abstract_method_errors = llvm::Error::success();
for (const auto &method_checker : *checker_or_err)
Author: Adrian Prantl
Date: 2024-09-19T10:07:13-07:00
New Revision: 104b249c236578d298384416c495ff7310b97f4d
URL:
https://github.com/llvm/llvm-project/commit/104b249c236578d298384416c495ff7310b97f4d
DIFF:
https://github.com/llvm/llvm-project/commit/104b249c236578d298384416c495ff7310b97f4d.diff
Author: Pavel Labath
Date: 2024-09-19T10:07:13-07:00
New Revision: 1f8a3286e065b8cb82628db0d335b3e82b9373fd
URL:
https://github.com/llvm/llvm-project/commit/1f8a3286e065b8cb82628db0d335b3e82b9373fd
DIFF:
https://github.com/llvm/llvm-project/commit/1f8a3286e065b8cb82628db0d335b3e82b9373fd.diff
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309
>From f47b38cd26107108f082df437196832fbe9ad78d Mon Sep 17 00:00:00 2001
From: Nikita Popov
Date: Thu, 19 Sep 2024 17:27:13 +0200
Subject: [PATCH] apint only
---
clang/lib/AST/ByteCode/IntegralAP.h | 6
https://github.com/zibi2 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/107906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM too
But please wait a bit for @lhames to chime in about the `RuntimeDyld` changes
in case he has any comments/ideas for testing those
https://github.com/llvm/llvm-project/pull/99336
___
l
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
> Ping, anyone wants to review this? Thanks
The usual ping time is one week, and this is definitely one of the more nuanced
patches, which usually take a longer time to review.
This isn't really a review, just noting something that caught my eye.
I'm also
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
--
@@ -444,6 +492,98 @@ void DebugNamesDWARFIndex::GetNamespaces(
m_fallback.GetNamespaces(name, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ Progress progress("Get
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
https://github.com/felipepiovezan commented:
Very cool work! I've left some high level thoughts and questions inline.
Focused only on the namespace bit for now, and didn't do a _code_ review, just
algorithm ideas
https://github.com/llvm/llvm-project/pull/108907
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -20,6 +23,47 @@
namespace lldb_private {
+/// A compiler-independent representation of a Diagnostic. Expression
+/// evaluation failures often have more than one diagnostic that a UI
+/// layer might want to render differently, for example to colorize
+/// it.
+///
+/// Ru
@@ -328,18 +328,20 @@ UserExpression::Evaluate(ExecutionContext &exe_ctx,
}
if (!parse_success) {
- std::string msg;
- {
-llvm::raw_string_ostream os(msg);
-if (!diagnostic_manager.Diagnostics().empty())
- os << diagnostic_manager.Get
labath wrote:
Any chance of a test case for the Diagnostic->DetailedExpressionError
conversion?
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
@@ -279,6 +279,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error,
lldb::addr_t &func_addr,
.setMCJITMemoryManager(std::make_unique(*this))
.setOptLevel(llvm::CodeGenOptLevel::Less);
+ if (triple.isRISCV64())
dlav-sc wrote:
addressed
http
https://github.com/labath commented:
Sorry for being late to the party. I don't usually follow lldb-dap patches, but
the mention of memory reads and windows errors intrigued me.
I don't think this is a good approach to reading memory. You shouldn't trust
GetMemoryRegionInfo over ReadMemory. Th
@@ -682,17 +683,51 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
}
bool DAP::HandleObject(const llvm::json::Object &object) {
+ auto start_time = std::chrono::steady_clock::now();
const auto packet_type = GetString(object, "type");
if (packet_type ==
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,13 +54,20 @@ def run_test_evaluate_expressions(
line_number(source, "// breakpoint 5"),
line_number(source, "// breakpoint 6"),
line_number(source, "// breakpoint 7"),
+line_number(source, "// breakpoint 8")
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix,
// RunTerminateCommands.
static std::mutex handle_command_mutex;
std::lock_guard locker(handle_command_mutex);
- interp.HandleCommand(command.str().c_str(), result);
+ interp.HandleComman
https://github.com/labath commented:
This works for me. Walter?
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/108806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-19T15:08:47+02:00
New Revision: 1f8e6624e5052d56244b28fef3eb64bd0408f75d
URL:
https://github.com/llvm/llvm-project/commit/1f8e6624e5052d56244b28fef3eb64bd0408f75d
DIFF:
https://github.com/llvm/llvm-project/commit/1f8e6624e5052d56244b28fef3eb64bd0408f75d.diff
labath wrote:
Good find. Somewhat surprising, but I guess it's possible. I'll try to look
into whether this is some defensive coding or if this can legitimately happen
for some reason.
https://github.com/llvm/llvm-project/pull/108810
___
lldb-commits
1 - 100 of 114 matches
Mail list logo
