tstellar wrote:
> > the tests were only run when libcxx was enabled.
>
> Interesting bit here, I'm not sure where this is orchestrated.
It's controlled by this line:
https://github.com/llvm/llvm-project/blob/main/lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/TestDbg
JDevlieghere wrote:
> Thanks! Is this asserting cause something changed in how llvm::formatv
> validates the format string?
Correct: https://github.com/llvm/llvm-project/pull/105745
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits ma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Thanks! Is this asserting cause something changed in how llvm::formatv
validates the format string? Or maybe I just never hit this codepath with
expression log enabled before
https://github.com/llvm/llvm-project/pull/107325
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
Without this, LLDB asserts when enabling the expression logs.
---
Full diff: https://github.com/llvm/llvm-project/pull/107325.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ExpressionParser/Clan
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/107325
Without this, LLDB asserts when enabling the expression logs.
>From 622c5b636d1a505f1ea3f68540db28061d8606ce Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Wed, 4 Sep 2024 16:02:20 -0700
Subject: [PATCH]
https://github.com/dfukalov updated
https://github.com/llvm/llvm-project/pull/106810
>From 7e9c4b1d0da02cf923a790c8025ac1e1a333094e Mon Sep 17 00:00:00 2001
From: dfukalov
Date: Sat, 31 Aug 2024 01:45:27 +0200
Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its
macros are
llvmbot wrote:
@llvm/pr-subscribers-pgo
Author: Daniil Fukalov (dfukalov)
Changes
This is the second part.
Without these explicit includes, removing other headers, who implicitly include
llvm-config.h, may have non-trivial side effects. For example, `clagd` may
report `llvm-config.h` as
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
@llvm/pr-subscribers-debuginfo
Author: Daniil Fukalov (dfukalov)
Changes
This is the second part.
Without these explicit includes, removing other headers, who implicitly include
llvm-config.h, may have non-trivial side effects. For exa
https://github.com/dfukalov ready_for_review
https://github.com/llvm/llvm-project/pull/106810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Wasn't half as bad. @labath This update introduces a `ClonableError` base
class. This will enable us (after a bit more refactoring) to move the various
Error subclass declarations closer to where they are needed. Right now the
ErrorFromEnums() method still prevents that.
@@ -201,3 +216,12 @@ std::string ScriptSummaryFormat::GetDescription() {
}
return std::string(sstr.GetString());
}
+
+std::string ScriptSummaryFormat::GetName() { return m_script_formatter_name; }
+
+std::string ScriptSummaryFormat::GetSummaryKindName() {
+ if (!m_python_s
@@ -258,6 +258,14 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ /// Get the name of the Type Summary Provider, either a C++ class, a summary
+ /// string, or a script function name.
+ virtual std::string GetName() = 0;
+
+ /// Get the name of th
@@ -174,6 +176,85 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
@@ -174,6 +176,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/106767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106767
>From ceb20d62d9cef3090e34e8b9fc0bc620a7d9da3d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 30 Aug 2024 10:33:08 -0700
Subject: [PATCH 1/4] Extend the minidump x86_64 registers to include fs_base
and
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/5] [lldb-dap] Make environment option an object
---
.../tools/l
felipepiovezan wrote:
> > Ah I've just noticed the other PR
>
> Do we actually have abetter solution for stacked commits than what I'm doing
> here?
short answer is "maybe":
https://llvm.org/docs/GitHub.html#using-graphite-for-stacked-pull-requests
https://github.com/llvm/llvm-project/pull/1
jimingham wrote:
Ah, I thought you were echoing something and pointing into that, I missed that
you were pointing into the original command line. Does this also work if I
have an alias that scrambles the command arguments compared to how they are in
the command that eventually got invoked.
I
jimingham wrote:
Are you planning to do this more generally? There are lots of API's that can
ValueObjects that might or might not succeed, and it's not clear to me how
AddressOf is special in this regard.
If we're planning on changing how we hand out ValueObjects more generally in
the API t
adrian-prantl wrote:
> Ah I've just noticed the other PR
Do we actually have abetter solution for stacked commits than what I'm doing
here?
https://github.com/llvm/llvm-project/pull/107170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107163
>From 1c258c6efb04688ccb2e60a9c472c5c40e93c9ac Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 15:29:25 -0700
Subject: [PATCH] [lldb] Make conversions from llvm::Error explicit with
Sta
felipepiovezan wrote:
Ah I've just noticed the other PR
https://github.com/llvm/llvm-project/pull/107170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
I'm not if this is your intention, but the way LLVM has configured their
github, your two nicely separated commits will be squashed :(
https://github.com/llvm/llvm-project/pull/107170
___
lldb-commits mailing list
lldb-commits@l
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9626e84faeaab200665bae9694458c2beb3d49c7
47e2879bf9f49ece471d9e0d47d16c175d012703 --e
@@ -26,6 +26,36 @@ class raw_ostream;
namespace lldb_private {
+class MachKernelError
adrian-prantl wrote:
Updated.
https://github.com/llvm/llvm-project/pull/107170
___
lldb-commits mailing list
lldb-commits@lists
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9626e84faeaab200665bae9694458c2beb3d49c7
3a133869fd7defac30329ef4c81eb082883e --e
adrian-prantl wrote:
@labath Done.
https://github.com/llvm/llvm-project/pull/107163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107163
>From 3a133869fd7defac30329ef4c81eb082883e Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 15:29:25 -0700
Subject: [PATCH] [lldb] Make conversions from llvm::Error explicit with
Sta
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c4906588ce47de33d59bcd95f3e82ce2c3e61c23
3da1e51b77592dc193328ad3b7d64165ccc3c71e --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/106767
>From ceb20d62d9cef3090e34e8b9fc0bc620a7d9da3d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 30 Aug 2024 10:33:08 -0700
Subject: [PATCH 1/3] Extend the minidump x86_64 registers to include fs_base
and
https://github.com/labath commented:
No, I'm just saying we should ditch the rvalue references. I.e., do this.
https://github.com/llvm/llvm-project/pull/107163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
@@ -145,6 +145,7 @@ class Status {
bool Success() const;
protected:
+ Status(llvm::Error &&error);
labath wrote:
```suggestion
Status(llvm::Error error);
```
https://github.com/llvm/llvm-project/pull/107163
__
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/107163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -91,9 +91,9 @@ class Status {
~Status();
- // llvm::Error support
- explicit Status(llvm::Error error) { *this = std::move(error); }
- const Status &operator=(llvm::Error error);
+ /// Avoid using this in new code. Migrate APIs to llvm::Expected instead.
+ static St
bulbazord wrote:
> OK, I see in `Symtab::InitAddressIndexes` we go through the symbol table and
> calculate the sizes of any entries that don't have a size based on the next
> symbol, or the end of the section.
>
> A little further in ObjectFileMachO::ParseSymtab when we add any
> LC_FUNCTION
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/4] [lldb-dap] Make environment option an object
---
.../tools/l
Jlalond wrote:
Hey @bulbazord, this was reverted because it failed `TestSkinnyCorefile.py`
[Link](https://github.com/llvm/llvm-project/blob/main/lldb/test/API/macosx/skinny-corefile/TestSkinnyCorefile.py#L15),
I'm running into issues where it keeps coming up as unsupported. Is there a
way to t
@@ -666,7 +756,23 @@ ConnectionStatus
ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#ifdef _WIN32
+ int64_t
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 18b8a835a3182e5be5f0dd848977333d9b8a26fa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH 1/2] [lldb] Removed gdbserver ports map from lldb-server
List
https://github.com/dfukalov updated
https://github.com/llvm/llvm-project/pull/106810
>From 0221e97459534f0f7396e7970663e1a4f1f98cca Mon Sep 17 00:00:00 2001
From: dfukalov
Date: Sat, 31 Aug 2024 01:45:27 +0200
Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its
macros are
@@ -667,7 +669,22 @@ ConnectionStatus
ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#ifdef _WIN32
+ int64_t
@@ -160,66 +95,58 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
@@ -879,20 +879,12 @@ lldb::thread_result_t
GDBRemoteCommunication::ListenThread() {
return {};
}
-Status GDBRemoteCommunication::StartDebugserverProcess(
-const char *url, Platform *platform, ProcessLaunchInfo &launch_info,
-uint16_t *port, const Args *inferior_arg
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 18b8a835a3182e5be5f0dd848977333d9b8a26fa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH 1/2] [lldb] Removed gdbserver ports map from lldb-server
List
Da-Viper wrote:
> Can we modify this patch to support both formats? It should be easy to see if
> "env" is a dictionary, and if it is, use your new code. If it is an array,
> use the old parsing code. I would like to make sure this change doesn't break
> anyone that has existing launch configu
DhruvSrivastavaX wrote:
One more thing. For platform differentiating files/paths like HostInfoAIX
future files like PlatformAIX, How do you suggest we add them?
To keep the code path more streamlined, shall we keep their code under Linux
with #if _AIX, Or shall we use some form of inheritance
DhruvSrivastavaX wrote:
Ok sure.
For readability and clarity, for the files having comparatively bigger changes,
I can drop it as multiple commits in the same PR, so that the changes can be
seen as cleanly as possible:
1. Commit 1 - copy paste the original
2. Commit 2 - Make AIX dependant cha
https://github.com/Michael137 approved this pull request.
makes sense
https://github.com/llvm/llvm-project/pull/107240
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,7 +50,8 @@ class ElaboratingDIEIterator
m_worklist.pop_back();
// And add back any items that elaborate it.
-for (dw_attr_t attr : {DW_AT_specification, DW_AT_abstract_origin}) {
+for (dw_attr_t attr :
+ {DW_AT_specification, DW_AT_abstract_origi
https://github.com/Michael137 deleted
https://github.com/llvm/llvm-project/pull/107241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,7 +50,8 @@ class ElaboratingDIEIterator
m_worklist.pop_back();
// And add back any items that elaborate it.
-for (dw_attr_t attr : {DW_AT_specification, DW_AT_abstract_origin}) {
+for (dw_attr_t attr :
+ {DW_AT_specification, DW_AT_abstract_origi
@@ -38,6 +38,12 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+# This has been added to keep the AIX build isolated for now.
+# It will need to be modified later.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett
@@ -377,11 +378,6 @@ static void GetDeclContextImpl(DWARFDIE die,
die = spec;
continue;
}
-// To find the name of a type in a type unit, we must follow the signature.
-if (DWARFDIE spec = die.GetReferencedDIE(DW_AT_signature)) {
Michael1
@@ -38,6 +38,12 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+# This has been added to keep the AIX build isolated for now.
+# It will need to be modified later.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett
DavidSpickett wrote:
A couple of suggestions.
Perhaps you could reduce the PRs just to the files with the biggest differences
on AIX, and include those changes in the PR. So that it is copying the file +
making the AIX changes in one PR. Even if you have to add files that aren't
used yet, we
@@ -38,6 +38,12 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+# This has been added to keep the AIX build isolated for now.
+# It will need to be modified later.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DhruvSrivasta
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/107241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -60,44 +60,45 @@ class DWARFDebugInfoEntry {
return attrs;
}
- dw_offset_t
- GetAttributeValue(const DWARFUnit *cu, const dw_attr_t attr,
-DWARFFormValue &formValue,
-dw_offset_t *end_attr_offset_ptr = nullptr,
-
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -163,11 +166,83 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 34b10e165d809bb133d37dfe934859800f21a100
66d055aa303c8fa07c4db2023dc175bad48a15a0 --e
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
DavidSpickett wrote:
Just one more thing then this is good to go.
Do you have commit access or will you need me to merge it for you?
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -728,7 +746,6 @@ def test_riscv64_regs(self):
"fa2",
"fa3",
"fa4",
-"fa5",
DavidSpickett wrote:
I would replace this line with:
```
# fa5 is non-zero and checked in the list above.
```
https://github.com/llvm
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/105883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-09-04T07:02:55-07:00
New Revision: 1b0a80249399dadfe0c3f682fff77bf9eb666535
URL:
https://github.com/llvm/llvm-project/commit/1b0a80249399dadfe0c3f682fff77bf9eb666535
DIFF:
https://github.com/llvm/llvm-project/commit/1b0a80249399dadfe0c3f682fff77bf9e
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/105883
>From e91140e2c059df5f65ad907e9c93329c75e36dc4 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 23 Aug 2024 13:10:00 -0700
Subject: [PATCH 1/2] [GDBRemote] Handle 'heap' memory region
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/107240
We need to resolve the type signature to get a hold of the template argument
dies.
The associated test case passes even without this patch, but it only does it by
accident (because the subsequent code considers
dlav-sc wrote:
> > Well, for now I assume that existing tests are enough. Meaning we have a
> > list of tests that start passing
> > after these patches are applied.
>
> How are you running the tests? We're working on getting the tests running in
> a sane fashion, using user space qemu.
For n
Author: David Spickett
Date: 2024-09-04T10:22:58Z
New Revision: d77ccae4a629ba11b5c28f97222a8834c5e5c183
URL:
https://github.com/llvm/llvm-project/commit/d77ccae4a629ba11b5c28f97222a8834c5e5c183
DIFF:
https://github.com/llvm/llvm-project/commit/d77ccae4a629ba11b5c28f97222a8834c5e5c183.diff
LOG
Author: David Spickett
Date: 2024-09-04T09:43:18Z
New Revision: 5a658ee933065d0e4ef1a65d9a6ddfba2874ee98
URL:
https://github.com/llvm/llvm-project/commit/5a658ee933065d0e4ef1a65d9a6ddfba2874ee98
DIFF:
https://github.com/llvm/llvm-project/commit/5a658ee933065d0e4ef1a65d9a6ddfba2874ee98.diff
LOG
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/106640
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-09-04T13:38:55+04:00
New Revision: deeafeab815ddfe7b507e9f79fe8f992265a9f3b
URL:
https://github.com/llvm/llvm-project/commit/deeafeab815ddfe7b507e9f79fe8f992265a9f3b
DIFF:
https://github.com/llvm/llvm-project/commit/deeafeab815ddfe7b507e9f79fe8f992265a9f3b.dif
Author: David Spickett
Date: 2024-09-04T09:33:35Z
New Revision: 0b2550f8ab77a53f560f6a7a1b401c4803a36d48
URL:
https://github.com/llvm/llvm-project/commit/0b2550f8ab77a53f560f6a7a1b401c4803a36d48
DIFF:
https://github.com/llvm/llvm-project/commit/0b2550f8ab77a53f560f6a7a1b401c4803a36d48.diff
LOG
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-04T11:30:58+02:00
New Revision: cc5c526c80a4cacf7ed5b7fbe50072594ec1aeaf
URL:
https://github.com/llvm/llvm-project/commit/cc5c526c80a4cacf7ed5b7fbe50072594ec1aeaf
DIFF:
https://github.com/llvm/llvm-project/commit/cc5c526c80a4cacf7ed5b7fbe50072594ec1aeaf.diff
https://github.com/labath approved this pull request.
cool. thanks.
https://github.com/llvm/llvm-project/pull/106640
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,9 +34,11 @@ namespace lldb_private {
#if defined(_WIN32)
typedef SOCKET NativeSocket;
typedef lldb::pipe_t shared_fd_t;
+typedef const char *set_socket_option_arg_type;
slydiman wrote:
Updated. Fixed also a typo
`set`_socket_option_arg_type option_value
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
> For this PR, just consider renaming the test functions here so that they list
> what they are testing.
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/106640
>From fe58bf1f08553b75f089692077abdff0ccaf96bb Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:29:58 +0400
Subject: [PATCH 1/2] [lldb][NFC] Move few static helpers to the class Socket
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
As an example of what I mean about future extensions being "too weird" -
In the new Arm extension suppor
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
I'm saying that if risc-v grows a lot of strange register state, it will be
better served by separate te
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/104193
>From ecd84ae96fd59eeb4a2bb47d80980d861dc042d1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 14 Aug 2024 19:58:27 +0200
Subject: [PATCH 1/3] [lldb] Fix and speedup the `memory find` command
This patch f
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -26,6 +26,36 @@ class raw_ostream;
namespace lldb_private {
+class MachKernelError
labath wrote:
These aren't yet used in this PR right? Can we get rid of them?
https://github.com/llvm/llvm-project/pull/107170
https://github.com/labath commented:
I don't think this usage of rvalue references is very idiomatic. It saves an
object copy (move), but:
- that should be very cheap anyway
- it increases the risk of improper handling and weird side-effects -- a
function like `void use(Error E) {}` will always
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
1 - 100 of 112 matches
Mail list logo
