@@ -34,9 +34,11 @@ namespace lldb_private {
#if defined(_WIN32)
typedef SOCKET NativeSocket;
typedef lldb::pipe_t shared_fd_t;
+typedef const char *set_socket_option_arg_type;
labath wrote:
Instead of exposing this quirk, it would be better to have a static ve
clayborg wrote:
We already have bits that know if the size is synthesize in
`lldb_private::Symbol::m_size_is_synthesized` and we have a bit that tracks is
the size is valid with `lldb_private::Symbol::m_size_is_valid`. We could
accomplish this `size on demand` feature by letting clients subcla
https://github.com/clayborg commented:
All symbol sizes are zero for mach-o symbols unless they come from the debug
map as there is no size field in nlist entries. This PR seems to just not do
the work of setting the symbol size at all. Does something try to set the
symbol sizes later? Does th
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107159
>From 63a343d2613d09a866180c8bebdf4568e20fd3b7 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 29 Aug 2024 10:09:19 -0700
Subject: [PATCH 1/3] =?UTF-8?q?Reapply=20"[LLDB][SBSaveCore]=20Add=20selec?=
=?U
adrian-prantl wrote:
So far I broke out https://github.com/llvm/llvm-project/pull/106774 and
https://github.com/llvm/llvm-project/pull/107170. I'm still thinking about how
to approach Pavel's cloneableError suggestion.
https://github.com/llvm/llvm-project/pull/106774
__
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Broken out from https://github.com/llvm/llvm-project/pull/106774 for easier
review.
---
Patch is 108.56 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/1071
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/4279
Here is the relevant piece of the bu
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/105765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-09-03T16:45:28-07:00
New Revision: b076f6640e3c2781410588f4a8e4ccfeed8eb606
URL:
https://github.com/llvm/llvm-project/commit/b076f6640e3c2781410588f4a8e4ccfeed8eb606
DIFF:
https://github.com/llvm/llvm-project/commit/b076f6640e3c2781410588f4a8e4ccfeed8eb606.diff
jasonmolenda wrote:
OK, I see in `Symtab::InitAddressIndexes` we go through the symbol table and
calculate the sizes of any entries that don't have a size based on the next
symbol, or the end of the section.
A little further in ObjectFileMachO::ParseSymtab when we add any
LC_FUNCTION_STARTS
https://github.com/medismailben approved this pull request.
LGTM for lldb's part
https://github.com/llvm/llvm-project/pull/106505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dfukalov updated
https://github.com/llvm/llvm-project/pull/106810
>From 0221e97459534f0f7396e7970663e1a4f1f98cca Mon Sep 17 00:00:00 2001
From: dfukalov
Date: Sat, 31 Aug 2024 01:45:27 +0200
Subject: [PATCH 1/2] [NFC] Add explicit #include llvm-config.h where its
macros are
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107163
>From 98a56877999a24edd62f9a1b7ef205c8defb686f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 15:29:25 -0700
Subject: [PATCH] [lldb] Make conversions from llvm::Error explicit with
Sta
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
…ror() [NFC]
Broken out from https://github.com/llvm/llvm-project/pull/106774 for easier
review.
---
Patch is 52.99 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-proj
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/107163
…ror() [NFC]
Broken out from https://github.com/llvm/llvm-project/pull/106774 for easier
review.
>From 012b0a7d135a4d4816c78988d6145595c7852b0e Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3
Author: Jonas Devlieghere
Date: 2024-09-03T15:40:39-07:00
New Revision: 7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
URL:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
DIFF:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b.d
https://github.com/slinder1 closed
https://github.com/llvm/llvm-project/pull/104847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 18cf14efe3e82b2343817fd174bcac48244c8f50
e79e6561b68ff11f93239ce901de1e02aa0c16c3 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Reapplies #106293, testing identified issue in the merging code. I used
this opportunity to strip CoreFileMemoryRanges to it's own file and then add
unit tests on it's behavior.
---
Patch is 41.75 KiB, tru
Jlalond wrote:
Need to verify this passes `SaveSkinnyCore`.
https://github.com/llvm/llvm-project/pull/107159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/107159
Reapplies #106293, testing identified issue in the merging code. I used this
opportunity to strip CoreFileMemoryRanges to it's own file and then add unit
tests on it's behavior.
>From 63a343d2613d09a866180c8be
Author: Scott Linder
Date: 2024-09-03T22:05:03Z
New Revision: 18cf14efe3e82b2343817fd174bcac48244c8f50
URL:
https://github.com/llvm/llvm-project/commit/18cf14efe3e82b2343817fd174bcac48244c8f50
DIFF:
https://github.com/llvm/llvm-project/commit/18cf14efe3e82b2343817fd174bcac48244c8f50.diff
LOG:
Author: Jonas Devlieghere
Date: 2024-09-03T14:38:39-07:00
New Revision: 98bde7fd872c10e49035d5dc5d2f2b44489f6a07
URL:
https://github.com/llvm/llvm-project/commit/98bde7fd872c10e49035d5dc5d2f2b44489f6a07
DIFF:
https://github.com/llvm/llvm-project/commit/98bde7fd872c10e49035d5dc5d2f2b44489f6a07.d
Author: Jonas Devlieghere
Date: 2024-09-03T14:38:34-07:00
New Revision: d966d4708fe5084e47ca3d9d411935d6870aefff
URL:
https://github.com/llvm/llvm-project/commit/d966d4708fe5084e47ca3d9d411935d6870aefff
DIFF:
https://github.com/llvm/llvm-project/commit/d966d4708fe5084e47ca3d9d411935d6870aefff.d
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/13] [lldb][test] Improve toolchain detection in
Mak
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Two high-level comments:
>
> * I think that the `FromError`/`clone` changes would be better of as a
> separate patch(es). I have no problem with the changes themselves, but I
> think it'd be better to separate the meat of this patch from the mechanical
> renaming. The r
clayborg wrote:
Can we modify this patch to support both formats? It should be easy to see if
"env" is a dictionary, and if it is, use your new code. If it is an array, use
the old parsing code. I would like to make sure this change doesn't break
anyone that has existing launch configurations.
https://github.com/AaronBallman approved this pull request.
Clang bits LGTM
https://github.com/llvm/llvm-project/pull/106505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Ping for my comments?
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
We need the `DWARFFormValue::ExtractValue ` to work. We spoke about pointing
the `DWARFFormValue::ValueType::data` at the 16 bytes of data and have the
`DWARFFormValue::ValueType::value.uval` contain 16 as the length of the data in
`DWARFFormValue::ValueT
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 3ffcc5e1d8a088f3ebd988ab9e18a658149be7f7 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Aug 2024 17:29:10 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
ll
@@ -33,16 +33,16 @@ class RemoteAwarePlatformTester : public
RemoteAwarePlatform {
MOCK_METHOD0(CalculateTrapHandlerSymbolNames, void());
MOCK_METHOD2(ResolveExecutable,
- std::pair(const ModuleSpec &,
- const FileSp
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 992600a058c8dffb0d39a3c840ed03087181376c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Aug 2024 17:29:10 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
ll
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/DavidSpickett commented:
Please update the PR description with an explanation of the bug you are fixing,
along the lines of the comment you wrote previously.
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Refactored after merging #106955.
Acceptor.cpp has been deleted.
Please review. Thanks.
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 18b8a835a3182e5be5f0dd848977333d9b8a26fa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen t
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/106640
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/106640
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/106640
>From fe58bf1f08553b75f089692077abdff0ccaf96bb Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:29:58 +0400
Subject: [PATCH] [lldb][NFC] Move few static helpers to the class Socket
---
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/106955
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-03T13:24:39+02:00
New Revision: 3d5e1ec6508c8425601d4cfaba4c8a8f18791e2b
URL:
https://github.com/llvm/llvm-project/commit/3d5e1ec6508c8425601d4cfaba4c8a8f18791e2b
DIFF:
https://github.com/llvm/llvm-project/commit/3d5e1ec6508c8425601d4cfaba4c8a8f18791e2b.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/107061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-03T13:23:07+02:00
New Revision: 4353530a6fc92c5748a73042371c2ddf487433e7
URL:
https://github.com/llvm/llvm-project/commit/4353530a6fc92c5748a73042371c2ddf487433e7
DIFF:
https://github.com/llvm/llvm-project/commit/4353530a6fc92c5748a73042371c2ddf487433e7.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/107077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-03T13:22:31+02:00
New Revision: a5f03b4adcd147aeecc0e0d029660c12fb4d2951
URL:
https://github.com/llvm/llvm-project/commit/a5f03b4adcd147aeecc0e0d029660c12fb4d2951
DIFF:
https://github.com/llvm/llvm-project/commit/a5f03b4adcd147aeecc0e0d029660c12fb4d2951.diff
https://github.com/slydiman approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/107061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/106955
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -79,6 +79,18 @@ def cleanup():
],
)
+self.expect_var_path("*number_engaged", value="42")
+self.expect_var_path("*x", children=[ValueCheck(name="x", value="42")])
+self.expect_var_path("x->x", value="42")
+
+# The error mes
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/107077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Nice, was wishing for this just yesterday
https://github.com/llvm/llvm-project/pull/107077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/107077.diff
3 Files Affected:
- (modified) lldb/source/Plugins/Language/CPlusPlus/GenericOptional.cpp (+2)
- (modified)
lldb/test/API/functionaliti
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/107077
None
>From 86b1e913b0756974b82b69f803238974f249b876 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 3 Sep 2024 12:15:17 +0200
Subject: [PATCH] [lldb] Support "dereferencing" std::optional
---
.../Plugin
labath wrote:
Yeah, that's probably it.
https://github.com/llvm/llvm-project/pull/107061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Is this related to https://github.com/llvm/llvm-project/issues/106283 as well?
https://github.com/llvm/llvm-project/pull/107061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -95,6 +96,40 @@ TEST_P(SocketTest, TCPListen0ConnectAccept) {
&socket_b_up);
}
+TEST_P(SocketTest, TCPMainLoopAccept) {
+ const bool child_processes_inherit = false;
+ auto listen_socket_up =
+ std::make_unique(true, child_processes_inheri
@@ -254,67 +255,60 @@ void TCPSocket::CloseListenSockets() {
m_listen_sockets.clear();
}
-Status TCPSocket::Accept(Socket *&conn_socket) {
- Status error;
- if (m_listen_sockets.size() == 0) {
-error = Status::FromErrorString("No open listening sockets!");
-return
labath wrote:
> BTW, I have figured out a side effect. MainLoopWindows uses events created by
> WSACreateEvent(). WSACreateEvent() creates the `manual-reset` event. But
> WSAResetEvent() is used only for m_trigger_event. All other events (READ,
> ACCEPT, CLOSE) are never reset. I have no idea
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This prevents the callback function from being called in a busy loop.
Discovered by @slydiman on #106955.
---
Full diff: https://github.com/llvm/llvm-project/pull/107061.diff
2 Files Affected:
- (modified)
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/107061
This prevents the callback function from being called in a busy loop.
Discovered by @slydiman on #106955.
>From 0a5ea38fe79ed5433535a3bc3bf895385c9d96e9 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 3
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/106981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-03T10:48:40+02:00
New Revision: 04ed12ca3f027a3a189d181e5e5880285ebc7916
URL:
https://github.com/llvm/llvm-project/commit/04ed12ca3f027a3a189d181e5e5880285ebc7916
DIFF:
https://github.com/llvm/llvm-project/commit/04ed12ca3f027a3a189d181e5e5880285ebc7916.diff
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/106981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/106955
>From 50e1aeec73b5c5ad3571d040c2ecc04c8d7e4009 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 2 Sep 2024 11:18:50 +0200
Subject: [PATCH 1/2] [lldb] Add a callback version of TCPSocket::Accept
The existin
@@ -276,16 +276,29 @@ Status ProcessDebugger::ReadMemory(lldb::addr_t vm_addr,
void *buf, size_t size,
LLDB_LOG(log, "attempting to read {0} bytes from address {1:x}", size,
vm_addr);
- HostProcess process = m_session_data->m_debugger->GetProcess();
+ lldb::pro
70 matches
Mail list logo
