[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

jasonmolenda wrote: Thanks again for all the help @AlexK0 I pushed an update that should compile correctly with my update. It's great to hear that the testsuite looks clean -- that's the part that worried me the most about these changes. I finished an aarch64 Ubuntu testsuite run and it is cl

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/96260 >From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 20 Jun 2024 17:53:17 -0700 Subject: [PATCH 1/6] [lldb] Change lldb's breakpoint handling behavior lldb

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b2fd1eb - Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (#98101)

Author: Kevin Frei Date: 2024-07-08T17:59:00-07:00 New Revision: b2fd1ebc3523d225956120052bcc0698adf4579f URL: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f DIFF: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f.diff LO

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f6eda6fb7a335861d8a8ce32ea805830685f218d 76f102112c8a8a1292929b65ebb7db8b033ee344 --

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes Reverts llvm/llvm-project#96802 Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no ability to even *detect* these failures without _landing_ a diff. In the mean time, we have no testi

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

https://github.com/kevinfrei ready_for_review https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

https://github.com/kevinfrei created https://github.com/llvm/llvm-project/pull/98101 Reverts llvm/llvm-project#96802 Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no ability to even *detect* these failures without _landing_ a diff. In the mean time, we have no testin

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/1213 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/96802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2a7abb0 - [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (#96802)

Author: Kevin Frei Date: 2024-07-08T16:44:16-07:00 New Revision: 2a7abb04e258542679476fa6527418c34412283c URL: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c DIFF: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c.diff LO

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jimingham wrote: > > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > > (like a random breakpoint hit) that on the face of it it's not responsible > > for > > Just a quick comment to add the context for this question: we are doing so to > ensure `ThreadPlanSingleThr

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Refactor address writers (PR #98094)

https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/98094 Refactors address writers to create an instance for each CU and its DWO CU. >From b2fe35ae825dc757ea1daaf49142e789c4a560fc Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject:

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

bulbazord wrote: This is the exact same PR as https://github.com/apple/llvm-project/pull/8952 (on apple's LLVM fork). It should have gone here first. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Fixes https://github.com/llvm/llvm-project/issues/97511 --- Full diff: https://github.com/llvm/llvm-project/pull/98089.diff 1 Files Affected: - (modified) lldb/source/Target/StackFrameList.cpp (+3-3)

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/98089 Fixes https://github.com/llvm/llvm-project/issues/97511 >From 31b3d4db2389dd4bd72b54618ba12c86f51fe02f Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 8 Jul 2024 13:24:49 -0700 Subject: [PATCH] [lldb]

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/97871 >From aa2ad3b675f67581dde07a476725d2574fc6e7da Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 5 Jul 2024 20:30:44 -0400 Subject: [PATCH] [lldb-dap] Support throw and catch exception breakpoin

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -58,10 +58,17 @@ DAP::DAP() DAP::~DAP() = default; +/// Return string with first character capitalized. +static std::string capitalize(llvm::StringRef str) { + if (str.empty()) +return ""; + return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str(); +} +

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jeffreytan81 wrote: > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > (like a random breakpoint hit) that on the face of it it's not responsible for We are doing so to ensure `ThreadPlanSingleThreadTimeout` can stay in the leaf thread plan. And it comes from your su

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

@@ -109,7 +109,7 @@ class ProcessMinidump : public PostMortemProcess { private: lldb::DataBufferSP m_core_data; llvm::ArrayRef m_thread_list; - const minidump::ExceptionStream *m_active_exception; + std::unordered_map m_exceptions_by_tid; Jlalond wrote:

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jimingham wrote: > On Jul 8, 2024, at 12:55 PM, jeffreytan81 ***@***.***> wrote: > > > @jimingham , thanks for the comment. > > When I try to add a new testcase for stepping over a function with a user set > breakpoint, there is a bug found -- the user set brea

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

walter-erquinigo wrote: > Exception Breakpoints are created by the static method > LanguageRuntime::CreateExceptionBreakpoint. So they don't require a process. Indeed, but let me elaborate. What I need is a method that doesn't require a process that could tell me if a certain language can sup

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

Jlalond wrote: > > @jeffreytan81 I think the callout for multiple exception is a good > > question. I made a C# testbed to see what would happen if I had multiple > > simultaneous exceptions. [Gist > > here](https://gist.github.com/Jlalond/467bc990f10fbb75cc9ca7db897a7beb). > > When manually

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jeffreytan81 wrote: @jimingham, thanks for the comment. When I try to add a new testcase for stepping over a function with a user set breakpoint, there is a bug found -- the user set breakpoint did not stop with `ThreadPlanSingleThreadTimeout` present (which is `c` case in your RFC comment) I

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec &src_file_spec, static constexpr llvm::StringLiteral k_zip_separator("!/"); size_t pos = source_file.find(k_zip_separator); if (pos != std::string::npos) -source_file = source_file.substr(

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -80,6 +87,46 @@ void DAP::PopulateExceptionBreakpoints() { exception_breakpoints->emplace_back("swift_throw", "Swift Throw", lldb::eLanguageTypeSwift); } +// Besides handling the hardcoded list of languages from above,

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -80,6 +87,46 @@ void DAP::PopulateExceptionBreakpoints() { exception_breakpoints->emplace_back("swift_throw", "Swift Throw", lldb::eLanguageTypeSwift); } +// Besides handling the hardcoded list of languages from above,

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -58,10 +58,17 @@ DAP::DAP() DAP::~DAP() = default; +/// Return string with first character capitalized. +static std::string capitalize(llvm::StringRef str) { + if (str.empty()) +return ""; + return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str(); +} +

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -26,3 +26,43 @@ SBLanguageRuntime::GetNameForLanguageType(lldb::LanguageType language) { return Language::GetNameForLanguageType(language); } + +bool SBLanguageRuntime::LanguageIsCPlusPlus(lldb::LanguageType language) { + return Language::LanguageIsCPlusPlus(language);

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/96802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/98055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

@@ -115,6 +116,18 @@ GlobalVariable *replaceBuffer(CGHLSLRuntime::Buffer &Buf) { } // namespace +llvm::Type *CGHLSLRuntime::convertHLSLSpecificType(const Type *T) { + assert(T->isHLSLSpecificType() && "Not an HLSL specific type!"); + + // Check if the target has a specific

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

ayushsahay1837 wrote: > This is only a very light review. I agree with others that an RFC thread is a > better place to discuss this. After we sort that out, this patch should be > further subdivided into smaller pieces. Thanks, @labath! I'll look into these and get back to you at the earliest

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

kevinfrei wrote: Friendly ping @JDevlieghere https://github.com/llvm/llvm-project/pull/96802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/97470 >From dc4730dcff31c2c9212d2ce5412ecb8a9f4d83c0 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 2 Jul 2024 12:41:02 -0700 Subject: [PATCH 1/6] Add support to read multiple exception streams in minidumps

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

https://github.com/JoeLoser approved this pull request. https://github.com/llvm/llvm-project/pull/98055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Keith Smiley (keith) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/98055.diff 1 Files Affected: - (modified) lldb/tools/debugserver/source/PThreadMutex.h (+3-3) ``diff diff --git a/lldb/tools/debugserver/so

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

https://github.com/keith created https://github.com/llvm/llvm-project/pull/98055 None >From 6a6fc355e3623a0d0aacc465220a562e103e6dfc Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Mon, 8 Jul 2024 10:28:22 -0700 Subject: [PATCH] [lldb][NFC] Add maybe_unused to err used in asserts --- lldb/t

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

jeffreytan81 wrote: > @jeffreytan81 I think the callout for multiple exception is a good question. > I made a C# testbed to see what would happen if I had multiple simultaneous > exceptions. [Gist > here](https://gist.github.com/Jlalond/467bc990f10fbb75cc9ca7db897a7beb). When > manually colle

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

jimingham wrote: > CommandObjectBreakpoint has a harcoded list of languages for which exception > breakpoints can be enabled. I'm making this a bit more generic so that my > Mojo plugin can get this feature. Basically, I'm adding a new overridable > method `Language::SupportsExceptionBreakpoin

[Lldb-commits] [lldb] [lldb] Improve error message for unrecognized executables (PR #97490)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/97490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ed7e468 - [lldb] Improve error message for unrecognized executables (#97490)

Author: Jonas Devlieghere Date: 2024-07-08T09:29:01-07:00 New Revision: ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a URL: https://github.com/llvm/llvm-project/commit/ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a DIFF: https://github.com/llvm/llvm-project/commit/ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a.d

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

labath wrote: This explains why the `test_OneTargetTwoDebuggers` flavour of the test was crashing. It doesn't explain why would the other two versions crash. However I'm not sure if the other two flavours are indeed crashing (all of the crashes I've seen were in this flavour). https://github.

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fe8933b - [lldb][DataFormatter] Simplify std::map formatter (#97579)

Author: Michael Buch Date: 2024-07-08T17:19:25+01:00 New Revision: fe8933ba211da094dc866b2bde64928c8121131b URL: https://github.com/llvm/llvm-project/commit/fe8933ba211da094dc866b2bde64928c8121131b DIFF: https://github.com/llvm/llvm-project/commit/fe8933ba211da094dc866b2bde64928c8121131b.diff

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes In async mode, the test terminates sooner that it should (`run_to_source_breakpoint` does not work in this mode), and then the test crashes due to #98038. Most of the time, the test does not fail because its

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/98041 In async mode, the test terminates sooner that it should (`run_to_source_breakpoint` does not work in this mode), and then the test crashes due to #98038. Most of the time, the test does not fail because its alr

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

https://github.com/ayushsahay1837 edited https://github.com/llvm/llvm-project/pull/97630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [DynamicLoaderPOSIXDYLD] Enable POSIX-DYLD for QNX (PR #97536)

https://github.com/ayushsahay1837 edited https://github.com/llvm/llvm-project/pull/97536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [Platform] Introduce PlatformQNX (PR #97487)

https://github.com/ayushsahay1837 edited https://github.com/llvm/llvm-project/pull/97487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [ObjectFileELF] Detect QNX Neutrino RTOS targets (PR #97439)

https://github.com/ayushsahay1837 edited https://github.com/llvm/llvm-project/pull/97439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97713 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9dca3ac - [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (#97713)

Author: Michael Buch Date: 2024-07-08T15:56:05+01:00 New Revision: 9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd URL: https://github.com/llvm/llvm-project/commit/9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd DIFF: https://github.com/llvm/llvm-project/commit/9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd.diff

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/96654 >From be1646f4b41c5dced296a279b448624996c592d0 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Wed, 19 Jun 2024 23:50:18 + Subject: [PATCH] [lldb][test] Set target and host OS for API tests in ca

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

@@ -36,10 +38,17 @@ using namespace lldb; using namespace lldb_private; static sig_atomic_t g_signal_flags[NSIG]; +#if defined(__QNX__) +static llvm::DenseMap g_signal_info; labath wrote: This code is definitely not async-signal-safe. However, before you try

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

@@ -222,6 +232,148 @@ struct ForkLaunchInfo { // End of code running in the child process. +#if defined(__QNX__) +static ::pid_t PosixSpawn(const ForkLaunchInfo &info, labath wrote: This is basically reimplementing `LaunchProcessPosixSpawn` inside `ProcessL

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

https://github.com/labath commented: This is only a very light review. I agree with others that an RFC thread is a better place to discuss this. After we sort that out, this patch should be further subdivided into smaller pieces. https://github.com/llvm/llvm-project/pull/97630

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

@@ -35,6 +39,10 @@ #include #endif +#if !defined(EOK) labath wrote: Everything else just uses zero (`0`) as "no error". I don't see a reason for this code to be different. https://github.com/llvm/llvm-project/pull/97630

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97579 >From 223606fa569d4d9ced91461ec10e63ef414ad15e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Jul 2024 11:43:47 +0200 Subject: [PATCH] [lldb][DataFormatter] Simplify std::map formatter Depends on: *

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da827d0 - [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (#97754)

Author: Michael Buch Date: 2024-07-08T14:38:58+01:00 New Revision: da827d0896e5e66fe9130f8f4479537d3bbee1da URL: https://github.com/llvm/llvm-project/commit/da827d0896e5e66fe9130f8f4479537d3bbee1da DIFF: https://github.com/llvm/llvm-project/commit/da827d0896e5e66fe9130f8f4479537d3bbee1da.diff

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97754 >From b10f76bd6d02106e80315a70a7b72461cb6f2a99 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 4 Jul 2024 13:35:21 +0200 Subject: [PATCH 1/3] [lldb][DataFormatter] Move std::unordered_map::iterator for

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

@@ -456,3 +477,97 @@ lldb_private::formatters::LibcxxStdMapSyntheticFrontEndCreator( CXXSyntheticChildren *, lldb::ValueObjectSP valobj_sp) { return (valobj_sp ? new LibcxxStdMapSyntheticFrontEnd(valobj_sp) : nullptr); } + +lldb_private::formatters::LibCxxMapIteratorSynt

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97713 >From f6b3e6055a9e2263f61e3f70d7a97ddbb7db5ab0 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 4 Jul 2024 09:30:19 +0200 Subject: [PATCH 1/7] [lldb][DataFormatter][NFC] Move std::map iterator formatter

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97713 >From f6b3e6055a9e2263f61e3f70d7a97ddbb7db5ab0 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 4 Jul 2024 09:30:19 +0200 Subject: [PATCH 1/6] [lldb][DataFormatter][NFC] Move std::map iterator formatter

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

@@ -56,6 +56,10 @@ def target_is_android(): return configuration.lldb_platform_name == "remote-android" +def target_is_remote_linux(): +return configuration.lldb_platform_name == "remote-linux" + + labath wrote: I guess this isn't used anymore. http

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

@@ -92,11 +96,22 @@ def match_android_device(device_arch, valid_archs=None, valid_api_levels=None): def finalize_build_dictionary(dictionary): +if dictionary is None: +dictionary = {} if target_is_android(): -if dictionary is None: -dicti

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/97579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97754 >From b10f76bd6d02106e80315a70a7b72461cb6f2a99 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 4 Jul 2024 13:35:21 +0200 Subject: [PATCH 1/2] [lldb][DataFormatter] Move std::unordered_map::iterator for

[Lldb-commits] [lldb] [lldb][DataFormatter] Move std::unordered_map::iterator formatter into LibCxxUnorderedMap.cpp (PR #97752)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cb72aec - [lldb][DataFormatter] Move std::unordered_map::iterator formatter into LibCxxUnorderedMap.cpp (#97752)

Author: Michael Buch Date: 2024-07-08T13:48:06+01:00 New Revision: cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba URL: https://github.com/llvm/llvm-project/commit/cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba DIFF: https://github.com/llvm/llvm-project/commit/cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba.diff

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1e6dfc6 - [lldb][DataFormatter] Remove support for old std::map layout (#97549)

Author: Michael Buch Date: 2024-07-08T13:47:44+01:00 New Revision: 1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc URL: https://github.com/llvm/llvm-project/commit/1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc DIFF: https://github.com/llvm/llvm-project/commit/1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc.diff

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 857700ff6fb9f9f653c3788445df06db07e7bb59...c107d5d43ed4f696bb2095b2a7d32ca59696f220 lldb/

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/96654 >From c107d5d43ed4f696bb2095b2a7d32ca59696f220 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Wed, 19 Jun 2024 23:50:18 + Subject: [PATCH] [lldb][test] Set target and host OS for API tests in ca

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

dzhidzhoev wrote: Could you please give your opinion @JDevlieghere ? https://github.com/llvm/llvm-project/pull/95986 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/97328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 857700f - [lldb][test] Fix type error when calling random.randrange with 'float' arg (#97328)

Author: Kendal Harland Date: 2024-07-08T12:22:03+02:00 New Revision: 857700ff6fb9f9f653c3788445df06db07e7bb59 URL: https://github.com/llvm/llvm-project/commit/857700ff6fb9f9f653c3788445df06db07e7bb59 DIFF: https://github.com/llvm/llvm-project/commit/857700ff6fb9f9f653c3788445df06db07e7bb59.diff

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/97328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] 4c23625 - Fix flake in TestZerothFrame.py (#96685)

Author: Kendal Harland Date: 2024-07-08T12:20:45+02:00 New Revision: 4c23625357b0b6091bc97478a79d522a832c2b21 URL: https://github.com/llvm/llvm-project/commit/4c23625357b0b6091bc97478a79d522a832c2b21 DIFF: https://github.com/llvm/llvm-project/commit/4c23625357b0b6091bc97478a79d522a832c2b21.diff

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/96685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/96685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/97754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

@@ -246,3 +270,119 @@ lldb_private::formatters::LibcxxStdUnorderedMapSyntheticFrontEndCreator( return (valobj_sp ? new LibcxxStdUnorderedMapSyntheticFrontEnd(valobj_sp) : nullptr); } + +lldb_private::formatters::LibCxxUnorderedMapIteratorSyntheticFrontEnd

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97713 >From f6b3e6055a9e2263f61e3f70d7a97ddbb7db5ab0 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 4 Jul 2024 09:30:19 +0200 Subject: [PATCH 1/2] [lldb][DataFormatter][NFC] Move std::map iterator formatter

[Lldb-commits] [lldb] [lldb][DataFormatter] Move std::unordered_map::iterator formatter into LibCxxUnorderedMap.cpp (PR #97752)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/97752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

@@ -456,3 +477,97 @@ lldb_private::formatters::LibcxxStdMapSyntheticFrontEndCreator( CXXSyntheticChildren *, lldb::ValueObjectSP valobj_sp) { return (valobj_sp ? new LibcxxStdMapSyntheticFrontEnd(valobj_sp) : nullptr); } + +lldb_private::formatters::LibCxxMapIteratorSynt

  1   2   >