Troy-Butler wrote:
I apologize - I'm not sure how this happened. I was careful to refresh my
fork/clone before starting on this issue, but somehow not all of the files were
updated, and now my PR requests are getting wires crossed. I think it would be
safest for me to close this issue, delete
https://github.com/Troy-Butler closed
https://github.com/llvm/llvm-project/pull/89480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
+1 on what Cyndy said. The lldb change itself looks fine.
https://github.com/llvm/llvm-project/pull/89480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
cyndyishida wrote:
It appears your PR branch is based on a stale version of the target `llvm/main`
branch, resulting in more commits than what this PR intended for. Please merge
in the target branch and resolve any conflicts.
https://github.com/llvm/llvm-project/pull/89480
___
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Troy Butler (Troy-Butler)
Changes
Addresses issue #85984
---
Full diff: https://github.com/llvm/llvm-project/pull/89480.diff
6 Files Affected:
- (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h
(+2-2)
- (modifi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Troy Butler (Troy-Butler)
Changes
Addresses issue #85984
---
Full diff: https://github.com/llvm/llvm-project/pull/89480.diff
6 Files Affected:
- (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h
(+2-2)
- (modifie
https://github.com/Troy-Butler created
https://github.com/llvm/llvm-project/pull/89480
Addresses issue #85984
>From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001
From: Troy-Butler
Date: Mon, 25 Mar 2024 13:28:45 -0400
Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant Cond
https://github.com/hawkinsw commented:
I hate when I can only contribute nits, but I wanted to try to be helpful!
https://github.com/llvm/llvm-project/pull/89357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies.
//
// Response is F, followed by the number of bytes written (base 16)
+//--
+// vFile:MD5:
+//
+// BRIEF
+// Generate an MD5 hash of the
https://github.com/hawkinsw edited
https://github.com/llvm/llvm-project/pull/89357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-19T16:41:07-07:00
New Revision: 6a35ee8077647b32626c3c41f9d9da4dae6670fc
URL:
https://github.com/llvm/llvm-project/commit/6a35ee8077647b32626c3c41f9d9da4dae6670fc
DIFF:
https://github.com/llvm/llvm-project/commit/6a35ee8077647b32626c3c41f9d9da4dae6670fc.diff
Author: Adrian Prantl
Date: 2024-04-19T16:37:09-07:00
New Revision: c8627e4e0c8ac453844638522b887ac7b7687672
URL:
https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672
DIFF:
https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672.diff
@@ -104,3 +127,27 @@ def test_empty_escape_prefix(self):
"Help can be invoked",
command_escape_prefix="",
)
+
+@skipIfWindows
+@skipIfRemote
+def test_exit_status_message(self):
+source = "main.cpp"
+program = self.get
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Nicolas van Kempen
Date: 2024-04-19T14:00:13-07:00
New Revision: 5232cec8f947ed8bff4ca57f990954228d58e66d
URL:
https://github.com/llvm/llvm-project/commit/5232cec8f947ed8bff4ca57f990954228d58e66d
DIFF:
https://github.com/llvm/llvm-project/commit/5232cec8f947ed8bff4ca57f990954228d58e66d.
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/89140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From 3a69226e9ca90bb7ae220b9c3a71a0c2371e52fc Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
nicovank wrote:
Maybe @kazutakahirata (or anyone else) can stamp the minor `clang-doc` change?
I don't have commit access, feel free to hit merge when everything is in order
👍 .
https://github.com/llvm/llvm-project/pull/89140
___
lldb-commits mailing
https://github.com/mbucko edited https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From 31d688e70beec442cf731986ff8e4c8e9b5a9f0c Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/JDevlieghere approved this pull request.
LLDB & VFS change LGTM.
https://github.com/llvm/llvm-project/pull/89140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Awfa edited https://github.com/llvm/llvm-project/pull/89357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies.
//
// Response is F, followed by the number of bytes written (base 16)
+//--
+// vFile:MD5:
+//
+// BRIEF
+// Generate an MD5 hash of the
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/89433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-19T13:14:55-07:00
New Revision: 08163cd9d82690e808c28515523b5fd0923d7b38
URL:
https://github.com/llvm/llvm-project/commit/08163cd9d82690e808c28515523b5fd0923d7b38
DIFF:
https://github.com/llvm/llvm-project/commit/08163cd9d82690e808c28515523b5fd0923d7b38.diff
Awfa wrote:
Thanks for taking a look at the build. I will do a new PR addressing the issues.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/bulbazord approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/89445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89433
>From 162907c6527464f828756b7152e2364ae3be88b5 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 19 Apr 2024 11:08:16 -0700
Subject: [PATCH] [lldb] Provide a better error message for missing symbols
nicovank wrote:
Added one missed instance due to CMake configuration options.
https://github.com/llvm/llvm-project/pull/89140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89140
>From 2c82316a0f6641b93c666143211a87f06de8feab Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Wed, 17 Apr 2024 14:27:42 -0400
Subject: [PATCH] Apply modernize-use-starts-ends-with on llvm-project
---
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Christensen (mdko)
Changes
Very minor change to help message on `process save-core`. Adds space between
two sentences explaining the `-p` option:
"Specify a plugin name to create the core file.This allows core files to be
saved i
https://github.com/mdko created https://github.com/llvm/llvm-project/pull/89445
Very minor change to help message on `process save-core`. Adds space between
two sentences explaining the `-p` option:
"Specify a plugin name to create the core file.This allows core files to be
saved in different
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -431,7 +431,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error,
lldb::addr_t &func_addr,
}
m_failed_lookups.clear();
-
+ss.PutCString(
+"\nHint: The expression tried to call a function missing from the "
+"target, perhaps because it was op
https://github.com/JDevlieghere approved this pull request.
LGMT with the formatting fixed.
https://github.com/llvm/llvm-project/pull/89433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/jeffreytan81 approved this pull request.
Looks good. Please undo the "{}" in the single line comment.
https://github.com/llvm/llvm-project/pull/88564
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -649,16 +651,25 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
DataBufferHeap helper_data;
std::vector mem_descriptors;
for (const auto &core_range : core_ranges) {
-// Skip empty memory regions or any regions with no permissions.
-if
https://github.com/felipepiovezan approved this pull request.
This LGTM!
I like the wording in the sense that it uses a slightly less "systemy"
language, and so it becomes less cryptic to a wider audience.
https://github.com/llvm/llvm-project/pull/89433
_
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4841d70a4b7d7cd8c492c16a9da339ec75bca135...d57f2adff84dc5148c417135aa4733e05476876c
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This adds a hint to the missing symbols error message to make it easier to
understand what this means to users.
---
Full diff: https://github.com/llvm/llvm-project/pull/89433.diff
2 Files Affected:
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/89433
This adds a hint to the missing symbols error message to make it easier to
understand what this means to users.
>From d57f2adff84dc5148c417135aa4733e05476876c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/89427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This removes `m_forward_decl_die_to_compiler_type` which is a map from `const
DWARFDebugInfoEntry *` to `lldb::opaque_compiler_type_t`. This map is currently
used in `DWARFASTParserClang::ParseEnum` and
`DWARF
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/89427
This removes `m_forward_decl_die_to_compiler_type` which is a map from `const
DWARFDebugInfoEntry *` to `lldb::opaque_compiler_type_t`. This map is currently
used in `DWARFASTParserClang::ParseEnum` and
`DWARF
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies.
//
// Response is F, followed by the number of bytes written (base 16)
+//--
+// vFile:MD5:
+//
+// BRIEF
+// Generate an MD5 hash of the
bulbazord wrote:
> I got an email that the build failed and I should revert because of this:
> https://lab.llvm.org/buildbot/#/builders/68/builds/72623
>
> @bulbazord can you or someone with write permissions revert this PR so I have
> time to triage the issue?
As David said, no need since th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Fangrui Song (MaskRay)
Changes
Test that ld.lld --debug-names (#86508) built per-module index can be
consumed by lldb. This has uncovered a bug during the development of the
lld feature.
---
Full diff: https://github.com/llvm/llvm-project/p
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/88335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/MaskRay ready_for_review
https://github.com/llvm/llvm-project/pull/88335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/88335
>From 210b1e85f2d827a7c57f3b1106d876d2e0f18511 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Wed, 10 Apr 2024 18:03:57 -0700
Subject: [PATCH] [lldb/test] Add basic ld.lld --debug-names tests
Test that ld.lld
walter-erquinigo wrote:
Yep, please write a python test. A possible idea is to have a target that does
nothing for 10 seconds, during which you kill the debug server (lldb-server or
debugserver) and then you assert on the final message sent by lldb-vscode.
https://github.com/llvm/llvm-project/
JDevlieghere wrote:
Is it possible to test this, for example by explicitly killing the debug stub?
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
kevinfrei wrote:
You generally have to tag people with an at sign to get their attention :)
@jeffreytan81 @clayborg @kusmour
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Miro Bucko (mbucko)
Changes
Summary:
When the target inferior process that is being debugged exits in lldb command
line, it emits following message:
`Process 4049526 exited with status = -1 (0x) debugserver died with
signal SIGTERM
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/89405
Summary:
When the target inferior process that is being debugged exits in lldb command
line, it emits following message:
`Process 4049526 exited with status = -1 (0x) debugserver died with
signal SIGTERM`
amordo wrote:
Applied @DavidSpickett's remark
https://github.com/llvm/llvm-project/pull/89037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/amordo updated
https://github.com/llvm/llvm-project/pull/89037
>From 1a2ae41cf5004439c534bc71eb6b8911f7bf0a0a Mon Sep 17 00:00:00 2001
From: Alexander Mordovskiy
Date: Fri, 19 Apr 2024 17:21:05 +0200
Subject: [PATCH] [lldb] check python extension debug suffix on Win
ae389b24
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/89183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-04-19T14:16:09+02:00
New Revision: e7c042f12fd6f3e9aeb37854d499aada8457
URL:
https://github.com/llvm/llvm-project/commit/e7c042f12fd6f3e9aeb37854d499aada8457
DIFF:
https://github.com/llvm/llvm-project/commit/e7c042f12fd6f3e9aeb37854d499aada8457.diff
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/89183
>From 80ba4f24cdfe8b5f2aa44a016ea69ad08f56d558 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 18 Apr 2024 07:34:45 +
Subject: [PATCH 1/2] [lldb] Make SBType::FindDirectNestedType work with
expression
labath wrote:
> @Michael137 suggested that I check that performance of `FindDirectNestedType`
> doesn't regress (at least for my use case), since I have custom
> instrumentation in my formatter. I can confirm that 3 versions of this
> function (#68705, #74786, and this PR) exhibit the same lev
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/89183
>From 80ba4f24cdfe8b5f2aa44a016ea69ad08f56d558 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 18 Apr 2024 07:34:45 +
Subject: [PATCH 1/2] [lldb] Make SBType::FindDirectNestedType work with
expression
DavidSpickett wrote:
Please address @JDevlieghere's comments in a new PR.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> @bulbazord can you or someone with write permissions revert this PR so I have
> time to triage the issue?
The next build is green, those DAP tests do fail once in a while so it's
unrelated to your change.
https://github.com/llvm/llvm-project/pull/88812
_
DavidSpickett wrote:
> So a good follow up PR would be to list it in that document. It's self
> explanatory but still, weird that it's not there.
https://github.com/llvm/llvm-project/pull/89357
https://github.com/llvm/llvm-project/pull/88812
___
lldb
DavidSpickett wrote:
Ideally they'd be in some sort of order but they are already not, and I'm
thinking it would be good to get these on the website anyway. So I'm leaving
concerns like that until later.
https://github.com/llvm/llvm-project/pull/89357
__
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
These are extensions the lldb platform has to:
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Host-I_002fO-Packets.html#Host-I_002fO-Packets
---
Full diff: https://github.com/llvm/llvm-project/
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/89357
These are extensions the lldb platform has to:
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Host-I_002fO-Packets.html#Host-I_002fO-Packets
>From 518cb052ee364192fc5c813a2962f80f39345cd5 Mon Sep 17
Endilll wrote:
@Michael137 suggested that I check that performance of `FindDirectNestedType`
doesn't regress (at least for my use case), since I have custom instrumentation
in my formatter. I can confirm that 3 versions of this function (#68705,
#74786, and this PR) exhibit the same level of p
Awfa wrote:
I got an email that the build failed and I should revert because of this:
https://lab.llvm.org/buildbot/#/builders/68/builds/72623
@bulbazord can you or someone with write permissions revert this PR so I have
time to triage the issue?
https://github.com/llvm/llvm-project/pull/8881
74 matches
Mail list logo
