https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/89324
>From b6021cf31e4c607dc4d541b4dd3b028e93050767 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 18 Apr 2024 15:02:37 -0700
Subject: [PATCH 1/3] Check for null oso SymbolFile in
SymbolFileDwarfDebugMap::Res
https://github.com/JDevlieghere approved this pull request.
LGTM with Alex' suggestion and the code formatted.
https://github.com/llvm/llvm-project/pull/89324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/89324
>From b6021cf31e4c607dc4d541b4dd3b028e93050767 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 18 Apr 2024 15:02:37 -0700
Subject: [PATCH 1/2] Check for null oso SymbolFile in
SymbolFileDwarfDebugMap::Res
@@ -848,9 +848,18 @@ SymbolFileDWARFDebugMap::ResolveSymbolContext(const
Address &exe_so_addr,
debug_map_entry->data.GetOSOFileAddress();
Address oso_so_addr;
if (oso_module->ResolveFileAddress(oso_file_addr, oso_so_addr)) {
-
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/89324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/89324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6f1e23b47d428d792866993ed26f4173d479d43d
b6021cf31e4c607dc4d541b4dd3b028e93050767 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The couple other places that use the oso module's SymbolFile, they check that
it's non-null, so this is just an oversight in ResolveSymbolContext.
I didn't add a test for this (but did add a log message for the err
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/89324
The couple other places that use the oso module's SymbolFile, they check that
it's non-null, so this is just an oversight in ResolveSymbolContext.
I didn't add a test for this (but did add a log message for th
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3419,7 +3419,7 @@ bool GDBRemoteCommunicationClient::GetFileExists(
}
bool GDBRemoteCommunicationClient::CalculateMD5(
-const lldb_private::FileSpec &file_spec, uint64_t &high, uint64_t &low) {
+const lldb_private::FileSpec &file_spec, uint64_t &low, uint64_t &high
@@ -1197,6 +1197,32 @@ Status Platform::PutFile(const FileSpec &source, const
FileSpec &destination,
if (!source_file)
return Status(source_file.takeError());
Status error;
+
+ bool requires_upload = true;
+ uint64_t dest_md5_low, dest_md5_high;
+ bool success = Cal
github-actions[bot] wrote:
@Awfa Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build, yo
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Anthony Ha
Date: 2024-04-18T12:24:24-07:00
New Revision: 22c26fa13d46e174e3d862e5f40cff06d804af0c
URL:
https://github.com/llvm/llvm-project/commit/22c26fa13d46e174e3d862e5f40cff06d804af0c
DIFF:
https://github.com/llvm/llvm-project/commit/22c26fa13d46e174e3d862e5f40cff06d804af0c.diff
LO
bulbazord wrote:
> Someone will have to merge for me because it says "Only those with write
> access to this repository can merge pull requests."
>
> Am I supposed to request write access somewhere before making these PRs? I
> haven't contributed before.
First time contributors aren't expecte
JDevlieghere wrote:
Can you please put up a follow-up that removes the code instead of commenting
it out?
https://github.com/llvm/llvm-project/pull/89267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
Awfa wrote:
Someone will have to merge for me because it says "Only those with write access
to this repository can merge pull requests."
Am I supposed to request write access somewhere before making these PRs? I
haven't contributed before.
https://github.com/llvm/llvm-project/pull/88812
_
ayermolo wrote:
Thanks.
It's failing internally in our automatic multi stage build. Trying to dig into
it as part of my oncall. :)
https://github.com/llvm/llvm-project/pull/89266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
This member variable is completely unused. I also don't think it makes a ton of
sense since (1) The "base address" can be obtained from the first Instruction
in its InstructionList, and (2) InstructionList
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/89289
This member variable is completely unused. I also don't think it makes a ton of
sense since (1) The "base address" can be obtained from the first Instruction
in its InstructionList, and (2) InstructionLists ma
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/89260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan Rupprecht
Date: 2024-04-18T13:17:39-05:00
New Revision: 0e5c28d1930e7210f0f293312382c54d298dda06
URL:
https://github.com/llvm/llvm-project/commit/0e5c28d1930e7210f0f293312382c54d298dda06
DIFF:
https://github.com/llvm/llvm-project/commit/0e5c28d1930e7210f0f293312382c54d298dda06.di
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
Ok, submitted https://github.com/llvm/llvm-project/issues/89271 for the MD5
migration. I agree that issue does not block this change.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
Author: Fred Grim
Date: 2024-04-18T10:29:39-07:00
New Revision: 98427264cab558d285c7222f1f25b904124c6b93
URL:
https://github.com/llvm/llvm-project/commit/98427264cab558d285c7222f1f25b904124c6b93
DIFF:
https://github.com/llvm/llvm-project/commit/98427264cab558d285c7222f1f25b904124c6b93.diff
LOG
https://github.com/feg208 closed https://github.com/llvm/llvm-project/pull/89267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/compnerd approved this pull request.
Approving it in case it needs to be merged, but I think that we should try to
determine how it is breaking. This change feels like it should be correct and
is a pretty good cleanup, so I would prefer that fix forward rather than revert.
h
feg208 wrote:
I had to just comment this test out because it randomly fails on at least
x86_64 and arm
https://github.com/llvm/llvm-project/pull/89267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/89267
>From 24fa0fc2f54ef4141302ed7178ee0dc1b6d6af4e Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Thu, 18 Apr 2024 10:13:03 -0700
Subject: [PATCH] this test is flakey on arm in linux because I got too clever
---
lld
etcwilde wrote:
@ayermolo, one idea might be to see if `clang-resource-headers` is in the
install distribution list? I'm not seeing a matching `get_property` in a
CMakeLists.txt that matches the above error exactly, so I'm not sure how to
reproduce this or how you're picking up the clang-resou
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Fred Grim (feg208)
Changes
the assembly jazz doesn't work on arm. oops
---
Full diff: https://github.com/llvm/llvm-project/pull/89267.diff
1 Files Affected:
- (modified) lldb/unittests/Host/linux/HostTest.cpp (+2-1)
``diff
dif
https://github.com/feg208 created
https://github.com/llvm/llvm-project/pull/89267
the assembly jazz doesn't work on arm. oops
>From 13e982588d75b240ce515c8ff1b2d9c89a595908 Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Thu, 18 Apr 2024 10:13:03 -0700
Subject: [PATCH] this test is flakey on ar
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-backend-x86
Author: Evan Wilde (etcwilde)
Changes
This reverts commit 8d468c132eed7ffe34d601b224220efd51655eb3.
@ayermolo reports seeing the following error when the
clang-resource-headers are a library instead of a custom tar
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Evan Wilde (etcwilde)
Changes
This reverts commit 8d468c132eed7ffe34d601b224220efd51655eb3.
@ayermolo reports seeing the following error when the
clang-resource-headers are a library instead of a custom target:
```
CMake Error at CMakeLis
https://github.com/etcwilde created
https://github.com/llvm/llvm-project/pull/89266
This reverts commit 8d468c132eed7ffe34d601b224220efd51655eb3.
@ayermolo reports seeing the following error when the clang-resource-headers
are a library instead of a custom target:
```
CMake Error at CMakeLists
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Can we get (a subset) of this information on Darwin? I understand it's only
necessary for ELF core files, and from the discussion that there's no standard
POSIX way to get this, but it still feels a bit unfortunate to implement all
these methods but only implement this for
https://github.com/feg208 closed https://github.com/llvm/llvm-project/pull/88995
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Fred Grim
Date: 2024-04-18T09:46:58-07:00
New Revision: 468107904098e0b5d32db710db80907befde614e
URL:
https://github.com/llvm/llvm-project/commit/468107904098e0b5d32db710db80907befde614e
DIFF:
https://github.com/llvm/llvm-project/commit/468107904098e0b5d32db710db80907befde614e.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
The `LLDB_TEST_USE_VENDOR_PACKAGES` has defaulted to `Off` for a while. Either
installing `pexpect` or skipping those tests with
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/89260
The `LLDB_TEST_USE_VENDOR_PACKAGES` has defaulted to `Off` for a while. Either
installing `pexpect` or skipping those tests with
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` seems to be enough that we can
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/89113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2024-04-18T09:24:33-07:00
New Revision: 6870ac201f9f50a13313213fea7a14b198d7280a
URL:
https://github.com/llvm/llvm-project/commit/6870ac201f9f50a13313213fea7a14b198d7280a
DIFF:
https://github.com/llvm/llvm-project/commit/6870ac201f9f50a13313213fea7a14b198d7280a.diff
Author: Zequan Wu
Date: 2024-04-18T11:13:17-04:00
New Revision: d3993ac1890731d2b24543646961c95680788207
URL:
https://github.com/llvm/llvm-project/commit/d3993ac1890731d2b24543646961c95680788207
DIFF:
https://github.com/llvm/llvm-project/commit/d3993ac1890731d2b24543646961c95680788207.diff
LOG
Author: Zequan Wu
Date: 2024-04-18T10:40:35-04:00
New Revision: a1e7c83af11ee111994ec19029494e6e9ea97dbd
URL:
https://github.com/llvm/llvm-project/commit/a1e7c83af11ee111994ec19029494e6e9ea97dbd
DIFF:
https://github.com/llvm/llvm-project/commit/a1e7c83af11ee111994ec19029494e6e9ea97dbd.diff
LOG
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/87649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/89183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > > One thing I'd like to get feedback on is whether this should be looking
> > > into base classes. The discussion on the original PR focuses on lexically
> > > nested types, but going through base classes (following usual language
> > > rules) is another form of nesting. Both
@@ -36,9 +36,7 @@ DAP::DAP()
{{"cpp_catch", "C++ Catch", lldb::eLanguageTypeC_plus_plus},
{"cpp_throw", "C++ Throw", lldb::eLanguageTypeC_plus_plus},
{"objc_catch", "Objective-C Catch", lldb::eLanguageTypeObjC},
- {"objc_throw", "Object
Michael137 wrote:
> > One thing I'd like to get feedback on is whether this should be looking
> > into base classes. The discussion on the original PR focuses on lexically
> > nested types, but going through base classes (following usual language
> > rules) is another form of nesting. Both the
DavidSpickett wrote:
@bulbazord please give the final approval if it looks good to you.
We can sort out moving from MD5 on an issue.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) {
exit(socket_error);
}
printf("Connection established.\n");
+
if (g_server) {
// Collect child zombie processes.
#if !defined(_WIN32)
- while (waitpid(-1, nullptr, WNOHANG) > 0)
-
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) {
exit(socket_error);
}
printf("Connection established.\n");
+
if (g_server) {
// Collect child zombie processes.
#if !defined(_WIN32)
- while (waitpid(-1, nullptr, WNOHANG) > 0)
-
@@ -282,17 +282,10 @@ int main_platform(int argc, char *argv[]) {
}
}
- do {
-GDBRemoteCommunicationServerPlatform platform(
-acceptor_up->GetSocketProtocol(), acceptor_up->GetSocketScheme());
-
-if (port_offset > 0)
DavidSpickett wrote:
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) {
exit(socket_error);
}
printf("Connection established.\n");
+
if (g_server) {
// Collect child zombie processes.
#if !defined(_WIN32)
- while (waitpid(-1, nullptr, WNOHANG) > 0)
-
Endilll wrote:
> One thing I'd like to get feedback on is whether this should be looking into
> base classes. The discussion on the original PR focuses on lexically nested
> types, but going through base classes (following usual language rules) is
> another form of nesting. Both the existing a
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/89183
>From 80ba4f24cdfe8b5f2aa44a016ea69ad08f56d558 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 18 Apr 2024 07:34:45 +
Subject: [PATCH] [lldb] Make SBType::FindDirectNestedType work with expression
ASTs
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/89183
>From c24f35cb4f568c42da9a11c7d91cfbaf7bf2f59e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 18 Apr 2024 07:34:45 +
Subject: [PATCH] [lldb] Make SBType::FindDirectNestedType work with expression
ASTs
labath wrote:
In terms of #68705, I think this will fix the issue where the data formatter
works on `frame var foo` but not `expr -- foo`. At least that's the problem I
ran into when trying to use this in my own formatter..
One thing I'd like to get feedback on is whether this should be lookin
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3c721b90d363bf73b78467f6e86c879235bac1b2
d8e6fdff0df7b1a2e9242d747831966c5db03e44 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
3c721b90d363bf73b78467f6e86c879235bac1b2...d8e6fdff0df7b1a2e9242d747831966c5db03e44
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The types we get out of expressions will not have an associated symbol file, so
the current method of looking up the type will fail. Instead, I plumb the query
through the TypeSystem class. This correctly find
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/89183
The types we get out of expressions will not have an associated symbol file, so
the current method of looking up the type will fail. Instead, I plumb the query
through the TypeSystem class. This correctly finds t
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/89042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-04-18T09:08:53+01:00
New Revision: 03e841c870e7beccf1368e566045e233b3bd8db5
URL:
https://github.com/llvm/llvm-project/commit/03e841c870e7beccf1368e566045e233b3bd8db5
DIFF:
https://github.com/llvm/llvm-project/commit/03e841c870e7beccf1368e566045e233b3bd8db5.diff
Author: Pavel Labath
Date: 2024-04-18T07:30:18Z
New Revision: 3c721b90d363bf73b78467f6e86c879235bac1b2
URL:
https://github.com/llvm/llvm-project/commit/3c721b90d363bf73b78467f6e86c879235bac1b2
DIFF:
https://github.com/llvm/llvm-project/commit/3c721b90d363bf73b78467f6e86c879235bac1b2.diff
LOG:
67 matches
Mail list logo
