[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-01 Thread Mehdi Amini via lldb-commits
@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [lldb] Add SBProcess methods for get/set/use address masks (PR #83095)

2024-03-01 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: After debugging, updating, and testing on aarch64-unbuntu, x86_64-macos, and arm64-macos, I have created a new PR with this commit plus an additional commit to fix the issues I found on the different platforms. https://github.com/llvm/llvm-project/pull/83663 https://github

[Lldb-commits] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

2024-03-01 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: @DavidSpickett I spent a little time debugging this on aarch64-ubuntu and also testing on x86_64-macos (which has no address masks at all). This PR has the original commit from https://github.com/llvm/llvm-project/pull/83095 and then a second commit with the changes I need

[Lldb-commits] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

2024-03-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/83663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

2024-03-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes [lldb] Add SBProcess methods for get/set/use address masks (#83095) I'm reviving a patch from phabracator, https://reviews.llvm.org/D155905 which was approved but I wasn't thrilled with all the API I was

[Lldb-commits] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

2024-03-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/83663 [lldb] Add SBProcess methods for get/set/use address masks (#83095) I'm reviving a patch from phabracator, https://reviews.llvm.org/D155905 which was approved but I wasn't thrilled with all the API I was add

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-01 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From fa249b44a8bbcbc7b0da148c51acd5792f393869 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-01 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From e2a6d2860c21489445a87bfd4ced85108462f601 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > Why not increase TypeSystem::GetNumChildren to return a size_t instead? > > We could, but even 2^32 seems like an outrageous amount of children to me. > What would be a use-case for this? A ValueObject that has the entire address > space as synthetic children? > > Ther

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-01 Thread via lldb-commits
jimingham wrote: I got one bug report - which I can't currently find - from someone who had managed to make a thing this big and we wouldn't print elements out of it correctly. We didn't do anything about it at the time, it did seem silly. But it WAS actually silly, at least once. Jim > On

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-01 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Why not increase TypeSystem::GetNumChildren to return a size_t instead? We could, but even 2^32 seems like an outrageous amount of children to me. What would be a use-case for this? A ValueObject that has the entire address space as synthetic children? There is other co

[Lldb-commits] [lldb] ebaf26d - [lldb] Fix -Wformat after #83602

2024-03-01 Thread Fangrui Song via lldb-commits
Author: Fangrui Song Date: 2024-03-01T12:09:32-08:00 New Revision: ebaf26dabec00c32177cd4fa47f3bf5902b194b7 URL: https://github.com/llvm/llvm-project/commit/ebaf26dabec00c32177cd4fa47f3bf5902b194b7 DIFF: https://github.com/llvm/llvm-project/commit/ebaf26dabec00c32177cd4fa47f3bf5902b194b7.diff

[Lldb-commits] [lldb] [lldb] Fix `thread backtrace --count` (PR #83602)

2024-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/83602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] af00945 - [lldb] Fix `thread backtrace --count` (#83602)

2024-03-01 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-01T11:06:58-08:00 New Revision: af009451ec439593554f03bc714e46ad2cd41738 URL: https://github.com/llvm/llvm-project/commit/af009451ec439593554f03bc714e46ad2cd41738 DIFF: https://github.com/llvm/llvm-project/commit/af009451ec439593554f03bc714e46ad2cd41738.d

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-03-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/83069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 137ed17 - [lldb][progress] Hook up new broadcast bit and progress manager (#83069)

2024-03-01 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-03-01T10:56:45-08:00 New Revision: 137ed17016757a6caea9db70ee6408dc3e2f6232 URL: https://github.com/llvm/llvm-project/commit/137ed17016757a6caea9db70ee6408dc3e2f6232 DIFF: https://github.com/llvm/llvm-project/commit/137ed17016757a6caea9db70ee6408dc3e2f6232.d

[Lldb-commits] [lldb] [lldb][X86] Fix setting target features in ClangExpressionParser (PR #82364)

2024-03-01 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I'll defer to @Michael137 but if he's okay with this, I'm fine with it. https://github.com/llvm/llvm-project/pull/82364 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb] Fix `thread backtrace --count` (PR #83602)

2024-03-01 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM. We really need to get option values to parse somewhere more generically so we don't have to change so many places just to get a good error for value conversion, but that's not this PR's fault... https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [lldb] Log to system log instead of stderr from Host::SystemLog (PR #83366)

2024-03-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @rupprecht @oontvoo How do you feel about the current approach? The other alternative is to make this function a NOOP on all platforms but Darwin (where I want to actively use it). It's not currently load bearing (except the log, which is opt-in). https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb] Fix `thread backtrace --count` (PR #83602)

2024-03-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The help output for `thread backtrace` specifies that you can pass -1 to `--count` to display all the frames. ``` -c ( --count ) How many frames to display (-1 for all) `

[Lldb-commits] [lldb] [lldb] Fix `thread backtrace --count` (PR #83602)

2024-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/83602 The help output for `thread backtrace` specifies that you can pass -1 to `--count` to display all the frames. ``` -c ( --count ) How many frames to display (-1 for all) ``` However, that does

[Lldb-commits] [lldb] [lldb] Add support for sorting by size to `target module dump symtab` (PR #83527)

2024-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/83527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8fa3301 - [lldb] Add support for sorting by size to `target module dump symtab` (#83527)

2024-03-01 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-01T08:34:36-08:00 New Revision: 8fa33013de5d2c47da93083642cf9f655a3d9722 URL: https://github.com/llvm/llvm-project/commit/8fa33013de5d2c47da93083642cf9f655a3d9722 DIFF: https://github.com/llvm/llvm-project/commit/8fa33013de5d2c47da93083642cf9f655a3d9722.d

[Lldb-commits] [lldb] [lldb][test] Add test for chained PCH debugging (PR #83582)

2024-03-01 Thread Michael Buch via lldb-commits
@@ -0,0 +1,73 @@ +""" +Tests that we correctly track AST layout info +(specifically alignment) when moving AST nodes +between several ClangASTImporter instances +(in this case, from a pch chain to executable +to expression AST). +""" + +import lldb +import os +from lldbsuite.test.

[Lldb-commits] [lldb] [lldb][test] Add test for chained PCH debugging (PR #83582)

2024-03-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Adds a test-case for debugging a program with a pch chain, that is, the main executable depends on a pch that itself included another pch. Currently clang doesn't emit the sekeleton CUs required for LLDB to

[Lldb-commits] [lldb] [lldb][test] Add test for chained PCH debugging (PR #83582)

2024-03-01 Thread Michael Buch via lldb-commits
@@ -0,0 +1,10 @@ +include Makefile.rules + +OBJECTS += main.o + +$(EXE): $(BUILDDIR)/main.o + +$(BUILDDIR)/main.o: main.cpp + $(CC) -cc1 -emit-pch -x c++-header -fmodule-format=obj -fmodules -O0 -dwarf-ext-refs -debug-info-kind=standalone $(SRCDIR)/base-pch.h -o base-pch.h

[Lldb-commits] [lldb] [lldb][test] Add test for chained PCH debugging (PR #83582)

2024-03-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/83582 Adds a test-case for debugging a program with a pch chain, that is, the main executable depends on a pch that itself included another pch. Currently clang doesn't emit the sekeleton CUs required for LLDB to tr

[Lldb-commits] [lldb] [lldb][test][NFC] Add option to exclude third_party packages (PR #83191)

2024-03-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: Done: https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de / https://github.com/llvm/llvm-zorg/commit/e08c692f75a922ee820ac8722f5033255913c195 https://github.com/llvm/llvm-project/pull/83191 ___ l

[Lldb-commits] [lldb] ec8df55 - [lldb][test][Windows] Don't check for pexpect with LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

2024-03-01 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-01T09:47:17Z New Revision: ec8df555702d85511290742388d28016b69468de URL: https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de DIFF: https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de.diff LOG