https://github.com/rastogishubham updated
https://github.com/llvm/llvm-project/pull/83312
>From 563ef808aa3b06e97b89e7b52d518705e97d9e14 Mon Sep 17 00:00:00 2001
From: Shubham Sandeep Rastogi
Date: Wed, 28 Feb 2024 10:28:55 -0800
Subject: [PATCH] Increase timeout to reduce test failure rate.
T
Author: Jonas Devlieghere
Date: 2024-02-28T21:23:19-08:00
New Revision: 81d94cad6d655d66adb08805a3bbef5a58125999
URL:
https://github.com/llvm/llvm-project/commit/81d94cad6d655d66adb08805a3bbef5a58125999
DIFF:
https://github.com/llvm/llvm-project/commit/81d94cad6d655d66adb08805a3bbef5a58125999.d
JDevlieghere wrote:
> @JDevlieghere @adrian-prantl we should consider adding this to the list of
> required python modules on our bots too and enforce it with
> `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after
> we can get our bots configured correctly.
Added in 793
Author: Jonas Devlieghere
Date: 2024-02-28T21:20:40-08:00
New Revision: 793300988b7c723bacadce67879ea8bf71c87e70
URL:
https://github.com/llvm/llvm-project/commit/793300988b7c723bacadce67879ea8bf71c87e70
DIFF:
https://github.com/llvm/llvm-project/commit/793300988b7c723bacadce67879ea8bf71c87e70.d
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/83366
>From c6599a05b5be0cbd279a96e98bed1c89d9de707e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 28 Feb 2024 18:12:45 -0800
Subject: [PATCH 1/2] [lldb] Log to system log instead of stderr from
Hos
hawkinsw wrote:
> Thanks for the second round of feedback @hawkinsw . Let me try to read the
> Doxygen docs a little more closely tonight and see if the references I threw
> in there might actually do what I hoped they would. I briefly looked at the
> Doxygen docs to see the Grouping feature a
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82799
>From 3db25301ed07ed0b44ff0f8cbe8d1657ba899036 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 28 Feb 2024 20:00:43 -0800
Subject: [PATCH] [lldb] Print a message when background tasks take a whil
JDevlieghere wrote:
I tried implementing this and waiting on the thread pool when the last debugger
is being destroyed is easy:
```
// Only hold the debugger list lock long enough to check if we're the last
// debugger being destroyed.
bool last_debugger_being_destroyed = false;
if (g_d
svs-quic wrote:
> Change itself is fine. But could you please add a test in
> `lldb/test/API/functionalities/completion/TestCompletion.py`? Specifically in
> `do_test_variable_completion`
Done
https://github.com/llvm/llvm-project/pull/83234
___
lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Currently, calls to Host::SystemLog print to stderr on all host platforms
except Darwin. This severely limits its value on the command line, where we
don't want to overload the user with log message
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83366
Currently, calls to Host::SystemLog print to stderr on all host platforms
except Darwin. This severely limits its value on the command line, where we
don't want to overload the user with log messages. Switc
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+ addr_
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-02-28T17:26:29-08:00
New Revision: 5784bf85bc5143266565586ece0113cd773a8616
URL:
https://github.com/llvm/llvm-project/commit/5784bf85bc5143266565586ece0113cd773a8616
DIFF:
https://github.com/llvm/llvm-project/commit/5784bf85bc5143266565586ece0113cd773a8616.diff
LOG
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/83350
>From 76eeb252b1f5fa71a68b439c84d13c8bcf042da7 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Wed, 28 Feb 2024 14:25:55 -0800
Subject: [PATCH 1/2] Fix interactive use of "command script add".
There was a thin
jasonmolenda wrote:
Thanks for the second round of feedback @hawkinsw . Let me try to read the
Doxygen docs a little more closely tonight and see if the references I threw in
there might actually do what I hoped they would. I briefly looked at the
Doxygen docs to see the Grouping feature and
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2024-02-28T16:54:32-08:00
New Revision: f7a544dd5f515c2f9b312142f573806cc8e64145
URL:
https://github.com/llvm/llvm-project/commit/f7a544dd5f515c2f9b312142f573806cc8e64145
DIFF:
https://github.com/llvm/llvm-project/commit/f7a544dd5f515c2f9b312142f573806cc8e64145.diff
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/3] [lldb] Add SBProcess methods for get/set/use address
ma
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/JDevlieghere approved this pull request.
LGTM but please fix the formatting before landing.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-02-28T16:14:19-08:00
New Revision: 97281708ac176e0464b770686ee314af4da0a3d5
URL:
https://github.com/llvm/llvm-project/commit/97281708ac176e0464b770686ee314af4da0a3d5
DIFF:
https://github.com/llvm/llvm-project/commit/97281708ac176e0464b770686ee314af4da0a3d5.diff
LOG
https://github.com/medismailben approved this pull request.
Thanks for fixing this think-o and adding a test
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
https://github.com/bulbazord approved this pull request.
Thinkos are the most insidious bugs. Nice catch.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-28T15:23:55-08:00
New Revision: d3173f4ab61c17337908eb7df3f1c515ddcd428c
URL:
https://github.com/llvm/llvm-project/commit/d3173f4ab61c17337908eb7df3f1c515ddcd428c
DIFF:
https://github.com/llvm/llvm-project/commit/d3173f4ab61c17337908eb7df3f1c515ddcd428c.d
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
kovdan01 wrote:
> Can this code be hit when using an x86 core file?
Thanks for suggestion! I'll try that and notify here if such approach succeeded.
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.
kovdan01 wrote:
> Would this change be observable by a test?
@adrian-prantl Theoretically, it should be: in
`ClangExpressionParser::ClangExpressionParser`, we try to hardcode sse and sse2
for both x86 and x86_64, while in `X86TargetInfo::initFeatureMap`, sse2
(implying sse) is only hardcoded
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4df364bc93af49ae413ec1ae8328f34ac70730c4...76eeb252b1f5fa71a68b439c84d13c8bcf042da7
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
There was a think-o in a previous commit that made us only able to define 1
line commands when using command script add interactively.
There was also no test for this feature, so I fixed the think-o and added a
te
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/83350
There was a think-o in a previous commit that made us only able to define 1
line commands when using command script add interactively.
There was also no test for this feature, so I fixed the think-o and added
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Does it make sense to have an image multiple times in the shared cache ? If
> not, instead of saying `{Y/N count}` what about printing `{location(shared
> cache/module collection)}` and only print it ref count if it's not in the
> shared cache ?
My bad, I thought you wer
kovdan01 wrote:
> tbh I have no problems with the patch, but I think it's fixing something that
> I think should be reconsidered altogether, I'm interested to hear more about
> what the use case looks like that led to this being a problem.
@jasonmolenda The use case is very simple, describing
https://github.com/bulbazord approved this pull request.
:)
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Does it make sense to have an image multiple times in the shared cache ? If
not, instead of saying `{Y/N count}` what about printing `{location(shared
cache/module collection)} and only print it ref count if it's not in the shared
cache ?
https://github.com/llvm/llvm-proje
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e427e934f677567f8184ff900cb4cbdb8cf21a21
b95ffa364ecfc8593dc48a1986385d81cbeb05c2 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The help for the `-r` option to `image list` says:
-r[] ( --ref-count=[] )
Display the reference count if the module is still in the shared
module cache.
but that's not what it act
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/83341
The help for the `-r` option to `image list` says:
-r[] ( --ref-count=[] )
Display the reference count if the module is still in the shared
module cache.
but that's not what it actually doe
https://github.com/medismailben approved this pull request.
Yeay 🥳
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The -d(ebug) option broke 5 years ago when I migrated the driver to libOption.
Since then, we were never check if the option is set. We were incorrectly
toggling the internal variable (m_debug_mode)
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83330
The -d(ebug) option broke 5 years ago when I migrated the driver to libOption.
Since then, we were never check if the option is set. We were incorrectly
toggling the internal variable (m_debug_mode) based o
Author: Jordan Rupprecht
Date: 2024-02-28T15:00:41-06:00
New Revision: 249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e
URL:
https://github.com/llvm/llvm-project/commit/249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e
DIFF:
https://github.com/llvm/llvm-project/commit/249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e.di
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/83312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
could you create instead a variable at the base test class level that can be
used by other DAP tests when setting timeouts? I'm pretty sure at least one
other test file uses timeouts.
https://github.com/llvm/llvm-proje
Author: Zequan Wu
Date: 2024-02-28T14:56:55-05:00
New Revision: 2cacc7a61095577ff42177373d46c8cb8df0cb1f
URL:
https://github.com/llvm/llvm-project/commit/2cacc7a61095577ff42177373d46c8cb8df0cb1f
DIFF:
https://github.com/llvm/llvm-project/commit/2cacc7a61095577ff42177373d46c8cb8df0cb1f.diff
LOG
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/83192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/83192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored,
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83317
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored, $LLV
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From f38204941062691bf3e3f6e57d8171a5c0258f77 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f01ed3bc8884223bf3edbaad8d3685622444cbf5
40caaa80180d4845393fc4b80ee2dc09b7c87a7e --
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 40caaa80180d4845393fc4b80ee2dc09b7c87a7e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 03268312834c61a16c4bc28efc442fcd027ec0a9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c1b8c6cf41df4a148e7a89c3a3c7e8049b0a47af...53c507046527e04b7faa70ea17cd59b45e724f55
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shubham Sandeep Rastogi (rastogishubham)
Changes
The timeout for this test was set to 1.0s which is very low, it should be a
default of 10s and be increased by a factor of 10 if ASAN is enabled. This will
help reduce the falkiness of the t
https://github.com/rastogishubham created
https://github.com/llvm/llvm-project/pull/83312
The timeout for this test was set to 1.0s which is very low, it should be a
default of 10s and be increased by a factor of 10 if ASAN is enabled. This will
help reduce the falkiness of the test, especiall
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
chelcassanova wrote:
Yeah, the ti
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Layout information for a record gets stored in the `ClangASTImporter`
associated with the `DWARFASTParserClang` that originally parsed the record.
LLDB sometimes moves clang types from one AST to another (
Michael137 wrote:
relies on https://github.com/llvm/llvm-project/pull/83291
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83295
Layout information for a record gets stored in the `ClangASTImporter`
associated with the `DWARFASTParserClang` that originally parsed the record.
LLDB sometimes moves clang types from one AST to another (in
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with the nit addressed.
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
JDevlieghere wrote:
This should t
@@ -97,27 +98,37 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// the progress manager.
+ struct ProgressData {
+
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch moves the logic for copying the layout info of a `RecordDecl`s
origin into a target AST.
A follow-up patch re-uses the logic from within the `ClangASTImporter`, so the
natural choice was to mov
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83291
This patch moves the logic for copying the layout info of a `RecordDecl`s
origin into a target AST.
A follow-up patch re-uses the logic from within the `ClangASTImporter`, so the
natural choice was to move i
Author: Walter Erquinigo
Date: 2024-02-28T11:43:36-05:00
New Revision: cd344a4c20e295d49f8163ec9a0656c1061a6e42
URL:
https://github.com/llvm/llvm-project/commit/cd344a4c20e295d49f8163ec9a0656c1061a6e42
DIFF:
https://github.com/llvm/llvm-project/commit/cd344a4c20e295d49f8163ec9a0656c1061a6e42.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/DavidSpickett approved this pull request.
I'd like to know if there's a good reason for the skip beyond machine load, but
this is fine as is. LGTM.
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-c
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/hawkinsw commented:
As I said before, I really appreciate you doing such in-depth documentation. I
hope these little suggestions help!
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.
1 - 100 of 132 matches
Mail list logo
