Author: Jonas Devlieghere
Date: 2024-02-22T23:54:13-08:00
New Revision: 354401f8d3dc08ed41895d03a12a122e9cc0482c
URL:
https://github.com/llvm/llvm-project/commit/354401f8d3dc08ed41895d03a12a122e9cc0482c
DIFF:
https://github.com/llvm/llvm-project/commit/354401f8d3dc08ed41895d03a12a122e9cc0482c.d
https://github.com/clayborg commented:
LGTM
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-22T21:48:49-08:00
New Revision: afd469023aad10786eaea3d444047a558ad8d5c1
URL:
https://github.com/llvm/llvm-project/commit/afd469023aad10786eaea3d444047a558ad8d5c1
DIFF:
https://github.com/llvm/llvm-project/commit/afd469023aad10786eaea3d444047a558ad8d5c1.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82736
>From 8df692af718f4fafcad99ef966b230af125199e7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:01:06 -0800
Subject: [PATCH] [lldb] Fix term-width setting
I noticed that the term-w
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82736
>From c6c2edf66adbe72c959925da886043cd77bfe528 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:01:06 -0800
Subject: [PATCH] [lldb] Fix term-width setting
I noticed that the term-w
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
I noticed that the term-width setting would always report its default value
(80) despite the driver correctly setting the value with
SBDebugger::SetTerminalWidth.
(lldb) settings show term-width
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82736
I noticed that the term-width setting would always report its default value
(80) despite the driver correctly setting the value with
SBDebugger::SetTerminalWidth.
(lldb) settings show term-width
term-w
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/82717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/82709
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
tbh I have no problems with the patch, but I think it's fixing something that I
think should be reconsidered altogether, I'm interested to hear more about what
the use case looks like that led to this being a problem.
https://github.com/llvm/llvm-project/pull/82603
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Target::SetArchitecture() does not necessarily set the triple that is being
passed in, and will unconditionally log the real architecture to the log
channel. By flipping the order between the log outpu
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/82717
Target::SetArchitecture() does not necessarily set the triple that is being
passed in, and will unconditionally log the real architecture to the log
channel. By flipping the order between the log outputs,
JDevlieghere wrote:
Also this is plugin code, it's probably more appropriate to disable the whole
plugin if the necessary backend isn't there?
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
JDevlieghere wrote:
Awesome, thank you making this happen!
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Makes sense to me, but I'll defer to @jimingham as he's the expert.
https://github.com/llvm/llvm-project/pull/82709
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
This is next in my series of "fix the racey tests that fail on greendragon"
addressing the failure of TestConcurrentManyBreakpoints.py where we set a
breakpoint in a function that 100 threads execute, a
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/82709
This is next in my series of "fix the racey tests that fail on greendragon"
addressing the failure of TestConcurrentManyBreakpoints.py where we set a
breakpoint in a function that 100 threads execute, and w
jasonmolenda wrote:
`CreateEXXPacket("E96", "no such process");` that's a good idea, I'll rewrite
to use a helper method like that.
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/81680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/81909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-02-22T16:11:40-05:00
New Revision: df6f756a19277d936ec83f7cebc2501327ac3add
URL:
https://github.com/llvm/llvm-project/commit/df6f756a19277d936ec83f7cebc2501327ac3add
DIFF:
https://github.com/llvm/llvm-project/commit/df6f756a19277d936ec83f7cebc2501327ac3add.diff
LOG
jasonmolenda wrote:
Well, it would change source-level next and step too if we didn't have the
disassembler. When we're doing a source-level step/next, we look at the stream
of instructions and when we have a block of non-branching instructions, we put
a breakpoint after the block and continu
jasonmolenda wrote:
tbh most of lldb would work without the llvm target compiled in, but the
disassembler and the Intel assembly scanning unwind plan creator both need it,
and the latter is more important.
https://github.com/llvm/llvm-project/pull/82603
jasonmolenda wrote:
I'm a little curious the use case that led to this failure. We have a build of
llvm/lldb without the X86 target, and we're using that lldb to debug an
i386/x86_64 target (gdb connection or corefile)? Because we can't use
instruction emulation based unwinding, if we don't
rupprecht wrote:
> 🥳
>
> Please wait a little bit for others to look. Thanks for taking care of this!
Yep, no problem! I'll give it a few days, and assume no comments == submit.
Next up: I'd like to remove `pexpect` (available on pip) and completely remove
the lldb/third_party/ tree.
https:/
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/82672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan Rupprecht
Date: 2024-02-22T13:34:00-06:00
New Revision: 2685e7eadce08125672f0f6013145ae45b7a5ac3
URL:
https://github.com/llvm/llvm-project/commit/2685e7eadce08125672f0f6013145ae45b7a5ac3
DIFF:
https://github.com/llvm/llvm-project/commit/2685e7eadce08125672f0f6013145ae45b7a5ac3.di
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/81909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
@@ -3969,30 +3987,43 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
process_username = pw->pw_name;
}
DNBLogError("Tried to attach to process with uid mismatch");
- std::string return_message = "E96;";
- std::string msg
@@ -3969,30 +3987,43 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
process_username = pw->pw_name;
}
DNBLogError("Tried to attach to process with uid mismatch");
- std::string return_message = "E96;";
- std::string msg
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
@@ -3969,30 +3987,43 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
process_username = pw->pw_name;
}
DNBLogError("Tried to attach to process with uid mismatch");
- std::string return_message = "E96;";
- std::string msg
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
🥳
Please wait a little bit for others to look. Thanks for taking care of this!
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/82672.diff
3 Files Affected:
- (modified) lldb/docs/resources/test.rst (+4-4)
- (modified) lldb/docs/testsuite/a-detailed-walkthrough.txt (+4
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/82672
None
>From 9b971b403448a6e7ff374558c5d963b7c5636ea1 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Thu, 22 Feb 2024 10:24:22 -0800
Subject: [PATCH] [lldb][docs] Remove/update docs pointing to unittest2
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord approved this pull request.
LGTM, seems like a good fix. One question/suggestion.
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
The `unittest2` package is unused since
5b386158aacac4b41126983a5379d36ed413d0ea.
The `progress` package was only used internally by `unittest2`, so it can be
deleted as well.
---
Patch is 317.19 KiB
https://github.com/vsapsai closed
https://github.com/llvm/llvm-project/pull/82666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vsapsai created
https://github.com/llvm/llvm-project/pull/82666
None
error: too big or took too long to generate
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/6] Add support for source-level debugging of WebAssembly
@@ -2595,6 +2604,37 @@ bool DWARFExpression::Evaluate(
break;
}
+case DW_OP_WASM_location: {
+ uint8_t wasm_op = opcodes.GetU8(&offset);
+ uint32_t index;
+
+ /* LLDB doesn't have an address space to represents WebAssembly locals,
+ * globals
@@ -0,0 +1,108 @@
+//=== wasmRegisterContext.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
JDevlieghere wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/81909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -346,6 +346,15 @@ static offset_t GetOpcodeDataSize(const DataExtractor
&data,
return (offset - data_offset) + subexpr_len;
}
+ case DW_OP_WASM_location: {
+uint8_t wasm_op = data.GetU8(&offset);
+if (wasm_op == 3)
paolosevMSFT wrote:
I wil
@@ -1450,6 +1450,14 @@ class Process : public
std::enable_shared_from_this,
/// platforms where there is a difference (only Arm Thumb at this time).
lldb::addr_t FixAnyAddress(lldb::addr_t pc);
+ /// Some targets might use bits in a code address to represent additional
+
DavidSpickett wrote:
Can this code be hit when using an x86 core file? Then you could write a shell
test thatis `UNSUPPORTED: x86-registered-target` (whatever the proper syntax
is) and assert that it does not crash.
It won't get run on the build bots, they enable all targets, but it's nice to
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Daniil Kovalev (kovdan01)
Changes
If `LLVM_TARGETS_TO_BUILD` does not contain `X86` and we try to run an x86
binary in lldb, we get a `nullptr` dereference in `LLVMDisasmInstruction(...)`.
We try to call `getDisAsm()` method on a `LLVMDisa
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kovdan01 wrote:
Please suggest ideas how this could be tested. It looks like that
UnwindAssembly unittests is the right place for it - but UnwindAssemblyx86Tests
cmake target is not built without X86 in `LLVM_TARGETS_TO_BUILD`, which is the
pre-condition of the issue this PR is fixing.
https:
DavidSpickett wrote:
Thanks! Fixed the x86 bot and I confirmed it locally.
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/82603
If `LLVM_TARGETS_TO_BUILD` does not contain `X86` and we try to run an x86
binary in lldb, we get a `nullptr` dereference in `LLVMDisasmInstruction(...)`.
We try to call `getDisAsm()` method on a `LLVMDisasmCon
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
64 matches
Mail list logo
