[Lldb-commits] [lldb] 0c02329 - [lldb] Migrate distutils.version.LooseVersion to packaging (#82066)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-19T19:54:53-08:00 New Revision: 0c02329ff375100ddcf2cb104aebe97bb3c9126f URL: https://github.com/llvm/llvm-project/commit/0c02329ff375100ddcf2cb104aebe97bb3c9126f DIFF: https://github.com/llvm/llvm-project/commit/0c02329ff375100ddcf2cb104aebe97bb3c9126f.d

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: Reverted with 9ed8b272c30a01c450616f0ed8b2373d5d618ebb https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9ed8b27 - Revert "Centralize the handling of completion for simple argument lists. (#82085)"

2024-02-19 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2024-02-19T18:19:59-08:00 New Revision: 9ed8b272c30a01c450616f0ed8b2373d5d618ebb URL: https://github.com/llvm/llvm-project/commit/9ed8b272c30a01c450616f0ed8b2373d5d618ebb DIFF: https://github.com/llvm/llvm-project/commit/9ed8b272c30a01c450616f0ed8b2373d5d61

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: @jimingham It seems like this change broke greendragon TestCompletion.py https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/66519/ https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. This LGTM! I don't think I can see far enough ahead on what you are planning here, but I was just wondering if the ultimate goal is to have the `option_arg.getAsT` return an `Expected`. In this case, wouldn't all these arguments (s

[Lldb-commits] [lldb] Revert "[lldb] Migrate distutils.version.LooseVersion to packaging" (PR #82297)

2024-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#82066 because the following tests started failing after: [lldb-api.commands/expression/import-std-module/deque-basic.TestDequeFromStdModule.py](https://green.lab.llvm.org/g

[Lldb-commits] [lldb] Revert "[lldb] Migrate distutils.version.LooseVersion to packaging" (PR #82297)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 71e0623 - Revert "[lldb] Migrate distutils.version.LooseVersion to packaging" (#82297)

2024-02-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-19T17:46:51-08:00 New Revision: 71e0623110b674765fb9349f449279faa7361e3d URL: https://github.com/llvm/llvm-project/commit/71e0623110b674765fb9349f449279faa7361e3d DIFF: https://github.com/llvm/llvm-project/commit/71e0623110b674765fb9349f449279faa7361e3d.d

[Lldb-commits] [lldb] Revert "[lldb] Migrate distutils.version.LooseVersion to packaging" (PR #82297)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/82297 Reverts llvm/llvm-project#82066 because the following tests started failing after: [lldb-api.commands/expression/import-std-module/deque-basic.TestDequeFromStdModule.py](https://green.lab.llvm.org/green/vie

[Lldb-commits] [lldb] [lldb] python-bindings: fix `SBTarget.get_target_watchpoints()` (PR #82295)

2024-02-19 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/82295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread via lldb-commits
jimingham wrote: Actually, I'm going to leave this as approved, but please add a header doc comment on your new API when you commit. Preferably with a stirring exhortation for people to use this in new code. https://github.com/llvm/llvm-project/pull/82273 _

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/82273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread via lldb-commits
jimingham wrote: This is a good direction. The API for creating the error message seems fine, a known part and a "site-specific error" is a workable division w/o being over designed. The one thing that bugs me about this whole setup is that we know the argument type for each option, so even

[Lldb-commits] [lldb] [lldb] python-bindings: fix `SBTarget.get_target_watchpoints()` (PR #82295)

2024-02-19 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-em

[Lldb-commits] [lldb] [lldb] python-bindings: fix `SBTarget.get_target_watchpoints()` (PR #82295)

2024-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (nikitalita) Changes Fixes erroneous usage of `bkpts` instead of `watchpoints` (probably introduced from copying and pasting `get_target_bkpts()`). --- Full diff: https://github.com/llvm/llvm-project/pull/82295.diff 1 Files Affected

[Lldb-commits] [lldb] [lldb] python-bindings: fix `SBTarget.get_target_watchpoints()` (PR #82295)

2024-02-19 Thread via lldb-commits
https://github.com/nikitalita created https://github.com/llvm/llvm-project/pull/82295 Fixes erroneous usage of `bkpts` instead of `watchpoints` (probably introduced from copying and pasting `get_target_bkpts()`). >From 17b15c7ca7c62dad1011e7920e3d06e8e09f6808 Mon Sep 17 00:00:00 2001 From: nik

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2163149 - Centralize the handling of completion for simple argument lists. (#82085)

2024-02-19 Thread via lldb-commits
Author: jimingham Date: 2024-02-19T16:43:08-08:00 New Revision: 21631494b068d9364b8dc8f18e59adee9131a0a5 URL: https://github.com/llvm/llvm-project/commit/21631494b068d9364b8dc8f18e59adee9131a0a5 DIFF: https://github.com/llvm/llvm-project/commit/21631494b068d9364b8dc8f18e59adee9131a0a5.diff LOG

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Migrate distutils.version.LooseVersion to packaging (PR #82066)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 13dce35 - [lldb] Migrate distutils.version.LooseVersion to packaging (#82066)

2024-02-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-19T15:31:08-08:00 New Revision: 13dce35876acdd35269f7d64c187c1d831bbf980 URL: https://github.com/llvm/llvm-project/commit/13dce35876acdd35269f7d64c187c1d831bbf980 DIFF: https://github.com/llvm/llvm-project/commit/13dce35876acdd35269f7d64c187c1d831bbf980.d

[Lldb-commits] [lldb] [lldb] Migrate distutils.version.LooseVersion to packaging (PR #82066)

2024-02-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. Thanks for doing this https://github.com/llvm/llvm-project/pull/82066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82272 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 513d9f2 - [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (#82272)

2024-02-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-19T15:29:00-08:00 New Revision: 513d9f2395ea017e72602ca6e747a2e061ab8c3f URL: https://github.com/llvm/llvm-project/commit/513d9f2395ea017e72602ca6e747a2e061ab8c3f DIFF: https://github.com/llvm/llvm-project/commit/513d9f2395ea017e72602ca6e747a2e061ab8c3f.d

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
jimingham wrote: The next two pieces are "one heterogenous argument list" and then "multiple argument lists". The first one should be easy. The second one is harder because you have to figure out what group matches the current state of the command line. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/82085 >From d08b2b0f10fd449a2b47252aa0da75d515a68664 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 16 Feb 2024 16:58:35 -0800 Subject: [PATCH 1/3] Centralize the handling of completion for simple argument lis

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/82272 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1b26c25 - [llvm] Upstream the BridgeOS triple enum value (NFC)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-19T12:20:23-08:00 New Revision: 1b26c25f7e56fe3d5e06c285566ef43812d7baee URL: https://github.com/llvm/llvm-project/commit/1b26c25f7e56fe3d5e06c285566ef43812d7baee DIFF: https://github.com/llvm/llvm-project/commit/1b26c25f7e56fe3d5e06c285566ef43812d7baee.d

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes I have been looking to simplify parsing logic and improve the interfaces so that they are both easier to use and harder to abuse. To be specific, I am referring to functions such as `OptionArgParser::ToBoo

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

2024-02-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/82273 I have been looking to simplify parsing logic and improve the interfaces so that they are both easier to use and harder to abuse. To be specific, I am referring to functions such as `OptionArgParser::ToBoolean

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread Anton Korobeynikov via lldb-commits
asl wrote: Tagging @kovdan01 https://github.com/llvm/llvm-project/pull/82272 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Jonas Devlieghere (JDevlieghere) Changes Teach LLVM & LLDB about `DW_AT_LLVM_ptrauth_authentication_mode` --- Full diff: https://github.com/llvm/llvm-project/pull/82272.diff 4 Files Affected: - (modified) lldb/source/Plugins/SymbolF

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Teach LLVM & LLDB about `DW_AT_LLVM_ptrauth_authentication_mode` --- Full diff: https://github.com/llvm/llvm-project/pull/82272.diff 4 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/D

[Lldb-commits] [lldb] [llvm] [ptrauth] Teach LLVM & LLDB about LLVM_ptrauth_authentication_mode (PR #82272)

2024-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/82272 Teach LLVM & LLDB about `DW_AT_LLVM_ptrauth_authentication_mode` >From 36cdd0e2991e9ed28bdd023630a81595ec3c70bf Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 19 Feb 2024 11:11:05 -0800 Subject

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest &request) { } } +void +CommandObject::HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) { + size_t num_arg_entries = GetNumAr

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest &request) { } } +void +CommandObject::HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) { + size_t num_arg_entries = GetNumAr

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
@@ -1139,6 +1097,15 @@ class CommandObjectPlatformProcessLaunch : public CommandObjectParsed { m_arguments.push_back({run_arg_arg}); } + void + HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) ov

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

2024-02-19 Thread via lldb-commits
jimingham wrote: This is responding to both Greg and Alex's "can't we also do X completion" comments: It was clear that this was going to be a whole lot of change, some of it purely manual, and some requiring a little thought. To make it easier to review, I'm doing the work in stages. Thi

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-02-19 Thread Paolo Severini via lldb-commits
paolosevMSFT wrote: Removed the 'wasm' command and addressed all the other review comments. https://github.com/llvm/llvm-project/pull/77949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-02-19 Thread Paolo Severini via lldb-commits
@@ -0,0 +1,293 @@ +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-02-19 Thread Paolo Severini via lldb-commits
https://github.com/paolosevMSFT updated https://github.com/llvm/llvm-project/pull/77949 >From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001 From: Paolo Severini Date: Fri, 12 Jan 2024 09:10:59 -0800 Subject: [PATCH 1/4] Add support for source-level debugging of WebAssembly

[Lldb-commits] [clang] [lldb] Enable aarch64-amazon-linux triple (PR #82231)

2024-02-19 Thread Sébastien Stormacq via lldb-commits
https://github.com/sebsto closed https://github.com/llvm/llvm-project/pull/82231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Enable aarch64-amazon-linux triple (PR #82231)

2024-02-19 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] Enable aarch64-amazon-linux triple (PR #82231)

2024-02-19 Thread Sébastien Stormacq via lldb-commits
https://github.com/sebsto created https://github.com/llvm/llvm-project/pull/82231 Add aarch64-amazon-linux triplet to allow compilation for Amazon Linux 2023 on Graviton CPU This should address https://github.com/apple/llvm-project/issues/8227 Also submitted to downstream `apple/llvm-project`