llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Use a Python Bytes and ByteArray object instead of Integers for
TestOwnedReferences and TestBorrowedReferences. These two tests were
failing when building against Python 3.12 because these Integer obj
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/82098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82098
Use a Python Bytes and ByteArray object instead of Integers for
TestOwnedReferences and TestBorrowedReferences. These two tests were
failing when building against Python 3.12 because these Integer objects
had
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The unit tests only test the Python objects and don't actually use
anything from the LLDB module. That means that all the additional
complexity in ScriptInterpreterPythonImpl::Initialize is overkill.
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82096
>From 7a05913528f2d747f4c5b7c0385a38a3c4e27d83 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 22:51:08 -0800
Subject: [PATCH] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initia
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/82095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82095
>From b937713b2733f2da9de4919b3da881ca0ea0aa04 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 22:56:28 -0800
Subject: [PATCH] [lldb] Call Import_AppendInittab exactly once before
Py
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82096
…nittests
The unit tests only test the Python objects and don't actually use anything
from the LLDB module. On the one hand that means that everything we do in
ScriptInterpreterPythonImpl::Initialize is ov
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The Python documentation [1] says that `PyImport_AppendInittab` should be
called before `Py_Initialize()`. Starting with Python 3.12, this is enforced
with a fatal error:
Fatal Python error: PyIm
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82095
The Python documentation [1] says that `PyImport_AppendInittab` should be
called before `Py_Initialize()`. Starting with Python 3.12, this is enforced
with a fatal error:
Fatal Python error: PyImport_App
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82066
>From 2e663a2e4a056529e2e17908fc39b90ea8c16eb9 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 14:59:15 -0800
Subject: [PATCH] [lldb] Migrate distutils.version.LooseVersion to packagi
@@ -1,33 +1,33 @@
"""
-This is a sanity check that verifies that test can be sklipped based on
settings.
+This is a sanity check that verifies that test can be skipped based on
settings.
"""
-
import lldb
from lldbsuite.test.lldbtest import *
from lldbsuite.test.decorator
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-16T21:45:08-08:00
New Revision: 737bc9f76a14b955bdfeb3811ce6c9156572be9f
URL:
https://github.com/llvm/llvm-project/commit/737bc9f76a14b955bdfeb3811ce6c9156572be9f
DIFF:
https://github.com/llvm/llvm-project/commit/737bc9f76a14b955bdfeb3811ce6c9156572be9f.d
@@ -1,33 +1,33 @@
"""
-This is a sanity check that verifies that test can be sklipped based on
settings.
+This is a sanity check that verifies that test can be skipped based on
settings.
"""
-
import lldb
from lldbsuite.test.lldbtest import *
from lldbsuite.test.decorator
@@ -308,13 +308,21 @@ def expectedCompilerVersion(compiler_version):
return operator in [">", ">=", "!", "!=", "not"]
if operator == ">":
-return LooseVersion(test_compiler_version) > LooseVersion(version)
+return packaging.version.parse(test_compil
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82074
>From f78594900fa34cb9c96bfc6b2dedc2e86bce201f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 15:49:11 -0800
Subject: [PATCH] [lldb] Replace assertRegexpMatches with assertRegex (NFC
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/82074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1139,6 +1097,15 @@ class CommandObjectPlatformProcessLaunch : public
CommandObjectParsed {
m_arguments.push_back({run_arg_arg});
}
+ void
+ HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) ov
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
&request) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) {
+ size_t num_arg_entries = GetNumAr
@@ -243,7 +243,7 @@ static constexpr CommandObject::ArgumentTableEntry
g_argument_table[] = {
{ lldb::eArgTypeLogCategory, "log-category",
lldb::CompletionType::eNoCompletion, {}, { nullptr, false }, "The name of a
category within a log channel, e.g. all (try \"log list\"
jimingham wrote:
I didn't add any new tests, the TestCompletion.py is pretty thorough already.
https://github.com/llvm/llvm-project/pull/82085
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
jimingham wrote:
BTW, in case this is confusing, the completers that were returning if the
cursor was not in the first argument slot was preventing:
(lldb) command arg1
from starting another completion when the argument was eArgTypePlain (only one
arg). I moved that check to the CommandObje
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6ce03ff3fef8fb6fa9afe8eb22c6d98bced26d48
d08b2b0f10fd449a2b47252aa0da75d515a68664 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
Most commands were adding argument completion handling by themselves, resulting
in a lot of unnecessary boilerplate. In many cases, this could be done
generically given the argument definition and the entries in t
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/82085
Most commands were adding argument completion handling by themselves, resulting
in a lot of unnecessary boilerplate. In many cases, this could be done
generically given the argument definition and the entries
https://github.com/felipepiovezan approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/82073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
assertRegexpMatches is a deprecated alias for assertRegex and has been removed
in Python 3.12. This wasn't an issue previously because we used a vendored
version of the unittest module. Now that we
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82074
assertRegexpMatches is a deprecated alias for assertRegex and has been removed
in Python 3.12. This wasn't an issue previously because we used a vendored
version of the unittest module. Now that we use the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
assertEquals is a deprecated alias for assertEqual and has been removed in
Python 3.12. This wasn't an issue previously because we used a vendored version
of the unittest module. Now that we use the
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82066
>From dad7c2a49f118d11b213b9691c8b01733040a510 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 14:59:15 -0800
Subject: [PATCH] [lldb] Migrate distutils.version.LooseVersion to packagi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The distutils package has been deprecated and was removed from Python 3.12. The
migration page [1] advises to use the packaging module instead. Since Python
3.6 that's vendored into pkg_resources.
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82066
The distutils package has been deprecated and was removed from Python 3.12. The
migration page [1] advises to use the packaging module instead. Since Python
3.6 that's vendored into pkg_resources.
[1] http
ashgti wrote:
> Needs a test and this will be good to go.
Done, added tests
https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 61224ee2642e7fa2723e48e4a32c90f5ec04759a Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 465abea7e445271681f5107ccbd306f63ccd0956 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2de269a641e4ffbb7a44e559c4c0a91bb66df823...f76dbe10e30c84aadaf33c597fe81bc0a285c995
lldb/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From f76dbe10e30c84aadaf33c597fe81bc0a285c995 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
clayborg wrote:
Is there a website or something that details how to correctly save symbols for
split DWARF? Is there an existing tool people use? If the answer is no, I would
like to support all variations for now. I am happy to emit a warning with a URL
for best practices when it comes to emi
ayermolo wrote:
Just my 2 cents as a "random dude who works on DWARF". The interoperability of
various gnu extensions and DWARF spec is not well defined. Which leads to
situations like this.
If binary is A then DWP is A.dwp no direct link between binary and dwp file.
If binary has gnulink than
https://github.com/clayborg commented:
Needs a test and this will be good to go.
https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 300d2959e510f41607ce2487264a98814d0a1700 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This fixes an issue where the error is lost if a command while executing
`launchCommands` when launching the debugger.
This should fix #82048
---
Full diff: https://github.com/llvm/llvm-project/pull/82051.di
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/82051
This fixes an issue where the error is lost if a command while executing
`launchCommands` when launching the debugger.
This should fix #82048
>From 5e3787a61c92f002746f2437e2fc8509d787a0ce Mon Sep 17 00:00:00 20
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vlad Serebrennikov
Date: 2024-02-16T22:47:09+03:00
New Revision: 4214f25dccba36472c9666f1395eef894dca1bba
URL:
https://github.com/llvm/llvm-project/commit/4214f25dccba36472c9666f1395eef894dca1bba
DIFF:
https://github.com/llvm/llvm-project/commit/4214f25dccba36472c9666f1395eef894dca1bba.
Endilll wrote:
I'd appreciate if you gave me a slightly bit more time, because I've been
testing the fix locally in the meantime.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
rastogishubham wrote:
Hi @Endilll this patch has been reverted with
831ba9540089350b740c5db61159fe23ab6872d3 to make sure the lldb bots are green.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
Author: Shubham Sandeep Rastogi
Date: 2024-02-16T11:00:35-08:00
New Revision: 831ba9540089350b740c5db61159fe23ab6872d3
URL:
https://github.com/llvm/llvm-project/commit/831ba9540089350b740c5db61159fe23ab6872d3
DIFF:
https://github.com/llvm/llvm-project/commit/831ba9540089350b740c5db61159fe23ab68
rastogishubham wrote:
I am going to revert this patch for now, to make sure that green dragon is up
and running again
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
JDevlieghere wrote:
Great. Let me know if you need help reproducing stuff on macOS.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Endilll wrote:
@JDevlieghere I have an idea what have caused this failure, but I guess I have
to enable libcxx to replicate it locally.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
JDevlieghere wrote:
This is what the failure looks like:
```
==
FAIL: test_with_run_command_dsym
(TestDataFormatterLibcxxChrono.LibcxxChronoDataFormatterTestCase)
Test that that file and class static variables display correc
Endilll wrote:
Trying to take a look, but https://green.lab.llvm.org is extraordinary slow for
me.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
JDevlieghere wrote:
This breaks `TestDataFormatterLibcxxChrono.py` on macOS:
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/66400/
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/16178/
CC @rastogishubham
https://github.com/llvm/llvm-project/pull/81666
___
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 70d3c80aa73ef10284c6615ac9e5e73ff38a5245 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/kevinfrei converted_to_draft
https://github.com/llvm/llvm-project/pull/79181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-16T08:47:38-08:00
New Revision: 0da0966da4b813386a85cf70ae0d0efc7cb2eaea
URL:
https://github.com/llvm/llvm-project/commit/0da0966da4b813386a85cf70ae0d0efc7cb2eaea
DIFF:
https://github.com/llvm/llvm-project/commit/0da0966da4b813386a85cf70ae0d0efc7cb2eaea.d
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vlad Serebrennikov
Date: 2024-02-16T20:40:27+04:00
New Revision: 7b7d411de9f731d2bcf6b093f6cee2cf57a5196e
URL:
https://github.com/llvm/llvm-project/commit/7b7d411de9f731d2bcf6b093f6cee2cf57a5196e
DIFF:
https://github.com/llvm/llvm-project/commit/7b7d411de9f731d2bcf6b093f6cee2cf57a5196e.
Author: Jonas Devlieghere
Date: 2024-02-16T07:59:03-08:00
New Revision: bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
URL:
https://github.com/llvm/llvm-project/commit/bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
DIFF:
https://github.com/llvm/llvm-project/commit/bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f.d
67 matches
Mail list logo
