[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/70734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
@@ -96,7 +96,9 @@ function(finish_swig_python swig_target lldb_python_bindings_dir lldb_python_tar ${lldb_python_target_dir} "utils" FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py" - "${LLDB_SOURCE_DIR}/examples/python/symbolication.py") +

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
@@ -805,19 +805,25 @@ let Command = "script add" in { def script_add_function : Option<"function", "f">, Group<1>, Arg<"PythonFunction">, Desc<"Name of the Python function to bind to this command name.">; - def script_add_class : Option<"class", "c">, Group<2>, Arg<"

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,321 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for your command that inherits from ParsedCommandBase. +That will make an LLDBOptionValueParser which you will use

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
@@ -805,19 +805,25 @@ let Command = "script add" in { def script_add_function : Option<"function", "f">, Group<1>, Arg<"PythonFunction">, Desc<"Name of the Python function to bind to this command name.">; - def script_add_class : Option<"class", "c">, Group<2>, Arg<"

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben requested changes to this pull request. The implementation LGTM but as you know, I'm trying to consolidate scripting affordances & improve their documentation, so I left some comments that would greatly help me in this endeavor. Thanks! https://github.com/llvm/l

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,321 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for your command that inherits from ParsedCommandBase. +That will make an LLDBOptionValueParser which you will use

[Lldb-commits] [lldb] [LLDB][Docs] Replace LLDB_RELOCATABLE_PYTHON with LLDB_EMBED_PYTHON_HOME (PR #81310)

2024-02-10 Thread Po-yao Chang via lldb-commits
https://github.com/poyaoc97 closed https://github.com/llvm/llvm-project/pull/81310 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d70b1c1 - [LLDB][Docs] Replace LLDB_RELOCATABLE_PYTHON with LLDB_EMBED_PYTHON_HOME (#81310)

2024-02-10 Thread via lldb-commits
Author: Po-yao Chang Date: 2024-02-11T09:36:59+08:00 New Revision: d70b1c1206d93b5cdf31fa330d5717eb73e8794a URL: https://github.com/llvm/llvm-project/commit/d70b1c1206d93b5cdf31fa330d5717eb73e8794a DIFF: https://github.com/llvm/llvm-project/commit/d70b1c1206d93b5cdf31fa330d5717eb73e8794a.diff

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-02-10 Thread Ed Maste via lldb-commits
emaste wrote: commit message probably needs updating for the logic change (no longer beforehand) Another reason to defer the check until failure occurs - if the user happens to be running lldb as root ptrace will be able to attach independent of the state of that sysctl https://github.com/ll

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-02-10 Thread Ed Maste via lldb-commits
https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Docs] Replace LLDB_RELOCATABLE_PYTHON with LLDB_EMBED_PYTHON_HOME (PR #81310)

2024-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/81310 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM but I'm not really an expert on FreeBSD. @emaste ? https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Ok, I think this is good to go in. There are things that can be improved but it would be better to land this and change things in follow up PRs instead of continually adjusting this one. https://github.com/llvm/llvm-project/pull/70734 __

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-02-10 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

2024-02-10 Thread Mark de Wever via lldb-commits
https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/80609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5e9eaf8 - [lldb][libc++] Adds valarray data formatters. (#80609)

2024-02-10 Thread via lldb-commits
Author: Mark de Wever Date: 2024-02-10T20:44:14+01:00 New Revision: 5e9eaf87b374c3f6638543682b523827834494a8 URL: https://github.com/llvm/llvm-project/commit/5e9eaf87b374c3f6638543682b523827834494a8 DIFF: https://github.com/llvm/llvm-project/commit/5e9eaf87b374c3f6638543682b523827834494a8.diff

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

2024-02-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/80609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

2024-02-10 Thread Mark de Wever via lldb-commits
@@ -0,0 +1,140 @@ +//===-- LibCxxValarray.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

2024-02-10 Thread Mark de Wever via lldb-commits
https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/80609 >From 661f43e0aa40b29ca8bde6c643ee1f3241ecfb17 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 4 Feb 2024 18:46:50 +0100 Subject: [PATCH] [lldb][libc++] Adds valarray data formatters. The code is heavil

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

2024-02-10 Thread Mark de Wever via lldb-commits
@@ -750,6 +750,11 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { lldb_private::formatters::LibcxxStdVectorSyntheticFrontEndCreator, "libc++ std::vector synthetic children", "^std::__[[:alnum:]]+::vector<.+>$", stl_deref_flags,

[Lldb-commits] [lldb] [lldb] Fix printf formatting of std::time_t seconds (PR #81078)

2024-02-10 Thread Mark de Wever via lldb-commits
mordante wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/81078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-02-10 Thread Gleb Popov via lldb-commits
https://github.com/arrowd updated https://github.com/llvm/llvm-project/pull/81355 >From 6ef9c188bbfdb3fa9301060c2d8730b1099f5209 Mon Sep 17 00:00:00 2001 From: Gleb Popov <6year...@gmail.com> Date: Sat, 10 Feb 2024 14:15:49 +0300 Subject: [PATCH] [lldb] Teach LocateExecutableSymbolFile to look i

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-02-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Gleb Popov (arrowd) Changes Relevant change on the FreeBSD side: https://reviews.freebsd.org/D43515 @emaste @brooksdavis --- Full diff: https://github.com/llvm/llvm-project/pull/81355.diff 1 Files Affected: - (modified) lldb/source/Sym

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-02-10 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-02-10 Thread Gleb Popov via lldb-commits
https://github.com/arrowd created https://github.com/llvm/llvm-project/pull/81355 Relevant change on the FreeBSD side: https://reviews.freebsd.org/D43515 @emaste @brooksdavis >From 3c49dd6cd794facda5b17d66f9f7b4d62cb1b0fc Mon Sep 17 00:00:00 2001 From: Gleb Popov <6year...@gmail.com> Date: Sa

[Lldb-commits] [lldb] [lldb] Fix FreeBSD build. (PR #81353)

2024-02-10 Thread David CARLIER via lldb-commits
https://github.com/devnexen closed https://github.com/llvm/llvm-project/pull/81353 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8884ba4 - [lldb] Fix FreeBSD build. (#81353)

2024-02-10 Thread via lldb-commits
Author: David CARLIER Date: 2024-02-10T10:08:53Z New Revision: 8884ba43a8485bebef5c4d41e7ed457e3fa84f07 URL: https://github.com/llvm/llvm-project/commit/8884ba43a8485bebef5c4d41e7ed457e3fa84f07 DIFF: https://github.com/llvm/llvm-project/commit/8884ba43a8485bebef5c4d41e7ed457e3fa84f07.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix FreeBSD build. (PR #81353)

2024-02-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David CARLIER (devnexen) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/81353.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp (+1-1) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Fix FreeBSD build. (PR #81353)

2024-02-10 Thread David CARLIER via lldb-commits
https://github.com/devnexen created https://github.com/llvm/llvm-project/pull/81353 None >From eaa5c11364bebb5e85a1dc976f2bfaceefaef7f8 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Sat, 10 Feb 2024 10:02:07 + Subject: [PATCH] [lldb] Fix FreeBSD build. --- .../Plugins/Process/FreeBS