https://github.com/joker-eph requested changes to this pull request.
Can you add some tests for this?
https://github.com/llvm/llvm-project/pull/80331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public
InstVisitor {
}
if (!ElemTy->isSized())
return;
-Value *SizeVal =
- IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy));
+auto Size = DL.getTypeStoreSize(ElemTy);
+Value *Siz
@@ -1644,8 +1647,9 @@ class CommandObjectCommandsScriptAdd : public
CommandObjectParsed,
llvm::Error llvm_error =
m_container->LoadUserSubcommand(m_cmd_name, new_cmd_sp, m_overwrite);
if (llvm_error)
-result.AppendErrorWithFormat("cannot add comma
@@ -3055,8 +3055,8 @@ void CommandInterpreter::PrintCommandOutput(IOHandler
&io_handler,
}
std::lock_guard guard(io_handler.GetOutputMutex());
- if (had_output && INTERRUPT_REQUESTED(GetDebugger(),
-"Interrupted dumping command ou
@@ -1623,15 +1625,16 @@ class CommandObjectCommandsScriptAdd : public
CommandObjectParsed,
m_options.m_class_name.c_str());
if (!cmd_obj_sp) {
result.AppendErrorWithFormatv("cannot create helper object for: "
- "'{0}
@@ -1577,7 +1579,7 @@ class CommandObjectCommandsScriptAdd : public
CommandObjectParsed,
case eLazyBoolNo:
m_overwrite = false;
}
-
+
clayborg wrote:
revert non related whitespace change
https://github.com/llvm/llvm-project/pull/80375
_
@@ -1623,15 +1625,16 @@ class CommandObjectCommandsScriptAdd : public
CommandObjectParsed,
m_options.m_class_name.c_str());
if (!cmd_obj_sp) {
result.AppendErrorWithFormatv("cannot create helper object for: "
- "'{0}
@@ -1788,12 +1792,13 @@ class CommandObjectCommandsScriptDelete : public
CommandObjectParsed {
return;
}
const char *leaf_cmd = command[num_args - 1].c_str();
-llvm::Error llvm_error = container->RemoveUserSubcommand(leaf_cmd,
-
@@ -70,3 +73,26 @@ def test_stats_api(self):
True,
'Make sure the "failures" key in in "frameVariable" dictionary"',
)
+
+def test_command_stats_api(self):
+"""
+Test GetCommandInterpreter::GetStatistics() API.
+"""
+
@@ -575,7 +576,7 @@ class CommandInterpreter : public Broadcaster,
void SetEchoCommentCommands(bool enable);
bool GetRepeatPreviousCommand() const;
-
+
clayborg wrote:
revert non related whitespace change
https://github.com/llvm/llvm-project/pull/80375
@@ -246,13 +247,13 @@ class SBCommandInterpreter {
lldb::SBStringList &matches,
lldb::SBStringList &descriptions);
- /// Returns whether an interrupt flag was raised either by the SBDebugger -
+ /
@@ -307,7 +311,8 @@ llvm::json::Value DebuggerStats::ReportStatistics(Debugger
&debugger,
{"totalModuleCount", num_modules},
{"totalModuleCountHasDebugInfo", num_modules_has_debug_info},
{"totalModuleCountWithVariableErrors", num_modules_with_variable_errors}
@@ -1788,12 +1792,13 @@ class CommandObjectCommandsScriptDelete : public
CommandObjectParsed {
return;
}
const char *leaf_cmd = command[num_args - 1].c_str();
-llvm::Error llvm_error = container->RemoveUserSubcommand(leaf_cmd,
-
@@ -240,7 +241,7 @@ class CommandInterpreter : public Broadcaster,
eCommandTypesAllThem = 0x //< all commands
};
- // The CommandAlias and CommandInterpreter both have a hand in
+ // The CommandAlias and CommandInterpreter both have a hand in
cla
@@ -246,13 +247,13 @@ class SBCommandInterpreter {
lldb::SBStringList &matches,
lldb::SBStringList &descriptions);
- /// Returns whether an interrupt flag was raised either by the SBDebugger -
+ /
@@ -150,7 +150,7 @@ bool SBCommandInterpreter::WasInterrupted() const {
bool SBCommandInterpreter::InterruptCommand() {
LLDB_INSTRUMENT_VA(this);
-
+
clayborg wrote:
revert non related whitespace change
https://github.com/llvm/llvm-project/pull/80375
___
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/80375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
Adding command interpreter statistics into "statistics dump" command so that we
can track the command usage frequency for telemetry purpose. This is useful to
answer questions like what is the most frequently us
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/80375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/80375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
That one's odd, it almost belongs in Platform, after all, there's no guarantee
that "assert" is implemented by pthread functions at all. It just happens to
be on Unix systems.
Jim
> On Feb 1, 2024, at 7:32 PM, Jim Ingham ***@***.***> wrote:
>
> There IS an AssertFrameRecog
jimingham wrote:
There IS an AssertFrameRecogizer that does just what you suggest, but it is in
source/Target. These really should go somewhere else, however, Target is too
general for anything but the base recognizer class.
Jim
> On Feb 1, 2024, at 6:43 PM, Greg Clayton ***@***.***> wrote:
Author: Jason Molenda
Date: 2024-02-01T19:17:44-08:00
New Revision: 7dd790db8b77c4a833c06632e903dc4f13877a64
URL:
https://github.com/llvm/llvm-project/commit/7dd790db8b77c4a833c06632e903dc4f13877a64
DIFF:
https://github.com/llvm/llvm-project/commit/7dd790db8b77c4a833c06632e903dc4f13877a64.diff
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/2] [lldb] Add QSupported key to report watchpoint types
sup
@@ -220,6 +220,28 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
+
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/80375
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH 1/3] Add commands frequency to statistics dump
---
lldb/inclu
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jasonmolenda wrote:
> I didn't have time to review before merge, just looking at this now.
>
> > see what the Windows CI thinks.
>
> I assume you mean the buildbots (lldb isn't built in the pre-commit CI), but
> I think given:
> https://github.com/llvm/llvm-zorg/blob/590f0a62919ad313758362d18
jasonmolenda wrote:
The QSupported packet from debugserver also has a "compression minimum size"
field it adds (see the change to RNBRemote.cpp) and the QEnableCompression
packet accepts that field as well. I must have had a reason for adding this
when I added compression to the protocol, but
clayborg wrote:
This almost seems like a compiler runtime plug-in, but C language would be
fine. I would rather see this in plug-in somewhere if possible. It might be
nice to have these plug-ins register one or more frame regular expression
values that point to the plug-in so we can add more t
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/80375
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH 1/2] Add commands frequency to statistics dump
---
lldb/inclu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1f3c30911cc5eee4b42bdc9c6358c689b2f2f223
59e1499ec0afebb533c4952f079278341b957241 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1f3c30911cc5eee4b42bdc9c6358c689b2f2f223...59e1499ec0afebb533c4952f079278341b957241
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
debugserver on arm64 devices can manage both Byte Address Select watchpoints
(1-8 bytes) and MASK watchpoints (8 bytes-2 gigabytes). This adds a
SupportedWatchpointTypes key to the QSupported response f
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/80376
debugserver on arm64 devices can manage both Byte Address Select watchpoints
(1-8 bytes) and MASK watchpoints (8 bytes-2 gigabytes). This adds a
SupportedWatchpointTypes key to the QSupported response from
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/80375
None
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH] Add commands frequency to statistics dump
---
lldb/inc
jimingham wrote:
The patch looks fine to me, but I'm a bit bugged by the fact that it is in
Target. In my mind, this is part of the C LanguageRuntime, except we don't yet
have a C Language Runtime...
https://github.com/llvm/llvm-project/pull/80368
_
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch adds a frame recognizer for Clang's
`__builtin_verbose_trap`, which behaves like a
`__builtin_trap`, but emits a failure-reason string into debug-info in order
for debuggers to display
it to a us
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/80368
This patch adds a frame recognizer for Clang's
`__builtin_verbose_trap`, which behaves like a
`__builtin_trap`, but emits a failure-reason string into debug-info in order
for debuggers to display
it to a user.
https://github.com/jpienaar approved this pull request.
https://github.com/llvm/llvm-project/pull/80246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ytmukai updated
https://github.com/llvm/llvm-project/pull/79589
>From bcdb1e47ce841df96b2916d61cda018503f62358 Mon Sep 17 00:00:00 2001
From: Yuta Mukai
Date: Tue, 12 Dec 2023 16:59:09 +
Subject: [PATCH] [AArch64][MachinePipeliner] Add pipeliner support for AArch64
Add A
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/80310
>From 92950afd39034c0184a3c807f8062e0053eead5c Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Thu, 1 Feb 2024 17:22:34 +
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
@@ -3930,30 +4065,68 @@ static LoadsState canVectorizeLoads(ArrayRef
VL, const Value *VL0,
std::optional Diff =
getPointersDiff(ScalarTy, Ptr0, ScalarTy, PtrN, DL, SE);
// Check that the sorted loads are consecutive.
- if (static_cast(*Diff) == VL.si
@@ -3930,30 +4065,68 @@ static LoadsState canVectorizeLoads(ArrayRef
VL, const Value *VL0,
std::optional Diff =
getPointersDiff(ScalarTy, Ptr0, ScalarTy, PtrN, DL, SE);
// Check that the sorted loads are consecutive.
- if (static_cast(*Diff) == VL.si
@@ -3878,6 +3883,130 @@ static Align computeCommonAlignment(ArrayRef
VL) {
return CommonAlignment;
}
+/// Check if \p Order represents reverse order.
+static bool isReverseOrder(ArrayRef Order) {
+ unsigned Sz = Order.size();
+ return !Order.empty() && all_of(enumerate(Or
@@ -397,27 +241,12 @@ define void @test3([48 x float]* %p, float* noalias %s) {
; CHECK-NEXT: entry:
; CHECK-NEXT:[[ARRAYIDX:%.*]] = getelementptr inbounds [48 x float], ptr
[[P:%.*]], i64 0, i64 0
; CHECK-NEXT:[[ARRAYIDX2:%.*]] = getelementptr inbounds float, ptr
[[
@@ -7,7 +7,7 @@ define i32 @test(ptr noalias %p, ptr noalias %addr) {
; CHECK-NEXT: entry:
; CHECK-NEXT:[[TMP0:%.*]] = insertelement <8 x ptr> poison, ptr
[[ADDR:%.*]], i32 0
; CHECK-NEXT:[[TMP1:%.*]] = shufflevector <8 x ptr> [[TMP0]], <8 x ptr>
poison, <8 x i32> ze
@@ -30,7 +30,7 @@ define void @test() {
; CHECK-SLP-THRESHOLD: bb:
; CHECK-SLP-THRESHOLD-NEXT:[[TMP0:%.*]] = insertelement <4 x ptr> poison,
ptr [[COND_IN_V]], i32 0
; CHECK-SLP-THRESHOLD-NEXT:[[TMP1:%.*]] = shufflevector <4 x ptr>
[[TMP0]], <4 x ptr> poison, <4
@@ -17,7 +17,7 @@ define i16 @test() {
; CHECK-NEXT:[[TMP4:%.*]] = call <2 x i16>
@llvm.masked.gather.v2i16.v2p0(<2 x ptr> [[TMP3]], i32 2, <2 x i1> , <2 x i16> poison)
; CHECK-NEXT:[[TMP5:%.*]] = extractelement <2 x i16> [[TMP4]], i32 0
; CHECK-NEXT:[[TMP6:%.*]] =
https://github.com/pzread edited https://github.com/llvm/llvm-project/pull/80331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pzread edited https://github.com/llvm/llvm-project/pull/80331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pzread edited https://github.com/llvm/llvm-project/pull/80331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Jerry Wu (pzread)
Changes
Adds a new method `replaceWithZeroTripCheck` to `LoopLikeOpInterface`, to
create zero-trip-check around the loop
The purpose is to let loop ops (e.g. `scf.while`, `scf.for`) implement their
own transformations to
https://github.com/pzread updated
https://github.com/llvm/llvm-project/pull/80331
>From 70f54b51bef87bde5e3f5ee067c0f2414d34e915 Mon Sep 17 00:00:00 2001
From: Jerry Wu
Date: Thu, 1 Feb 2024 19:57:26 +
Subject: [PATCH] Add replaceWithZeroTripCheck to LoopLikeOpInterface
---
.../mlir/Inter
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH 1/6] Make clang report invalid target versions for all
environme
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH 1/5] Make clang report invalid target versions for all
environme
@@ -3878,6 +3883,130 @@ static Align computeCommonAlignment(ArrayRef
VL) {
return CommonAlignment;
}
+/// Check if \p Order represents reverse order.
+static bool isReverseOrder(ArrayRef Order) {
+ unsigned Sz = Order.size();
+ return !Order.empty() && all_of(enumerate(Or
@@ -3930,30 +4065,68 @@ static LoadsState canVectorizeLoads(ArrayRef
VL, const Value *VL0,
std::optional Diff =
getPointersDiff(ScalarTy, Ptr0, ScalarTy, PtrN, DL, SE);
// Check that the sorted loads are consecutive.
- if (static_cast(*Diff) == VL.si
https://github.com/preames commented:
These comments are trying to be helpful in pointing out bits which might be
simplified or split off, but my track record with SLP reviews is not great.
Feel free to ignore any or all of these.
https://github.com/llvm/llvm-project/pull/80310
@@ -30,7 +30,7 @@ define void @test() {
; CHECK-SLP-THRESHOLD: bb:
; CHECK-SLP-THRESHOLD-NEXT:[[TMP0:%.*]] = insertelement <4 x ptr> poison,
ptr [[COND_IN_V]], i32 0
; CHECK-SLP-THRESHOLD-NEXT:[[TMP1:%.*]] = shufflevector <4 x ptr>
[[TMP0]], <4 x ptr> poison, <4
@@ -17,7 +17,7 @@ define i16 @test() {
; CHECK-NEXT:[[TMP4:%.*]] = call <2 x i16>
@llvm.masked.gather.v2i16.v2p0(<2 x ptr> [[TMP3]], i32 2, <2 x i1> , <2 x i16> poison)
; CHECK-NEXT:[[TMP5:%.*]] = extractelement <2 x i16> [[TMP4]], i32 0
; CHECK-NEXT:[[TMP6:%.*]] =
@@ -397,27 +241,12 @@ define void @test3([48 x float]* %p, float* noalias %s) {
; CHECK-NEXT: entry:
; CHECK-NEXT:[[ARRAYIDX:%.*]] = getelementptr inbounds [48 x float], ptr
[[P:%.*]], i64 0, i64 0
; CHECK-NEXT:[[ARRAYIDX2:%.*]] = getelementptr inbounds float, ptr
[[
@@ -3930,30 +4065,68 @@ static LoadsState canVectorizeLoads(ArrayRef
VL, const Value *VL0,
std::optional Diff =
getPointersDiff(ScalarTy, Ptr0, ScalarTy, PtrN, DL, SE);
// Check that the sorted loads are consecutive.
- if (static_cast(*Diff) == VL.si
https://github.com/preames edited
https://github.com/llvm/llvm-project/pull/80310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -7,7 +7,7 @@ define i32 @test(ptr noalias %p, ptr noalias %addr) {
; CHECK-NEXT: entry:
; CHECK-NEXT:[[TMP0:%.*]] = insertelement <8 x ptr> poison, ptr
[[ADDR:%.*]], i32 0
; CHECK-NEXT:[[TMP1:%.*]] = shufflevector <8 x ptr> [[TMP0]], <8 x ptr>
poison, <8 x i32> ze
clayborg wrote:
This broke the buildbots. Fixed with:
```
commit 4eac14683855e040adaf507ed6b14e28a09f983e (HEAD -> main, origin/main,
origin/HEAD)
Author: Greg Clayton
Date: Thu Feb 1 15:26:26 2024 -0800
Fix buildbots after #79544
https://github.com/llvm/llvm-project/pull/79544
Author: Greg Clayton
Date: 2024-02-01T15:26:26-08:00
New Revision: 4eac14683855e040adaf507ed6b14e28a09f983e
URL:
https://github.com/llvm/llvm-project/commit/4eac14683855e040adaf507ed6b14e28a09f983e
DIFF:
https://github.com/llvm/llvm-project/commit/4eac14683855e040adaf507ed6b14e28a09f983e.diff
preames wrote:
FYI - https://github.com/llvm/llvm-project/pull/80360 adds testing
infrastructure to exercise the TTI hooks.
https://github.com/llvm/llvm-project/pull/80310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
@@ -1305,6 +1305,13 @@ enum CompletionType {
eTerminatorCompletion = (1ul << 27)
};
+/// Specifies if children need to be re-computed
+/// after a call to \ref SyntheticChildrenFrontEnd::Update.
+enum class ChildCacheState {
+ eRefetch = 0, ///< Children need to be recomput
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/79544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Greg Clayton
Date: 2024-02-01T13:58:18-08:00
New Revision: 9258f3e692493a69e0f4755bb129a5391ef10b50
URL:
https://github.com/llvm/llvm-project/commit/9258f3e692493a69e0f4755bb129a5391ef10b50
DIFF:
https://github.com/llvm/llvm-project/commit/9258f3e692493a69e0f4755bb129a5391ef10b50.diff
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/79544
>From 90cfa4700d8590d58cecd678ce107ba3ec8481c7 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Thu, 25 Jan 2024 19:21:25 -0800
Subject: [PATCH 1/4] Fix a crash when using .dwp files and make type lookup
relia
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/80310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/80310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/80310
>From 92950afd39034c0184a3c807f8062e0053eead5c Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Thu, 1 Feb 2024 17:22:34 +
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/80164
>From cfd0dcfa1f5fabd12cf4d7bf8d5a10bd324ace0a Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Wed, 31 Jan 2024 16:47:49 +
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
@@ -1305,6 +1305,13 @@ enum CompletionType {
eTerminatorCompletion = (1ul << 27)
};
+/// Specifies if children need to be re-computed
+/// after a call to \ref SyntheticChildrenFrontEnd::Update.
+enum class ChildCacheState {
+ eRefetch = 0, ///< Children need to be recomput
@@ -1305,6 +1305,13 @@ enum CompletionType {
eTerminatorCompletion = (1ul << 27)
};
+/// Specifies if children need to be re-computed
+/// after a call to \ref SyntheticChildrenFrontEnd::Update.
+enum class ChildCacheState {
+ eRefetch = 0, ///< Children need to be recomput
clayborg wrote:
> > But if it'd require substantial reengineering to clang to get this working
> > - this seems an unfortunate regression to carry in the interim, and it
> > might be worth reverting to the previous (differently buggy, but at least
> > work-around-able) behavior.
>
> To clarif
clayborg wrote:
> > I've added a log message with the `Error` itself being logged as well
>
> Thanks! I wasted half a day stepping through the DWARF parser recently,
> thinking I'm debugging a parser bug, when it was really invalid DWARF
> produced by an older version of dsymutil, so even just
clayborg wrote:
I like the `eReuse` and `eRefetch` values as well!
https://github.com/llvm/llvm-project/pull/80167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZijunZhaoCCK wrote:
> If I remove `OpenCL`, `clang/test/CodeGenOpenCL/amdgpu-alignment.cl` won't
> fail. It seems that OpenCL is a not a necessary change in this PR.
>
> ```
> --- i/llvm/lib/TargetParser/Triple.cpp
> +++ w/llvm/lib/TargetParser/Triple.cpp
> @@ -325,4 +325,2 @@ StringRef Triple:
@@ -326,6 +326,50 @@ InstructionCost
RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
switch (Kind) {
default:
break;
+case TTI::SK_ExtractSubvector:
+ if (isa(SubTp)) {
+unsigned TpRegs = getRegUsageForType(Tp);
+unsigned NumElems =
+
@@ -326,6 +326,50 @@ InstructionCost
RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
switch (Kind) {
default:
break;
+case TTI::SK_ExtractSubvector:
+ if (isa(SubTp)) {
+unsigned TpRegs = getRegUsageForType(Tp);
+unsigned NumElems =
+
@@ -326,6 +326,50 @@ InstructionCost
RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
switch (Kind) {
default:
break;
+case TTI::SK_ExtractSubvector:
+ if (isa(SubTp)) {
+unsigned TpRegs = getRegUsageForType(Tp);
+unsigned NumElems =
+
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/77529
>From 7440ee8ba235fd871af0999f66d5d6130456400b Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Tue, 9 Jan 2024 21:43:31 +
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
jimingham wrote:
I agree with Dave that verbs would be more naturally follow the intent of the
return. Since the return is telling the caller: either "You can reuse the
children you have cached" or "you must refetch the children". So `eReuse`,
`eRefetch` would produce code like:
if (somet
MaskRay wrote:
If I remove `OpenCL`, `clang/test/CodeGenOpenCL/amdgpu-alignment.cl` won't
fail. It seems that OpenCL is a not a necessary change in this PR.
```
--- i/llvm/lib/TargetParser/Triple.cpp
+++ w/llvm/lib/TargetParser/Triple.cpp
@@ -325,4 +325,2 @@ StringRef Triple::getEnvironmentTypeN
jasonmolenda wrote:
Thanks for the great feedback @DavidSpickett sorry I merged it before you had a
chance to look. These are good points, I'll land a cleanup patch in a bit to
address them.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-c
@@ -400,12 +400,12 @@
// LONG-CALLS-DEF-NOT: "long-calls"
//
// -mbranch-likely
-// RUN: %clang -target -mips-mti-linux-gnu -### -c %s -mbranch-likely 2>&1 \
+// RUN: %clang -target mips-mti-linux-gnu -### -c %s -mbranch-likely 2>&1 \
MaskRay wrote:
while upda
@@ -1219,8 +1222,24 @@ VersionTuple Triple::getEnvironmentVersion() const {
StringRef Triple::getEnvironmentVersionString() const {
StringRef EnvironmentName = getEnvironmentName();
+
+ // none is a valid environment type - it basically amounts to a freestanding
+ // envir
smithp35 wrote:
Apologies I'll send a new pull request with the typo fixed. Probably the
fastest thing to do than trying to get my local branch back into the same state
to recreate the additional commit.
https://github.com/llvm/llvm-project/pull/80272
__
https://github.com/smithp35 closed
https://github.com/llvm/llvm-project/pull/80272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH 1/5] Make clang report invalid target versions for all
environme
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/80201
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f34418c73b718abb24cd5b921b5a2846011e7d0c
7d2c1eb97abf162522d030f9dfe9e281758f24b3 --
smithp35 wrote:
Apologies managed to mess up my branch when trying to fix the typo. I'll try
and fix.
https://github.com/llvm/llvm-project/pull/80272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -1305,6 +1305,14 @@ enum CompletionType {
eTerminatorCompletion = (1ul << 27)
};
+/// Specifies if children need to be re-computed
+/// after a call to \ref SyntheticChildrenFrontEnd::Update.
+enum class ChildCacheState {
+ eDynamic = 0, ///< Children need to be recomput
@@ -0,0 +1,76 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv32 -relocation-model=static < %s | FileCheck %s
--check-prefix=RV32
+; RUN: llc -mtriple=riscv64 -relocation-model=pic < %s | FileCheck %s
--check-prefix=RV6
1 - 100 of 129 matches
Mail list logo
