[Lldb-commits] [clang-tools-extra] [lldb] [libcxxabi] [lld] [flang] [libunwind] [compiler-rt] [clang] [llvm] [libc] [libcxx] [mlir] [asan] Install `pthread_atfork` (PR #75290)

2023-12-15 Thread Vitaly Buka via lldb-commits
vitalybuka wrote: That's bad, we need to fix this. Do you see how we endup in handler, from `internal_fork`. `internal_fork` claims it will not call handlers. https://github.com/llvm/llvm-project/pull/75290 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [clang] [llvm] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
@@ -1722,6 +1738,11 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args, #include "clang/Driver/Options.inc" #undef CODEGEN_OPTION_WITH_MARSHALLING +#define DEBUG_OPTION_WITH_MARSHALLING(...) \

[Lldb-commits] [llvm] [lldb] [clang] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
@@ -224,19 +233,20 @@ class CompilerInvocation : public CompilerInvocationBase { /// @{ // Note: These need to be pulled in manually. Otherwise, they get hidden by // the mutable getters with the same names. - using CompilerInvocationBase::getLangOpts; - using CompilerI

[Lldb-commits] [lldb] [clang] [llvm] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
@@ -11,6 +11,7 @@ #include "clang/APINotes/APINotesOptions.h" #include "clang/Basic/CodeGenOptions.h" +#include "clang/Basic/DebugOptions.h" jansvoboda11 wrote: Wouldn't a forward declaration be enough in this case? https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [clang] [llvm] [lldb] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
@@ -11,46 +11,13 @@ namespace clang { -CodeGenOptions::CodeGenOptions() { -#define CODEGENOPT(Name, Bits, Default) Name = Default; -#define ENUM_CODEGENOPT(Name, Type, Bits, Default) set##Name(Default); -#include "clang/Basic/CodeGenOptions.def" +CodeGenOptions::CodeGenOption

[Lldb-commits] [clang] [lldb] [llvm] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
https://github.com/jansvoboda11 requested changes to this pull request. This looks pretty nice, I left just a couple of notes. You might want to take a look at the CI failures. https://github.com/llvm/llvm-project/pull/75530 ___ lldb-commits mailing l

[Lldb-commits] [clang] [llvm] [lldb] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

2023-12-15 Thread Jan Svoboda via lldb-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/75530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [lldb] [libcxx] [llvm] [clang-tools-extra] [lld] [libc] [mlir] [openmp] [flang] [clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-12-15 Thread Sang Ik Lee via lldb-commits
silee2 wrote: Closing as all sub-components has been merged. https://github.com/llvm/llvm-project/pull/65539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [libcxx] [flang] [clang] [lldb] [clang-tools-extra] [mlir] [lld] [openmp] [compiler-rt] [libc] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-12-15 Thread Sang Ik Lee via lldb-commits
https://github.com/silee2 closed https://github.com/llvm/llvm-project/pull/65539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

2023-12-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/75515 >From b209c5276d14c46c08143af458188a42e6a28615 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 14 Dec 2023 12:29:52 -0500 Subject: [PATCH] Add TS files --- lldb/tools/lldb-dap/.editorconfig

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

2023-12-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/75515 >From f43036155fd42a6203e99ff6757054f2d256d81a Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 14 Dec 2023 12:29:52 -0500 Subject: [PATCH] Add TS files --- lldb/tools/lldb-dap/.editorconfig

[Lldb-commits] [lldb] [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (PR #75374)

2023-12-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/75374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7113c80 - [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (#75374)

2023-12-15 Thread via lldb-commits
Author: Alex Langford Date: 2023-12-15T10:26:01-08:00 New Revision: 7113c80289d62de95bca818109324601a51fefd8 URL: https://github.com/llvm/llvm-project/commit/7113c80289d62de95bca818109324601a51fefd8 DIFF: https://github.com/llvm/llvm-project/commit/7113c80289d62de95bca818109324601a51fefd8.diff

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [lld] [libcxx] [libcxxabi] [mlir] [flang] [clang] [openmp] [libc] [compiler-rt] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Jon Roelofs via lldb-commits
jroelofs wrote: Refactor here: https://github.com/llvm/llvm-project/pull/75635 https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [clang-tools-extra] [clang] [flang] [compiler-rt] [lld] [libcxxabi] [libc] [lldb] [openmp] [mlir] [libcxx] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Jon Roelofs via lldb-commits
jroelofs wrote: https://github.com/llvm/llvm-project/pull/75635 https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-12-15 Thread Michał Górny via lldb-commits
mgorny wrote: It's linking to `/home/freik/src/rel-llvm/lib/libLLVMDebuginfod.a`, i.e. the leftover build directory in your case. It doesn't exist anymore in our case. Try removing it, that should trigger the error. https://github.com/llvm/llvm-project/pull/70996 __

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-12-15 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: It looks we have kind of an impasse here, I've posted an RFC to try and clear up any misunderstandings and get some input about how we can move forward with this: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 Looking forward to everyone's feedback!

[Lldb-commits] [clang] [lld] [libcxxabi] [llvm] [flang] [clang-tools-extra] [openmp] [compiler-rt] [lldb] [libc] [libcxx] [mlir] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Jon Roelofs via lldb-commits
jroelofs wrote: > this file suffers from a pretty deep ifdef nesting jungle, so I'm not sure if > that's the best solution I'll refactor, and put up a new PR. https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [llvm] [lld] [clang] [compiler-rt] [libcxxabi] [lldb] [clang-tools-extra] [flang] [libcxx] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-15 Thread Mariusz Sikora via lldb-commits
https://github.com/mariusz-sikora-at-amd closed https://github.com/llvm/llvm-project/pull/74576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [llvm] [libcxxabi] [compiler-rt] [libc] [openmp] [mlir] [clang-tools-extra] [clang] [lldb] [libcxx] [flang] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > > BTW, when compiling the file I also get a bunch of warnings in this style: > > @mstorsjo maybe `unsigned long` is 32 bits on that platform... what's the > target triple? Ah, indeed - yes, Windows has 32 bit `long`s. The triples are `aarch64-windows-gnu` or `aarch64-windows

[Lldb-commits] [lld] [llvm] [libcxxabi] [compiler-rt] [libc] [openmp] [mlir] [clang-tools-extra] [clang] [lldb] [libcxx] [flang] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Jon Roelofs via lldb-commits
jroelofs wrote: > BTW, when compiling the file I also get a bunch of warnings in this style: @mstorsjo maybe `unsigned long` is 32 bits on that platform... what's the target triple? https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mai

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [openmp] [clang] [mlir] [lld] [llvm] [clang-tools-extra] [compiler-rt] [flang] [libc] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Jon Roelofs via lldb-commits
jroelofs wrote: Sorry about that... thanks! https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [llvm] [openmp] [clang] [flang] [lld] [libc] [clang-tools-extra] [compiler-rt] Gcc 75 libomptarget type convert (PR #75562)

2023-12-15 Thread via lldb-commits
SunilKuravinakop wrote: Since this has been done in https://github.com/llvm/llvm-project/pull/75419 with the change suggested by Joseph Huber, I am closing this. https://github.com/llvm/llvm-project/pull/75562 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [libcxx] [lldb] [llvm] [openmp] [clang] [flang] [lld] [libc] [clang-tools-extra] [compiler-rt] Gcc 75 libomptarget type convert (PR #75562)

2023-12-15 Thread via lldb-commits
https://github.com/SunilKuravinakop closed https://github.com/llvm/llvm-project/pull/75562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Trying to fix windows buildbots after #74786 (PR #75566)

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: I didn't get time for the follow up, so I'm going to put the bot back online over the weekend and come back to it on Monday. https://github.com/llvm/llvm-project/pull/75566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lld] [flang] [clang-tools-extra] [lldb] [compiler-rt] [libcxx] [clang] [libc] [llvm] [openmp] Gcc 75 libomptarget type convert (PR #75562)

2023-12-15 Thread Shilei Tian via lldb-commits
shiltian wrote: FYI: #75419 https://github.com/llvm/llvm-project/pull/75562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [clang] [lldb] [libc] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libcxx] [openmp] Gcc 75 libomptarget type convert (PR #75562)

2023-12-15 Thread Joseph Huber via lldb-commits
@@ -47,7 +47,9 @@ PluginAdaptorTy::create(const std::string &Name) { new PluginAdaptorTy(Name, std::move(LibraryHandler))); if (auto Err = PluginAdaptor->init()) return Err; - return PluginAdaptor; jhuber6 wrote: Does putting `std::move` here not

[Lldb-commits] [flang] [clang] [lldb] [libcxxabi] [lld] [compiler-rt] [clang-tools-extra] [llvm] [libcxx] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-15 Thread Mariusz Sikora via lldb-commits
https://github.com/mariusz-sikora-at-amd updated https://github.com/llvm/llvm-project/pull/74576 >From 23759746b66c33028ad2340b1e98067ebf1f8074 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 28 Jun 2022 15:24:24 -0700 Subject: [PATCH 1/4] [AMDGPU] GFX12: select @llvm.prefetch i

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

2023-12-15 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,21 @@ +import * as vscode from 'vscode'; walter-erquinigo wrote: Perhaps your docker config is allowing you to do that, but you can see this old gh issue that talks more about this problem https://github.com/llvm/llvm-project/issues/63655#issuecommen

[Lldb-commits] [flang] [clang] [mlir] [lldb] [libcxxabi] [libc] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libcxx] [openmp] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also seen on Linaro's Windows on Arm 2 stage bot: https://lab.llvm.org/buildbot/#/builders/120/builds/5990 https://github.com/llvm/llvm-project/pull/73685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] Trying to fix windows buildbots after #74786 (PR #75566)

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Works locally, I'll do the unit test update this afternoon and get the bot running again. https://github.com/llvm/llvm-project/pull/75566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] Trying to fix windows buildbots after #74786 (PR #75566)

2023-12-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/75566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8959cef - [lldb] Trying to fix windows buildbots after #74786 (#75566)

2023-12-15 Thread via lldb-commits
Author: Greg Clayton Date: 2023-12-15T11:55:40Z New Revision: 8959cef135d06e83a5fc02e09b532df21f4285d9 URL: https://github.com/llvm/llvm-project/commit/8959cef135d06e83a5fc02e09b532df21f4285d9 DIFF: https://github.com/llvm/llvm-project/commit/8959cef135d06e83a5fc02e09b532df21f4285d9.diff LOG:

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Though the original assert was: `m_plans.size() > 1 && "Can't pop the base thread plan"` Not that there was exactly 1 plan on the stack. So `current_plan` might be the single step plan as expected, then when we go to pop that off the stack, but the stack has been emptied/

[Lldb-commits] [lldb] Trying to fix windows buildbots after #74786 (PR #75566)

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks! Testing this locally. If it works I'll probably land this and then work on what you suggested updating the PDB input file. https://github.com/llvm/llvm-project/pull/75566 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: My extra logging resulted in this: ``` intern-state Thread::ShouldStop Begin intern-state Plan stack initial state: thread #1: tid = 0x47d2d: Active plan stack: Element 0: Base thread plan. Element 1: Single stepping past breakpoint

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

2023-12-15 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

2023-12-15 Thread via lldb-commits
@@ -0,0 +1,21 @@ +import * as vscode from 'vscode'; Dodzey wrote: Is this only true for extensions that include typescript? Or perhaps only for extensions installed client side (when using remote VS Code workflows). I've recently installed the current lldb-dap

[Lldb-commits] [libunwind] [compiler-rt] [mlir] [llvm] [lld] [flang] [lldb] [libcxx] [libcxxabi] [clang] [libc] [clang-tools-extra] [asan] Install `pthread_atfork` (PR #75290)

2023-12-15 Thread Rainer Orth via lldb-commits
rorth wrote: Since this patch, all asan tests loop on Solaris. This had been hidden for a bit by an unrelated extended build breakage on the bots, but now every `ninja check-all` on the Solaris/amd64 bot times out. I could trace this to this patch. E.g. when running `projects/compiler-rt/t

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [lldb] [mlir] [flang] [lld] [AMDGPU] GFX12: Add Split Workgroup Barrier (PR #74836)

2023-12-15 Thread Mariusz Sikora via lldb-commits
@@ -684,6 +684,51 @@ s_rndne_f16 s5, 0xfe0b s_rndne_f16 s5, 0x3456 // GFX12: encoding: [0xff,0x6e,0x85,0xbe,0x56,0x34,0x00,0x00] +s_barrier_signal -2 mariusz-sikora-at-amd wrote: Patch: https://github.com/llvm/llvm-project/pull/75575 https://github.com/llvm/

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [openmp] [mlir] [lldb] [flang] [libcxxabi] [lld] [builtins][arm64] Build __init_cpu_features_resolver on Apple platforms

2023-12-15 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: This commit broken building compiler-rt builtins for Windows on aarch64; building now hits these errors: ``` llvm-project/compiler-rt/lib/builtins/cpu_model.c:1192:2: error: No support for checking for lse atomics on this platfrom yet. 1192 | #error No support for checking for